dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Improve flaky tests in asm tests

Open uurien opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes packages/dd-trace/test/appsec/iast/overhead-controller.spec.js which was failing when was executed in local environment. Fix flaky tests happening in a test related with overhead-controller, because some request was executed before than expected.

Motivation

Improve flaky tests in the tracer.

uurien avatar Mar 21 '24 08:03 uurien

Overall package size

Self size: 7.93 MB Deduped: 64.95 MB No deduping: 65.29 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Mar 21 '24 08:03 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.19%. Comparing base (7000ae5) to head (171cf23). Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4176   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files           1        1           
  Lines         198      198           
  Branches       33       33           
=======================================
  Hits          137      137           
  Misses         61       61           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 08:03 codecov[bot]

Benchmarks

Benchmark execution time: 2024-11-06 17:03:44

Comparing candidate commit 6a6c56c78fe4a3f48895efa7680f8683f74d0efb in PR branch ugaitz/testing-flaky-test with baseline commit ff9b02b769598e428b9d8587d8a40ed47fb21b2c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

pr-commenter[bot] avatar Mar 21 '24 08:03 pr-commenter[bot]

I am going to close this since quite some time passed and things changed in the meanwhile. I know we worked on flaky tests, so it's hopefully resolved. If there are parts missing that we should still get in, it would be great to get a new PR!

BridgeAR avatar May 28 '25 23:05 BridgeAR