dd-trace-js
dd-trace-js copied to clipboard
Activate AVM OSS via environment variable
What does this PR do?
Adds a new configuration DD_APPSEC_SCA_ENABLED
, used to enable AVM OSS.
The value of this new configuration is sent via telemetry to the backend in the configuration
payload for the following telemetry messages: app-started
, app-extended-heartbeat
and app-client-configuration-change
.
Motivation
Customers need a way to enable AVM OSS via an environment variable, just as they enable APM or other products or features, instead of having to do it exclusively through the UI.
Plugin Checklist
- [x] Unit tests.
- [ ] TypeScript definitions.
- [ ] TypeScript tests.
- [ ] API documentation.
- [ ] CircleCI jobs/workflows.
- [ ] Plugin is exported.
Additional Notes
Security
Datadog employees:
- [ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
. - [x] This PR doesn't touch any of that.
Unsure? Have a question? Request a review!
Overall package size
Self size: 6.45 MB Deduped: 60.95 MB No deduping: 61.23 MB
Dependency sizes
name | version | self size | total size |
---|---|---|---|
@datadog/native-iast-taint-tracking | 1.7.0 | 16.71 MB | 16.72 MB |
@datadog/native-appsec | 7.1.1 | 14.39 MB | 14.4 MB |
@datadog/pprof | 5.2.0 | 8.84 MB | 9.21 MB |
protobufjs | 7.2.5 | 2.77 MB | 6.56 MB |
@datadog/native-iast-rewriter | 2.3.0 | 2.15 MB | 2.24 MB |
@opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB |
@datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB |
@opentelemetry/api | 1.4.1 | 780.32 kB | 780.32 kB |
import-in-the-middle | 1.7.3 | 67.62 kB | 731.01 kB |
msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB |
opentracing | 0.14.7 | 194.81 kB | 194.81 kB |
semver | 7.5.4 | 93.4 kB | 123.8 kB |
pprof-format | 2.1.0 | 111.69 kB | 111.69 kB |
@datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB |
lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB |
lru-cache | 7.14.0 | 74.95 kB | 74.95 kB |
ipaddr.js | 2.1.0 | 60.23 kB | 60.23 kB |
ignore | 5.2.4 | 51.22 kB | 51.22 kB |
int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB |
shell-quote | 1.8.1 | 44.96 kB | 44.96 kB |
istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB |
tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB |
limiter | 1.1.5 | 23.17 kB | 23.17 kB |
dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB |
retry | 0.13.1 | 18.85 kB | 18.85 kB |
node-abort-controller | 3.1.1 | 16.89 kB | 16.89 kB |
jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB |
crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB |
path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB |
koalas | 1.0.2 | 6.47 kB | 6.47 kB |
methods | 1.1.2 | 5.29 kB | 5.29 kB |
module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |
🤖 This report was automatically generated by heaviest-objects-in-the-universe
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.76%. Comparing base (
c11fcfd
) to head (7b97662
). Report is 11 commits behind head on master.
:exclamation: Current head 7b97662 differs from pull request most recent head 6ec04c5. Consider uploading reports for the commit 6ec04c5 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #4119 +/- ##
===========================================
+ Coverage 83.11% 95.76% +12.65%
===========================================
Files 244 97 -147
Lines 10255 3259 -6996
Branches 33 33
===========================================
- Hits 8523 3121 -5402
+ Misses 1732 138 -1594
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Benchmarks
Benchmark execution time: 2024-05-03 07:59:56
Comparing candidate commit 6ec04c58e728b15efde3d04553d4dba03d5d4313 in PR branch ccapell/activate-oss-vm-via-env-var
with baseline commit 3031b6e5eea918064b4806f497cdb6e3b4fdfca1 in branch master
.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 5 unstable metrics.
scenario:plugin-graphql-with-depth-on-max-18
- 🟩
max_rss_usage
[-116.988MB; -73.936MB] or [-12.550%; -7.931%]
Can we include the system test enablement PR link in the description ?
@CarlesDD sorry for the system-tests PR i meant the PR where we enable the test :+1: