dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

upgrade eslint, eslint-plugin-n, eslint-config-standard (VULN-5530)

Open tlhunter opened this issue 1 year ago • 4 comments

What does this PR do?

  • drops eslint-plugin-node and depends entirely on eslint-plugin-n
  • upgrades eslint

Motivation

  • original eslint-plugin-node is unmaintained
  • quiets automated vuln scanners

tlhunter avatar Feb 06 '24 18:02 tlhunter

Overall package size

Self size: 5.99 MB Deduped: 61.58 MB No deduping: 62.34 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 7.0.0 14.51 MB 14.52 MB
@datadog/pprof 5.0.0 9.59 MB 10.44 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.2.3 2.19 MB 2.28 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Feb 06 '24 18:02 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-02-07 18:16:12

Comparing candidate commit 57c2f6ca528a72496360c2ebcbdeff4353556517 in PR branch tlhunter/replace-eslint-plugin-node with baseline commit 192421235e53af1be9b2fd270abe27794d295173 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 4 unstable metrics.

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-125.310MB; -124.190MB] or [-13.021%; -12.905%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-134.821MB; -107.215MB] or [-14.115%; -11.225%]

pr-commenter[bot] avatar Feb 06 '24 18:02 pr-commenter[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1924212) 85.15% compared to head (57c2f6c) 85.15%. Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4032   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files         243      243           
  Lines       10504    10504           
  Branches       33       33           
=======================================
  Hits         8945     8945           
  Misses       1559     1559           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 06 '24 19:02 codecov[bot]

do we still want to do this? @tlhunter

juan-fernandez avatar Mar 07 '24 09:03 juan-fernandez