dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

DeprecationWarning: Buffer

Open imgalli opened this issue 1 year ago • 11 comments

Hi! We're seeing this error in the log that we're tracking back to protobuf.js, which is in turn a dep of dd-trace. Your module is the only reason for this dep to be included, is there a way you can upgrade or mitigate?

(node:7) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

imgalli avatar Aug 17 '23 08:08 imgalli

We saw a similar message this morning, but tracked it back to the use of msgpack-lite (which is a direct dependency of dd-trace).

X-Ref: https://github.com/kawanet/msgpack-lite/issues/98

ofhouse avatar Aug 22 '23 13:08 ofhouse

any update on this ?

opeologist avatar Oct 04 '23 19:10 opeologist

Any update on this?

juancarlosjr97 avatar Dec 21 '23 11:12 juancarlosjr97

Given that the library was last updated 7 years ago and this issue still remains, it may be worth considering a different msgpack library

swcm-mnestler avatar Jan 04 '24 09:01 swcm-mnestler

Keeping this thread alive.

yelsayed avatar Jan 22 '24 16:01 yelsayed

Just wanted to check in -- is there any update on this? (looks like it's been open for 6 months now, and presumably is affecting every customer using dd-trace on modern Node?)

Que3216 avatar Mar 04 '24 17:03 Que3216

Looks like there is a fork that may fix this https://github.com/meetnow/msgpack-long-lite/commit/b7a42528919f05e2d61b13bc0fbd3b05b37fc300 ? (but haven't investigated closely)

Que3216 avatar Mar 04 '24 17:03 Que3216

Any timeline on this?

kasleet avatar Apr 17 '24 09:04 kasleet

:(...

juancarlosjr97 avatar Jun 07 '24 12:06 juancarlosjr97