dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

http module configuration breaks server APM reporting

Open clement-heliot opened this issue 3 years ago • 4 comments

:wave: I have a case where configuring the http module breaks the APM reporting of the server. The service http-client is still being reported correctly.

Expected behaviour I would expect configuring the http module this way would not break the APM server reporting.

Actual behaviour APM server reporting is broken and stop reporting.

Steps to reproduce

tracer.use('http', {
    server: {
      blocklist: ['/ping'],
    },
    client: {
      blocklist: [
        'https://back.sqreen.io/sqreen/v1/app-beat',
        'https://ingestion.sqreen.com/batches',
        'https://events.launchdarkly.com/bulk',
      ],
    },
  })

Environment

  • Tracer version: 2.10.0

clement-heliot avatar Jul 28 '22 09:07 clement-heliot

When you say "stop reporting" do you mean that you're no longer getting traces at all, only when you use a blocklist configuration?

rochdev avatar Jul 28 '22 14:07 rochdev

@rochdev Yep, the APM Service page stopped being updated. Say the service name was saturne, saturne APM page wasn't receiving anything. However saturne-http-client was working as expected. When I rolled back the changes and removed the configuration, saturne APM page worked again.

clement-heliot avatar Jul 28 '22 16:07 clement-heliot

Is this something you are able to easily isolate in a reproduction snippet? Also, was there anything else in that change, for example changing the version of dd-trace?

rochdev avatar Jul 28 '22 17:07 rochdev

@rochdev Nope, basically I changed

tracer.use('http', { blocklist: ['/ping'] })

to

tracer.use('http', {
  server: {
    blocklist: ['/ping'],
  },
  client: {
    blocklist: [
      'https://back.sqreen.io/sqreen/v1/app-beat',
      'https://ingestion.sqreen.com/batches',
      'https://events.launchdarkly.com/bulk',
    ],
  },
})

Only those changes were made, no dd-trace version change were involved.

clement-heliot avatar Jul 28 '22 19:07 clement-heliot

@clement-heliot can you confirm if you're still facing this issue with a current tracer version?

tlhunter avatar Dec 18 '23 22:12 tlhunter

I'll close this for now but we can reopen it if it's still an issue.

tlhunter avatar Jan 12 '24 17:01 tlhunter