dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

[WIP] support for fetch

Open bengl opened this issue 3 years ago • 2 comments

What does this PR do?

See title

Motivation

As of Node 18, it's a pretty big hole in our HTTP support.

Additional Notes

This is WIP. Mainly, there are a lot of tests to do.

bengl avatar Apr 26 '22 18:04 bengl

Undici has diagnostics_channel support built in. Can we not just use that? https://github.com/nodejs/undici/blob/main/docs/api/DiagnosticsChannel.md

Qard avatar Apr 26 '22 18:04 Qard

@Qard If I read that right, there are no events for the response.

bengl avatar Apr 26 '22 18:04 bengl

Hi @bengl, the draft is open for a long time now, is it still worked on, or is it abandoned? If it's still worked on, is there any rough estimation when it might be done?

tipok avatar Mar 20 '23 15:03 tipok

Hi @tipok!

We're actually looking at a different approach right now using TracingChannel in undici, and we're hoping to round this out in the coming months. I'll close this PR.

bengl avatar Mar 20 '23 15:03 bengl