What Does This Do

Prefix system tests env var to not conflict with local dev env vars

Motivation

Additional Notes

Contributor Checklist

[ ] Format the title according the contribution guidelines
[ ] Assign the type: and (comp: or inst:) labels in addition to any usefull labels
[ ] Squash your commits prior merging or merge using GitHub's Squash and merge
[ ] Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
[ ] Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

Oct 01 '24 18:10 wconti27

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-10-22T17:45:43	2024-10-22T17:52:37
git_branch	master	conti/prefix-system-tests-env-var
git_commit_date	1729609825	1729618526
git_commit_sha	179c62ad1e	362d52dec0
release_version	1.42.0-SNAPSHOT~179c62ad1e	1.42.0-SNAPSHOT~362d52dec0
start_time	2024-10-22T17:45:30	2024-10-22T17:52:24

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1729619905	1729619905
ci_job_id	680448988	680448988
ci_pipeline_id	47171158	47171158
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~362d52dec0, baseline=1.42.0-SNAPSHOT~179c62ad1e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.343 ms) : 1324, 1362
.   : milestone, 1343,
appsec (1.703 ms) : 1680, 1727
.   : milestone, 1703,
appsec_no_iast (1.729 ms) : 1705, 1753
.   : milestone, 1729,
iast (1.485 ms) : 1463, 1507
.   : milestone, 1485,
profiling (1.48 ms) : 1457, 1503
.   : milestone, 1480,
tracing (1.477 ms) : 1452, 1502
.   : milestone, 1477,
section candidate
no_agent (1.355 ms) : 1335, 1374
.   : milestone, 1355,
appsec (1.729 ms) : 1705, 1753
.   : milestone, 1729,
appsec_no_iast (1.702 ms) : 1678, 1727
.   : milestone, 1702,
iast (1.479 ms) : 1456, 1503
.   : milestone, 1479,
profiling (1.496 ms) : 1471, 1521
.   : milestone, 1496,
tracing (1.457 ms) : 1432, 1481
.   : milestone, 1457,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.343 ms [1.324 ms, 1.362 ms]	-
appsec	1.703 ms [1.68 ms, 1.727 ms]	360.279 µs (26.8%)
appsec_no_iast	1.729 ms [1.705 ms, 1.753 ms]	385.931 µs (28.7%)
iast	1.485 ms [1.463 ms, 1.507 ms]	141.78 µs (10.6%)
profiling	1.48 ms [1.457 ms, 1.503 ms]	136.838 µs (10.2%)
tracing	1.477 ms [1.452 ms, 1.502 ms]	134.1 µs (10.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.355 ms [1.335 ms, 1.374 ms]	-
appsec	1.729 ms [1.705 ms, 1.753 ms]	374.47 µs (27.6%)
appsec_no_iast	1.702 ms [1.678 ms, 1.727 ms]	347.957 µs (25.7%)
iast	1.479 ms [1.456 ms, 1.503 ms]	124.982 µs (9.2%)
profiling	1.496 ms [1.471 ms, 1.521 ms]	141.598 µs (10.5%)
tracing	1.457 ms [1.432 ms, 1.481 ms]	102.348 µs (7.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.42.0-SNAPSHOT~362d52dec0, baseline=1.42.0-SNAPSHOT~179c62ad1e
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.258 µs) : 353, 393
.   : milestone, 373,
iast (482.607 µs) : 461, 504
.   : milestone, 483,
iast_FULL (560.746 µs) : 539, 582
.   : milestone, 561,
iast_GLOBAL (526.45 µs) : 505, 548
.   : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (482.829 µs) : 462, 504
.   : milestone, 483,
iast_INACTIVE (452.005 µs) : 430, 474
.   : milestone, 452,
iast_TELEMETRY_OFF (474.749 µs) : 453, 496
.   : milestone, 475,
tracing (439.73 µs) : 419, 461
.   : milestone, 440,
section candidate
no_agent (368.594 µs) : 349, 388
.   : milestone, 369,
iast (485.935 µs) : 464, 508
.   : milestone, 486,
iast_FULL (558.054 µs) : 537, 579
.   : milestone, 558,
iast_GLOBAL (512.325 µs) : 491, 534
.   : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (490.383 µs) : 469, 512
.   : milestone, 490,
iast_INACTIVE (458.498 µs) : 437, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (480.85 µs) : 459, 503
.   : milestone, 481,
tracing (445.734 µs) : 424, 467
.   : milestone, 446,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.258 µs [353.187 µs, 393.328 µs]	-
iast	482.607 µs [461.145 µs, 504.069 µs]	109.349 µs (29.3%)
iast_FULL	560.746 µs [539.403 µs, 582.088 µs]	187.488 µs (50.2%)
iast_GLOBAL	526.45 µs [504.974 µs, 547.926 µs]	153.192 µs (41.0%)
iast_HARDCODED_SECRET_DISABLED	482.829 µs [461.743 µs, 503.915 µs]	109.571 µs (29.4%)
iast_INACTIVE	452.005 µs [429.968 µs, 474.043 µs]	78.748 µs (21.1%)
iast_TELEMETRY_OFF	474.749 µs [453.18 µs, 496.318 µs]	101.491 µs (27.2%)
tracing	439.73 µs [418.686 µs, 460.773 µs]	66.472 µs (17.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	368.594 µs [348.789 µs, 388.398 µs]	-
iast	485.935 µs [464.289 µs, 507.581 µs]	117.342 µs (31.8%)
iast_FULL	558.054 µs [536.838 µs, 579.269 µs]	189.46 µs (51.4%)
iast_GLOBAL	512.325 µs [491.112 µs, 533.538 µs]	143.731 µs (39.0%)
iast_HARDCODED_SECRET_DISABLED	490.383 µs [469.261 µs, 511.506 µs]	121.79 µs (33.0%)
iast_INACTIVE	458.498 µs [436.946 µs, 480.05 µs]	89.904 µs (24.4%)
iast_TELEMETRY_OFF	480.85 µs [459.135 µs, 502.564 µs]	112.256 µs (30.5%)
tracing	445.734 µs [424.001 µs, 467.468 µs]	77.14 µs (20.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	conti/prefix-system-tests-env-var
git_commit_date	1729609825	1729618526
git_commit_sha	179c62ad1e	362d52dec0
release_version	1.42.0-SNAPSHOT~179c62ad1e	1.42.0-SNAPSHOT~362d52dec0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1729620440	1729620440
ci_job_id	680448989	680448989
ci_pipeline_id	47171158	47171158
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~362d52dec0, baseline=1.42.0-SNAPSHOT~179c62ad1e
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
appsec (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
iast (18.867 s) : 18867000, 18867000
.   : milestone, 18867000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
.   : milestone, 17963000,
profiling (15.36 s) : 15360000, 15360000
.   : milestone, 15360000,
tracing (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
section candidate
no_agent (15.477 s) : 15477000, 15477000
.   : milestone, 15477000,
appsec (15.175 s) : 15175000, 15175000
.   : milestone, 15175000,
iast (18.616 s) : 18616000, 18616000
.   : milestone, 18616000,
iast_GLOBAL (17.832 s) : 17832000, 17832000
.   : milestone, 17832000,
profiling (14.924 s) : 14924000, 14924000
.   : milestone, 14924000,
tracing (15.194 s) : 15194000, 15194000
.   : milestone, 15194000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.075 s [15.075 s, 15.075 s]	-
appsec	15.137 s [15.137 s, 15.137 s]	62.0 ms (0.4%)
iast	18.867 s [18.867 s, 18.867 s]	3.792 s (25.2%)
iast_GLOBAL	17.963 s [17.963 s, 17.963 s]	2.888 s (19.2%)
profiling	15.36 s [15.36 s, 15.36 s]	285.0 ms (1.9%)
tracing	15.095 s [15.095 s, 15.095 s]	20.0 ms (0.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.477 s [15.477 s, 15.477 s]	-
appsec	15.175 s [15.175 s, 15.175 s]	-302.0 ms (-2.0%)
iast	18.616 s [18.616 s, 18.616 s]	3.139 s (20.3%)
iast_GLOBAL	17.832 s [17.832 s, 17.832 s]	2.355 s (15.2%)
profiling	14.924 s [14.924 s, 14.924 s]	-553.0 ms (-3.6%)
tracing	15.194 s [15.194 s, 15.194 s]	-283.0 ms (-1.8%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.42.0-SNAPSHOT~362d52dec0, baseline=1.42.0-SNAPSHOT~179c62ad1e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.336 ms) : 2295, 2378
.   : milestone, 2336,
iast (2.094 ms) : 2041, 2147
.   : milestone, 2094,
iast_GLOBAL (2.126 ms) : 2073, 2179
.   : milestone, 2126,
profiling (1.955 ms) : 1912, 1998
.   : milestone, 1955,
tracing (1.931 ms) : 1891, 1972
.   : milestone, 1931,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.332 ms) : 2290, 2373
.   : milestone, 2332,
iast (2.091 ms) : 2039, 2143
.   : milestone, 2091,
iast_GLOBAL (2.125 ms) : 2072, 2177
.   : milestone, 2125,
profiling (1.943 ms) : 1901, 1986
.   : milestone, 1943,
tracing (1.919 ms) : 1880, 1959
.   : milestone, 1919,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.336 ms [2.295 ms, 2.378 ms]	865.935 µs (58.9%)
iast	2.094 ms [2.041 ms, 2.147 ms]	623.609 µs (42.4%)
iast_GLOBAL	2.126 ms [2.073 ms, 2.179 ms]	655.798 µs (44.6%)
profiling	1.955 ms [1.912 ms, 1.998 ms]	484.341 µs (32.9%)
tracing	1.931 ms [1.891 ms, 1.972 ms]	461.098 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.332 ms [2.29 ms, 2.373 ms]	860.913 µs (58.5%)
iast	2.091 ms [2.039 ms, 2.143 ms]	620.282 µs (42.2%)
iast_GLOBAL	2.125 ms [2.072 ms, 2.177 ms]	653.949 µs (44.5%)
profiling	1.943 ms [1.901 ms, 1.986 ms]	472.547 µs (32.1%)
tracing	1.919 ms [1.88 ms, 1.959 ms]	448.737 µs (30.5%)

Oct 01 '24 19:10 pr-commenter[bot]

This pull request has been marked as stale because it has not had activity over the past quarter. It will be closed in 7 days if no further activity occurs. Feel free to reopen the PR if you are still working on it.

Feb 01 '25 03:02 github-actions[bot]

This pull request has been closed because it has not had activity over the past quarter. Feel free to reopen the PR if you are still working on it.

Mar 01 '25 03:03 github-actions[bot]

dd-trace-java
dd-trace-java copied to clipboard

chore: prefix system tests env var

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

dd-trace-java dd-trace-java copied to clipboard

chore: prefix system tests env var

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

dd-trace-java
dd-trace-java copied to clipboard