dd-trace-java icon indicating copy to clipboard operation
dd-trace-java copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

fix(OCI): Name the archive properly

Open BaptisteFoy opened this issue 1 year ago • 1 comments
trafficstars

What Does This Do

Changes the name used for OCI packaging to match the flavor defined in the promotion repository

Motivation

Plugging things together

Additional Notes

Jira ticket: RC-1645

BaptisteFoy avatar Mar 12 '24 16:03 BaptisteFoy

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master baptiste.foy/RC/use-flavor-name
git_commit_date 1710833793 1710786863
git_commit_sha f97f63248a dd6e351010
release_version 1.32.0-SNAPSHOT~f97f63248a 1.32.0-SNAPSHOT~dd6e351010
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1710876208 1710876208
ci_job_id 463744360 463744360
ci_pipeline_id 30394455 30394455
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079537
Total [baseline] (8.551 s) : 0, 8550939
Agent [candidate] (1.08 s) : 0, 1079566
Total [candidate] (8.568 s) : 0, 8567635
section iast
Agent [baseline] (1.204 s) : 0, 1204243
Total [baseline] (9.029 s) : 0, 9029454
Agent [candidate] (1.216 s) : 0, 1216242
Total [candidate] (9.1 s) : 0, 9099709
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.205 s) : 0, 1204913
Total [baseline] (9.017 s) : 0, 9016667
Agent [candidate] (1.214 s) : 0, 1213745
Total [candidate] (9.041 s) : 0, 9040746
section iast_TELEMETRY_OFF
Agent [baseline] (1.197 s) : 0, 1197305
Total [baseline] (9.03 s) : 0, 9029799
Agent [candidate] (1.21 s) : 0, 1209729
Total [candidate] (9.09 s) : 0, 9089729
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.204 s 124.706 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.205 s 125.377 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.197 s 117.768 ms (10.9%)
Total tracing 8.551 s -
Total iast 9.029 s 478.514 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.017 s 465.728 ms (5.4%)
Total iast_TELEMETRY_OFF 9.03 s 478.86 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.216 s 136.675 ms (12.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.214 s 134.179 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.21 s 130.163 ms (12.1%)
Total tracing 8.568 s -
Total iast 9.1 s 532.074 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.041 s 473.111 ms (5.5%)
Total iast_TELEMETRY_OFF 9.09 s 522.094 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.491 ms) : 0, 696491
BytebuddyAgent [candidate] (696.333 ms) : 0, 696333
GlobalTracer [baseline] (291.254 ms) : 0, 291254
GlobalTracer [candidate] (291.366 ms) : 0, 291366
AppSec [baseline] (48.96 ms) : 0, 48960
AppSec [candidate] (49.116 ms) : 0, 49116
Remote Config [baseline] (1.088 ms) : 0, 1088
Remote Config [candidate] (1.106 ms) : 0, 1106
Telemetry [baseline] (7.431 ms) : 0, 7431
Telemetry [candidate] (7.473 ms) : 0, 7473
section iast
BytebuddyAgent [baseline] (800.375 ms) : 0, 800375
BytebuddyAgent [candidate] (808.211 ms) : 0, 808211
GlobalTracer [baseline] (288.251 ms) : 0, 288251
GlobalTracer [candidate] (291.328 ms) : 0, 291328
AppSec [baseline] (51.073 ms) : 0, 51073
AppSec [candidate] (48.433 ms) : 0, 48433
IAST [baseline] (22.217 ms) : 0, 22217
IAST [candidate] (25.754 ms) : 0, 25754
Remote Config [baseline] (568.861 µs) : 0, 569
Remote Config [candidate] (576.331 µs) : 0, 576
Telemetry [baseline] (7.4 ms) : 0, 7400
Telemetry [candidate] (7.354 ms) : 0, 7354
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.715 ms) : 0, 800715
BytebuddyAgent [candidate] (806.707 ms) : 0, 806707
GlobalTracer [baseline] (288.691 ms) : 0, 288691
GlobalTracer [candidate] (290.998 ms) : 0, 290998
AppSec [baseline] (51.039 ms) : 0, 51039
AppSec [candidate] (48.969 ms) : 0, 48969
IAST [baseline] (22.939 ms) : 0, 22939
IAST [candidate] (25.42 ms) : 0, 25420
Remote Config [baseline] (573.785 µs) : 0, 574
Remote Config [candidate] (563.409 µs) : 0, 563
Telemetry [baseline] (6.633 ms) : 0, 6633
Telemetry [candidate] (6.553 ms) : 0, 6553
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (793.537 ms) : 0, 793537
BytebuddyAgent [candidate] (800.837 ms) : 0, 800837
GlobalTracer [baseline] (288.784 ms) : 0, 288784
GlobalTracer [candidate] (292.545 ms) : 0, 292545
AppSec [baseline] (50.055 ms) : 0, 50055
AppSec [candidate] (49.018 ms) : 0, 49018
IAST [baseline] (22.926 ms) : 0, 22926
IAST [candidate] (25.588 ms) : 0, 25588
Remote Config [baseline] (570.975 µs) : 0, 571
Remote Config [candidate] (573.91 µs) : 0, 574
Telemetry [baseline] (7.239 ms) : 0, 7239
Telemetry [candidate] (6.596 ms) : 0, 6596
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079531
Total [baseline] (9.166 s) : 0, 9165513
Agent [candidate] (1.082 s) : 0, 1082403
Total [candidate] (9.292 s) : 0, 9291652
section appsec
Agent [baseline] (1.209 s) : 0, 1208974
Total [baseline] (9.312 s) : 0, 9311954
Agent [candidate] (1.202 s) : 0, 1202499
Total [candidate] (9.299 s) : 0, 9299276
section iast
Agent [baseline] (1.208 s) : 0, 1207890
Total [baseline] (9.358 s) : 0, 9357850
Agent [candidate] (1.209 s) : 0, 1208850
Total [candidate] (9.351 s) : 0, 9351447
section profiling
Agent [baseline] (1.285 s) : 0, 1284666
Total [baseline] (9.363 s) : 0, 9362688
Agent [candidate] (1.272 s) : 0, 1272191
Total [candidate] (9.355 s) : 0, 9355378
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent appsec 1.209 s 129.443 ms (12.0%)
Agent iast 1.208 s 128.36 ms (11.9%)
Agent profiling 1.285 s 205.135 ms (19.0%)
Total tracing 9.166 s -
Total appsec 9.312 s 146.441 ms (1.6%)
Total iast 9.358 s 192.337 ms (2.1%)
Total profiling 9.363 s 197.175 ms (2.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.082 s -
Agent appsec 1.202 s 120.096 ms (11.1%)
Agent iast 1.209 s 126.446 ms (11.7%)
Agent profiling 1.272 s 189.788 ms (17.5%)
Total tracing 9.292 s -
Total appsec 9.299 s 7.624 ms (0.1%)
Total iast 9.351 s 59.795 ms (0.6%)
Total profiling 9.355 s 63.726 ms (0.7%) 
gantt
    title petclinic - break down per module: candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.999 ms) : 0, 695999
BytebuddyAgent [candidate] (697.664 ms) : 0, 697664
GlobalTracer [baseline] (291.495 ms) : 0, 291495
GlobalTracer [candidate] (292.685 ms) : 0, 292685
AppSec [baseline] (49.138 ms) : 0, 49138
AppSec [candidate] (49.23 ms) : 0, 49230
Remote Config [baseline] (1.061 ms) : 0, 1061
Remote Config [candidate] (1.078 ms) : 0, 1078
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.428 ms) : 0, 7428
section appsec
BytebuddyAgent [baseline] (701.439 ms) : 0, 701439
BytebuddyAgent [candidate] (696.782 ms) : 0, 696782
GlobalTracer [baseline] (293.591 ms) : 0, 293591
GlobalTracer [candidate] (292.62 ms) : 0, 292620
AppSec [baseline] (153.852 ms) : 0, 153852
AppSec [candidate] (153.492 ms) : 0, 153492
IAST [baseline] (17.979 ms) : 0, 17979
IAST [candidate] (17.839 ms) : 0, 17839
Remote Config [baseline] (617.297 µs) : 0, 617
Remote Config [candidate] (608.586 µs) : 0, 609
Telemetry [baseline] (6.916 ms) : 0, 6916
Telemetry [candidate] (6.836 ms) : 0, 6836
section iast
BytebuddyAgent [baseline] (803.373 ms) : 0, 803373
BytebuddyAgent [candidate] (803.787 ms) : 0, 803787
GlobalTracer [baseline] (288.639 ms) : 0, 288639
GlobalTracer [candidate] (289.919 ms) : 0, 289919
AppSec [baseline] (49.867 ms) : 0, 49867
AppSec [candidate] (51.569 ms) : 0, 51569
IAST [baseline] (23.67 ms) : 0, 23670
IAST [candidate] (22.03 ms) : 0, 22030
Remote Config [baseline] (574.648 µs) : 0, 575
Remote Config [candidate] (553.777 µs) : 0, 554
Telemetry [baseline] (7.36 ms) : 0, 7360
Telemetry [candidate] (6.575 ms) : 0, 6575
section profiling
BytebuddyAgent [baseline] (695.769 ms) : 0, 695769
BytebuddyAgent [candidate] (688.481 ms) : 0, 688481
GlobalTracer [baseline] (378.254 ms) : 0, 378254
GlobalTracer [candidate] (375.686 ms) : 0, 375686
AppSec [baseline] (50.555 ms) : 0, 50555
AppSec [candidate] (49.665 ms) : 0, 49665
Remote Config [baseline] (857.85 µs) : 0, 858
Remote Config [candidate] (862.156 µs) : 0, 862
Telemetry [baseline] (7.351 ms) : 0, 7351
Telemetry [candidate] (7.258 ms) : 0, 7258
ProfilingAgent [baseline] (95.203 ms) : 0, 95203
ProfilingAgent [candidate] (94.219 ms) : 0, 94219
Profiling [baseline] (95.227 ms) : 0, 95227
Profiling [candidate] (94.243 ms) : 0, 94243

Load

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.722 µs) : 353, 393
.   : milestone, 373,
iast (476.022 µs) : 455, 497
.   : milestone, 476,
iast_FULL (552.169 µs) : 531, 573
.   : milestone, 552,
iast_GLOBAL (498.321 µs) : 478, 519
.   : milestone, 498,
iast_HARDCODED_SECRET_DISABLED (475.583 µs) : 455, 496
.   : milestone, 476,
iast_INACTIVE (454.031 µs) : 433, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (473.629 µs) : 452, 495
.   : milestone, 474,
tracing (449.261 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (367.692 µs) : 348, 388
.   : milestone, 368,
iast (473.446 µs) : 453, 494
.   : milestone, 473,
iast_FULL (541.506 µs) : 521, 562
.   : milestone, 542,
iast_GLOBAL (496.442 µs) : 475, 518
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (487.521 µs) : 467, 508
.   : milestone, 488,
iast_INACTIVE (451.319 µs) : 431, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (468.945 µs) : 448, 490
.   : milestone, 469,
tracing (450.373 µs) : 429, 472
.   : milestone, 450,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.722 µs [352.536 µs, 392.908 µs] -
iast 476.022 µs [455.236 µs, 496.808 µs] 103.3 µs (27.7%)
iast_FULL 552.169 µs [531.493 µs, 572.844 µs] 179.447 µs (48.1%)
iast_GLOBAL 498.321 µs [477.566 µs, 519.076 µs] 125.599 µs (33.7%)
iast_HARDCODED_SECRET_DISABLED 475.583 µs [455.0 µs, 496.166 µs] 102.861 µs (27.6%)
iast_INACTIVE 454.031 µs [432.648 µs, 475.415 µs] 81.31 µs (21.8%)
iast_TELEMETRY_OFF 473.629 µs [452.255 µs, 495.003 µs] 100.907 µs (27.1%)
tracing 449.261 µs [428.442 µs, 470.08 µs] 76.539 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.692 µs [347.638 µs, 387.745 µs] -
iast 473.446 µs [453.064 µs, 493.828 µs] 105.754 µs (28.8%)
iast_FULL 541.506 µs [520.899 µs, 562.113 µs] 173.814 µs (47.3%)
iast_GLOBAL 496.442 µs [475.107 µs, 517.776 µs] 128.75 µs (35.0%)
iast_HARDCODED_SECRET_DISABLED 487.521 µs [466.724 µs, 508.318 µs] 119.829 µs (32.6%)
iast_INACTIVE 451.319 µs [430.579 µs, 472.059 µs] 83.628 µs (22.7%)
iast_TELEMETRY_OFF 468.945 µs [448.242 µs, 489.649 µs] 101.254 µs (27.5%)
tracing 450.373 µs [429.008 µs, 471.739 µs] 82.682 µs (22.5%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.32.0-SNAPSHOT~dd6e351010, baseline=1.32.0-SNAPSHOT~f97f63248a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.366 ms) : 1346, 1385
.   : milestone, 1366,
appsec (1.775 ms) : 1751, 1799
.   : milestone, 1775,
iast (1.547 ms) : 1524, 1570
.   : milestone, 1547,
profiling (1.55 ms) : 1527, 1574
.   : milestone, 1550,
tracing (1.494 ms) : 1471, 1517
.   : milestone, 1494,
section candidate
no_agent (1.351 ms) : 1333, 1370
.   : milestone, 1351,
appsec (1.746 ms) : 1723, 1770
.   : milestone, 1746,
iast (1.529 ms) : 1506, 1552
.   : milestone, 1529,
profiling (1.525 ms) : 1502, 1549
.   : milestone, 1525,
tracing (1.509 ms) : 1486, 1532
.   : milestone, 1509,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.346 ms, 1.385 ms] -
appsec 1.775 ms [1.751 ms, 1.799 ms] 409.466 µs (30.0%)
iast 1.547 ms [1.524 ms, 1.57 ms] 181.104 µs (13.3%)
profiling 1.55 ms [1.527 ms, 1.574 ms] 184.833 µs (13.5%)
tracing 1.494 ms [1.471 ms, 1.517 ms] 128.648 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.351 ms [1.333 ms, 1.37 ms] -
appsec 1.746 ms [1.723 ms, 1.77 ms] 394.637 µs (29.2%)
iast 1.529 ms [1.506 ms, 1.552 ms] 177.94 µs (13.2%)
profiling 1.525 ms [1.502 ms, 1.549 ms] 173.888 µs (12.9%)
tracing 1.509 ms [1.486 ms, 1.532 ms] 157.2 µs (11.6%)

pr-commenter[bot] avatar Mar 12 '24 17:03 pr-commenter[bot]