dd-trace-java icon indicating copy to clipboard operation
dd-trace-java copied to clipboard

[WIP] Ignore unexpected context-store access

Open mcculls opened this issue 1 year ago • 1 comments
trafficstars

What Does This Do

Motivation

Additional Notes

mcculls avatar Jan 05 '24 14:01 mcculls

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/ignore-unexpected-context-store-access
git_commit_date 1704390361 1704462132
git_commit_sha c784ae91b5 c85026c785
release_version 1.28.0-SNAPSHOT~c784ae91b5 1.28.0-SNAPSHOT~c85026c785
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1704464836 1704464836
ci_job_id 401563350 401563350
ci_pipeline_id 25947059 25947059
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 8 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054492
Total [baseline] (9.351 s) : 0, 9350643
Agent [candidate] (1.054 s) : 0, 1053675
Total [candidate] (9.357 s) : 0, 9356901
section appsec
Agent [baseline] (1.156 s) : 0, 1155842
Total [baseline] (9.556 s) : 0, 9555978
Agent [candidate] (1.154 s) : 0, 1153980
Total [candidate] (9.458 s) : 0, 9458019
section iast
Agent [baseline] (1.169 s) : 0, 1169189
Total [baseline] (9.559 s) : 0, 9559481
Agent [candidate] (1.182 s) : 0, 1181557
Total [candidate] (9.67 s) : 0, 9669677
section profiling
Agent [baseline] (1.281 s) : 0, 1280884
Total [baseline] (9.684 s) : 0, 9684150
Agent [candidate] (1.274 s) : 0, 1274174
Total [candidate] (9.623 s) : 0, 9622723
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.156 s 101.35 ms (9.6%)
Agent iast 1.169 s 114.696 ms (10.9%)
Agent profiling 1.281 s 226.392 ms (21.5%)
Total tracing 9.351 s -
Total appsec 9.556 s 205.335 ms (2.2%)
Total iast 9.559 s 208.838 ms (2.2%)
Total profiling 9.684 s 333.507 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.154 s 100.306 ms (9.5%)
Agent iast 1.182 s 127.882 ms (12.1%)
Agent profiling 1.274 s 220.5 ms (20.9%)
Total tracing 9.357 s -
Total appsec 9.458 s 101.118 ms (1.1%)
Total iast 9.67 s 312.776 ms (3.3%)
Total profiling 9.623 s 265.822 ms (2.8%)
gantt
    title petclinic - break down per module: candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (652.95 ms) : 0, 652950
BytebuddyAgent [candidate] (651.717 ms) : 0, 651717
GlobalTracer [baseline] (308.343 ms) : 0, 308343
GlobalTracer [candidate] (308.989 ms) : 0, 308989
AppSec [baseline] (50.881 ms) : 0, 50881
AppSec [candidate] (50.654 ms) : 0, 50654
Remote Config [baseline] (679.248 µs) : 0, 679
Remote Config [candidate] (678.379 µs) : 0, 678
Telemetry [baseline] (7.29 ms) : 0, 7290
Telemetry [candidate] (7.308 ms) : 0, 7308
section appsec
BytebuddyAgent [baseline] (655.144 ms) : 0, 655144
BytebuddyAgent [candidate] (652.216 ms) : 0, 652216
GlobalTracer [baseline] (309.143 ms) : 0, 309143
GlobalTracer [candidate] (310.179 ms) : 0, 310179
AppSec [baseline] (149.512 ms) : 0, 149512
AppSec [candidate] (149.655 ms) : 0, 149655
Remote Config [baseline] (650.209 µs) : 0, 650
Remote Config [candidate] (652.814 µs) : 0, 653
Telemetry [baseline] (6.946 ms) : 0, 6946
Telemetry [candidate] (6.957 ms) : 0, 6957
section iast
BytebuddyAgent [baseline] (770.611 ms) : 0, 770611
BytebuddyAgent [candidate] (777.258 ms) : 0, 777258
GlobalTracer [baseline] (284.757 ms) : 0, 284757
GlobalTracer [candidate] (288.94 ms) : 0, 288940
AppSec [baseline] (53.151 ms) : 0, 53151
AppSec [candidate] (54.015 ms) : 0, 54015
Remote Config [baseline] (570.53 µs) : 0, 571
Remote Config [candidate] (585.233 µs) : 0, 585
Telemetry [baseline] (7.364 ms) : 0, 7364
Telemetry [candidate] (8.124 ms) : 0, 8124
IAST [baseline] (18.416 ms) : 0, 18416
IAST [candidate] (18.093 ms) : 0, 18093
section profiling
BytebuddyAgent [baseline] (665.654 ms) : 0, 665654
BytebuddyAgent [candidate] (661.682 ms) : 0, 661682
GlobalTracer [baseline] (377.218 ms) : 0, 377218
GlobalTracer [candidate] (376.057 ms) : 0, 376057
AppSec [baseline] (51.424 ms) : 0, 51424
AppSec [candidate] (50.835 ms) : 0, 50835
Remote Config [baseline] (1.008 ms) : 0, 1008
Remote Config [candidate] (1.007 ms) : 0, 1007
Telemetry [baseline] (7.24 ms) : 0, 7240
Telemetry [candidate] (7.262 ms) : 0, 7262
ProfilingAgent [baseline] (123.675 ms) : 0, 123675
ProfilingAgent [candidate] (122.89 ms) : 0, 122890
Profiling [baseline] (123.7 ms) : 0, 123700
Profiling [candidate] (122.915 ms) : 0, 122915
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056535
Total [baseline] (8.736 s) : 0, 8736132
Agent [candidate] (1.051 s) : 0, 1050721
Total [candidate] (8.772 s) : 0, 8771620
section iast
Agent [baseline] (1.169 s) : 0, 1168655
Total [baseline] (9.268 s) : 0, 9268386
Agent [candidate] (1.17 s) : 0, 1170354
Total [candidate] (9.262 s) : 0, 9262267
section iast_TELEMETRY_OFF
Agent [baseline] (1.16 s) : 0, 1159661
Total [baseline] (9.243 s) : 0, 9243123
Agent [candidate] (1.181 s) : 0, 1180583
Total [candidate] (9.267 s) : 0, 9266715
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.169 s 112.12 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.16 s 103.126 ms (9.8%)
Total tracing 8.736 s -
Total iast 9.268 s 532.255 ms (6.1%)
Total iast_TELEMETRY_OFF 9.243 s 506.992 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.051 s -
Agent iast 1.17 s 119.633 ms (11.4%)
Agent iast_TELEMETRY_OFF 1.181 s 129.862 ms (12.4%)
Total tracing 8.772 s -
Total iast 9.262 s 490.648 ms (5.6%)
Total iast_TELEMETRY_OFF 9.267 s 495.095 ms (5.6%)
gantt
    title insecure-bank - break down per module: candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (653.881 ms) : 0, 653881
BytebuddyAgent [candidate] (650.7 ms) : 0, 650700
GlobalTracer [baseline] (309.404 ms) : 0, 309404
GlobalTracer [candidate] (307.344 ms) : 0, 307344
AppSec [baseline] (50.908 ms) : 0, 50908
AppSec [candidate] (50.529 ms) : 0, 50529
Remote Config [baseline] (673.099 µs) : 0, 673
Remote Config [candidate] (668.701 µs) : 0, 669
Telemetry [baseline] (7.194 ms) : 0, 7194
Telemetry [candidate] (7.167 ms) : 0, 7167
section iast
BytebuddyAgent [baseline] (770.232 ms) : 0, 770232
BytebuddyAgent [candidate] (770.547 ms) : 0, 770547
GlobalTracer [baseline] (285.336 ms) : 0, 285336
GlobalTracer [candidate] (286.103 ms) : 0, 286103
AppSec [baseline] (54.874 ms) : 0, 54874
AppSec [candidate] (54.878 ms) : 0, 54878
Remote Config [baseline] (570.877 µs) : 0, 571
Remote Config [candidate] (579.423 µs) : 0, 579
Telemetry [baseline] (6.471 ms) : 0, 6471
Telemetry [candidate] (7.232 ms) : 0, 7232
IAST [baseline] (16.831 ms) : 0, 16831
IAST [candidate] (16.638 ms) : 0, 16638
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (761.184 ms) : 0, 761184
BytebuddyAgent [candidate] (775.814 ms) : 0, 775814
GlobalTracer [baseline] (285.364 ms) : 0, 285364
GlobalTracer [candidate] (289.822 ms) : 0, 289822
AppSec [baseline] (49.197 ms) : 0, 49197
AppSec [candidate] (49.935 ms) : 0, 49935
Remote Config [baseline] (567.076 µs) : 0, 567
Remote Config [candidate] (581.291 µs) : 0, 581
Telemetry [baseline] (6.435 ms) : 0, 6435
Telemetry [candidate] (6.522 ms) : 0, 6522
IAST [baseline] (22.642 ms) : 0, 22642
IAST [candidate] (23.177 ms) : 0, 23177

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-01-05T14:06:26 2024-01-05T14:23:01
git_branch master mcculls/ignore-unexpected-context-store-access
git_commit_date 1704390361 1704462132
git_commit_sha c784ae91b5 c85026c785
release_version 1.28.0-SNAPSHOT~c784ae91b5 1.28.0-SNAPSHOT~c85026c785
start_time 2024-01-05T14:06:13 2024-01-05T14:22:48
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1704464836 1704464836
ci_job_id 401563350 401563350
ci_pipeline_id 25947059 25947059
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 13 unstable metrics.

Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1326, 1364
.   : milestone, 1345,
appsec (1.751 ms) : 1726, 1777
.   : milestone, 1751,
iast (1.538 ms) : 1514, 1562
.   : milestone, 1538,
profiling (1.523 ms) : 1497, 1549
.   : milestone, 1523,
tracing (1.49 ms) : 1466, 1515
.   : milestone, 1490,
section candidate
no_agent (1.361 ms) : 1342, 1381
.   : milestone, 1361,
appsec (1.748 ms) : 1723, 1773
.   : milestone, 1748,
iast (1.534 ms) : 1510, 1558
.   : milestone, 1534,
profiling (1.546 ms) : 1519, 1573
.   : milestone, 1546,
tracing (1.507 ms) : 1482, 1531
.   : milestone, 1507,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.326 ms, 1.364 ms] -
appsec 1.751 ms [1.726 ms, 1.777 ms] 405.918 µs (30.2%)
iast 1.538 ms [1.514 ms, 1.562 ms] 192.487 µs (14.3%)
profiling 1.523 ms [1.497 ms, 1.549 ms] 177.724 µs (13.2%)
tracing 1.49 ms [1.466 ms, 1.515 ms] 144.918 µs (10.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.361 ms [1.342 ms, 1.381 ms] -
appsec 1.748 ms [1.723 ms, 1.773 ms] 386.624 µs (28.4%)
iast 1.534 ms [1.51 ms, 1.558 ms] 172.778 µs (12.7%)
profiling 1.546 ms [1.519 ms, 1.573 ms] 184.552 µs (13.6%)
tracing 1.507 ms [1.482 ms, 1.531 ms] 145.276 µs (10.7%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.28.0-SNAPSHOT~c85026c785, baseline=1.28.0-SNAPSHOT~c784ae91b5
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.546 µs) : 348, 389
.   : milestone, 369,
iast (472.605 µs) : 452, 493
.   : milestone, 473,
iast_FULL (539.068 µs) : 519, 560
.   : milestone, 539,
iast_INACTIVE (446.755 µs) : 426, 468
.   : milestone, 447,
iast_TELEMETRY_OFF (473.152 µs) : 453, 494
.   : milestone, 473,
tracing (446.726 µs) : 426, 468
.   : milestone, 447,
section candidate
no_agent (373.744 µs) : 352, 395
.   : milestone, 374,
iast (480.0 µs) : 459, 501
.   : milestone, 480,
iast_FULL (539.307 µs) : 519, 560
.   : milestone, 539,
iast_INACTIVE (449.66 µs) : 428, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (468.829 µs) : 449, 489
.   : milestone, 469,
tracing (440.623 µs) : 420, 461
.   : milestone, 441,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.546 µs [348.421 µs, 388.672 µs] -
iast 472.605 µs [452.293 µs, 492.918 µs] 104.059 µs (28.2%)
iast_FULL 539.068 µs [518.618 µs, 559.518 µs] 170.521 µs (46.3%)
iast_INACTIVE 446.755 µs [425.922 µs, 467.587 µs] 78.208 µs (21.2%)
iast_TELEMETRY_OFF 473.152 µs [452.747 µs, 493.558 µs] 104.606 µs (28.4%)
tracing 446.726 µs [425.78 µs, 467.672 µs] 78.18 µs (21.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.744 µs [352.422 µs, 395.067 µs] -
iast 480.0 µs [459.363 µs, 500.637 µs] 106.255 µs (28.4%)
iast_FULL 539.307 µs [518.942 µs, 559.673 µs] 165.563 µs (44.3%)
iast_INACTIVE 449.66 µs [428.286 µs, 471.034 µs] 75.916 µs (20.3%)
iast_TELEMETRY_OFF 468.829 µs [448.576 µs, 489.081 µs] 95.084 µs (25.4%)
tracing 440.623 µs [420.076 µs, 461.171 µs] 66.879 µs (17.9%)

pr-commenter[bot] avatar Jan 05 '24 14:01 pr-commenter[bot]