dd-trace-java icon indicating copy to clipboard operation
dd-trace-java copied to clipboard

Flush data streams stats when lambda stops

Open piochelepiotr opened this issue 2 years ago • 1 comments
trafficstars

What Does This Do

Flush Data Streams Monitoring stats when tracer is stopped. For example, when Lambda function exits.

Motivation

Data Streams stats were missing when executing Lambda functions

Additional Notes

Jira ticket: [PROJ-IDENT]

piochelepiotr avatar Oct 10 '23 02:10 piochelepiotr

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master piotr-wolski/flush-data-streams-lambda-stop
git_commit_date 1702387995 1702388246
git_commit_sha c056a84dad c79692656f
release_version 1.26.0-SNAPSHOT~c056a84dad 1.26.0-SNAPSHOT~c79692656f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702390800 1702390800
ci_job_id 387752961 387752961
ci_pipeline_id 24914688 24914688
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 7 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044684
Total [baseline] (8.739 s) : 0, 8738580
Agent [candidate] (1.047 s) : 0, 1047088
Total [candidate] (8.706 s) : 0, 8705635
section iast
Agent [baseline] (1.16 s) : 0, 1159789
Total [baseline] (9.251 s) : 0, 9250933
Agent [candidate] (1.162 s) : 0, 1161640
Total [candidate] (9.273 s) : 0, 9272605
section iast_TELEMETRY_OFF
Agent [baseline] (1.153 s) : 0, 1153347
Total [baseline] (9.257 s) : 0, 9256601
Agent [candidate] (1.155 s) : 0, 1154839
Total [candidate] (9.281 s) : 0, 9281305
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.16 s 115.106 ms (11.0%)
Agent iast_TELEMETRY_OFF 1.153 s 108.663 ms (10.4%)
Total tracing 8.739 s -
Total iast 9.251 s 512.354 ms (5.9%)
Total iast_TELEMETRY_OFF 9.257 s 518.021 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.162 s 114.552 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.155 s 107.75 ms (10.3%)
Total tracing 8.706 s -
Total iast 9.273 s 566.971 ms (6.5%)
Total iast_TELEMETRY_OFF 9.281 s 575.67 ms (6.6%)
gantt
    title insecure-bank - break down per module: candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (646.399 ms) : 0, 646399
BytebuddyAgent [candidate] (647.594 ms) : 0, 647594
GlobalTracer [baseline] (307.497 ms) : 0, 307497
GlobalTracer [candidate] (307.957 ms) : 0, 307957
AppSec [baseline] (48.658 ms) : 0, 48658
AppSec [candidate] (49.403 ms) : 0, 49403
Remote Config [baseline] (670.062 µs) : 0, 670
Remote Config [candidate] (666.473 µs) : 0, 666
Telemetry [baseline] (7.098 ms) : 0, 7098
Telemetry [candidate] (7.199 ms) : 0, 7199
section iast
BytebuddyAgent [baseline] (764.967 ms) : 0, 764967
BytebuddyAgent [candidate] (767.05 ms) : 0, 767050
GlobalTracer [baseline] (285.089 ms) : 0, 285089
GlobalTracer [candidate] (285.569 ms) : 0, 285569
AppSec [baseline] (46.549 ms) : 0, 46549
AppSec [candidate] (46.69 ms) : 0, 46690
IAST [baseline] (21.717 ms) : 0, 21717
IAST [candidate] (19.418 ms) : 0, 19418
Remote Config [baseline] (594.722 µs) : 0, 595
Remote Config [candidate] (602.381 µs) : 0, 602
Telemetry [baseline] (6.528 ms) : 0, 6528
Telemetry [candidate] (8.032 ms) : 0, 8032
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (759.576 ms) : 0, 759576
BytebuddyAgent [candidate] (759.614 ms) : 0, 759614
GlobalTracer [baseline] (285.88 ms) : 0, 285880
GlobalTracer [candidate] (286.134 ms) : 0, 286134
AppSec [baseline] (46.354 ms) : 0, 46354
AppSec [candidate] (46.99 ms) : 0, 46990
IAST [baseline] (17.143 ms) : 0, 17143
IAST [candidate] (19.435 ms) : 0, 19435
Remote Config [baseline] (614.778 µs) : 0, 615
Remote Config [candidate] (603.086 µs) : 0, 603
Telemetry [baseline] (9.497 ms) : 0, 9497
Telemetry [candidate] (7.895 ms) : 0, 7895
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052359
Total [baseline] (9.399 s) : 0, 9398691
Agent [candidate] (1.046 s) : 0, 1046459
Total [candidate] (9.326 s) : 0, 9325879
section appsec
Agent [baseline] (1.134 s) : 0, 1133807
Total [baseline] (9.49 s) : 0, 9489747
Agent [candidate] (1.132 s) : 0, 1131926
Total [candidate] (9.43 s) : 0, 9429932
section iast
Agent [baseline] (1.174 s) : 0, 1174085
Total [baseline] (9.618 s) : 0, 9618384
Agent [candidate] (1.164 s) : 0, 1164120
Total [candidate] (9.539 s) : 0, 9538799
section profiling
Agent [baseline] (1.235 s) : 0, 1234593
Total [baseline] (9.591 s) : 0, 9590799
Agent [candidate] (1.243 s) : 0, 1243429
Total [candidate] (9.647 s) : 0, 9647353
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.052 s -
Agent appsec 1.134 s 81.448 ms (7.7%)
Agent iast 1.174 s 121.727 ms (11.6%)
Agent profiling 1.235 s 182.234 ms (17.3%)
Total tracing 9.399 s -
Total appsec 9.49 s 91.056 ms (1.0%)
Total iast 9.618 s 219.692 ms (2.3%)
Total profiling 9.591 s 192.108 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.132 s 85.468 ms (8.2%)
Agent iast 1.164 s 117.661 ms (11.2%)
Agent profiling 1.243 s 196.97 ms (18.8%)
Total tracing 9.326 s -
Total appsec 9.43 s 104.053 ms (1.1%)
Total iast 9.539 s 212.92 ms (2.3%)
Total profiling 9.647 s 321.473 ms (3.4%)
gantt
    title petclinic - break down per module: candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.188 ms) : 0, 650188
BytebuddyAgent [candidate] (647.713 ms) : 0, 647713
GlobalTracer [baseline] (310.31 ms) : 0, 310310
GlobalTracer [candidate] (307.907 ms) : 0, 307907
AppSec [baseline] (49.547 ms) : 0, 49547
AppSec [candidate] (48.831 ms) : 0, 48831
Remote Config [baseline] (685.572 µs) : 0, 686
Remote Config [candidate] (661.827 µs) : 0, 662
Telemetry [baseline] (7.215 ms) : 0, 7215
Telemetry [candidate] (7.095 ms) : 0, 7095
section appsec
BytebuddyAgent [baseline] (645.684 ms) : 0, 645684
BytebuddyAgent [candidate] (646.056 ms) : 0, 646056
GlobalTracer [baseline] (308.527 ms) : 0, 308527
GlobalTracer [candidate] (307.349 ms) : 0, 307349
AppSec [baseline] (137.122 ms) : 0, 137122
AppSec [candidate] (136.922 ms) : 0, 136922
Remote Config [baseline] (645.469 µs) : 0, 645
Remote Config [candidate] (641.123 µs) : 0, 641
Telemetry [baseline] (7.549 ms) : 0, 7549
Telemetry [candidate] (6.857 ms) : 0, 6857
section iast
BytebuddyAgent [baseline] (775.816 ms) : 0, 775816
BytebuddyAgent [candidate] (768.016 ms) : 0, 768016
GlobalTracer [baseline] (288.56 ms) : 0, 288560
GlobalTracer [candidate] (285.842 ms) : 0, 285842
AppSec [baseline] (47.154 ms) : 0, 47154
AppSec [candidate] (47.09 ms) : 0, 47090
Remote Config [baseline] (624.779 µs) : 0, 625
Remote Config [candidate] (602.621 µs) : 0, 603
Telemetry [baseline] (7.455 ms) : 0, 7455
Telemetry [candidate] (6.577 ms) : 0, 6577
IAST [baseline] (19.672 ms) : 0, 19672
IAST [candidate] (21.656 ms) : 0, 21656
section profiling
ProfilingAgent [baseline] (89.018 ms) : 0, 89018
ProfilingAgent [candidate] (88.994 ms) : 0, 88994
BytebuddyAgent [baseline] (656.38 ms) : 0, 656380
BytebuddyAgent [candidate] (663.059 ms) : 0, 663059
GlobalTracer [baseline] (378.282 ms) : 0, 378282
GlobalTracer [candidate] (379.711 ms) : 0, 379711
AppSec [baseline] (48.651 ms) : 0, 48651
AppSec [candidate] (48.955 ms) : 0, 48955
Remote Config [baseline] (680.313 µs) : 0, 680
Remote Config [candidate] (682.23 µs) : 0, 682
Telemetry [baseline] (7.43 ms) : 0, 7430
Telemetry [candidate] (7.493 ms) : 0, 7493
Profiling [baseline] (89.043 ms) : 0, 89043
Profiling [candidate] (89.02 ms) : 0, 89020

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2023-12-12T13:59:12 2023-12-12T14:15:46
git_branch master piotr-wolski/flush-data-streams-lambda-stop
git_commit_date 1702387995 1702388246
git_commit_sha c056a84dad c79692656f
release_version 1.26.0-SNAPSHOT~c056a84dad 1.26.0-SNAPSHOT~c79692656f
start_time 2023-12-12T13:58:59 2023-12-12T14:15:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1702390800 1702390800
ci_job_id 387752961 387752961
ci_pipeline_id 24914688 24914688
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.942 µs) : 345, 385
.   : milestone, 365,
iast (480.216 µs) : 460, 501
.   : milestone, 480,
iast_FULL (546.398 µs) : 526, 567
.   : milestone, 546,
iast_INACTIVE (448.599 µs) : 428, 469
.   : milestone, 449,
iast_TELEMETRY_OFF (479.372 µs) : 458, 500
.   : milestone, 479,
tracing (448.492 µs) : 428, 469
.   : milestone, 448,
section candidate
no_agent (371.551 µs) : 350, 393
.   : milestone, 372,
iast (482.76 µs) : 462, 503
.   : milestone, 483,
iast_FULL (541.474 µs) : 521, 562
.   : milestone, 541,
iast_INACTIVE (447.561 µs) : 427, 468
.   : milestone, 448,
iast_TELEMETRY_OFF (471.317 µs) : 450, 493
.   : milestone, 471,
tracing (444.9 µs) : 424, 466
.   : milestone, 445,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.942 µs [345.282 µs, 384.602 µs] -
iast 480.216 µs [459.654 µs, 500.778 µs] 115.274 µs (31.6%)
iast_FULL 546.398 µs [525.821 µs, 566.975 µs] 181.457 µs (49.7%)
iast_INACTIVE 448.599 µs [428.068 µs, 469.131 µs] 83.658 µs (22.9%)
iast_TELEMETRY_OFF 479.372 µs [458.372 µs, 500.372 µs] 114.43 µs (31.4%)
tracing 448.492 µs [427.937 µs, 469.047 µs] 83.551 µs (22.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.551 µs [350.184 µs, 392.918 µs] -
iast 482.76 µs [462.441 µs, 503.079 µs] 111.209 µs (29.9%)
iast_FULL 541.474 µs [521.087 µs, 561.861 µs] 169.923 µs (45.7%)
iast_INACTIVE 447.561 µs [427.134 µs, 467.988 µs] 76.01 µs (20.5%)
iast_TELEMETRY_OFF 471.317 µs [450.102 µs, 492.533 µs] 99.767 µs (26.9%)
tracing 444.9 µs [424.072 µs, 465.728 µs] 73.349 µs (19.7%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.26.0-SNAPSHOT~c79692656f, baseline=1.26.0-SNAPSHOT~c056a84dad
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1385
.   : milestone, 1366,
appsec (1.759 ms) : 1734, 1784
.   : milestone, 1759,
iast (1.537 ms) : 1513, 1561
.   : milestone, 1537,
profiling (1.532 ms) : 1506, 1557
.   : milestone, 1532,
tracing (1.506 ms) : 1482, 1531
.   : milestone, 1506,
section candidate
no_agent (1.366 ms) : 1346, 1385
.   : milestone, 1366,
appsec (1.744 ms) : 1719, 1770
.   : milestone, 1744,
iast (1.545 ms) : 1521, 1570
.   : milestone, 1545,
profiling (1.531 ms) : 1506, 1556
.   : milestone, 1531,
tracing (1.505 ms) : 1480, 1529
.   : milestone, 1505,
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.347 ms, 1.385 ms] -
appsec 1.759 ms [1.734 ms, 1.784 ms] 392.685 µs (28.7%)
iast 1.537 ms [1.513 ms, 1.561 ms] 170.88 µs (12.5%)
profiling 1.532 ms [1.506 ms, 1.557 ms] 165.594 µs (12.1%)
tracing 1.506 ms [1.482 ms, 1.531 ms] 140.024 µs (10.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.366 ms [1.346 ms, 1.385 ms] -
appsec 1.744 ms [1.719 ms, 1.77 ms] 378.883 µs (27.7%)
iast 1.545 ms [1.521 ms, 1.57 ms] 179.84 µs (13.2%)
profiling 1.531 ms [1.506 ms, 1.556 ms] 165.807 µs (12.1%)
tracing 1.505 ms [1.48 ms, 1.529 ms] 139.179 µs (10.2%)

pr-commenter[bot] avatar Oct 10 '23 02:10 pr-commenter[bot]