dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

[POC] experimenting Orchestrion for lambda

Open joeyzhao2018 opened this issue 5 months ago • 4 comments

What does this PR do?

Motivation

Reviewer's Checklist

  • [ ] Changed code has unit tests for its functionality at or near 100% coverage.
  • [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • [ ] There is a benchmark for any new code, or changes to existing code.
  • [ ] If this interacts with the agent in a new way, a system test has been added.
  • [ ] New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

joeyzhao2018 avatar Aug 02 '25 01:08 joeyzhao2018

Benchmarks

Benchmark execution time: 2025-08-02 01:34:04

Comparing candidate commit 12357d7b58c292ec83325644b2daf5a01be3e261 in PR branch joey/orchestrion-lambda with baseline commit e03025875ae009664b423e56dfb622e4e89e6c32 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

pr-commenter[bot] avatar Aug 02 '25 01:08 pr-commenter[bot]

⚠️ Tests

⚠️ Warnings

🧪 4 Tests failed

TestGetEventType from github.com/DataDog/dd-trace-go/contrib/aws/aws-lambda-go/v2 (Datadog)
Failed

=== RUN   TestGetEventType
--- FAIL: TestGetEventType (0.00s)
TestGetEventType/ALB from github.com/DataDog/dd-trace-go/contrib/aws/aws-lambda-go/v2 (Datadog)
Failed

=== RUN   TestGetEventType/ALB
    lambda_test.go:144: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-lambda-go/lambda_test.go:144
        	Error:      	Not equal: 
        	            	expected: "aws:alb"
        	            	actual  : "aws:apigateway"
        	            	
        	            	Diff:
...
TestIntegrationEnabled from github.com/DataDog/dd-trace-go/v2/instrumentation (Datadog)
Failed

=== RUN   TestIntegrationEnabled
    contrib_test.go:31: /home/runner/work/dd-trace-go/dd-trace-go/contrib/99designs/gqlgen
    contrib_test.go:31: /home/runner/work/dd-trace-go/dd-trace-go/contrib/IBM/sarama
    contrib_test.go:31: /home/runner/work/dd-trace-go/dd-trace-go/contrib/Shopify/sarama
    contrib_test.go:31: /home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-lambda-go
--- FAIL: TestIntegrationEnabled (0.08s)
❄️ Known flaky: TestTelemetryEnabled from github.com/DataDog/dd-trace-go/v2/instrumentation/internal/telemetrytest (Datadog)
Failed

=== RUN   TestTelemetryEnabled
    telemetry_test.go:49: /home/runner/work/dd-trace-go/dd-trace-go/contrib/99designs/gqlgen
    telemetry_test.go:49: /home/runner/work/dd-trace-go/dd-trace-go/contrib/IBM/sarama
    telemetry_test.go:49: /home/runner/work/dd-trace-go/dd-trace-go/contrib/Shopify/sarama
    telemetry_test.go:49: /home/runner/work/dd-trace-go/dd-trace-go/contrib/aws/aws-lambda-go
--- FAIL: TestTelemetryEnabled (5.39s)
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 12357d7 | Docs | Was this helpful? Give us feedback!

@joeyzhao2018 Is this PR alive?

darccio avatar Nov 14 '25 16:11 darccio

@darccio we still plan to do it. but probably Q1 ....

joeyzhao2018 avatar Nov 17 '25 19:11 joeyzhao2018