dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

profiler: use faster gzip for delta decompression

Open nsrip-dd opened this issue 7 months ago • 1 comments

What does this PR do?

For delta profiles, use github.com/klauspost/compress/gzip rather than compress/gzip.

Motivation

It's faster, and we already use it for other decompression after introducing recompression to zstd, so we might as well use it for decompressing during delta computeation too.

nsrip-dd avatar May 29 '25 15:05 nsrip-dd

Benchmarks

Benchmark execution time: 2025-06-04 12:40:13

Comparing candidate commit 6840c862d497030a25dd2213ea0b18dfbfb40a46 in PR branch push-luqzotwszlpp with baseline commit b7ba964b4ad3df3b065cafa664db9a8d21105217 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 21 metrics, 0 unstable metrics.

pr-commenter[bot] avatar Jun 03 '25 15:06 pr-commenter[bot]

@nsrip-dd Is this PR alive?

darccio avatar Nov 14 '25 15:11 darccio

@nsrip-dd Is this PR alive?

We can close it for now. I'll reopen/recreate if I actually get back to this.

nsrip-dd avatar Nov 14 '25 16:11 nsrip-dd