dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard
verified publisher icon DataDog

contrib/gomodule/redigo: adds the DialURLContext method

Open Succo opened this issue 1 year ago • 1 comments

Matches what the redigo package provides. Also rewrite non context variant of dialer to use Context equivalent with context.Background

What does this PR do?

Matches what the redigo package provides. Also rewrite non context variant of dialer to use Context equivalent with context.Background

Motivation

Matches what the redigo package provides is done so that DialURL can propagates the caller context.

Also rewrite non context variant of dialer to use Context equivalent with context.Background is done to reduce duplication in code and ensure switching to the Context aware variant has no side effect.

Reviewer's Checklist

  • [ ] Changed code has unit tests for its functionality at or near 100% coverage.
  • [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • [ ] There is a benchmark for any new code, or changes to existing code.
  • [ ] If this interacts with the agent in a new way, a system test has been added.
  • [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • [ ] For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Succo avatar Dec 06 '24 11:12 Succo

@DataDog/apm-idm-go Please, can you review this?

darccio avatar Mar 10 '25 16:03 darccio

/merge

rarguelloF avatar Aug 27 '25 09:08 rarguelloF

View all feedbacks in Devflow UI.

2025-08-27 09:26:27 UTC :information_source: Start processing command /merge

2025-08-27 09:26:42 UTC :information_source: MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Note: if you pushed new commits since the last approval, you may need additional approval. You can remove it from the waiting list with /remove command.

2025-08-27 09:46:16 UTC :information_source: MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-27 09:57:39 UTC :x: MergeQueue: The checks failed on this merge request

Tests failed on this commit ae95167:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

dd-devflow-routing-codex[bot] avatar Aug 27 '25 09:08 dd-devflow-routing-codex[bot]

/merge

rarguelloF avatar Aug 27 '25 10:08 rarguelloF

View all feedbacks in Devflow UI.

2025-08-27 10:51:36 UTC :information_source: Start processing command /merge

2025-08-27 10:51:43 UTC :information_source: MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-27 11:02:06 UTC :information_source: MergeQueue: This merge request was merged

dd-devflow-routing-codex[bot] avatar Aug 27 '25 10:08 dd-devflow-routing-codex[bot]