dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

[BUG] 99designs/gqlgen/tracer.go: panic cause nil pointer

Open dienvoandpadcojp opened this issue 1 year ago • 0 comments

I was implement graphQL subscription, it just a simple subscription like this (https://gqlgen.com/recipes/subscriptions/) but I want to stop the subscription in server side so I close the response channel when there is no more data. But I found that in 99designs/gqlgen/tracer.go#L119 , there is missing check response nil. I think because we have to trace even if the response is nil, but when we get Data and Error from response it lead to panic.

Version of dd-trace-go v1.65.1 Describe what happened: When I want to stop the subscription from server side. I close channel and then I got panic: runtime error: invalid memory address or nil pointer dereference Describe what you expected: No panic when response from responseHandler(ctx) is nil

Steps to reproduce the issue:

Additional environment details (Version of Go, Operating System, etc.):

dienvoandpadcojp avatar Jul 17 '24 09:07 dienvoandpadcojp