dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

contrib/jackc/pgx.v5: publish pgxpool stats to statsd client

Open bengentree opened this issue 1 year ago • 1 comments

Fixes #2680

What does this PR do?

Adds a new option to contrib/jackc/pgx.v5 to enable polling and submission of pgxpool stats as metrics to Datadog Ref: https://pkg.go.dev/github.com/jackc/pgx/v5/pgxpool#Stat

Motivation

Reviewer's Checklist

  • [ ] Changed code has unit tests for its functionality at or near 100% coverage.
  • [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • [ ] There is a benchmark for any new code, or changes to existing code.
  • [ ] If this interacts with the agent in a new way, a system test has been added.
  • [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

bengentree avatar May 11 '24 16:05 bengentree

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 21 '24 01:06 github-actions[bot]

@rarguelloF @zarirhamza This looks good. Can you review it, please?

darccio avatar Jul 10 '24 08:07 darccio