dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

ddtrace/tracer: Add test to ensure global config inherits statsd address when configured with tracer.WithDogstatsdAddress

Open mtoffl01 opened this issue 1 year ago • 1 comments

What does this PR do?

Ensure that the address provided to the tracer via the WithDogstatsdAddress option is passed along to the globalconfig, for contribs to use. This includes a unix domain socket path.

Motivation

Cover a test case that was not previously covered

Reviewer's Checklist

  • [ ] Changed code has unit tests for its functionality at or near 100% coverage.
  • [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • [ ] There is a benchmark for any new code, or changes to existing code.
  • [ ] If this interacts with the agent in a new way, a system test has been added.
  • [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

mtoffl01 avatar May 02 '24 21:05 mtoffl01

Benchmarks

Benchmark execution time: 2024-05-09 20:52:54

Comparing candidate commit 847f04701a93a5affb4ddede62be2f29dc4bcaf4 in PR branch mtoff/dbstats-uds with baseline commit 3a426cad6b642bc0dab36d49c02f8e09b40529e5 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

pr-commenter[bot] avatar May 09 '24 20:05 pr-commenter[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 31 '24 01:05 github-actions[bot]

This PR was closed because it has been open for 30 days with no activity.

github-actions[bot] avatar Jun 30 '24 01:06 github-actions[bot]

@mtoffl01 Do you want to merge this PR?

darccio avatar Jul 03 '24 08:07 darccio

LGTM

darccio avatar Jul 05 '24 14:07 darccio