dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

[v2] ddtrace/tracer: tidy up Tracer interface

Open darccio opened this issue 3 months ago • 2 comments

What does this PR do?

This PR tidies up the Tracer interface for v2. It adds some functions to allow tracers implementing the interface to integrate with our implementation.

Motivation

v2 work was interrupted due to team changes. To reach release candidate quality we need to resolve pending TODOs regarding public API.

Reviewer's Checklist

  • [ ] Changed code has unit tests for its functionality at or near 100% coverage.
  • [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • [ ] There is a benchmark for any new code, or changes to existing code.
  • [ ] If this interacts with the agent in a new way, a system test has been added.
  • [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
  • [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • [ ] If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • [ ] This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

darccio avatar Mar 26 '24 15:03 darccio

Benchmarks

Benchmark execution time: 2024-03-26 15:51:28

Comparing candidate commit 7c15f9fc3ed7a03205e87fad823fbc88eafa0821 in PR branch dario.castane/tracer-iface-tidyup with baseline commit 42807ee071041470726be505c551c7a59be336d4 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

pr-commenter[bot] avatar Mar 26 '24 15:03 pr-commenter[bot]

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 01 '24 01:05 github-actions[bot]