dd-trace-go
dd-trace-go copied to clipboard
[data streams] process input when closing tracer
What does this PR do?
Today, closing the tracer can cause the last 10ms of payloads to be dropped. This is an issue for lambda functions.
Motivation
Reviewer's Checklist
- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
- [ ] There is a benchmark for any new code, or changes to existing code.
- [ ] If this interacts with the agent in a new way, a system test has been added.
- [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
For Datadog employees:
- [ ] If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from
@DataDog/security-design-and-guidance. - [ ] This PR doesn't touch any of that.
Unsure? Have a question? Request a review!
Benchmarks
Benchmark execution time: 2024-02-15 03:49:11
Comparing candidate commit 60b29e4ddb3921da3d45fc44fa2a81ffdb572103 in PR branch piotr-wolski/fix-data-streams-lambda with baseline commit dbe790f480b299cced9ae0801de694d6d38f522d in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR was closed because it has been open for 30 days with no activity.