dd-trace-go
dd-trace-go copied to clipboard
appsec: add Start() and Stop() to API
What does this PR do?
This PR adds Start and Stop and options to it on the appsec public API for a programmatic access to enabling ASM Threats.
Motivation
We would like to have a way to enable and configure ASM directly in consul internally in Datadog. A Version 1 of this works already but requires to redeploy everything which can be slow and cannot be done by us. A way to dynamically activate ASM but more granularly than Remote Activation is required to make this happen.
Reviewer's Checklist
- [ ] Changed code has unit tests for its functionality at or near 100% coverage.
- [ ] System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
- [ ] There is a benchmark for any new code, or changes to existing code.
- [ ] If this interacts with the agent in a new way, a system test has been added.
- [ ] Add an appropriate team label so this PR gets put in the right place for the release notes.
- [ ] Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
For Datadog employees:
- [ ] If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from
@DataDog/security-design-and-guidance. - [ ] This PR doesn't touch any of that.
Unsure? Have a question? Request a review!
Benchmarks
Benchmark execution time: 2024-01-25 16:50:37
Comparing candidate commit 33d82494ed553ad49282f46d1b53b2c1f415e44d in PR branch eliott.bouhana/public-appsec-start with baseline commit c03c56b47042238f18d16f623b4f6918a9a14e9c in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR was closed because it has been open for 30 days with no activity.