dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

contrib/aws-sdk-go: add WithErrorCheck for aws sdk (v1 & v2)

Open amwill04 opened this issue 1 year ago • 1 comments

Adds WithErrorCheck option to aws so an error can be determined if it should be marked as an error or not. Been added to both contrib/aws-sdk-go and contrib/aws-sdk-go-v2

Closes #1664. Code is taken from #1315

amwill04 avatar Apr 06 '23 11:04 amwill04

@amwill04 it looks like this has actually already been completed and merged here: https://github.com/DataDog/dd-trace-go/pull/2042 and https://github.com/DataDog/dd-trace-go/pull/1682

When I resolved the merge conflicts, only test changes remained.

Are we good to close this PR then? Thanks for contributing it regardless, and apologies for the delay and back and forth. Glad to see the feature is already supported though 😄

katiehockman avatar Nov 28 '23 21:11 katiehockman

Closing as this has been already implemented in https://github.com/DataDog/dd-trace-go/pull/2042 and https://github.com/DataDog/dd-trace-go/pull/1682.

rarguelloF avatar Jun 27 '24 10:06 rarguelloF