dd-trace-go icon indicating copy to clipboard operation
dd-trace-go copied to clipboard

contrib/net/http Add WithQueryParams option to include query params in the value for http.url tag in trace

Open abhishp opened this issue 3 years ago • 2 comments

What does this PR do?

  • Add an option in the net/http tracer contrib package to toggle query parameters inclusion in the http.url span tag.

Motivation

  • The httputil.TracerConfig supports the QueryParams config but the same is not exposed as a http.Option function in the contrib/net/http package.

Describe how to test/QA your changes

  • Have added unit test which should test these changes.

Reviewer's Checklist

  • [ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • [x] Changed code has unit tests for its functionality.
  • [ ] If this interacts with the agent in a new way, a system test has been added.

abhishp avatar Nov 14 '22 20:11 abhishp

@knusbaum can you please approve the PR again? The review got dismissed after rebasing the PR.

abhishp avatar Jun 27 '23 10:06 abhishp

Hi @abhishp, there are some small issues with the code not compiling (missing commas, wrong struct field name), feel free to ping me for a quick review after you fix those 🙌

dianashevchenko avatar Jul 26 '23 13:07 dianashevchenko