dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Config Registry] 7/7 Integration names to keys

Open anna-git opened this issue 3 weeks ago • 2 comments

Context

Part of Configuration Inversion (Step 6) - Stack progress:

  1. #7548 - Add GitLab step and JSON configuration file
  2. #7688 - Cleanup configuration / platform keys + source generator
  3. #7698 - Aliases handling via source generator
  4. #7689 - Analyzers for platform and ConfigurationBuilder
  5. #7931 - Replace manual ConfigurationKeys by generated ones in the whole solution
  6. #7932 - Forbid use of System.Environment methods and adapt everywhere
  7. → #7937 - Integration names to generated keys (this PR)

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

anna-git avatar Dec 10 '25 09:12 anna-git

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing This PR (7937) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration68.24 ± (68.23 - 68.42) ms68.26 ± (68.29 - 68.49) ms+0.0%✅⬆️
.NET Framework 4.8 - Bailout
duration71.98 ± (71.93 - 72.16) ms72.17 ± (72.18 - 72.40) ms+0.3%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1004.14 ± (1010.66 - 1020.72) ms1003.47 ± (1005.96 - 1012.54) ms-0.1%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms22.02 ± (21.98 - 22.06) ms21.98 ± (21.95 - 22.01) ms-0.2%✅
process.time_to_main_ms78.78 ± (78.61 - 78.95) ms78.66 ± (78.51 - 78.82) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.93 ± (10.92 - 10.93) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms21.93 ± (21.91 - 21.96) ms21.83 ± (21.81 - 21.85) ms-0.5%✅
process.time_to_main_ms79.86 ± (79.78 - 79.95) ms79.73 ± (79.63 - 79.84) ms-0.2%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.94 ± (10.94 - 10.95) MB10.95 ± (10.94 - 10.95) MB+0.0%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms210.36 ± (208.88 - 211.85) ms210.00 ± (208.62 - 211.39) ms-0.2%✅
process.time_to_main_ms471.25 ± (470.64 - 471.87) ms472.99 ± (472.50 - 473.49) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.09 ± (48.07 - 48.12) MB48.06 ± (48.05 - 48.08) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)+0.0%✅
.NET 6 - Baseline
process.internal_duration_ms20.79 ± (20.77 - 20.82) ms20.62 ± (20.59 - 20.65) ms-0.8%✅
process.time_to_main_ms68.40 ± (68.26 - 68.54) ms68.18 ± (68.06 - 68.30) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.59 ± (10.58 - 10.59) MB10.62 ± (10.62 - 10.63) MB+0.3%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms20.72 ± (20.70 - 20.75) ms20.47 ± (20.46 - 20.49) ms-1.2%✅
process.time_to_main_ms69.16 ± (69.10 - 69.23) ms68.74 ± (68.68 - 68.79) ms-0.6%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.71 ± (10.71 - 10.72) MB10.66 ± (10.66 - 10.66) MB-0.5%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms200.41 ± (199.51 - 201.32) ms199.48 ± (198.44 - 200.52) ms-0.5%✅
process.time_to_main_ms440.66 ± (439.87 - 441.44) ms439.50 ± (438.98 - 440.02) ms-0.3%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed48.45 ± (48.40 - 48.50) MB48.38 ± (48.30 - 48.45) MB-0.2%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms18.82 ± (18.79 - 18.85) ms18.80 ± (18.77 - 18.83) ms-0.1%✅
process.time_to_main_ms67.21 ± (67.10 - 67.31) ms66.93 ± (66.82 - 67.03) ms-0.4%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.65 ± (7.65 - 7.66) MB7.67 ± (7.66 - 7.67) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms18.70 ± (18.68 - 18.73) ms18.82 ± (18.79 - 18.85) ms+0.6%✅⬆️
process.time_to_main_ms68.06 ± (68.01 - 68.11) ms68.24 ± (68.18 - 68.29) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.72 ± (7.71 - 7.73) MB7.76 ± (7.74 - 7.77) MB+0.5%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms179.05 ± (178.19 - 179.90) ms179.54 ± (178.87 - 180.22) ms+0.3%✅⬆️
process.time_to_main_ms422.60 ± (422.13 - 423.07) ms425.42 ± (424.92 - 425.91) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed36.31 ± (36.28 - 36.34) MB36.39 ± (36.37 - 36.41) MB+0.2%✅⬆️
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)-0.0%✅

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.39 ± (193.35 - 194.00) ms193.37 ± (193.33 - 194.11) ms-0.0%✅
.NET Framework 4.8 - Bailout
duration196.97 ± (196.95 - 197.77) ms197.15 ± (197.05 - 197.63) ms+0.1%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1111.82 ± (1115.44 - 1124.23) ms1118.24 ± (1123.93 - 1133.78) ms+0.6%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms189.44 ± (189.00 - 189.88) ms187.78 ± (187.42 - 188.14) ms-0.9%✅
process.time_to_main_ms80.86 ± (80.65 - 81.08) ms80.61 ± (80.42 - 80.81) ms-0.3%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.08 ± (16.06 - 16.11) MB16.09 ± (16.06 - 16.12) MB+0.0%✅⬆️
runtime.dotnet.threads.count20 ± (20 - 20)20 ± (20 - 20)+0.5%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.26 ± (187.02 - 187.50) ms188.52 ± (188.24 - 188.81) ms+0.7%✅⬆️
process.time_to_main_ms82.11 ± (81.95 - 82.27) ms82.28 ± (82.11 - 82.46) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.17 ± (16.14 - 16.19) MB16.13 ± (16.11 - 16.14) MB-0.3%✅
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.3%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms398.17 ± (395.26 - 401.08) ms395.40 ± (392.47 - 398.32) ms-0.7%✅
process.time_to_main_ms474.49 ± (473.87 - 475.11) ms476.35 ± (475.68 - 477.01) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed58.08 ± (57.93 - 58.24) MB58.28 ± (58.13 - 58.43) MB+0.3%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.0%✅⬆️
.NET 6 - Baseline
process.internal_duration_ms192.09 ± (191.70 - 192.47) ms193.62 ± (193.16 - 194.08) ms+0.8%✅⬆️
process.time_to_main_ms69.83 ± (69.64 - 70.01) ms70.42 ± (70.22 - 70.61) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.20 ± (16.08 - 16.32) MB16.16 ± (16.04 - 16.28) MB-0.2%✅
runtime.dotnet.threads.count19 ± (18 - 19)19 ± (19 - 19)+0.8%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms191.49 ± (191.16 - 191.82) ms192.17 ± (191.79 - 192.55) ms+0.4%✅⬆️
process.time_to_main_ms70.81 ± (70.70 - 70.92) ms70.88 ± (70.78 - 70.98) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.27 ± (16.16 - 16.39) MB16.32 ± (16.23 - 16.41) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (20 - 20)+2.3%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.39 ± (408.89 - 413.89) ms409.61 ± (407.51 - 411.70) ms-0.4%✅
process.time_to_main_ms445.57 ± (444.98 - 446.16) ms452.68 ± (451.98 - 453.39) ms+1.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed59.30 ± (59.19 - 59.42) MB59.23 ± (59.10 - 59.36) MB-0.1%✅
runtime.dotnet.threads.count30 ± (29 - 30)30 ± (30 - 30)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.85 ± (190.48 - 191.21) ms194.09 ± (193.65 - 194.52) ms+1.7%✅⬆️
process.time_to_main_ms69.52 ± (69.35 - 69.70) ms70.87 ± (70.66 - 71.09) ms+1.9%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.73 ± (11.70 - 11.76) MB11.70 ± (11.68 - 11.72) MB-0.3%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.3%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms189.72 ± (189.46 - 189.97) ms190.88 ± (190.41 - 191.35) ms+0.6%✅⬆️
process.time_to_main_ms70.35 ± (70.26 - 70.44) ms70.75 ± (70.57 - 70.94) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.86 ± (11.83 - 11.89) MB11.80 ± (11.77 - 11.83) MB-0.5%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.4%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms365.97 ± (364.58 - 367.35) ms364.61 ± (362.95 - 366.26) ms-0.4%✅
process.time_to_main_ms427.54 ± (426.84 - 428.25) ms428.51 ± (427.93 - 429.10) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed47.98 ± (47.95 - 48.01) MB47.99 ± (47.95 - 48.02) MB+0.0%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (68ms)  : 67, 70
    master - mean (68ms)  : 67, 70

    section Bailout
    This PR (7937) - mean (72ms)  : 71, 73
    master - mean (72ms)  : 71, 73

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (1,009ms)  : 962, 1056
    master - mean (1,016ms)  : 942, 1090
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (106ms)  : 103, 109
    master - mean (106ms)  : 104, 108

    section Bailout
    This PR (7937) - mean (107ms)  : 106, 108
    master - mean (107ms)  : 106, 108

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (709ms)  : 682, 736
    master - mean (710ms)  : 683, 736
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (94ms)  : 91, 96
    master - mean (94ms)  : 92, 96

    section Bailout
    This PR (7937) - mean (94ms)  : 93, 95
    master - mean (95ms)  : 93, 96

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (665ms)  : 643, 687
    master - mean (668ms)  : 635, 701
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (92ms)  : 89, 94
    master - mean (92ms)  : 90, 94

    section Bailout
    This PR (7937) - mean (93ms)  : 92, 94
    master - mean (93ms)  : 91, 94

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (633ms)  : 614, 651
    master - mean (629ms)  : 614, 644
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (194ms)  : 189, 198
    master - mean (194ms)  : 190, 197

    section Bailout
    This PR (7937) - mean (197ms)  : 195, 200
    master - mean (197ms)  : 193, 201

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (1,129ms)  : 1052, 1205
    master - mean (1,120ms)  : 1054, 1186
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (277ms)  : 272, 283
    master - mean (279ms)  : 270, 288

    section Bailout
    This PR (7937) - mean (279ms)  : 273, 285
    master - mean (277ms)  : 274, 281

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (904ms)  : 862, 947
    master - mean (905ms)  : 854, 955
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (272ms)  : 266, 279
    master - mean (271ms)  : 266, 275

    section Bailout
    This PR (7937) - mean (271ms)  : 267, 276
    master - mean (270ms)  : 266, 274

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (898ms)  : 860, 935
    master - mean (891ms)  : 840, 942
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7937) - mean (275ms)  : 267, 282
    master - mean (270ms)  : 265, 274

    section Bailout
    This PR (7937) - mean (271ms)  : 265, 277
    master - mean (270ms)  : 266, 273

    section CallTarget+Inlining+NGEN
    This PR (7937) - mean (824ms)  : 805, 843
    master - mean (824ms)  : 802, 846

dd-trace-dotnet-ci-bot[bot] avatar Dec 10 '25 13:12 dd-trace-dotnet-ci-bot[bot]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 39 Tests failed

AllConfigurationValuesAreRegisteredWithIntake from Datadog.Trace.Tests.Telemetry.ConfigurationTests (Datadog) (Fix with Cursor) 
Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_AwsEventBridge_ENABLED"}.
AllConfigurationValuesAreRegisteredWithIntake from Datadog.Trace.Tests.Telemetry.ConfigurationTests (Datadog) (Fix with Cursor) 
Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_AwsEventBridge_ENABLED"}.
AllConfigurationValuesAreRegisteredWithIntake from Datadog.Trace.Tests.Telemetry.ConfigurationTests (Datadog) (Fix with Cursor) 
Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_AwsEventBridge_ENABLED"}.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c14af6e | Docs | Datadog PR Page | Was this helpful? Give us feedback!

datadog-official[bot] avatar Dec 10 '25 14:12 datadog-official[bot]