Stop storing tracer setting telemetry forever
Summary of changes
Stop storing the TracerSettings telemetry forever
Reason for change
Back in v2, when we first implemented config telemetry, we had to store the telemetry on TracerSettings, because a customer could "reconfigure" the tracer with an existing TracerSettings object, thereby overriding the "latest" config. Put another way, the config recorded when the TracerSettings was created, wasn't necessarily the config actually used.
As of v3, and particularly with the MutableSettings split, this is no longer the case. The TracerSettings object is created only once, and the results are immutable, so there's no need to keep the config around "just in case".
Implementation details
Instead of creating a dedicated ConfigurationTelemetry object associated with the TracerSettings, and then copying it into the collector, just write directly to the collector.
Test coverage
Should be covered by existing, but updated some tests (and made one of the constructor overloads easier to use in tests)
Other details
Should have a (tiny) impact on startup time and overall memory use
⚠️ Warnings
❄️ 2 New flaky tests detected
SinkRejectsGiantMessagesfromDatadog.Trace.Tests.Logging.DirectSubmission.Sink.DatadogSinkTests(Datadog)Expected logsApi.Logs to be True, but found False.
SinkBatchesMultipleLogsfromDatadog.Trace.Tests.Logging.DirectSubmission.Sink.OtlpSinkTests(Datadog)Expected capturedLogs to be True, but found False.
ℹ️ Info
🧪 All tests passed
This comment will be updated automatically if new data arrives.🔗 Commit SHA: 43a58d3 | Docs | Datadog PR Page | Was this helpful? Give us feedback!
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing This PR (7914) and master.
✅ No regressions detected - check the details below
Full Metrics Comparison
FakeDbCommand
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 75.12 ± (75.21 - 75.88) ms | 74.51 ± (74.59 - 75.30) ms | -0.8% | ✅ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 79.31 ± (79.35 - 80.15) ms | 80.25 ± (80.15 - 80.89) ms | +1.2% | ✅⬆️ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1059.72 ± (1057.54 - 1065.46) ms | 1058.97 ± (1059.36 - 1067.91) ms | -0.1% | ✅ |
| .NET Core 3.1 - Baseline | ||||
| process.internal_duration_ms | 23.12 ± (23.04 - 23.20) ms | 23.21 ± (23.13 - 23.29) ms | +0.4% | ✅⬆️ |
| process.time_to_main_ms | 88.80 ± (88.40 - 89.20) ms | 88.36 ± (88.02 - 88.70) ms | -0.5% | ✅ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.93 ± (10.93 - 10.94) MB | 10.92 ± (10.91 - 10.92) MB | -0.1% | ✅ |
| runtime.dotnet.threads.count | 12 ± (12 - 12) | 12 ± (12 - 12) | +0.0% | ✅ |
| .NET Core 3.1 - Bailout | ||||
| process.internal_duration_ms | 22.77 ± (22.70 - 22.84) ms | 22.85 ± (22.79 - 22.91) ms | +0.3% | ✅⬆️ |
| process.time_to_main_ms | 88.71 ± (88.35 - 89.06) ms | 88.44 ± (88.15 - 88.73) ms | -0.3% | ✅ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.97 ± (10.97 - 10.98) MB | 10.95 ± (10.95 - 10.95) MB | -0.2% | ✅ |
| runtime.dotnet.threads.count | 13 ± (13 - 13) | 13 ± (13 - 13) | +0.0% | ✅ |
| .NET Core 3.1 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 222.25 ± (220.95 - 223.56) ms | 222.75 ± (221.50 - 224.00) ms | +0.2% | ✅⬆️ |
| process.time_to_main_ms | 500.24 ± (499.11 - 501.37) ms | 500.91 ± (499.76 - 502.06) ms | +0.1% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 47.87 ± (47.85 - 47.89) MB | 47.94 ± (47.92 - 47.96) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 28 ± (28 - 28) | 28 ± (28 - 28) | +0.5% | ✅⬆️ |
| .NET 6 - Baseline | ||||
| process.internal_duration_ms | 21.70 ± (21.62 - 21.77) ms | 21.87 ± (21.80 - 21.94) ms | +0.8% | ✅⬆️ |
| process.time_to_main_ms | 76.63 ± (76.34 - 76.92) ms | 75.98 ± (75.71 - 76.25) ms | -0.8% | ✅ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.62 ± (10.62 - 10.63) MB | 10.63 ± (10.63 - 10.63) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 10 ± (10 - 10) | 10 ± (10 - 10) | +0.0% | ✅ |
| .NET 6 - Bailout | ||||
| process.internal_duration_ms | 21.83 ± (21.77 - 21.90) ms | 21.93 ± (21.86 - 22.00) ms | +0.4% | ✅⬆️ |
| process.time_to_main_ms | 77.84 ± (77.55 - 78.13) ms | 78.66 ± (78.34 - 78.99) ms | +1.1% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 10.67 ± (10.66 - 10.67) MB | 10.68 ± (10.67 - 10.68) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 11 ± (11 - 11) | 11 ± (11 - 11) | +0.0% | ✅ |
| .NET 6 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 210.92 ± (209.78 - 212.06) ms | 213.00 ± (211.74 - 214.27) ms | +1.0% | ✅⬆️ |
| process.time_to_main_ms | 468.69 ± (467.67 - 469.71) ms | 468.94 ± (467.87 - 470.01) ms | +0.1% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 48.09 ± (48.07 - 48.12) MB | 48.13 ± (48.11 - 48.15) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 28 ± (28 - 28) | 28 ± (28 - 28) | +0.0% | ✅⬆️ |
| .NET 8 - Baseline | ||||
| process.internal_duration_ms | 19.81 ± (19.75 - 19.88) ms | 19.91 ± (19.85 - 19.97) ms | +0.5% | ✅⬆️ |
| process.time_to_main_ms | 75.09 ± (74.74 - 75.43) ms | 75.44 ± (75.17 - 75.71) ms | +0.5% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 7.68 ± (7.67 - 7.68) MB | 7.64 ± (7.64 - 7.65) MB | -0.5% | ✅ |
| runtime.dotnet.threads.count | 10 ± (10 - 10) | 10 ± (10 - 10) | +0.0% | ✅ |
| .NET 8 - Bailout | ||||
| process.internal_duration_ms | 19.95 ± (19.88 - 20.01) ms | 19.90 ± (19.84 - 19.96) ms | -0.2% | ✅ |
| process.time_to_main_ms | 76.98 ± (76.68 - 77.28) ms | 77.10 ± (76.82 - 77.39) ms | +0.2% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 7.74 ± (7.73 - 7.74) MB | 7.70 ± (7.69 - 7.71) MB | -0.5% | ✅ |
| runtime.dotnet.threads.count | 11 ± (11 - 11) | 11 ± (11 - 11) | +0.0% | ✅ |
| .NET 8 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 191.44 ± (190.35 - 192.53) ms | 193.87 ± (192.97 - 194.76) ms | +1.3% | ✅⬆️ |
| process.time_to_main_ms | 453.43 ± (452.56 - 454.31) ms | 455.64 ± (454.74 - 456.54) ms | +0.5% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 0 ± (0 - 0) | 0 ± (0 - 0) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 36.38 ± (36.34 - 36.43) MB | 36.42 ± (36.38 - 36.46) MB | +0.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 27 ± (27 - 27) | 27 ± (27 - 27) | +0.0% | ✅⬆️ |
HttpMessageHandler
| Metric | Master (Mean ± 95% CI) | Current (Mean ± 95% CI) | Change | Status |
|---|---|---|---|---|
| .NET Framework 4.8 - Baseline | ||||
| duration | 194.02 ± (193.84 - 194.73) ms | 193.52 ± (193.68 - 194.53) ms | -0.3% | ✅ |
| .NET Framework 4.8 - Bailout | ||||
| duration | 197.05 ± (196.89 - 197.39) ms | 196.91 ± (196.91 - 197.59) ms | -0.1% | ✅ |
| .NET Framework 4.8 - CallTarget+Inlining+NGEN | ||||
| duration | 1109.78 ± (1111.34 - 1118.80) ms | 1116.01 ± (1119.62 - 1128.66) ms | +0.6% | ✅⬆️ |
| .NET Core 3.1 - Baseline | ||||
| process.internal_duration_ms | 192.36 ± (191.93 - 192.78) ms | 188.37 ± (188.05 - 188.68) ms | -2.1% | ✅ |
| process.time_to_main_ms | 82.33 ± (82.09 - 82.58) ms | 80.74 ± (80.55 - 80.93) ms | -1.9% | ✅ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.04 ± (16.02 - 16.06) MB | 16.12 ± (16.09 - 16.14) MB | +0.5% | ✅⬆️ |
| runtime.dotnet.threads.count | 20 ± (20 - 20) | 20 ± (20 - 20) | +0.2% | ✅⬆️ |
| .NET Core 3.1 - Bailout | ||||
| process.internal_duration_ms | 193.06 ± (192.61 - 193.50) ms | 188.19 ± (187.86 - 188.52) ms | -2.5% | ✅ |
| process.time_to_main_ms | 84.17 ± (83.94 - 84.41) ms | 82.12 ± (81.97 - 82.27) ms | -2.4% | ✅ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.07 ± (16.05 - 16.09) MB | 16.13 ± (16.10 - 16.15) MB | +0.3% | ✅⬆️ |
| runtime.dotnet.threads.count | 21 ± (20 - 21) | 20 ± (20 - 21) | -0.3% | ✅ |
| .NET Core 3.1 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 402.34 ± (399.63 - 405.06) ms | 402.13 ± (399.46 - 404.79) ms | -0.1% | ✅ |
| process.time_to_main_ms | 481.90 ± (480.91 - 482.90) ms | 475.24 ± (474.58 - 475.89) ms | -1.4% | ✅ |
| runtime.dotnet.exceptions.count | 3 ± (3 - 3) | 3 ± (3 - 3) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 58.67 ± (58.55 - 58.78) MB | 58.94 ± (58.83 - 59.05) MB | +0.5% | ✅⬆️ |
| runtime.dotnet.threads.count | 29 ± (29 - 30) | 29 ± (29 - 30) | -0.0% | ✅ |
| .NET 6 - Baseline | ||||
| process.internal_duration_ms | 193.35 ± (192.90 - 193.80) ms | 193.09 ± (192.68 - 193.50) ms | -0.1% | ✅ |
| process.time_to_main_ms | 70.53 ± (70.31 - 70.74) ms | 70.53 ± (70.33 - 70.74) ms | +0.0% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.38 ± (16.35 - 16.41) MB | 16.29 ± (16.18 - 16.40) MB | -0.6% | ✅ |
| runtime.dotnet.threads.count | 19 ± (19 - 19) | 19 ± (18 - 19) | -2.3% | ✅ |
| .NET 6 - Bailout | ||||
| process.internal_duration_ms | 191.98 ± (191.65 - 192.32) ms | 194.19 ± (193.70 - 194.68) ms | +1.1% | ✅⬆️ |
| process.time_to_main_ms | 71.05 ± (70.94 - 71.16) ms | 71.58 ± (71.43 - 71.73) ms | +0.7% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 16.15 ± (15.99 - 16.31) MB | 16.32 ± (16.24 - 16.40) MB | +1.1% | ✅⬆️ |
| runtime.dotnet.threads.count | 19 ± (19 - 19) | 20 ± (20 - 20) | +4.3% | ✅⬆️ |
| .NET 6 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 407.79 ± (405.83 - 409.75) ms | 408.78 ± (406.88 - 410.68) ms | +0.2% | ✅⬆️ |
| process.time_to_main_ms | 444.14 ± (443.42 - 444.86) ms | 444.50 ± (443.80 - 445.20) ms | +0.1% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 59.11 ± (58.97 - 59.25) MB | 59.12 ± (59.00 - 59.25) MB | +0.0% | ✅⬆️ |
| runtime.dotnet.threads.count | 30 ± (30 - 30) | 30 ± (29 - 30) | -0.1% | ✅ |
| .NET 8 - Baseline | ||||
| process.internal_duration_ms | 191.36 ± (190.95 - 191.76) ms | 192.22 ± (191.81 - 192.63) ms | +0.5% | ✅⬆️ |
| process.time_to_main_ms | 69.83 ± (69.64 - 70.02) ms | 70.01 ± (69.83 - 70.19) ms | +0.3% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 11.74 ± (11.71 - 11.77) MB | 11.72 ± (11.70 - 11.74) MB | -0.2% | ✅ |
| runtime.dotnet.threads.count | 18 ± (18 - 18) | 18 ± (18 - 18) | -0.0% | ✅ |
| .NET 8 - Bailout | ||||
| process.internal_duration_ms | 190.25 ± (189.97 - 190.53) ms | 191.05 ± (190.70 - 191.39) ms | +0.4% | ✅⬆️ |
| process.time_to_main_ms | 70.50 ± (70.40 - 70.60) ms | 70.84 ± (70.71 - 70.97) ms | +0.5% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 11.82 ± (11.78 - 11.87) MB | 11.73 ± (11.70 - 11.75) MB | -0.8% | ✅ |
| runtime.dotnet.threads.count | 19 ± (19 - 19) | 19 ± (19 - 19) | +0.0% | ✅⬆️ |
| .NET 8 - CallTarget+Inlining+NGEN | ||||
| process.internal_duration_ms | 370.98 ± (369.44 - 372.53) ms | 368.09 ± (366.82 - 369.36) ms | -0.8% | ✅ |
| process.time_to_main_ms | 430.80 ± (430.14 - 431.45) ms | 432.17 ± (431.36 - 432.98) ms | +0.3% | ✅⬆️ |
| runtime.dotnet.exceptions.count | 4 ± (4 - 4) | 4 ± (4 - 4) | +0.0% | ✅ |
| runtime.dotnet.mem.committed | 47.85 ± (47.82 - 47.88) MB | 47.93 ± (47.90 - 47.96) MB | +0.2% | ✅⬆️ |
| runtime.dotnet.threads.count | 29 ± (29 - 29) | 29 ± (29 - 29) | +0.1% | ✅⬆️ |
Comparison explanation
Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (75ms) : 70, 80
master - mean (76ms) : 71, 80
section Bailout
This PR (7914) - mean (81ms) : 75, 86
master - mean (80ms) : 74, 86
section CallTarget+Inlining+NGEN
This PR (7914) - mean (1,064ms) : 1002, 1125
master - mean (1,062ms) : 1003, 1120
FakeDbCommand (.NET Core 3.1)
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (119ms) : 113, 125
master - mean (119ms) : 112, 127
section Bailout
This PR (7914) - mean (119ms) : 114, 124
master - mean (119ms) : 111, 127
section CallTarget+Inlining+NGEN
This PR (7914) - mean (763ms) : 732, 794
master - mean (759ms) : 725, 794
FakeDbCommand (.NET 6)
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (105ms) : 100, 110
master - mean (106ms) : 100, 111
section Bailout
This PR (7914) - mean (108ms) : 101, 115
master - mean (107ms) : 101, 112
section CallTarget+Inlining+NGEN
This PR (7914) - mean (711ms) : 680, 741
master - mean (711ms) : 676, 746
FakeDbCommand (.NET 8)
gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (104ms) : 99, 109
master - mean (103ms) : 97, 110
section Bailout
This PR (7914) - mean (106ms) : 100, 111
master - mean (106ms) : 99, 112
section CallTarget+Inlining+NGEN
This PR (7914) - mean (687ms) : 651, 723
master - mean (682ms) : 653, 712
HttpMessageHandler (.NET Framework 4.8)
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (194ms) : 189, 199
master - mean (194ms) : 190, 198
section Bailout
This PR (7914) - mean (197ms) : 194, 201
master - mean (197ms) : 195, 200
section CallTarget+Inlining+NGEN
This PR (7914) - mean (1,124ms) : 1059, 1189
master - mean (1,115ms) : 1065, 1165
HttpMessageHandler (.NET Core 3.1)
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (278ms) : 272, 283
master - mean (283ms) : 274, 292
section Bailout
This PR (7914) - mean (279ms) : 275, 282
master - mean (286ms) : 278, 293
section CallTarget+Inlining+NGEN
This PR (7914) - mean (912ms) : 867, 956
master - mean (921ms) : 871, 971
HttpMessageHandler (.NET 6)
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (272ms) : 266, 278
master - mean (272ms) : 266, 279
section Bailout
This PR (7914) - mean (274ms) : 265, 283
master - mean (271ms) : 266, 275
section CallTarget+Inlining+NGEN
This PR (7914) - mean (885ms) : 848, 923
master - mean (885ms) : 847, 922
HttpMessageHandler (.NET 8)
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (7914) - mean (272ms) : 265, 279
master - mean (271ms) : 265, 276
section Bailout
This PR (7914) - mean (272ms) : 266, 277
master - mean (270ms) : 267, 274
section CallTarget+Inlining+NGEN
This PR (7914) - mean (831ms) : 809, 853
master - mean (833ms) : 809, 857