dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Detect libdatadog available

Open anna-git opened this issue 4 months ago • 2 comments

Summary of changes

Expose the native check for the libdatadog library to the managed side and use it instead of !IsServerless && ClrProfiler.Attached

Reason for change

Implementation details

Test coverage

Other details

anna-git avatar Aug 12 '25 16:08 anna-git

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

AspNetWebApi2TestsCallTargetIntegratedWithRouteTemplateExpansion+AspNetWebApi2TestsModuleOnlyClassic.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)

---- System.DllNotFoundException : Unable to load DLL 'Datadog.Tracer.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
AspNetWebApi2TestsCallTargetIntegratedWithRouteTemplateExpansion+AspNetWebApi2TestsModuleOnlyClassic.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)

---- System.DllNotFoundException : Unable to load DLL 'Datadog.Tracer.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
AspNetWebApi2TestsCallTargetIntegratedWithRouteTemplateExpansion+AspNetWebApi2TestsModuleOnlyClassic.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog)

---- System.DllNotFoundException : Unable to load DLL 'Datadog.Tracer.Native.dll': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 24e0a4b | Docs | Was this helpful? Give us feedback!

datadog-official[bot] avatar Aug 12 '25 16:08 datadog-official[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7380) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (1,027ms)  : 1003, 1050
     .   : milestone, 1027,
    master - mean (1,016ms)  : 999, 1034
     .   : milestone, 1016,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (107ms)  : 106, 109
     .   : milestone, 107,
    master - mean (108ms)  : 107, 109
     .   : milestone, 108,

    section Baseline
    This PR (7380) - mean (106ms)  : 104, 109
     .   : milestone, 106,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (723ms)  : 713, 734
     .   : milestone, 723,
    master - mean (719ms)  : 710, 727
     .   : milestone, 719,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (95ms)  : 94, 96
     .   : milestone, 95,
    master - mean (95ms)  : 94, 96
     .   : milestone, 95,

    section Baseline
    This PR (7380) - mean (95ms)  : 93, 97
     .   : milestone, 95,
    master - mean (95ms)  : 93, 96
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (678ms)  : 666, 690
     .   : milestone, 678,
    master - mean (679ms)  : 666, 691
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (94ms)  : 93, 96
     .   : milestone, 94,
    master - mean (94ms)  : 93, 95
     .   : milestone, 94,

    section Baseline
    This PR (7380) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (619ms)  : 608, 630
     .   : milestone, 619,
    master - mean (620ms)  : 609, 631
     .   : milestone, 620,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (206ms)  : 197, 215
     .   : milestone, 206,
    master - mean (206ms)  : 194, 217
     .   : milestone, 206,

    section Baseline
    This PR (7380) - mean (207ms)  : 193, 221
     .   : milestone, 207,
    master - mean (213ms)  : 198, 229
     .   : milestone, 213,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (1,255ms)  : 1200, 1311
     .   : milestone, 1255,
    master - mean (1,223ms)  : 1165, 1282
     .   : milestone, 1223,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (304ms)  : 277, 330
     .   : milestone, 304,
    master - mean (296ms)  : 274, 318
     .   : milestone, 296,

    section Baseline
    This PR (7380) - mean (304ms)  : 281, 328
     .   : milestone, 304,
    master - mean (291ms)  : 273, 309
     .   : milestone, 291,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (1,014ms)  : 968, 1061
     .   : milestone, 1014,
    master - mean (990ms)  : 931, 1050
     .   : milestone, 990,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (292ms)  : 270, 313
     .   : milestone, 292,
    master - mean (295ms)  : 272, 319
     .   : milestone, 295,

    section Baseline
    This PR (7380) - mean (302ms)  : 282, 321
     .   : milestone, 302,
    master - mean (284ms)  : 272, 295
     .   : milestone, 284,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (964ms)  : 914, 1015
     .   : milestone, 964,
    master - mean (974ms)  : 924, 1025
     .   : milestone, 974,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7380) - mean (302ms)  : 274, 330
     .   : milestone, 302,
    master - mean (292ms)  : 269, 316
     .   : milestone, 292,

    section Baseline
    This PR (7380) - mean (296ms)  : 273, 320
     .   : milestone, 296,
    master - mean (297ms)  : 279, 315
     .   : milestone, 297,

    section CallTarget+Inlining+NGEN
    This PR (7380) - mean (903ms)  : 801, 1005
     .   : milestone, 903,
    master - mean (874ms)  : 801, 948
     .   : milestone, 874,