dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[DO NOT MERGE] [fleet installer] Update IIS install command to do global install

Open andrewlock opened this issue 5 months ago • 2 comments

Summary of changes

  • Changes the IIS command to do a global install instead of IIS
  • Re-instates smoke tests for global instrumentation

Reason for change

We want to maintain this branch for testing out new approaches to the fleet installer, as discussed with @bmermet. We will primarily keep this rebased on top of master, but not merged in yet.

Implementation details

  • Update the IIS install commands to execute the "global" behaviour
  • Reinstate the smoke tests that use the "global" behaviour

Test coverage

As long as the smoke tests pass, this is fine

Other details

Requires https://github.com/DataDog/dd-trace-dotnet/pull/7182

andrewlock avatar Jul 04 '25 15:07 andrewlock

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (75ms)  : 70, 80
     .   : milestone, 75,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7183) - mean (71ms)  : 63, 78
     .   : milestone, 71,
    master - mean (68ms)  : 66, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (1,075ms)  : 1006, 1144
     .   : milestone, 1075,
    master - mean (1,060ms)  : 979, 1142
     .   : milestone, 1060,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (7183) - mean (113ms)  : 107, 120
     .   : milestone, 113,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (756ms)  : 719, 792
     .   : milestone, 756,
    master - mean (750ms)  : 726, 775
     .   : milestone, 750,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (107ms)  : 99, 114
     .   : milestone, 107,
    master - mean (102ms)  : 98, 105
     .   : milestone, 102,

    section Baseline
    This PR (7183) - mean (103ms)  : 98, 107
     .   : milestone, 103,
    master - mean (101ms)  : 98, 104
     .   : milestone, 101,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (786ms)  : 718, 853
     .   : milestone, 786,
    master - mean (776ms)  : 725, 827
     .   : milestone, 776,


gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (99ms)  : crit, 93, 105
     .   : crit, milestone, 99,
    master - mean (93ms)  : 92, 94
     .   : milestone, 93,

    section Baseline
    This PR (7183) - mean (96ms)  : 90, 101
     .   : milestone, 96,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (673ms)  : 643, 703
     .   : milestone, 673,
    master - mean (666ms)  : 650, 682
     .   : milestone, 666,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (219ms)  : crit, 197, 241
     .   : crit, milestone, 219,
    master - mean (202ms)  : 195, 208
     .   : milestone, 202,

    section Baseline
    This PR (7183) - mean (215ms)  : 193, 238
     .   : milestone, 215,
    master - mean (199ms)  : 193, 205
     .   : milestone, 199,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (1,277ms)  : crit, 1190, 1365
     .   : crit, milestone, 1277,
    master - mean (1,202ms)  : 1119, 1285
     .   : milestone, 1202,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (310ms)  : crit, 285, 336
     .   : crit, milestone, 310,
    master - mean (289ms)  : 279, 299
     .   : milestone, 289,

    section Baseline
    This PR (7183) - mean (311ms)  : 279, 344
     .   : milestone, 311,
    master - mean (287ms)  : 277, 298
     .   : milestone, 287,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (1,014ms)  : 972, 1057
     .   : milestone, 1014,
    master - mean (963ms)  : 919, 1007
     .   : milestone, 963,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (313ms)  : crit, 283, 343
     .   : crit, milestone, 313,
    master - mean (292ms)  : 281, 303
     .   : milestone, 292,

    section Baseline
    This PR (7183) - mean (311ms)  : 284, 338
     .   : milestone, 311,
    master - mean (292ms)  : 278, 306
     .   : milestone, 292,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (1,072ms)  : 1022, 1123
     .   : milestone, 1072,
    master - mean (1,024ms)  : 975, 1074
     .   : milestone, 1024,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7183) - mean (291ms)  : 274, 309
     .   : milestone, 291,
    master - mean (280ms)  : 269, 290
     .   : milestone, 280,

    section Baseline
    This PR (7183) - mean (295ms)  : 272, 318
     .   : milestone, 295,
    master - mean (280ms)  : 271, 288
     .   : milestone, 280,

    section CallTarget+Inlining+NGEN
    This PR (7183) - mean (935ms)  : crit, 842, 1029
     .   : crit, milestone, 935,
    master - mean (879ms)  : 851, 908
     .   : milestone, 879,

dd-trace-dotnet-ci-bot[bot] avatar Jul 04 '25 16:07 dd-trace-dotnet-ci-bot[bot]

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7183 compared to master:

  • 1 benchmarks are slower, with geometric mean 2.549
  • 8 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7183

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.05 KB 6.09 KB 45 B 0.74%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 57.9ns 317ns 0 0 0 5.48 KB
master StartStopWithChild netcoreapp3.1 13.6μs 65.3ns 261ns 0 0 0 5.71 KB
master StartStopWithChild net472 22μs 98.5ns 429ns 1.01 0.337 0.112 6.05 KB
#7183 StartStopWithChild net6.0 10.1μs 56.4ns 352ns 0 0 0 5.5 KB
#7183 StartStopWithChild netcoreapp3.1 14μs 21.1ns 81.7ns 0 0 0 5.68 KB
#7183 StartStopWithChild net472 22.6μs 119ns 631ns 0.926 0.231 0 6.09 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 50.5ns 189ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 58.1ns 209ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 365ns 1.41μs 0 0 0 3.31 KB
#7183 WriteAndFlushEnrichedTraces net6.0 925μs 140ns 543ns 0 0 0 2.71 KB
#7183 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 1.4μs 5.4μs 0 0 0 2.7 KB
#7183 WriteAndFlushEnrichedTraces net472 1.2ms 133ns 516ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 329μs 1.13μs 4.37μs 0 0 0 172.07 KB
master AllCycleSimpleBody netcoreapp3.1 451μs 2.07μs 8.28μs 0 0 0 174.18 KB
master AllCycleSimpleBody net472 423μs 73.5ns 275ns 29.2 0 0 194.24 KB
master AllCycleMoreComplexBody net6.0 334μs 1.1μs 4.26μs 0 0 0 175.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 481μs 2.1μs 7.57μs 0 0 0 177.6 KB
master AllCycleMoreComplexBody net472 433μs 114ns 428ns 30.2 0 0 197.76 KB
master ObjectExtractorSimpleBody net6.0 318ns 1.73ns 9.96ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.13ns 11.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 304ns 0.272ns 1.05ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.38μs 4.05ns 15.7ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.8μs 23.2ns 83.5ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.86μs 31.4ns 122ns 0.573 0 0 3.8 KB
#7183 AllCycleSimpleBody net6.0 315μs 1.51μs 6.59μs 0 0 0 172.07 KB
#7183 AllCycleSimpleBody netcoreapp3.1 490μs 606ns 2.35μs 0 0 0 174.18 KB
#7183 AllCycleSimpleBody net472 428μs 104ns 401ns 29.2 0 0 194.24 KB
#7183 AllCycleMoreComplexBody net6.0 331μs 1.28μs 4.95μs 0 0 0 175.58 KB
#7183 AllCycleMoreComplexBody netcoreapp3.1 472μs 149ns 579ns 0 0 0 177.6 KB
#7183 AllCycleMoreComplexBody net472 437μs 98ns 379ns 30.2 0 0 197.76 KB
#7183 ObjectExtractorSimpleBody net6.0 324ns 0.383ns 1.48ns 0 0 0 280 B
#7183 ObjectExtractorSimpleBody netcoreapp3.1 414ns 0.227ns 0.878ns 0 0 0 272 B
#7183 ObjectExtractorSimpleBody net472 300ns 0.0131ns 0.0472ns 0.0438 0 0 281 B
#7183 ObjectExtractorMoreComplexBody net6.0 6.26μs 2.61ns 10.1ns 0 0 0 3.78 KB
#7183 ObjectExtractorMoreComplexBody netcoreapp3.1 7.83μs 21.1ns 81.6ns 0 0 0 3.69 KB
#7183 ObjectExtractorMoreComplexBody net472 6.68μs 1.13ns 4.37ns 0.601 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 77.1μs 242ns 937ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.7μs 64.5ns 250ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 21.3ns 82.7ns 4.92 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 20.3ns 78.7ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 206ns 713ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 263μs 49ns 170ns 0 0 0 2.16 KB
#7183 EncodeArgs net6.0 76.1μs 130ns 488ns 0 0 0 32.4 KB
#7183 EncodeArgs netcoreapp3.1 97.3μs 129ns 499ns 0 0 0 32.4 KB
#7183 EncodeArgs net472 110μs 14.9ns 57.7ns 4.93 0 0 32.5 KB
#7183 EncodeLegacyArgs net6.0 146μs 54.9ns 213ns 0 0 0 2.14 KB
#7183 EncodeLegacyArgs netcoreapp3.1 200μs 162ns 584ns 0 0 0 2.14 KB
#7183 EncodeLegacyArgs net472 262μs 31ns 112ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #7183

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.549 298,942.63 762,099.66

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 396μs 87.2ns 326ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 856μs 2.86μs 10.7μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 437μs 48ns 186ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 290μs 46.2ns 173ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 299μs 49.6ns 185ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 314μs 42.8ns 166ns 0 0 0 2.29 KB
#7183 RunWafRealisticBenchmark net6.0 396μs 110ns 427ns 0 0 0 4.55 KB
#7183 RunWafRealisticBenchmark netcoreapp3.1 824μs 12.3μs 121μs 0 0 0 4.48 KB
#7183 RunWafRealisticBenchmark net472 433μs 46.3ns 179ns 0 0 0 4.68 KB
#7183 RunWafRealisticBenchmarkWithAttack net6.0 287μs 104ns 401ns 0 0 0 2.24 KB
#7183 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 711μs 10.9μs 104μs 0 0 0 2.22 KB
#7183 RunWafRealisticBenchmarkWithAttack net472 315μs 29.5ns 106ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.3μs 61.6ns 238ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 73.1μs 217ns 841ns 0 0 0 17.42 KB
master SendRequest net472 0.0012ns 0.000689ns 0.00267ns 0 0 0 0 b
#7183 SendRequest net6.0 61μs 137ns 531ns 0 0 0 14.52 KB
#7183 SendRequest netcoreapp3.1 72.5μs 191ns 740ns 0 0 0 17.42 KB
#7183 SendRequest net472 0.00259ns 0.00107ns 0.00415ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7183

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 5 B 4 B -1 B -20.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 7 B 2 B -5 B -71.43%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 49 B 0 b -49 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.94ms 505ns 1.89μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.1ms 6.02μs 22.5μs 0 0 0 640 KB
master OriginalCharSlice net472 2.64ms 261ns 1.01μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.51ms 921ns 3.57μs 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.67ms 140ns 541ns 0 0 0 1 B
master OptimizedCharSlice net472 1.97ms 272ns 1.06μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 829μs 43.5ns 168ns 0 0 0 5 B
master OptimizedCharSliceWithPool netcoreapp3.1 850μs 61.7ns 239ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.13ms 72.2ns 280ns 0 0 0 49 B
#7183 OriginalCharSlice net6.0 1.93ms 2.45μs 9.48μs 0 0 0 640.01 KB
#7183 OriginalCharSlice netcoreapp3.1 2.12ms 8.93μs 32.2μs 0 0 0 640 KB
#7183 OriginalCharSlice net472 2.67ms 67.6ns 253ns 100 0 0 641.95 KB
#7183 OptimizedCharSlice net6.0 1.36ms 175ns 676ns 0 0 0 2 B
#7183 OptimizedCharSlice netcoreapp3.1 1.66ms 228ns 788ns 0 0 0 1 B
#7183 OptimizedCharSlice net472 2.04ms 187ns 724ns 0 0 0 0 b
#7183 OptimizedCharSliceWithPool net6.0 811μs 30.8ns 119ns 0 0 0 4 B
#7183 OptimizedCharSliceWithPool netcoreapp3.1 831μs 60.9ns 220ns 0 0 0 0 b
#7183 OptimizedCharSliceWithPool net472 1.19ms 55.4ns 207ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7183

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.38 KB 41.76 KB -623 B -1.47%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 721μs 2.28μs 8.83μs 0 0 0 42.38 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 632μs 1.53μs 5.29μs 0 0 0 41.99 KB
master WriteAndFlushEnrichedTraces net472 879μs 4.27μs 17.1μs 4.46 0 0 55.83 KB
#7183 WriteAndFlushEnrichedTraces net6.0 659μs 3.7μs 28.2μs 0 0 0 41.76 KB
#7183 WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 1.01μs 3.79μs 0 0 0 41.95 KB
#7183 WriteAndFlushEnrichedTraces net472 981μs 3.87μs 15μs 4.46 0 0 55.64 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.83μs 0.825ns 3.2ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.49μs 0.854ns 3.2ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.76μs 6.5ns 25.2ns 0.152 0.0138 0 987 B
#7183 ExecuteNonQuery net6.0 1.94μs 9.79ns 44.9ns 0 0 0 1.02 KB
#7183 ExecuteNonQuery netcoreapp3.1 2.44μs 10.9ns 40.8ns 0 0 0 1.02 KB
#7183 ExecuteNonQuery net472 2.76μs 3.4ns 13.2ns 0.151 0.0138 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.72μs 8.96ns 43ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.28μs 8.12ns 31.4ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.57μs 1.51ns 5.85ns 0.16 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.89μs 6.24ns 24.2ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.42μs 8.19ns 31.7ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.69μs 1.27ns 4.76ns 0.167 0 0 1.1 KB
#7183 CallElasticsearch net6.0 1.8μs 0.738ns 2.86ns 0 0 0 1.03 KB
#7183 CallElasticsearch netcoreapp3.1 2.34μs 8.17ns 31.6ns 0 0 0 1.03 KB
#7183 CallElasticsearch net472 3.55μs 3.9ns 14.1ns 0.161 0 0 1.04 KB
#7183 CallElasticsearchAsync net6.0 1.85μs 8.23ns 30.8ns 0 0 0 1.01 KB
#7183 CallElasticsearchAsync netcoreapp3.1 2.36μs 11.4ns 45.4ns 0 0 0 1.08 KB
#7183 CallElasticsearchAsync net472 3.79μs 6.13ns 23.7ns 0.171 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.83μs 7.54ns 29.2ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.32μs 4.48ns 17.4ns 0 0 0 952 B
master ExecuteAsync net472 2.46μs 2.18ns 8.45ns 0.135 0 0 915 B
#7183 ExecuteAsync net6.0 1.81μs 6.9ns 26.7ns 0 0 0 952 B
#7183 ExecuteAsync netcoreapp3.1 2.32μs 6.85ns 25.6ns 0 0 0 952 B
#7183 ExecuteAsync net472 2.43μs 3.3ns 12.8ns 0.134 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.85μs 8.44ns 32.7ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.53μs 29.1ns 113ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 5.71ns 20.6ns 0.492 0 0 3.18 KB
#7183 SendAsync net6.0 7.05μs 19.2ns 74.2ns 0 0 0 2.36 KB
#7183 SendAsync netcoreapp3.1 8.26μs 25.6ns 99ns 0 0 0 2.9 KB
#7183 SendAsync net472 12.3μs 10.7ns 41.4ns 0.493 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7183

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%

Fewer allocations :tada: in #7183

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.67 KB 258.08 KB -16.59 KB -6.04%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 278.73 KB 256.83 KB -21.9 KB -7.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.7μs 214ns 1.05μs 0 0 0 43.86 KB
master StringConcatBenchmark netcoreapp3.1 55.2μs 671ns 6.61μs 0 0 0 42.82 KB
master StringConcatBenchmark net472 57.7μs 263ns 1.02μs 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 477μs 1.68μs 5.83μs 0 0 0 278.73 KB
master StringConcatAspectBenchmark netcoreapp3.1 523μs 1.26μs 4.73μs 0 0 0 274.67 KB
master StringConcatAspectBenchmark net472 404μs 2.31μs 16.8μs 0 0 0 278.53 KB
#7183 StringConcatBenchmark net6.0 49.7μs 292ns 2.46μs 0 0 0 44.06 KB
#7183 StringConcatBenchmark netcoreapp3.1 49.7μs 284ns 2.03μs 0 0 0 42.69 KB
#7183 StringConcatBenchmark net472 57.4μs 151ns 565ns 0 0 0 65.54 KB
#7183 StringConcatAspectBenchmark net6.0 459μs 2.08μs 8.31μs 0 0 0 256.83 KB
#7183 StringConcatAspectBenchmark netcoreapp3.1 500μs 1.75μs 6.32μs 0 0 0 258.08 KB
#7183 StringConcatAspectBenchmark net472 400μs 2.31μs 18.2μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.52μs 12.2ns 50.4ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.33μs 17.1ns 78.1ns 0 0 0 1.7 KB
master EnrichedLog net472 3.81μs 2.83ns 11ns 0.248 0 0 1.64 KB
#7183 EnrichedLog net6.0 2.56μs 0.784ns 2.93ns 0 0 0 1.7 KB
#7183 EnrichedLog netcoreapp3.1 3.53μs 3.33ns 12.9ns 0 0 0 1.7 KB
#7183 EnrichedLog net472 3.92μs 2.32ns 8.99ns 0.254 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 25.1ns 93.8ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 127μs 122ns 472ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 126ns 488ns 0 0 0 4.52 KB
#7183 EnrichedLog net6.0 123μs 33.1ns 124ns 0 0 0 4.31 KB
#7183 EnrichedLog netcoreapp3.1 129μs 284ns 1.06μs 0 0 0 4.31 KB
#7183 EnrichedLog net472 168μs 110ns 428ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.98μs 4.71ns 16.3ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.53μs 14ns 52.2ns 0 0 0 2.26 KB
master EnrichedLog net472 7.5μs 6.54ns 25.3ns 0.299 0 0 2.08 KB
#7183 EnrichedLog net6.0 5.07μs 3.64ns 13.6ns 0 0 0 2.26 KB
#7183 EnrichedLog netcoreapp3.1 6.94μs 9.52ns 36.9ns 0 0 0 2.26 KB
#7183 EnrichedLog net472 7.38μs 4.82ns 18ns 0.294 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.05μs 5.68ns 21.3ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.59μs 10.8ns 40.6ns 0 0 0 1.2 KB
master SendReceive net472 3.14μs 6.6ns 25.6ns 0.189 0 0 1.2 KB
#7183 SendReceive net6.0 1.99μs 0.959ns 3.59ns 0 0 0 1.2 KB
#7183 SendReceive netcoreapp3.1 2.63μs 8.33ns 32.3ns 0 0 0 1.2 KB
#7183 SendReceive net472 3.24μs 3.01ns 11.7ns 0.178 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.19μs 5.46ns 21.1ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.76μs 6.44ns 24.9ns 0 0 0 1.63 KB
master EnrichedLog net472 6.55μs 7.75ns 30ns 0.292 0 0 2.03 KB
#7183 EnrichedLog net6.0 4.36μs 4.47ns 16.7ns 0 0 0 1.58 KB
#7183 EnrichedLog netcoreapp3.1 5.57μs 11.4ns 44.2ns 0 0 0 1.63 KB
#7183 EnrichedLog net472 6.7μs 9.21ns 35.7ns 0.301 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 754ns 0.347ns 1.34ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 949ns 5.12ns 29ns 0 0 0 576 B
master StartFinishSpan net472 893ns 0.325ns 1.26ns 0.0896 0 0 578 B
master StartFinishScope net6.0 908ns 4.38ns 17ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.11μs 5.75ns 27.6ns 0 0 0 696 B
master StartFinishScope net472 1.09μs 0.601ns 2.25ns 0.104 0 0 658 B
#7183 StartFinishSpan net6.0 774ns 3.99ns 19.1ns 0 0 0 576 B
#7183 StartFinishSpan netcoreapp3.1 932ns 4.31ns 17.8ns 0 0 0 576 B
#7183 StartFinishSpan net472 918ns 0.224ns 0.866ns 0.0918 0 0 578 B
#7183 StartFinishScope net6.0 876ns 0.433ns 1.62ns 0 0 0 696 B
#7183 StartFinishScope netcoreapp3.1 1.13μs 2.67ns 10.4ns 0 0 0 696 B
#7183 StartFinishScope net472 1.1μs 0.122ns 0.471ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.04μs 2.92ns 11.3ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.33μs 6.69ns 30.6ns 0 0 0 696 B
master RunOnMethodBegin net472 1.37μs 0.543ns 2.1ns 0.103 0 0 658 B
#7183 RunOnMethodBegin net6.0 1.05μs 3.2ns 12.4ns 0 0 0 696 B
#7183 RunOnMethodBegin netcoreapp3.1 1.41μs 6.91ns 28.5ns 0 0 0 696 B
#7183 RunOnMethodBegin net472 1.45μs 1.49ns 5.76ns 0.1 0 0 658 B

pr-commenter[bot] avatar Jul 04 '25 17:07 pr-commenter[bot]