dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

[Test Optimization] Rework on test impact tests

Open tonyredondo opened this issue 5 months ago • 3 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

tonyredondo avatar Jun 27 '25 11:06 tonyredondo

Datadog Report

Branch report: tony/check-impacted-test-tests Commit report: 8f81a01 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 247868 Passed, 2276 Skipped, 15h 11m 33.67s Total Time

datadog-datadog-prod-us1[bot] avatar Jun 27 '25 12:06 datadog-datadog-prod-us1[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (75ms)  : 73, 77
     .   : milestone, 75,
    master - mean (75ms)  : 73, 77
     .   : milestone, 75,

    section Baseline
    This PR (7151) - mean (72ms)  : 68, 75
     .   : milestone, 72,
    master - mean (71ms)  : 68, 74
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (1,025ms)  : 998, 1051
     .   : milestone, 1025,
    master - mean (1,024ms)  : 998, 1050
     .   : milestone, 1024,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (107ms)  : 106, 109
     .   : milestone, 107,
    master - mean (109ms)  : 107, 110
     .   : milestone, 109,

    section Baseline
    This PR (7151) - mean (107ms)  : 103, 110
     .   : milestone, 107,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (710ms)  : 691, 729
     .   : milestone, 710,
    master - mean (710ms)  : 684, 736
     .   : milestone, 710,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (96ms)  : 94, 97
     .   : milestone, 96,
    master - mean (96ms)  : 94, 98
     .   : milestone, 96,

    section Baseline
    This PR (7151) - mean (95ms)  : 93, 97
     .   : milestone, 95,
    master - mean (95ms)  : 92, 97
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (676ms)  : 659, 694
     .   : milestone, 676,
    master - mean (678ms)  : 653, 704
     .   : milestone, 678,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (193ms)  : 191, 195
     .   : milestone, 193,
    master - mean (193ms)  : 190, 195
     .   : milestone, 193,

    section Baseline
    This PR (7151) - mean (189ms)  : 185, 193
     .   : milestone, 189,
    master - mean (189ms)  : 185, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (1,113ms)  : 1086, 1141
     .   : milestone, 1113,
    master - mean (1,116ms)  : 1088, 1145
     .   : milestone, 1116,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (271ms)  : 267, 274
     .   : milestone, 271,
    master - mean (271ms)  : 268, 273
     .   : milestone, 271,

    section Baseline
    This PR (7151) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (886ms)  : 854, 919
     .   : milestone, 886,
    master - mean (889ms)  : 863, 914
     .   : milestone, 889,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (263ms)  : 261, 266
     .   : milestone, 263,
    master - mean (264ms)  : 262, 267
     .   : milestone, 264,

    section Baseline
    This PR (7151) - mean (263ms)  : 260, 267
     .   : milestone, 263,
    master - mean (264ms)  : 261, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (882ms)  : 843, 920
     .   : milestone, 882,
    master - mean (884ms)  : 845, 922
     .   : milestone, 884,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7151) - mean (262ms)  : 259, 264
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section Baseline
    This PR (7151) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7151) - mean (782ms)  : 764, 799
     .   : milestone, 782,
    master - mean (778ms)  : 759, 796
     .   : milestone, 778,

dd-trace-dotnet-ci-bot[bot] avatar Jun 30 '25 14:06 dd-trace-dotnet-ci-bot[bot]

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7151 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.224
  • 43 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.67 KB -81 B -1.41%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.5 KB -79 B -1.42%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 5.99 KB -99 B -1.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7151 StartStopWithChild net6.0 10.3μs 52ns 250ns 0 0 0 5.5 KB
#7151 StartStopWithChild netcoreapp3.1 14.5μs 67.3ns 269ns 0 0 0 5.67 KB
#7151 StartStopWithChild net472 22.2μs 120ns 669ns 0.982 0.436 0.109 5.99 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7151 WriteAndFlushEnrichedTraces net6.0 914μs 55.6ns 216ns 0 0 0 2.71 KB
#7151 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 1.74μs 6.74μs 0 0 0 2.7 KB
#7151 WriteAndFlushEnrichedTraces net472 1.2ms 112ns 434ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7151 AllCycleSimpleBody net6.0 332μs 153ns 574ns 0 0 0 197.61 KB
#7151 AllCycleSimpleBody netcoreapp3.1 493μs 2.35μs 9.95μs 0 0 0 205.37 KB
#7151 AllCycleSimpleBody net472 443μs 132ns 511ns 36.6 2.16 0 239.66 KB
#7151 AllCycleMoreComplexBody net6.0 336μs 1.63μs 7.1μs 0 0 0 201.12 KB
#7151 AllCycleMoreComplexBody netcoreapp3.1 521μs 1.33μs 5.14μs 0 0 0 208.78 KB
#7151 AllCycleMoreComplexBody net472 454μs 139ns 500ns 37.9 2.23 0 243.17 KB
#7151 ObjectExtractorSimpleBody net6.0 332ns 1.57ns 6.46ns 0 0 0 280 B
#7151 ObjectExtractorSimpleBody netcoreapp3.1 398ns 2.09ns 9.78ns 0 0 0 272 B
#7151 ObjectExtractorSimpleBody net472 306ns 0.0319ns 0.119ns 0.0432 0 0 281 B
#7151 ObjectExtractorMoreComplexBody net6.0 6.51μs 1.87ns 7.23ns 0 0 0 3.78 KB
#7151 ObjectExtractorMoreComplexBody netcoreapp3.1 7.78μs 35.8ns 139ns 0 0 0 3.69 KB
#7151 ObjectExtractorMoreComplexBody net472 6.8μs 0.723ns 2.8ns 0.58 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.14 KB -12 B -0.56%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7151 EncodeArgs net6.0 76.9μs 186ns 694ns 0 0 0 32.4 KB
#7151 EncodeArgs netcoreapp3.1 96.8μs 94ns 352ns 0 0 0 32.4 KB
#7151 EncodeArgs net472 108μs 15.6ns 60.6ns 4.88 0 0 32.51 KB
#7151 EncodeLegacyArgs net6.0 148μs 36.4ns 141ns 0 0 0 2.14 KB
#7151 EncodeLegacyArgs netcoreapp3.1 200μs 283ns 1.1μs 0 0 0 2.14 KB
#7151 EncodeLegacyArgs net472 261μs 44.5ns 166ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7151 RunWafRealisticBenchmark net6.0 270μs 120ns 464ns 0 0 0 4.55 KB
#7151 RunWafRealisticBenchmark netcoreapp3.1 297μs 140ns 543ns 0 0 0 4.48 KB
#7151 RunWafRealisticBenchmark net472 308μs 47.5ns 184ns 0 0 0 4.66 KB
#7151 RunWafRealisticBenchmarkWithAttack net6.0 182μs 71.5ns 258ns 0 0 0 2.24 KB
#7151 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 194μs 42.3ns 152ns 0 0 0 2.22 KB
#7151 RunWafRealisticBenchmarkWithAttack net472 207μs 34.5ns 133ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7151 SendRequest net6.0 61.3μs 72.8ns 252ns 0 0 0 14.52 KB
#7151 SendRequest netcoreapp3.1 71.4μs 54.1ns 203ns 0 0 0 17.42 KB
#7151 SendRequest net472 0.0108ns 0.00164ns 0.00637ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7151 OriginalCharSlice net6.0 1.93ms 153ns 591ns 0 0 0 640.01 KB
#7151 OriginalCharSlice netcoreapp3.1 2.16ms 10.6μs 42.2μs 0 0 0 640 KB
#7151 OriginalCharSlice net472 2.59ms 120ns 465ns 100 0 0 641.95 KB
#7151 OptimizedCharSlice net6.0 1.44ms 203ns 787ns 0 0 0 4 B
#7151 OptimizedCharSlice netcoreapp3.1 1.66ms 131ns 507ns 0 0 0 1 B
#7151 OptimizedCharSlice net472 2.02ms 395ns 1.53μs 0 0 0 73 B
#7151 OptimizedCharSliceWithPool net6.0 802μs 33.8ns 131ns 0 0 0 2 B
#7151 OptimizedCharSliceWithPool netcoreapp3.1 928μs 41.9ns 162ns 0 0 0 0 b
#7151 OptimizedCharSliceWithPool net472 1.15ms 211ns 791ns 0 0 0 48 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7151

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.201 631,437.50 758,286.11

More allocations :warning: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.89 KB 42.77 KB 885 B 2.11%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.31 KB 558 B 1.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7151 WriteAndFlushEnrichedTraces net6.0 693μs 3.16μs 12.6μs 0 0 0 41.66 KB
#7151 WriteAndFlushEnrichedTraces netcoreapp3.1 759μs 1.24μs 4.81μs 0 0 0 42.77 KB
#7151 WriteAndFlushEnrichedTraces net472 1ms 4.88μs 20.7μs 4.81 0 0 56.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7151 ExecuteNonQuery net6.0 1.93μs 1.15ns 4.3ns 0 0 0 1.02 KB
#7151 ExecuteNonQuery netcoreapp3.1 2.64μs 9.09ns 35.2ns 0 0 0 1.02 KB
#7151 ExecuteNonQuery net472 2.93μs 16.3ns 99.2ns 0.155 0.0141 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7151 CallElasticsearch net6.0 1.86μs 8.96ns 36.9ns 0 0 0 1.03 KB
#7151 CallElasticsearch netcoreapp3.1 2.3μs 7.18ns 27.8ns 0 0 0 1.03 KB
#7151 CallElasticsearch net472 3.56μs 1.1ns 3.96ns 0.159 0 0 1.04 KB
#7151 CallElasticsearchAsync net6.0 1.88μs 7.4ns 27.7ns 0 0 0 1.01 KB
#7151 CallElasticsearchAsync netcoreapp3.1 2.55μs 6.24ns 24.2ns 0 0 0 1.08 KB
#7151 CallElasticsearchAsync net472 3.79μs 1.88ns 6.77ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7151 ExecuteAsync net6.0 1.82μs 8.58ns 35.4ns 0 0 0 952 B
#7151 ExecuteAsync netcoreapp3.1 2.45μs 5.76ns 22.3ns 0 0 0 952 B
#7151 ExecuteAsync net472 2.54μs 0.542ns 2.1ns 0.14 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7151 SendAsync net6.0 6.71μs 4.99ns 19.3ns 0 0 0 2.36 KB
#7151 SendAsync netcoreapp3.1 8.67μs 17.1ns 64.1ns 0 0 0 2.9 KB
#7151 SendAsync net472 12.5μs 11.3ns 43.6ns 0.504 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7151

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.248 413,700.00 516,200.00

More allocations :warning: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 276.02 KB -10.7 KB -3.73%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 250.1 KB -9.86 KB -3.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7151 StringConcatBenchmark net6.0 43.4μs 203ns 730ns 0 0 0 43.82 KB
#7151 StringConcatBenchmark netcoreapp3.1 51μs 328ns 3.13μs 0 0 0 42.82 KB
#7151 StringConcatBenchmark net472 57.1μs 223ns 864ns 0 0 0 65.54 KB
#7151 StringConcatAspectBenchmark net6.0 471μs 2.34μs 10.5μs 0 0 0 250.1 KB
#7151 StringConcatAspectBenchmark netcoreapp3.1 519μs 2.24μs 8.09μs 0 0 0 275.25 KB
#7151 StringConcatAspectBenchmark net472 414μs 2.25μs 13.5μs 0 0 0 276.02 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7151 EnrichedLog net6.0 2.59μs 2.32ns 8.97ns 0 0 0 1.7 KB
#7151 EnrichedLog netcoreapp3.1 3.43μs 16.7ns 66.7ns 0 0 0 1.7 KB
#7151 EnrichedLog net472 3.96μs 2.78ns 10.8ns 0.256 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -56 B -1.22%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7151 EnrichedLog net6.0 122μs 125ns 468ns 0 0 0 4.31 KB
#7151 EnrichedLog netcoreapp3.1 127μs 209ns 780ns 0 0 0 4.31 KB
#7151 EnrichedLog net472 169μs 130ns 502ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7151 EnrichedLog net6.0 4.98μs 24.5ns 110ns 0 0 0 2.26 KB
#7151 EnrichedLog netcoreapp3.1 6.69μs 18.4ns 71.3ns 0 0 0 2.26 KB
#7151 EnrichedLog net472 7.51μs 4.27ns 16ns 0.3 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7151 SendReceive net6.0 2.01μs 1.71ns 6.63ns 0 0 0 1.2 KB
#7151 SendReceive netcoreapp3.1 2.6μs 2.37ns 8.55ns 0 0 0 1.2 KB
#7151 SendReceive net472 3.2μs 1.34ns 5.2ns 0.176 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7151 EnrichedLog net6.0 4.21μs 3.87ns 13.9ns 0 0 0 1.58 KB
#7151 EnrichedLog netcoreapp3.1 5.72μs 7.97ns 30.9ns 0 0 0 1.63 KB
#7151 EnrichedLog net472 6.54μs 7.56ns 29.3ns 0.293 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7151 StartFinishSpan net6.0 757ns 3.97ns 19.1ns 0 0 0 576 B
#7151 StartFinishSpan netcoreapp3.1 949ns 5.19ns 30.3ns 0 0 0 576 B
#7151 StartFinishSpan net472 924ns 0.474ns 1.84ns 0.0916 0 0 578 B
#7151 StartFinishScope net6.0 887ns 4.28ns 16.6ns 0 0 0 696 B
#7151 StartFinishScope netcoreapp3.1 1.14μs 5.28ns 21.1ns 0 0 0 696 B
#7151 StartFinishScope net472 1.12μs 0.835ns 3.01ns 0.101 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7151

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7151 RunOnMethodBegin net6.0 1.05μs 5.19ns 23.2ns 0 0 0 696 B
#7151 RunOnMethodBegin netcoreapp3.1 1.38μs 1.26ns 4.9ns 0 0 0 696 B
#7151 RunOnMethodBegin net472 1.39μs 1.28ns 4.94ns 0.104 0 0 658 B

pr-commenter[bot] avatar Jun 30 '25 14:06 pr-commenter[bot]