dd-trace-dotnet
dd-trace-dotnet copied to clipboard
Published
20 hours ago •
DataDog
DataDog
[AAP] Send WAF config errors to Telemetry Logs
Summary of changes
Upload WAF config errors to Telemetry Logs
Reason for change
WAF errors were only dumped to local logs
Implementation details
Test coverage
Other details
Datadog Report
Branch report: dani/asm/waf_telemetry_logs
Commit report: 03523c0
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 255988 Passed, 2414 Skipped, 18h 5m 4.46s Total Time
![datadog-datadog-prod-us1[bot] avatar](https://avatars.githubusercontent.com/u/365230?v=4 "Published by a pub.dev verified publisher"){kind=small}
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (75ms) : 72, 77
. : milestone, 75,
master - mean (74ms) : 73, 76
. : milestone, 74,
section Baseline
This PR (7142) - mean (70ms) : 68, 73
. : milestone, 70,
master - mean (71ms) : 68, 74
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (1,020ms) : 988, 1051
. : milestone, 1020,
master - mean (1,023ms) : 985, 1060
. : milestone, 1023,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (107ms) : 105, 108
. : milestone, 107,
master - mean (108ms) : 106, 110
. : milestone, 108,
section Baseline
This PR (7142) - mean (106ms) : 102, 109
. : milestone, 106,
master - mean (107ms) : 104, 110
. : milestone, 107,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (708ms) : 690, 726
. : milestone, 708,
master - mean (708ms) : 690, 727
. : milestone, 708,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (95ms) : 93, 97
. : milestone, 95,
master - mean (95ms) : 93, 96
. : milestone, 95,
section Baseline
This PR (7142) - mean (94ms) : 92, 97
. : milestone, 94,
master - mean (94ms) : 92, 97
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (667ms) : 642, 692
. : milestone, 667,
master - mean (674ms) : 640, 708
. : milestone, 674,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (192ms) : 190, 194
. : milestone, 192,
master - mean (193ms) : 190, 196
. : milestone, 193,
section Baseline
This PR (7142) - mean (190ms) : 184, 195
. : milestone, 190,
master - mean (189ms) : 185, 193
. : milestone, 189,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (1,107ms) : 1079, 1135
. : milestone, 1107,
master - mean (1,110ms) : 1076, 1145
. : milestone, 1110,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (269ms) : 266, 272
. : milestone, 269,
master - mean (270ms) : 267, 273
. : milestone, 270,
section Baseline
This PR (7142) - mean (269ms) : 265, 273
. : milestone, 269,
master - mean (269ms) : 264, 273
. : milestone, 269,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (878ms) : 852, 904
. : milestone, 878,
master - mean (884ms) : 848, 919
. : milestone, 884,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (263ms) : 260, 265
. : milestone, 263,
master - mean (263ms) : 261, 265
. : milestone, 263,
section Baseline
This PR (7142) - mean (263ms) : 259, 266
. : milestone, 263,
master - mean (263ms) : 259, 266
. : milestone, 263,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (872ms) : 839, 905
. : milestone, 872,
master - mean (879ms) : 840, 918
. : milestone, 879,
gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat X
axisFormat %s
todayMarker off
section Bailout
This PR (7142) - mean (262ms) : 259, 264
. : milestone, 262,
master - mean (261ms) : 258, 264
. : milestone, 261,
section Baseline
This PR (7142) - mean (262ms) : 258, 265
. : milestone, 262,
master - mean (261ms) : 257, 265
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (7142) - mean (778ms) : 748, 808
. : milestone, 778,
master - mean (778ms) : 756, 800
. : milestone, 778,
![dd-trace-dotnet-ci-bot[bot] avatar](https://avatars.githubusercontent.com/in/1362808?v=4 "Published by a pub.dev verified publisher"){kind=small}
Benchmarks
Benchmarks Report for benchmark platform :snail:
Benchmarks for #7142 compared to master:
- 3 benchmarks are slower, with geometric mean 1.218
- 42 benchmarks have fewer allocations
- 9 benchmarks have more allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1
5.75 KB
5.69 KB
-61 B
-1.06%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472
6.09 KB
6 KB
-85 B
-1.40%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0
5.58 KB
5.48 KB
-93 B
-1.67%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 11.2μs | 59.7ns | 322ns | 0 | 0 | 0 | 5.58 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 14.1μs | 67.5ns | 286ns | 0 | 0 | 0 | 5.75 KB |
| master | StartStopWithChild |
net472 | 22.1μs | 119ns | 651ns | 1.03 | 0.411 | 0.103 | 6.09 KB |
| #7142 | StartStopWithChild |
net6.0 | 10.6μs | 43.5ns | 168ns | 0 | 0 | 0 | 5.48 KB |
| #7142 | StartStopWithChild |
netcoreapp3.1 | 14.1μs | 74.7ns | 395ns | 0 | 0 | 0 | 5.69 KB |
| #7142 | StartStopWithChild |
net472 | 22.4μs | 70.2ns | 263ns | 1.03 | 0.342 | 0.114 | 6 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:
More allocations :warning: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
3.33 KB
3.35 KB
23 B
0.69%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 927μs | 26.6ns | 103ns | 0 | 0 | 0 | 2.71 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.04ms | 404ns | 1.56μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 1.25ms | 357ns | 1.38μs | 0 | 0 | 0 | 3.33 KB |
| #7142 | WriteAndFlushEnrichedTraces |
net6.0 | 929μs | 39.4ns | 147ns | 0 | 0 | 0 | 2.7 KB |
| #7142 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 1.03ms | 94.7ns | 354ns | 0 | 0 | 0 | 2.71 KB |
| #7142 | WriteAndFlushEnrichedTraces |
net472 | 1.19ms | 67.2ns | 260ns | 0 | 0 | 0 | 3.35 KB |
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:
More allocations :warning: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472
236.35 KB
239.66 KB
3.3 KB
1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472
239.87 KB
243.17 KB
3.3 KB
1.38%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | AllCycleSimpleBody |
net6.0 | 331μs | 1.76μs | 8.42μs | 0 | 0 | 0 | 197.06 KB |
| master | AllCycleSimpleBody |
netcoreapp3.1 | 510μs | 1.45μs | 5.61μs | 0 | 0 | 0 | 204.77 KB |
| master | AllCycleSimpleBody |
net472 | 436μs | 119ns | 460ns | 36.6 | 2.16 | 0 | 236.35 KB |
| master | AllCycleMoreComplexBody |
net6.0 | 338μs | 1.76μs | 8.8μs | 0 | 0 | 0 | 200.56 KB |
| master | AllCycleMoreComplexBody |
netcoreapp3.1 | 495μs | 987ns | 3.56μs | 0 | 0 | 0 | 208.18 KB |
| master | AllCycleMoreComplexBody |
net472 | 446μs | 106ns | 412ns | 36.6 | 2.16 | 0 | 239.87 KB |
| master | ObjectExtractorSimpleBody |
net6.0 | 311ns | 1.77ns | 12.3ns | 0 | 0 | 0 | 280 B |
| master | ObjectExtractorSimpleBody |
netcoreapp3.1 | 409ns | 1.93ns | 8.2ns | 0 | 0 | 0 | 272 B |
| master | ObjectExtractorSimpleBody |
net472 | 303ns | 0.175ns | 0.676ns | 0.0442 | 0 | 0 | 281 B |
| master | ObjectExtractorMoreComplexBody |
net6.0 | 6.52μs | 29.5ns | 110ns | 0 | 0 | 0 | 3.78 KB |
| master | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.76μs | 36.2ns | 140ns | 0 | 0 | 0 | 3.69 KB |
| master | ObjectExtractorMoreComplexBody |
net472 | 6.66μs | 0.89ns | 3.33ns | 0.599 | 0 | 0 | 3.8 KB |
| #7142 | AllCycleSimpleBody |
net6.0 | 332μs | 1.03μs | 3.97μs | 0 | 0 | 0 | 197.61 KB |
| #7142 | AllCycleSimpleBody |
netcoreapp3.1 | 504μs | 1.65μs | 6.41μs | 0 | 0 | 0 | 205.37 KB |
| #7142 | AllCycleSimpleBody |
net472 | 443μs | 169ns | 654ns | 37.9 | 2.23 | 0 | 239.66 KB |
| #7142 | AllCycleMoreComplexBody |
net6.0 | 334μs | 922ns | 3.57μs | 0 | 0 | 0 | 201.12 KB |
| #7142 | AllCycleMoreComplexBody |
netcoreapp3.1 | 486μs | 1.58μs | 5.9μs | 0 | 0 | 0 | 208.78 KB |
| #7142 | AllCycleMoreComplexBody |
net472 | 449μs | 93ns | 360ns | 37.9 | 2.23 | 0 | 243.17 KB |
| #7142 | ObjectExtractorSimpleBody |
net6.0 | 311ns | 1.67ns | 8.36ns | 0 | 0 | 0 | 280 B |
| #7142 | ObjectExtractorSimpleBody |
netcoreapp3.1 | 401ns | 1.9ns | 7.37ns | 0 | 0 | 0 | 272 B |
| #7142 | ObjectExtractorSimpleBody |
net472 | 303ns | 0.163ns | 0.63ns | 0.0435 | 0 | 0 | 281 B |
| #7142 | ObjectExtractorMoreComplexBody |
net6.0 | 6.41μs | 25.2ns | 97.6ns | 0 | 0 | 0 | 3.78 KB |
| #7142 | ObjectExtractorMoreComplexBody |
netcoreapp3.1 | 7.73μs | 29.3ns | 113ns | 0 | 0 | 0 | 3.69 KB |
| #7142 | ObjectExtractorMoreComplexBody |
net472 | 6.81μs | 2.76ns | 10.7ns | 0.579 | 0 | 0 | 3.8 KB |
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0
2.16 KB
2.14 KB
-12 B
-0.56%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EncodeArgs |
net6.0 | 73.3μs | 263ns | 984ns | 0 | 0 | 0 | 32.41 KB |
| master | EncodeArgs |
netcoreapp3.1 | 95.7μs | 36.2ns | 130ns | 0 | 0 | 0 | 32.4 KB |
| master | EncodeArgs |
net472 | 107μs | 17.6ns | 65.8ns | 4.82 | 0 | 0 | 32.51 KB |
| master | EncodeLegacyArgs |
net6.0 | 143μs | 122ns | 472ns | 0 | 0 | 0 | 2.16 KB |
| master | EncodeLegacyArgs |
netcoreapp3.1 | 197μs | 42.5ns | 147ns | 0 | 0 | 0 | 2.14 KB |
| master | EncodeLegacyArgs |
net472 | 261μs | 66.8ns | 250ns | 0 | 0 | 0 | 2.16 KB |
| #7142 | EncodeArgs |
net6.0 | 76.3μs | 207ns | 801ns | 0 | 0 | 0 | 32.4 KB |
| #7142 | EncodeArgs |
netcoreapp3.1 | 96.9μs | 188ns | 729ns | 0 | 0 | 0 | 32.4 KB |
| #7142 | EncodeArgs |
net472 | 108μs | 8.92ns | 34.5ns | 4.88 | 0 | 0 | 32.51 KB |
| #7142 | EncodeLegacyArgs |
net6.0 | 145μs | 55.7ns | 208ns | 0 | 0 | 0 | 2.14 KB |
| #7142 | EncodeLegacyArgs |
netcoreapp3.1 | 198μs | 699ns | 2.71μs | 0 | 0 | 0 | 2.15 KB |
| #7142 | EncodeLegacyArgs |
net472 | 260μs | 145ns | 560ns | 0 | 0 | 0 | 2.16 KB |
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunWafRealisticBenchmark |
net6.0 | 271μs | 133ns | 499ns | 0 | 0 | 0 | 4.55 KB |
| master | RunWafRealisticBenchmark |
netcoreapp3.1 | 294μs | 264ns | 989ns | 0 | 0 | 0 | 4.48 KB |
| master | RunWafRealisticBenchmark |
net472 | 307μs | 38.1ns | 147ns | 0 | 0 | 0 | 4.66 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net6.0 | 181μs | 80.1ns | 300ns | 0 | 0 | 0 | 2.24 KB |
| master | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 198μs | 104ns | 404ns | 0 | 0 | 0 | 2.22 KB |
| master | RunWafRealisticBenchmarkWithAttack |
net472 | 207μs | 45.3ns | 169ns | 0 | 0 | 0 | 2.28 KB |
| #7142 | RunWafRealisticBenchmark |
net6.0 | 272μs | 117ns | 437ns | 0 | 0 | 0 | 4.55 KB |
| #7142 | RunWafRealisticBenchmark |
netcoreapp3.1 | 289μs | 52ns | 201ns | 0 | 0 | 0 | 4.48 KB |
| #7142 | RunWafRealisticBenchmark |
net472 | 314μs | 1.26μs | 4.36μs | 0 | 0 | 0 | 4.65 KB |
| #7142 | RunWafRealisticBenchmarkWithAttack |
net6.0 | 184μs | 57.4ns | 222ns | 0 | 0 | 0 | 2.24 KB |
| #7142 | RunWafRealisticBenchmarkWithAttack |
netcoreapp3.1 | 195μs | 26.5ns | 103ns | 0 | 0 | 0 | 2.22 KB |
| #7142 | RunWafRealisticBenchmarkWithAttack |
net472 | 209μs | 25.5ns | 98.8ns | 0 | 0 | 0 | 2.29 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 61.1μs | 29ns | 104ns | 0 | 0 | 0 | 14.53 KB |
| master | SendRequest |
netcoreapp3.1 | 69.9μs | 118ns | 440ns | 0 | 0 | 0 | 17.42 KB |
| master | SendRequest |
net472 | 0.0171ns | 0.00147ns | 0.00551ns | 0 | 0 | 0 | 0 b |
| #7142 | SendRequest |
net6.0 | 60.7μs | 124ns | 448ns | 0 | 0 | 0 | 14.52 KB |
| #7142 | SendRequest |
netcoreapp3.1 | 70μs | 74.5ns | 269ns | 0 | 0 | 0 | 17.49 KB |
| #7142 | SendRequest |
net472 | 0.0205ns | 0.00229ns | 0.00887ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| #7142 | OriginalCharSlice |
net6.0 | 1.9ms | 2.32μs | 8.36μs | 0 | 0 | 0 | 640.01 KB |
| #7142 | OriginalCharSlice |
netcoreapp3.1 | 2.12ms | 5.19μs | 18.7μs | 0 | 0 | 0 | 640 KB |
| #7142 | OriginalCharSlice |
net472 | 2.7ms | 250ns | 935ns | 100 | 0 | 0 | 641.95 KB |
| #7142 | OptimizedCharSlice |
net6.0 | 1.43ms | 297ns | 1.11μs | 0 | 0 | 0 | 7 B |
| #7142 | OptimizedCharSlice |
netcoreapp3.1 | 1.88ms | 397ns | 1.54μs | 0 | 0 | 0 | 1 B |
| #7142 | OptimizedCharSlice |
net472 | 1.98ms | 1.39μs | 5.4μs | 0 | 0 | 0 | 73 B |
| #7142 | OptimizedCharSliceWithPool |
net6.0 | 796μs | 57.4ns | 222ns | 0 | 0 | 0 | 4 B |
| #7142 | OptimizedCharSliceWithPool |
netcoreapp3.1 | 831μs | 112ns | 434ns | 0 | 0 | 0 | 0 b |
| #7142 | OptimizedCharSliceWithPool |
net472 | 1.22ms | 46.2ns | 179ns | 0 | 0 | 0 | 47 B |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower :warning: More allocations :warning:
Slower :warning: in #7142
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
1.210
645,405.00
780,940.42
several?
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
1.203
924,947.10
1,112,545.83
More allocations :warning: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.73 KB
42.33 KB
596 B
1.43%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472
55.75 KB
56.15 KB
397 B
0.71%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1
41.89 KB
42.16 KB
268 B
0.64%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 645μs | 512ns | 1.98μs | 0 | 0 | 0 | 41.73 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 631μs | 1.67μs | 6.67μs | 0 | 0 | 0 | 41.89 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 923μs | 1.93μs | 7.2μs | 4.46 | 0 | 0 | 55.75 KB |
| #7142 | WriteAndFlushEnrichedTraces |
net6.0 | 776μs | 4.24μs | 25.4μs | 0 | 0 | 0 | 42.33 KB |
| #7142 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 683μs | 3.33μs | 14.5μs | 0 | 0 | 0 | 42.16 KB |
| #7142 | WriteAndFlushEnrichedTraces |
net472 | 1.11ms | 5.9μs | 32.3μs | 5.21 | 0 | 0 | 56.15 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0
1.03 KB
1.02 KB
-8 B
-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1
1.02 KB
1.02 KB
-8 B
-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472
995 B
987 B
-8 B
-0.80%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.99μs | 10.2ns | 46.8ns | 0 | 0 | 0 | 1.03 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 2.53μs | 3.43ns | 13.3ns | 0 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.7μs | 2.41ns | 9.34ns | 0.147 | 0.0134 | 0 | 995 B |
| #7142 | ExecuteNonQuery |
net6.0 | 1.87μs | 7.49ns | 29ns | 0 | 0 | 0 | 1.02 KB |
| #7142 | ExecuteNonQuery |
netcoreapp3.1 | 2.52μs | 7.06ns | 27.3ns | 0 | 0 | 0 | 1.02 KB |
| #7142 | ExecuteNonQuery |
net472 | 2.76μs | 4.79ns | 18.5ns | 0.149 | 0.0136 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472
1.11 KB
1.1 KB
-8 B
-0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1
1.09 KB
1.08 KB
-8 B
-0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472
1.05 KB
1.04 KB
-8 B
-0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0
1.04 KB
1.03 KB
-8 B
-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1
1.04 KB
1.03 KB
-8 B
-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0
1.02 KB
1.01 KB
-8 B
-0.79%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.83μs | 5.85ns | 22.7ns | 0 | 0 | 0 | 1.04 KB |
| master | CallElasticsearch |
netcoreapp3.1 | 2.3μs | 11.8ns | 56.6ns | 0 | 0 | 0 | 1.04 KB |
| master | CallElasticsearch |
net472 | 3.55μs | 3.05ns | 11.8ns | 0.159 | 0 | 0 | 1.05 KB |
| master | CallElasticsearchAsync |
net6.0 | 1.81μs | 3.89ns | 14.5ns | 0 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 2.35μs | 7.26ns | 28.1ns | 0 | 0 | 0 | 1.09 KB |
| master | CallElasticsearchAsync |
net472 | 3.84μs | 3.19ns | 12.4ns | 0.169 | 0 | 0 | 1.11 KB |
| #7142 | CallElasticsearch |
net6.0 | 1.82μs | 9.37ns | 41.9ns | 0 | 0 | 0 | 1.03 KB |
| #7142 | CallElasticsearch |
netcoreapp3.1 | 2.36μs | 11.3ns | 48.1ns | 0 | 0 | 0 | 1.03 KB |
| #7142 | CallElasticsearch |
net472 | 3.69μs | 1.91ns | 7.41ns | 0.147 | 0 | 0 | 1.04 KB |
| #7142 | CallElasticsearchAsync |
net6.0 | 1.83μs | 4.93ns | 18.5ns | 0 | 0 | 0 | 1.01 KB |
| #7142 | CallElasticsearchAsync |
netcoreapp3.1 | 2.44μs | 10.4ns | 40.1ns | 0 | 0 | 0 | 1.08 KB |
| #7142 | CallElasticsearchAsync |
net472 | 3.9μs | 3.53ns | 13.7ns | 0.172 | 0 | 0 | 1.1 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0
960 B
952 B
-8 B
-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1
960 B
952 B
-8 B
-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472
923 B
915 B
-8 B
-0.87%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.78μs | 9.27ns | 43.5ns | 0 | 0 | 0 | 960 B |
| master | ExecuteAsync |
netcoreapp3.1 | 2.29μs | 7.45ns | 25.8ns | 0 | 0 | 0 | 960 B |
| master | ExecuteAsync |
net472 | 2.58μs | 1.78ns | 6.88ns | 0.143 | 0 | 0 | 923 B |
| #7142 | ExecuteAsync |
net6.0 | 1.85μs | 6.05ns | 23.4ns | 0 | 0 | 0 | 952 B |
| #7142 | ExecuteAsync |
netcoreapp3.1 | 2.34μs | 1.15ns | 4.3ns | 0 | 0 | 0 | 952 B |
| #7142 | ExecuteAsync |
net472 | 2.51μs | 0.604ns | 2.34ns | 0.138 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 7.1μs | 10.4ns | 39ns | 0 | 0 | 0 | 2.37 KB |
| master | SendAsync |
netcoreapp3.1 | 8.69μs | 14.1ns | 54.6ns | 0 | 0 | 0 | 2.9 KB |
| master | SendAsync |
net472 | 12.5μs | 10.3ns | 38.5ns | 0.498 | 0 | 0 | 3.19 KB |
| #7142 | SendAsync |
net6.0 | 7.06μs | 6.3ns | 23.6ns | 0 | 0 | 0 | 2.36 KB |
| #7142 | SendAsync |
netcoreapp3.1 | 8.39μs | 20.9ns | 80.9ns | 0 | 0 | 0 | 2.9 KB |
| #7142 | SendAsync |
net472 | 12.5μs | 9.89ns | 38.3ns | 0.499 | 0 | 0 | 3.18 KB |
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:
Slower :warning: in #7142
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
1.241
413,700.00
513,400.00
More allocations :warning: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472
57.34 KB
65.54 KB
8.19 KB
14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0
259.96 KB
279.02 KB
19.06 KB
7.33%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1
42.64 KB
44.02 KB
1.38 KB
3.23%
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472
286.72 KB
278.53 KB
-8.19 KB
-2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1
274.93 KB
257.08 KB
-17.85 KB
-6.49%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StringConcatBenchmark |
net6.0 | 44.6μs | 212ns | 1.6μs | 0 | 0 | 0 | 43.83 KB |
| master | StringConcatBenchmark |
netcoreapp3.1 | 47.2μs | 224ns | 838ns | 0 | 0 | 0 | 42.64 KB |
| master | StringConcatBenchmark |
net472 | 56.8μs | 259ns | 968ns | 0 | 0 | 0 | 57.34 KB |
| master | StringConcatAspectBenchmark |
net6.0 | 458μs | 1.08μs | 3.89μs | 0 | 0 | 0 | 259.96 KB |
| master | StringConcatAspectBenchmark |
netcoreapp3.1 | 447μs | 6.44μs | 63.7μs | 0 | 0 | 0 | 274.93 KB |
| master | StringConcatAspectBenchmark |
net472 | 410μs | 2.07μs | 9.27μs | 0 | 0 | 0 | 286.72 KB |
| #7142 | StringConcatBenchmark |
net6.0 | 44.6μs | 233ns | 1.3μs | 0 | 0 | 0 | 43.87 KB |
| #7142 | StringConcatBenchmark |
netcoreapp3.1 | 46.9μs | 217ns | 782ns | 0 | 0 | 0 | 44.02 KB |
| #7142 | StringConcatBenchmark |
net472 | 57.4μs | 235ns | 879ns | 0 | 0 | 0 | 65.54 KB |
| #7142 | StringConcatAspectBenchmark |
net6.0 | 468μs | 1.89μs | 8.84μs | 0 | 0 | 0 | 279.02 KB |
| #7142 | StringConcatAspectBenchmark |
netcoreapp3.1 | 516μs | 2.15μs | 8.32μs | 0 | 0 | 0 | 257.08 KB |
| #7142 | StringConcatAspectBenchmark |
net472 | 403μs | 2.28μs | 16.3μs | 0 | 0 | 0 | 278.53 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0
1.76 KB
1.7 KB
-56 B
-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1
1.76 KB
1.7 KB
-56 B
-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472
1.69 KB
1.64 KB
-56 B
-3.31%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.63μs | 2.6ns | 10.1ns | 0 | 0 | 0 | 1.76 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.44μs | 4.38ns | 17ns | 0 | 0 | 0 | 1.76 KB |
| master | EnrichedLog |
net472 | 4.05μs | 4.83ns | 18.7ns | 0.265 | 0 | 0 | 1.69 KB |
| #7142 | EnrichedLog |
net6.0 | 2.62μs | 14ns | 75.2ns | 0 | 0 | 0 | 1.7 KB |
| #7142 | EnrichedLog |
netcoreapp3.1 | 3.44μs | 10.7ns | 41.6ns | 0 | 0 | 0 | 1.7 KB |
| #7142 | EnrichedLog |
net472 | 4μs | 1.22ns | 4.57ns | 0.26 | 0 | 0 | 1.64 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472
4.57 KB
4.52 KB
-55 B
-1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0
4.37 KB
4.31 KB
-56 B
-1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1
4.37 KB
4.31 KB
-56 B
-1.28%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 123μs | 145ns | 563ns | 0 | 0 | 0 | 4.37 KB |
| master | EnrichedLog |
netcoreapp3.1 | 126μs | 330ns | 1.24μs | 0 | 0 | 0 | 4.37 KB |
| master | EnrichedLog |
net472 | 167μs | 161ns | 603ns | 0 | 0 | 0 | 4.57 KB |
| #7142 | EnrichedLog |
net6.0 | 123μs | 61.3ns | 237ns | 0 | 0 | 0 | 4.31 KB |
| #7142 | EnrichedLog |
netcoreapp3.1 | 128μs | 67.9ns | 235ns | 0 | 0 | 0 | 4.31 KB |
| #7142 | EnrichedLog |
net472 | 166μs | 65.6ns | 254ns | 0 | 0 | 0 | 4.52 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0
2.32 KB
2.26 KB
-56 B
-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1
2.32 KB
2.26 KB
-56 B
-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472
2.14 KB
2.08 KB
-56 B
-2.62%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.94μs | 19.3ns | 74.6ns | 0 | 0 | 0 | 2.32 KB |
| master | EnrichedLog |
netcoreapp3.1 | 6.77μs | 22.2ns | 79.9ns | 0 | 0 | 0 | 2.32 KB |
| master | EnrichedLog |
net472 | 7.45μs | 8.04ns | 31.1ns | 0.335 | 0 | 0 | 2.14 KB |
| #7142 | EnrichedLog |
net6.0 | 5.21μs | 6.2ns | 24ns | 0 | 0 | 0 | 2.26 KB |
| #7142 | EnrichedLog |
netcoreapp3.1 | 6.77μs | 23.1ns | 89.5ns | 0 | 0 | 0 | 2.26 KB |
| #7142 | EnrichedLog |
net472 | 7.67μs | 7.33ns | 28.4ns | 0.308 | 0 | 0 | 2.08 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472
1.21 KB
1.2 KB
-8 B
-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0
1.21 KB
1.2 KB
-8 B
-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1
1.21 KB
1.2 KB
-8 B
-0.66%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 2.04μs | 10.5ns | 49.4ns | 0 | 0 | 0 | 1.21 KB |
| master | SendReceive |
netcoreapp3.1 | 2.53μs | 11.8ns | 47.4ns | 0 | 0 | 0 | 1.21 KB |
| master | SendReceive |
net472 | 3.28μs | 2.71ns | 10.5ns | 0.178 | 0 | 0 | 1.21 KB |
| #7142 | SendReceive |
net6.0 | 1.99μs | 9.15ns | 36.6ns | 0 | 0 | 0 | 1.2 KB |
| #7142 | SendReceive |
netcoreapp3.1 | 2.6μs | 11.4ns | 44.3ns | 0 | 0 | 0 | 1.2 KB |
| #7142 | SendReceive |
net472 | 3.29μs | 3.95ns | 14.8ns | 0.182 | 0 | 0 | 1.2 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472
2.08 KB
2.03 KB
-56 B
-2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1
1.69 KB
1.63 KB
-56 B
-3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0
1.64 KB
1.58 KB
-56 B
-3.41%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 4.18μs | 0.92ns | 3.44ns | 0 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 5.64μs | 23ns | 89.3ns | 0 | 0 | 0 | 1.69 KB |
| master | EnrichedLog |
net472 | 6.67μs | 7.28ns | 27.3ns | 0.298 | 0 | 0 | 2.08 KB |
| #7142 | EnrichedLog |
net6.0 | 4.2μs | 1.91ns | 7.16ns | 0 | 0 | 0 | 1.58 KB |
| #7142 | EnrichedLog |
netcoreapp3.1 | 5.61μs | 14ns | 52.5ns | 0 | 0 | 0 | 1.63 KB |
| #7142 | EnrichedLog |
net472 | 6.86μs | 9.63ns | 37.3ns | 0.306 | 0 | 0 | 2.03 KB |
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
704 B
696 B
-8 B
-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1
704 B
696 B
-8 B
-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472
666 B
658 B
-8 B
-1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472
586 B
578 B
-8 B
-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0
584 B
576 B
-8 B
-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1
584 B
576 B
-8 B
-1.37%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 751ns | 3.97ns | 22.4ns | 0 | 0 | 0 | 584 B |
| master | StartFinishSpan |
netcoreapp3.1 | 953ns | 4.42ns | 17.7ns | 0 | 0 | 0 | 584 B |
| master | StartFinishSpan |
net472 | 914ns | 0.809ns | 3.13ns | 0.0912 | 0 | 0 | 586 B |
| master | StartFinishScope |
net6.0 | 918ns | 0.479ns | 1.73ns | 0 | 0 | 0 | 704 B |
| master | StartFinishScope |
netcoreapp3.1 | 1.15μs | 6.24ns | 34.2ns | 0 | 0 | 0 | 704 B |
| master | StartFinishScope |
net472 | 1.09μs | 0.174ns | 0.652ns | 0.104 | 0 | 0 | 666 B |
| #7142 | StartFinishSpan |
net6.0 | 755ns | 4.04ns | 21.8ns | 0 | 0 | 0 | 576 B |
| #7142 | StartFinishSpan |
netcoreapp3.1 | 973ns | 4.33ns | 16.8ns | 0 | 0 | 0 | 576 B |
| #7142 | StartFinishSpan |
net472 | 992ns | 2.69ns | 10.4ns | 0.0898 | 0 | 0 | 578 B |
| #7142 | StartFinishScope |
net6.0 | 903ns | 0.212ns | 0.821ns | 0 | 0 | 0 | 696 B |
| #7142 | StartFinishScope |
netcoreapp3.1 | 1.21μs | 5.87ns | 25.6ns | 0 | 0 | 0 | 696 B |
| #7142 | StartFinishScope |
net472 | 1.09μs | 0.247ns | 0.923ns | 0.0995 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #7142
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
704 B
696 B
-8 B
-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1
704 B
696 B
-8 B
-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472
666 B
658 B
-8 B
-1.20%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 1.02μs | 5.36ns | 26.8ns | 0 | 0 | 0 | 704 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 1.38μs | 2.28ns | 8.82ns | 0 | 0 | 0 | 704 B |
| master | RunOnMethodBegin |
net472 | 1.36μs | 0.141ns | 0.544ns | 0.102 | 0 | 0 | 666 B |
| #7142 | RunOnMethodBegin |
net6.0 | 1.06μs | 5.46ns | 25.6ns | 0 | 0 | 0 | 696 B |
| #7142 | RunOnMethodBegin |
netcoreapp3.1 | 1.42μs | 7.34ns | 36ns | 0 | 0 | 0 | 696 B |
| #7142 | RunOnMethodBegin |
net472 | 1.42μs | 0.733ns | 2.84ns | 0.1 | 0 | 0 | 658 B |