dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Deduce StreamName from StreamARN for Kinesis when StreamName not provided

Open robcarlan-datadog opened this issue 5 months ago • 3 comments

Summary of changes

DSM does not submit data when requests are sent with StreamARN rather than StreamName. The cilent allows providing either, but recommends sending the full StreamARN instead (docs). So if people follow the AWS docs, they will not see DSM data.

We fix this by using a deduced StreamName from the StreamARN if provided to supply the streamname tag.

This is pretty much the same logic as we use in the Java tracer: here.

Reason for change

People using .NET & Kinesis won't see DSM data if they use use the StreamARN parameter, leading to a bad user experience.

Implementation details

This only affects the PutRecord/PutRecords (sync & async) requests. GetRecords always uses the stream ARN, and we use the same logic of deducing a stream name from the StreamARN to create the context on the receiving side. AWS Docs

We have to split the Kinesis instrumentation into two, as the new field is only introduced in v3.7 and above.

Test coverage

Added unit tests for the name deduction logic, existing integration tests cover versions below 3.7 and above, so test both instrumentations. The test doesn't use the StreamARN parameter, which I tested manually.

Other details

robcarlan-datadog avatar Jun 23 '25 20:06 robcarlan-datadog

Datadog Report

All test runs 5fc281b :link:

:white_check_mark: 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 568495 4424 32h 25m 58.48s Link
exploration_tests 0 0 0 22085 3 2m 30.69s Link

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7134 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.170
  • 43 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 6.05 KB -34 B -0.56%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.68 KB -71 B -1.23%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.49 KB -84 B -1.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7134 StartStopWithChild net6.0 10.7μs 58.6ns 331ns 0 0 0 5.49 KB
#7134 StartStopWithChild netcoreapp3.1 14.1μs 73.1ns 343ns 0 0 0 5.68 KB
#7134 StartStopWithChild net472 22.6μs 120ns 637ns 1.03 0.31 0.103 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7134 WriteAndFlushEnrichedTraces net6.0 924μs 227ns 881ns 0 0 0 2.71 KB
#7134 WriteAndFlushEnrichedTraces netcoreapp3.1 1.05ms 84.7ns 305ns 0 0 0 2.7 KB
#7134 WriteAndFlushEnrichedTraces net472 1.23ms 242ns 905ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.66 KB 3.3 KB 1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.17 KB 3.3 KB 1.38%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7134 AllCycleSimpleBody net6.0 332μs 1.26μs 4.89μs 0 0 0 197.61 KB
#7134 AllCycleSimpleBody netcoreapp3.1 475μs 2.01μs 6.96μs 0 0 0 205.37 KB
#7134 AllCycleSimpleBody net472 447μs 211ns 819ns 37.9 2.23 0 239.66 KB
#7134 AllCycleMoreComplexBody net6.0 344μs 1.78μs 8.35μs 0 0 0 201.12 KB
#7134 AllCycleMoreComplexBody netcoreapp3.1 530μs 2.79μs 14μs 0 0 0 208.78 KB
#7134 AllCycleMoreComplexBody net472 451μs 136ns 510ns 37.9 2.23 0 243.17 KB
#7134 ObjectExtractorSimpleBody net6.0 319ns 0.919ns 3.56ns 0 0 0 280 B
#7134 ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.15ns 11.6ns 0 0 0 272 B
#7134 ObjectExtractorSimpleBody net472 308ns 0.0348ns 0.135ns 0.0444 0 0 281 B
#7134 ObjectExtractorMoreComplexBody net6.0 6.4μs 7.92ns 30.7ns 0 0 0 3.78 KB
#7134 ObjectExtractorMoreComplexBody netcoreapp3.1 7.71μs 33.5ns 130ns 0 0 0 3.69 KB
#7134 ObjectExtractorMoreComplexBody net472 6.84μs 4.12ns 16ns 0.579 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7134 EncodeArgs net6.0 76.4μs 181ns 679ns 0 0 0 32.4 KB
#7134 EncodeArgs netcoreapp3.1 98μs 202ns 783ns 0 0 0 32.4 KB
#7134 EncodeArgs net472 110μs 11.1ns 43.1ns 4.93 0 0 32.51 KB
#7134 EncodeLegacyArgs net6.0 146μs 94.6ns 366ns 0 0 0 2.15 KB
#7134 EncodeLegacyArgs netcoreapp3.1 197μs 201ns 780ns 0 0 0 2.14 KB
#7134 EncodeLegacyArgs net472 260μs 46.5ns 180ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7134 RunWafRealisticBenchmark net6.0 275μs 58.7ns 219ns 0 0 0 4.55 KB
#7134 RunWafRealisticBenchmark netcoreapp3.1 291μs 59.3ns 214ns 0 0 0 4.48 KB
#7134 RunWafRealisticBenchmark net472 308μs 28ns 105ns 0 0 0 4.66 KB
#7134 RunWafRealisticBenchmarkWithAttack net6.0 181μs 43.4ns 162ns 0 0 0 2.24 KB
#7134 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 194μs 54.4ns 211ns 0 0 0 2.22 KB
#7134 RunWafRealisticBenchmarkWithAttack net472 207μs 26.7ns 103ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7134 SendRequest net6.0 62.2μs 107ns 401ns 0 0 0 14.52 KB
#7134 SendRequest netcoreapp3.1 71.2μs 69ns 249ns 0 0 0 17.42 KB
#7134 SendRequest net472 0.0132ns 0.00242ns 0.00937ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
#7134 OriginalCharSlice net6.0 1.88ms 1.48μs 5.55μs 0 0 0 640.01 KB
#7134 OriginalCharSlice netcoreapp3.1 2.13ms 5.11μs 19.8μs 0 0 0 640 KB
#7134 OriginalCharSlice net472 2.65ms 1.64μs 6.15μs 100 0 0 641.95 KB
#7134 OptimizedCharSlice net6.0 1.42ms 617ns 2.39μs 0 0 0 4 B
#7134 OptimizedCharSlice netcoreapp3.1 1.76ms 335ns 1.3μs 0 0 0 1 B
#7134 OptimizedCharSlice net472 2.04ms 316ns 1.22μs 0 0 0 0 b
#7134 OptimizedCharSliceWithPool net6.0 860μs 29.2ns 113ns 0 0 0 3 B
#7134 OptimizedCharSliceWithPool netcoreapp3.1 799μs 56ns 217ns 0 0 0 0 b
#7134 OptimizedCharSliceWithPool net472 1.21ms 148ns 574ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.03 KB 279 B 0.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7134 WriteAndFlushEnrichedTraces net6.0 665μs 3.35μs 15.4μs 0 0 0 41.83 KB
#7134 WriteAndFlushEnrichedTraces netcoreapp3.1 696μs 1.58μs 5.68μs 0 0 0 41.87 KB
#7134 WriteAndFlushEnrichedTraces net472 840μs 2.7μs 10.5μs 7.81 0 0 56.03 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7134 ExecuteNonQuery net6.0 1.94μs 4.44ns 17.2ns 0 0 0 1.02 KB
#7134 ExecuteNonQuery netcoreapp3.1 2.63μs 5.79ns 22.4ns 0 0 0 1.02 KB
#7134 ExecuteNonQuery net472 2.81μs 5.3ns 20.5ns 0.149 0.0149 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7134 CallElasticsearch net6.0 1.77μs 1.25ns 4.67ns 0 0 0 1.03 KB
#7134 CallElasticsearch netcoreapp3.1 2.31μs 8.94ns 34.6ns 0 0 0 1.03 KB
#7134 CallElasticsearch net472 3.51μs 1.6ns 6.19ns 0.159 0 0 1.04 KB
#7134 CallElasticsearchAsync net6.0 1.81μs 1.49ns 5.38ns 0 0 0 1.01 KB
#7134 CallElasticsearchAsync netcoreapp3.1 2.47μs 4.97ns 18.6ns 0 0 0 1.08 KB
#7134 CallElasticsearchAsync net472 3.88μs 4.67ns 18.1ns 0.172 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7134 ExecuteAsync net6.0 1.75μs 0.992ns 3.71ns 0 0 0 952 B
#7134 ExecuteAsync netcoreapp3.1 2.35μs 2.15ns 7.76ns 0 0 0 952 B
#7134 ExecuteAsync net472 2.63μs 4.63ns 17.9ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7134 SendAsync net6.0 6.88μs 6.59ns 24.7ns 0 0 0 2.36 KB
#7134 SendAsync netcoreapp3.1 8.69μs 29.4ns 114ns 0 0 0 2.9 KB
#7134 SendAsync net472 12.6μs 8.96ns 34.7ns 0.502 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: Fewer allocations :tada:

Slower :warning: in #7134

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.221 413,700.00 504,950.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.122 458,300.00 514,300.00

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.83 KB 43.44 KB -392 B -0.89%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7134 StringConcatBenchmark net6.0 43.9μs 235ns 1.47μs 0 0 0 43.44 KB
#7134 StringConcatBenchmark netcoreapp3.1 50.3μs 292ns 2.3μs 0 0 0 42.64 KB
#7134 StringConcatBenchmark net472 57.3μs 182ns 682ns 0 0 0 57.34 KB
#7134 StringConcatAspectBenchmark net6.0 518μs 2.41μs 9.95μs 0 0 0 259.14 KB
#7134 StringConcatAspectBenchmark netcoreapp3.1 507μs 1.88μs 7.03μs 0 0 0 275.97 KB
#7134 StringConcatAspectBenchmark net472 405μs 2.32μs 17.3μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7134 EnrichedLog net6.0 2.71μs 3.03ns 11.7ns 0 0 0 1.7 KB
#7134 EnrichedLog netcoreapp3.1 3.41μs 17.1ns 74.4ns 0 0 0 1.7 KB
#7134 EnrichedLog net472 3.95μs 6.55ns 25.4ns 0.255 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.51 KB -60 B -1.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7134 EnrichedLog net6.0 122μs 122ns 456ns 0 0 0 4.31 KB
#7134 EnrichedLog netcoreapp3.1 126μs 60.2ns 217ns 0 0 0 4.31 KB
#7134 EnrichedLog net472 166μs 130ns 487ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7134 EnrichedLog net6.0 5.04μs 8.31ns 28.8ns 0 0 0 2.26 KB
#7134 EnrichedLog netcoreapp3.1 6.86μs 31.5ns 122ns 0 0 0 2.26 KB
#7134 EnrichedLog net472 7.39μs 4.24ns 15.3ns 0.297 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7134 SendReceive net6.0 2.09μs 5.7ns 22.1ns 0 0 0 1.2 KB
#7134 SendReceive netcoreapp3.1 2.6μs 9.41ns 36.4ns 0 0 0 1.2 KB
#7134 SendReceive net472 3.07μs 3.19ns 12.3ns 0.183 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7134 EnrichedLog net6.0 4.22μs 18.7ns 72.4ns 0 0 0 1.58 KB
#7134 EnrichedLog netcoreapp3.1 5.55μs 14.6ns 56.4ns 0 0 0 1.63 KB
#7134 EnrichedLog net472 6.68μs 6.21ns 24ns 0.298 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7134 StartFinishSpan net6.0 765ns 3.56ns 14.2ns 0 0 0 576 B
#7134 StartFinishSpan netcoreapp3.1 965ns 4.43ns 17.2ns 0 0 0 576 B
#7134 StartFinishSpan net472 906ns 1.51ns 5.83ns 0.09 0 0 578 B
#7134 StartFinishScope net6.0 899ns 4.99ns 30.8ns 0 0 0 696 B
#7134 StartFinishScope netcoreapp3.1 1.2μs 6.57ns 37.2ns 0 0 0 696 B
#7134 StartFinishScope net472 1.11μs 0.642ns 2.49ns 0.0997 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7134

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7134 RunOnMethodBegin net6.0 1.06μs 5.18ns 20.7ns 0 0 0 696 B
#7134 RunOnMethodBegin netcoreapp3.1 1.41μs 3.41ns 13.2ns 0 0 0 696 B
#7134 RunOnMethodBegin net472 1.4μs 2.61ns 10.1ns 0.0984 0 0 658 B

pr-commenter[bot] avatar Jun 23 '25 21:06 pr-commenter[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (76ms)  : 74, 77
     .   : milestone, 76,
    master - mean (76ms)  : 74, 78
     .   : milestone, 76,

    section Baseline
    This PR (7134) - mean (72ms)  : 68, 75
     .   : milestone, 72,
    master - mean (72ms)  : 68, 76
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (1,032ms)  : 1007, 1057
     .   : milestone, 1032,
    master - mean (1,035ms)  : 1010, 1060
     .   : milestone, 1035,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (109ms)  : 107, 111
     .   : milestone, 109,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section Baseline
    This PR (7134) - mean (107ms)  : 104, 110
     .   : milestone, 107,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (715ms)  : 698, 732
     .   : milestone, 715,
    master - mean (721ms)  : 697, 744
     .   : milestone, 721,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (96ms)  : 93, 98
     .   : milestone, 96,
    master - mean (96ms)  : 94, 98
     .   : milestone, 96,

    section Baseline
    This PR (7134) - mean (96ms)  : 93, 99
     .   : milestone, 96,
    master - mean (96ms)  : 93, 99
     .   : milestone, 96,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (678ms)  : 655, 701
     .   : milestone, 678,
    master - mean (684ms)  : 662, 706
     .   : milestone, 684,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (193ms)  : 190, 195
     .   : milestone, 193,
    master - mean (193ms)  : 190, 195
     .   : milestone, 193,

    section Baseline
    This PR (7134) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (1,123ms)  : 1089, 1156
     .   : milestone, 1123,
    master - mean (1,115ms)  : 1089, 1141
     .   : milestone, 1115,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (270ms)  : 266, 273
     .   : milestone, 270,
    master - mean (270ms)  : 267, 272
     .   : milestone, 270,

    section Baseline
    This PR (7134) - mean (270ms)  : 264, 275
     .   : milestone, 270,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (891ms)  : 842, 940
     .   : milestone, 891,
    master - mean (885ms)  : 859, 912
     .   : milestone, 885,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (262ms)  : 260, 265
     .   : milestone, 262,
    master - mean (263ms)  : 260, 265
     .   : milestone, 263,

    section Baseline
    This PR (7134) - mean (262ms)  : 259, 266
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (874ms)  : 844, 905
     .   : milestone, 874,
    master - mean (880ms)  : 850, 910
     .   : milestone, 880,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7134) - mean (262ms)  : 259, 265
     .   : milestone, 262,
    master - mean (261ms)  : 259, 263
     .   : milestone, 261,

    section Baseline
    This PR (7134) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (261ms)  : 258, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (7134) - mean (782ms)  : 757, 807
     .   : milestone, 782,
    master - mean (780ms)  : 762, 798
     .   : milestone, 780,