Add support for NLog 6.0

[andrewlock]

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

[datadog-datadog-prod-us1[bot]]

Datadog Report

All test runs 87a68cd :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Test Service View
dd-trace-dotnet	1201	0	0	580648	4343	32h 10m 10.28s	Link
exploration_tests	0	0	0	22085	3	2m 24.71s	Link

:x: Failed Tests (1201)

This report shows up to 5 failed tests.

• SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.Elasticsearch7Tests - Details

  Expand for error

  xpected exit code: 0, actual exit code: 139.
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected collection to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected collection to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected collection to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected collection to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass14_0).hostName), but the collection is empty.
  xpected collection to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected collection to contain only items matching (x.Exception == null), but the collection is empty.
  xpected collection to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected collection to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected collection to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected collection to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected collection to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected collection to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass14_0).hostName), but the collection is empty.
  xpected collection to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected collection to contain only items matching (x.Exception == null), but the collection is empty.
  xpected collection to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected collection to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass14_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass14_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

[pr-commenter[bot]]

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7131 compared to master:

• 1 benchmarks are slower, with geometric mean 1.250
• 44 benchmarks have fewer allocations
• 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1	5.75 KB	5.72 KB	-37 B	-0.64%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472	6.09 KB	6.04 KB	-48 B	-0.79%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0	5.58 KB	5.49 KB	-87 B	-1.56%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartStopWithChild	net6.0	11.2μs	59.7ns	322ns	0	0	0	5.58 KB
master	StartStopWithChild	netcoreapp3.1	14.1μs	67.5ns	286ns	0	0	0	5.75 KB
master	StartStopWithChild	net472	22.1μs	119ns	651ns	1.03	0.411	0.103	6.09 KB
#7131	StartStopWithChild	net6.0	10.4μs	56.1ns	323ns	0	0	0	5.49 KB
#7131	StartStopWithChild	netcoreapp3.1	13.3μs	66.8ns	291ns	0	0	0	5.72 KB
#7131	StartStopWithChild	net472	22.4μs	123ns	741ns	1.06	0.319	0.106	6.04 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472	3.33 KB	3.31 KB	-23 B	-0.69%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	927μs	26.6ns	103ns	0	0	0	2.71 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	1.04ms	404ns	1.56μs	0	0	0	2.7 KB
master	WriteAndFlushEnrichedTraces	net472	1.25ms	357ns	1.38μs	0	0	0	3.33 KB
#7131	WriteAndFlushEnrichedTraces	net6.0	927μs	175ns	653ns	0	0	0	2.7 KB
#7131	WriteAndFlushEnrichedTraces	netcoreapp3.1	1.01ms	61.5ns	238ns	0	0	0	2.7 KB
#7131	WriteAndFlushEnrichedTraces	net472	1.19ms	66.9ns	241ns	0	0	0	3.31 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472	236.35 KB	239.66 KB	3.3 KB	1.40%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472	239.87 KB	243.17 KB	3.3 KB	1.38%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	AllCycleSimpleBody	net6.0	331μs	1.76μs	8.42μs	0	0	0	197.06 KB
master	AllCycleSimpleBody	netcoreapp3.1	510μs	1.45μs	5.61μs	0	0	0	204.77 KB
master	AllCycleSimpleBody	net472	436μs	119ns	460ns	36.6	2.16	0	236.35 KB
master	AllCycleMoreComplexBody	net6.0	338μs	1.76μs	8.8μs	0	0	0	200.56 KB
master	AllCycleMoreComplexBody	netcoreapp3.1	495μs	987ns	3.56μs	0	0	0	208.18 KB
master	AllCycleMoreComplexBody	net472	446μs	106ns	412ns	36.6	2.16	0	239.87 KB
master	ObjectExtractorSimpleBody	net6.0	311ns	1.77ns	12.3ns	0	0	0	280 B
master	ObjectExtractorSimpleBody	netcoreapp3.1	409ns	1.93ns	8.2ns	0	0	0	272 B
master	ObjectExtractorSimpleBody	net472	303ns	0.175ns	0.676ns	0.0442	0	0	281 B
master	ObjectExtractorMoreComplexBody	net6.0	6.52μs	29.5ns	110ns	0	0	0	3.78 KB
master	ObjectExtractorMoreComplexBody	netcoreapp3.1	7.76μs	36.2ns	140ns	0	0	0	3.69 KB
master	ObjectExtractorMoreComplexBody	net472	6.66μs	0.89ns	3.33ns	0.599	0	0	3.8 KB
#7131	AllCycleSimpleBody	net6.0	336μs	329ns	1.28μs	0	0	0	197.61 KB
#7131	AllCycleSimpleBody	netcoreapp3.1	504μs	1.86μs	7.21μs	0	0	0	205.37 KB
#7131	AllCycleSimpleBody	net472	445μs	117ns	422ns	36.6	2.16	0	239.66 KB
#7131	AllCycleMoreComplexBody	net6.0	343μs	288ns	1.08μs	0	0	0	201.12 KB
#7131	AllCycleMoreComplexBody	netcoreapp3.1	518μs	1.74μs	6.74μs	0	0	0	208.78 KB
#7131	AllCycleMoreComplexBody	net472	452μs	103ns	400ns	37.9	2.23	0	243.17 KB
#7131	ObjectExtractorSimpleBody	net6.0	316ns	1.62ns	7.59ns	0	0	0	280 B
#7131	ObjectExtractorSimpleBody	netcoreapp3.1	400ns	1.96ns	8.32ns	0	0	0	272 B
#7131	ObjectExtractorSimpleBody	net472	305ns	0.0322ns	0.125ns	0.0444	0	0	281 B
#7131	ObjectExtractorMoreComplexBody	net6.0	6.36μs	2.97ns	10.7ns	0	0	0	3.78 KB
#7131	ObjectExtractorMoreComplexBody	netcoreapp3.1	7.8μs	2.07ns	8.01ns	0	0	0	3.69 KB
#7131	ObjectExtractorMoreComplexBody	net472	6.78μs	2.21ns	8.28ns	0.576	0	0	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0	2.16 KB	2.15 KB	-11 B	-0.51%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EncodeArgs	net6.0	73.3μs	263ns	984ns	0	0	0	32.41 KB
master	EncodeArgs	netcoreapp3.1	95.7μs	36.2ns	130ns	0	0	0	32.4 KB
master	EncodeArgs	net472	107μs	17.6ns	65.8ns	4.82	0	0	32.51 KB
master	EncodeLegacyArgs	net6.0	143μs	122ns	472ns	0	0	0	2.16 KB
master	EncodeLegacyArgs	netcoreapp3.1	197μs	42.5ns	147ns	0	0	0	2.14 KB
master	EncodeLegacyArgs	net472	261μs	66.8ns	250ns	0	0	0	2.16 KB
#7131	EncodeArgs	net6.0	78μs	288ns	1.08μs	0	0	0	32.4 KB
#7131	EncodeArgs	netcoreapp3.1	97.1μs	28.9ns	108ns	0	0	0	32.4 KB
#7131	EncodeArgs	net472	109μs	14.2ns	53.3ns	4.9	0	0	32.51 KB
#7131	EncodeLegacyArgs	net6.0	149μs	64.9ns	251ns	0	0	0	2.15 KB
#7131	EncodeLegacyArgs	netcoreapp3.1	197μs	165ns	616ns	0	0	0	2.14 KB
#7131	EncodeLegacyArgs	net472	264μs	66.9ns	259ns	0	0	0	2.16 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunWafRealisticBenchmark	net6.0	271μs	133ns	499ns	0	0	0	4.55 KB
master	RunWafRealisticBenchmark	netcoreapp3.1	294μs	264ns	989ns	0	0	0	4.48 KB
master	RunWafRealisticBenchmark	net472	307μs	38.1ns	147ns	0	0	0	4.66 KB
master	RunWafRealisticBenchmarkWithAttack	net6.0	181μs	80.1ns	300ns	0	0	0	2.24 KB
master	RunWafRealisticBenchmarkWithAttack	netcoreapp3.1	198μs	104ns	404ns	0	0	0	2.22 KB
master	RunWafRealisticBenchmarkWithAttack	net472	207μs	45.3ns	169ns	0	0	0	2.28 KB
#7131	RunWafRealisticBenchmark	net6.0	272μs	112ns	419ns	0	0	0	4.55 KB
#7131	RunWafRealisticBenchmark	netcoreapp3.1	290μs	87.2ns	326ns	0	0	0	4.48 KB
#7131	RunWafRealisticBenchmark	net472	310μs	37.1ns	144ns	0	0	0	4.66 KB
#7131	RunWafRealisticBenchmarkWithAttack	net6.0	183μs	31.7ns	123ns	0	0	0	2.24 KB
#7131	RunWafRealisticBenchmarkWithAttack	netcoreapp3.1	194μs	46.5ns	168ns	0	0	0	2.22 KB
#7131	RunWafRealisticBenchmarkWithAttack	net472	207μs	45.9ns	178ns	0	0	0	2.28 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net6.0	61.1μs	29ns	104ns	0	0	0	14.53 KB
master	SendRequest	netcoreapp3.1	69.9μs	118ns	440ns	0	0	0	17.42 KB
master	SendRequest	net472	0.0171ns	0.00147ns	0.00551ns	0	0	0	0 b
#7131	SendRequest	net6.0	60.6μs	35.1ns	131ns	0	0	0	14.52 KB
#7131	SendRequest	netcoreapp3.1	71.3μs	92.2ns	332ns	0	0	0	17.42 KB
#7131	SendRequest	net472	0.0126ns	0.0016ns	0.00621ns	0	0	0	0 b

Benchmarks.Trace.CharSliceBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
#7131	OriginalCharSlice	net6.0	1.88ms	6.79μs	26.3μs	0	0	0	640.01 KB
#7131	OriginalCharSlice	netcoreapp3.1	2.15ms	7.19μs	27.9μs	0	0	0	640 KB
#7131	OriginalCharSlice	net472	2.62ms	179ns	671ns	100	0	0	641.95 KB
#7131	OptimizedCharSlice	net6.0	1.44ms	436ns	1.69μs	0	0	0	7 B
#7131	OptimizedCharSlice	netcoreapp3.1	1.78ms	266ns	1.03μs	0	0	0	1 B
#7131	OptimizedCharSlice	net472	1.95ms	488ns	1.89μs	0	0	0	73 B
#7131	OptimizedCharSliceWithPool	net6.0	906μs	75.3ns	282ns	0	0	0	5 B
#7131	OptimizedCharSliceWithPool	netcoreapp3.1	841μs	55.9ns	209ns	0	0	0	1 B
#7131	OptimizedCharSliceWithPool	net472	1.14ms	105ns	408ns	0	0	0	48 B

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.73 KB	42.01 KB	281 B	0.67%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	645μs	512ns	1.98μs	0	0	0	41.73 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	631μs	1.67μs	6.67μs	0	0	0	41.89 KB
master	WriteAndFlushEnrichedTraces	net472	923μs	1.93μs	7.2μs	4.46	0	0	55.75 KB
#7131	WriteAndFlushEnrichedTraces	net6.0	708μs	4.03μs	29.6μs	0	0	0	42.01 KB
#7131	WriteAndFlushEnrichedTraces	netcoreapp3.1	632μs	3.65μs	31.8μs	0	0	0	42.02 KB
#7131	WriteAndFlushEnrichedTraces	net472	966μs	4.65μs	18μs	4.46	0	0	55.87 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.03 KB	1.02 KB	-8 B	-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1	1.02 KB	1.02 KB	-8 B	-0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472	995 B	987 B	-8 B	-0.80%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net6.0	1.99μs	10.2ns	46.8ns	0	0	0	1.03 KB
master	ExecuteNonQuery	netcoreapp3.1	2.53μs	3.43ns	13.3ns	0	0	0	1.02 KB
master	ExecuteNonQuery	net472	2.7μs	2.41ns	9.34ns	0.147	0.0134	0	995 B
#7131	ExecuteNonQuery	net6.0	2μs	1.49ns	5.56ns	0	0	0	1.02 KB
#7131	ExecuteNonQuery	netcoreapp3.1	2.52μs	6.22ns	24.1ns	0	0	0	1.02 KB
#7131	ExecuteNonQuery	net472	2.79μs	5.28ns	20.4ns	0.149	0.0136	0	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472	1.11 KB	1.1 KB	-8 B	-0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1	1.09 KB	1.08 KB	-8 B	-0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472	1.05 KB	1.04 KB	-8 B	-0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.04 KB	1.03 KB	-8 B	-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1	1.04 KB	1.03 KB	-8 B	-0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.02 KB	1.01 KB	-8 B	-0.79%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net6.0	1.83μs	5.85ns	22.7ns	0	0	0	1.04 KB
master	CallElasticsearch	netcoreapp3.1	2.3μs	11.8ns	56.6ns	0	0	0	1.04 KB
master	CallElasticsearch	net472	3.55μs	3.05ns	11.8ns	0.159	0	0	1.05 KB
master	CallElasticsearchAsync	net6.0	1.81μs	3.89ns	14.5ns	0	0	0	1.02 KB
master	CallElasticsearchAsync	netcoreapp3.1	2.35μs	7.26ns	28.1ns	0	0	0	1.09 KB
master	CallElasticsearchAsync	net472	3.84μs	3.19ns	12.4ns	0.169	0	0	1.11 KB
#7131	CallElasticsearch	net6.0	1.78μs	6.65ns	25.7ns	0	0	0	1.03 KB
#7131	CallElasticsearch	netcoreapp3.1	2.42μs	8.44ns	31.6ns	0	0	0	1.03 KB
#7131	CallElasticsearch	net472	3.59μs	0.969ns	3.49ns	0.162	0	0	1.04 KB
#7131	CallElasticsearchAsync	net6.0	1.79μs	7.67ns	29.7ns	0	0	0	1.01 KB
#7131	CallElasticsearchAsync	netcoreapp3.1	2.57μs	6.38ns	24.7ns	0	0	0	1.08 KB
#7131	CallElasticsearchAsync	net472	3.91μs	4.38ns	16.9ns	0.156	0	0	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	960 B	952 B	-8 B	-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1	960 B	952 B	-8 B	-0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472	923 B	915 B	-8 B	-0.87%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net6.0	1.78μs	9.27ns	43.5ns	0	0	0	960 B
master	ExecuteAsync	netcoreapp3.1	2.29μs	7.45ns	25.8ns	0	0	0	960 B
master	ExecuteAsync	net472	2.58μs	1.78ns	6.88ns	0.143	0	0	923 B
#7131	ExecuteAsync	net6.0	1.9μs	1.79ns	6.45ns	0	0	0	952 B
#7131	ExecuteAsync	netcoreapp3.1	2.31μs	7.15ns	26.8ns	0	0	0	952 B
#7131	ExecuteAsync	net472	2.56μs	3.49ns	13.5ns	0.141	0	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net6.0	7.1μs	10.4ns	39ns	0	0	0	2.37 KB
master	SendAsync	netcoreapp3.1	8.69μs	14.1ns	54.6ns	0	0	0	2.9 KB
master	SendAsync	net472	12.5μs	10.3ns	38.5ns	0.498	0	0	3.19 KB
#7131	SendAsync	net6.0	7μs	21.7ns	84.1ns	0	0	0	2.36 KB
#7131	SendAsync	netcoreapp3.1	8.63μs	29.8ns	115ns	0	0	0	2.9 KB
#7131	SendAsync	net472	12.3μs	6.63ns	25.7ns	0.49	0	0	3.18 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7131

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	1.250	413,700.00	517,100.00

More allocations :warning: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	57.34 KB	65.54 KB	8.19 KB	14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	259.96 KB	276.63 KB	16.67 KB	6.41%

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0	43.83 KB	43.22 KB	-616 B	-1.41%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472	286.72 KB	278.53 KB	-8.19 KB	-2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	274.93 KB	257.08 KB	-17.85 KB	-6.49%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StringConcatBenchmark	net6.0	44.6μs	212ns	1.6μs	0	0	0	43.83 KB
master	StringConcatBenchmark	netcoreapp3.1	47.2μs	224ns	838ns	0	0	0	42.64 KB
master	StringConcatBenchmark	net472	56.8μs	259ns	968ns	0	0	0	57.34 KB
master	StringConcatAspectBenchmark	net6.0	458μs	1.08μs	3.89μs	0	0	0	259.96 KB
master	StringConcatAspectBenchmark	netcoreapp3.1	447μs	6.44μs	63.7μs	0	0	0	274.93 KB
master	StringConcatAspectBenchmark	net472	410μs	2.07μs	9.27μs	0	0	0	286.72 KB
#7131	StringConcatBenchmark	net6.0	48.8μs	276ns	1.83μs	0	0	0	43.22 KB
#7131	StringConcatBenchmark	netcoreapp3.1	48.7μs	270ns	1.57μs	0	0	0	42.64 KB
#7131	StringConcatBenchmark	net472	57.2μs	240ns	899ns	0	0	0	65.54 KB
#7131	StringConcatAspectBenchmark	net6.0	484μs	1.96μs	7.07μs	0	0	0	276.63 KB
#7131	StringConcatAspectBenchmark	netcoreapp3.1	515μs	1.24μs	4.45μs	0	0	0	257.08 KB
#7131	StringConcatAspectBenchmark	net472	402μs	2.15μs	11.8μs	0	0	0	278.53 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.76 KB	1.7 KB	-56 B	-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1	1.76 KB	1.7 KB	-56 B	-3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472	1.69 KB	1.64 KB	-56 B	-3.31%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	2.63μs	2.6ns	10.1ns	0	0	0	1.76 KB
master	EnrichedLog	netcoreapp3.1	3.44μs	4.38ns	17ns	0	0	0	1.76 KB
master	EnrichedLog	net472	4.05μs	4.83ns	18.7ns	0.265	0	0	1.69 KB
#7131	EnrichedLog	net6.0	2.63μs	2.34ns	8.74ns	0	0	0	1.7 KB
#7131	EnrichedLog	netcoreapp3.1	3.49μs	12.4ns	48.2ns	0	0	0	1.7 KB
#7131	EnrichedLog	net472	3.98μs	1.8ns	6.72ns	0.258	0	0	1.64 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0	4.37 KB	4.31 KB	-56 B	-1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1	4.37 KB	4.31 KB	-56 B	-1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472	4.57 KB	4.51 KB	-60 B	-1.31%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	123μs	145ns	563ns	0	0	0	4.37 KB
master	EnrichedLog	netcoreapp3.1	126μs	330ns	1.24μs	0	0	0	4.37 KB
master	EnrichedLog	net472	167μs	161ns	603ns	0	0	0	4.57 KB
#7131	EnrichedLog	net6.0	121μs	83.1ns	322ns	0	0	0	4.31 KB
#7131	EnrichedLog	netcoreapp3.1	126μs	157ns	589ns	0	0	0	4.31 KB
#7131	EnrichedLog	net472	165μs	44.5ns	160ns	0	0	0	4.51 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0	2.32 KB	2.26 KB	-56 B	-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1	2.32 KB	2.26 KB	-56 B	-2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472	2.14 KB	2.08 KB	-56 B	-2.62%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	4.94μs	19.3ns	74.6ns	0	0	0	2.32 KB
master	EnrichedLog	netcoreapp3.1	6.77μs	22.2ns	79.9ns	0	0	0	2.32 KB
master	EnrichedLog	net472	7.45μs	8.04ns	31.1ns	0.335	0	0	2.14 KB
#7131	EnrichedLog	net6.0	4.99μs	19.6ns	76ns	0	0	0	2.26 KB
#7131	EnrichedLog	netcoreapp3.1	6.82μs	6.13ns	23.8ns	0	0	0	2.26 KB
#7131	EnrichedLog	net472	7.57μs	8.7ns	32.5ns	0.303	0	0	2.08 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472	1.21 KB	1.2 KB	-8 B	-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0	1.21 KB	1.2 KB	-8 B	-0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1	1.21 KB	1.2 KB	-8 B	-0.66%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net6.0	2.04μs	10.5ns	49.4ns	0	0	0	1.21 KB
master	SendReceive	netcoreapp3.1	2.53μs	11.8ns	47.4ns	0	0	0	1.21 KB
master	SendReceive	net472	3.28μs	2.71ns	10.5ns	0.178	0	0	1.21 KB
#7131	SendReceive	net6.0	1.97μs	0.666ns	2.4ns	0	0	0	1.2 KB
#7131	SendReceive	netcoreapp3.1	2.61μs	8.65ns	33.5ns	0	0	0	1.2 KB
#7131	SendReceive	net472	3.08μs	4.45ns	17.2ns	0.185	0	0	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472	2.08 KB	2.03 KB	-56 B	-2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1	1.69 KB	1.63 KB	-56 B	-3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0	1.64 KB	1.58 KB	-56 B	-3.41%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	4.18μs	0.92ns	3.44ns	0	0	0	1.64 KB
master	EnrichedLog	netcoreapp3.1	5.64μs	23ns	89.3ns	0	0	0	1.69 KB
master	EnrichedLog	net472	6.67μs	7.28ns	27.3ns	0.298	0	0	2.08 KB
#7131	EnrichedLog	net6.0	4.25μs	8.74ns	33.9ns	0	0	0	1.58 KB
#7131	EnrichedLog	netcoreapp3.1	5.68μs	3.32ns	12.4ns	0	0	0	1.63 KB
#7131	EnrichedLog	net472	6.54μs	7.66ns	28.7ns	0.29	0	0	2.03 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	666 B	658 B	-8 B	-1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	586 B	578 B	-8 B	-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	584 B	576 B	-8 B	-1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	584 B	576 B	-8 B	-1.37%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net6.0	751ns	3.97ns	22.4ns	0	0	0	584 B
master	StartFinishSpan	netcoreapp3.1	953ns	4.42ns	17.7ns	0	0	0	584 B
master	StartFinishSpan	net472	914ns	0.809ns	3.13ns	0.0912	0	0	586 B
master	StartFinishScope	net6.0	918ns	0.479ns	1.73ns	0	0	0	704 B
master	StartFinishScope	netcoreapp3.1	1.15μs	6.24ns	34.2ns	0	0	0	704 B
master	StartFinishScope	net472	1.09μs	0.174ns	0.652ns	0.104	0	0	666 B
#7131	StartFinishSpan	net6.0	763ns	0.241ns	0.901ns	0	0	0	576 B
#7131	StartFinishSpan	netcoreapp3.1	972ns	4.6ns	17.8ns	0	0	0	576 B
#7131	StartFinishSpan	net472	956ns	0.134ns	0.5ns	0.0912	0	0	578 B
#7131	StartFinishScope	net6.0	919ns	0.224ns	0.837ns	0	0	0	696 B
#7131	StartFinishScope	netcoreapp3.1	1.16μs	6.03ns	28.9ns	0	0	0	696 B
#7131	StartFinishScope	net472	1.1μs	0.539ns	2.09ns	0.0993	0	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7131

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	704 B	696 B	-8 B	-1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	666 B	658 B	-8 B	-1.20%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net6.0	1.02μs	5.36ns	26.8ns	0	0	0	704 B
master	RunOnMethodBegin	netcoreapp3.1	1.38μs	2.28ns	8.82ns	0	0	0	704 B
master	RunOnMethodBegin	net472	1.36μs	0.141ns	0.544ns	0.102	0	0	666 B
#7131	RunOnMethodBegin	net6.0	1.03μs	5.08ns	21.6ns	0	0	0	696 B
#7131	RunOnMethodBegin	netcoreapp3.1	1.44μs	5.23ns	20.3ns	0	0	0	696 B
#7131	RunOnMethodBegin	net472	1.39μs	0.859ns	3.21ns	0.0979	0	0	658 B

[dd-trace-dotnet-ci-bot[bot]]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

• This PR (7131)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (75ms)  : 73, 77
     .   : milestone, 75,
    master - mean (75ms)  : 73, 76
     .   : milestone, 75,

    section Baseline
    This PR (7131) - mean (71ms)  : 68, 74
     .   : milestone, 71,
    master - mean (71ms)  : 68, 73
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (1,037ms)  : 1006, 1067
     .   : milestone, 1037,
    master - mean (1,034ms)  : 1009, 1060
     .   : milestone, 1034,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section Baseline
    This PR (7131) - mean (108ms)  : 104, 111
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (717ms)  : 701, 732
     .   : milestone, 717,
    master - mean (723ms)  : 701, 744
     .   : milestone, 723,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (96ms)  : 94, 98
     .   : milestone, 96,
    master - mean (96ms)  : 94, 97
     .   : milestone, 96,

    section Baseline
    This PR (7131) - mean (95ms)  : 92, 97
     .   : milestone, 95,
    master - mean (95ms)  : 92, 97
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (678ms)  : 661, 696
     .   : milestone, 678,
    master - mean (679ms)  : 658, 700
     .   : milestone, 679,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (189ms)  : 181, 196
     .   : milestone, 189,
    master - mean (187ms)  : 180, 193
     .   : milestone, 187,

    section Baseline
    This PR (7131) - mean (186ms)  : 179, 192
     .   : milestone, 186,
    master - mean (183ms)  : 175, 191
     .   : milestone, 183,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (1,090ms)  : 1062, 1118
     .   : milestone, 1090,
    master - mean (1,093ms)  : 1059, 1127
     .   : milestone, 1093,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (266ms)  : 257, 274
     .   : milestone, 266,
    master - mean (264ms)  : 256, 272
     .   : milestone, 264,

    section Baseline
    This PR (7131) - mean (262ms)  : 255, 270
     .   : milestone, 262,
    master - mean (260ms)  : 250, 271
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (883ms)  : 847, 919
     .   : milestone, 883,
    master - mean (869ms)  : 837, 901
     .   : milestone, 869,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (263ms)  : 259, 268
     .   : milestone, 263,
    master - mean (254ms)  : 246, 262
     .   : milestone, 254,

    section Baseline
    This PR (7131) - mean (262ms)  : 258, 267
     .   : milestone, 262,
    master - mean (256ms)  : 247, 265
     .   : milestone, 256,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (864ms)  : 822, 907
     .   : milestone, 864,
    master - mean (864ms)  : 830, 899
     .   : milestone, 864,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7131) - mean (260ms)  : 253, 268
     .   : milestone, 260,
    master - mean (255ms)  : 246, 263
     .   : milestone, 255,

    section Baseline
    This PR (7131) - mean (256ms)  : 247, 265
     .   : milestone, 256,
    master - mean (255ms)  : 245, 265
     .   : milestone, 255,

    section CallTarget+Inlining+NGEN
    This PR (7131) - mean (788ms)  : 762, 814
     .   : milestone, 788,
    master - mean (776ms)  : 756, 796
     .   : milestone, 776,

[snakefoot]

@bouwkast the dots in the injected JSON have changed, which seems strange.

This could be caused by the breaking change NLog v6 - JsonLayout SuppressSpaces default true.

But normal message-formatting should continue to emit spaces:

logger.Info("{@user}", new { Name = "Bob", UserId = 42 });