dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

[AAP] ASM Enabled telemetry metric

Open daniel-romano-DD opened this issue 5 months ago • 3 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

daniel-romano-DD avatar Jun 10 '25 18:06 daniel-romano-DD

Datadog Report

All test runs 4208b82 :link:

:white_check_mark: 2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 0 0 0 260893 2529 18h 26m 46.18s Link
exploration_tests 0 0 0 22085 3 2m 12.78s Link

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (68ms)  : 64, 72
     .   : milestone, 68,
    master - mean (69ms)  : 62, 76
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (1,024ms)  : 957, 1091
     .   : milestone, 1024,
    master - mean (1,004ms)  : 981, 1026
     .   : milestone, 1004,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (103ms)  : 97, 109
     .   : milestone, 103,
    master - mean (101ms)  : 100, 103
     .   : milestone, 101,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (721ms)  : 587, 856
     .   : milestone, 721,
    master - mean (691ms)  : 674, 709
     .   : milestone, 691,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 87, 90
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (656ms)  : 633, 679
     .   : milestone, 656,
    master - mean (654ms)  : 635, 673
     .   : milestone, 654,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (188ms)  : 184, 192
     .   : milestone, 188,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (1,103ms)  : 1075, 1131
     .   : milestone, 1103,
    master - mean (1,114ms)  : 1077, 1151
     .   : milestone, 1114,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (267ms)  : 263, 270
     .   : milestone, 267,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (874ms)  : 847, 901
     .   : milestone, 874,
    master - mean (879ms)  : 852, 906
     .   : milestone, 879,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7089) - mean (261ms)  : 256, 266
     .   : milestone, 261,
    master - mean (260ms)  : 256, 263
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (7089) - mean (867ms)  : 834, 900
     .   : milestone, 867,
    master - mean (876ms)  : 846, 905
     .   : milestone, 876,

andrewlock avatar Jun 10 '25 18:06 andrewlock

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7089 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.168
  • 43 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.75 KB 5.7 KB -57 B -0.99%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.58 KB 5.49 KB -86 B -1.54%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.09 KB 5.97 KB -115 B -1.89%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.2μs 59.7ns 322ns 0 0 0 5.58 KB
master StartStopWithChild netcoreapp3.1 14.1μs 67.5ns 286ns 0 0 0 5.75 KB
master StartStopWithChild net472 22.1μs 119ns 651ns 1.03 0.411 0.103 6.09 KB
#7089 StartStopWithChild net6.0 11μs 60.1ns 340ns 0 0 0 5.49 KB
#7089 StartStopWithChild netcoreapp3.1 13.8μs 56.3ns 211ns 0 0 0 5.7 KB
#7089 StartStopWithChild net472 22.8μs 127ns 791ns 1.05 0.419 0.105 5.97 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.33 KB 3.31 KB -23 B -0.69%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 927μs 26.6ns 103ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 404ns 1.56μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 357ns 1.38μs 0 0 0 3.33 KB
#7089 WriteAndFlushEnrichedTraces net6.0 922μs 63ns 236ns 0 0 0 2.71 KB
#7089 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 115ns 430ns 0 0 0 2.7 KB
#7089 WriteAndFlushEnrichedTraces net472 1.23ms 877ns 3.4μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 236.35 KB 239.62 KB 3.27 KB 1.38%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 239.87 KB 243.13 KB 3.27 KB 1.36%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 331μs 1.76μs 8.42μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 510μs 1.45μs 5.61μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 436μs 119ns 460ns 36.6 2.16 0 236.35 KB
master AllCycleMoreComplexBody net6.0 338μs 1.76μs 8.8μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 495μs 987ns 3.56μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 446μs 106ns 412ns 36.6 2.16 0 239.87 KB
master ObjectExtractorSimpleBody net6.0 311ns 1.77ns 12.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 409ns 1.93ns 8.2ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 303ns 0.175ns 0.676ns 0.0442 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.52μs 29.5ns 110ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 36.2ns 140ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.66μs 0.89ns 3.33ns 0.599 0 0 3.8 KB
#7089 AllCycleSimpleBody net6.0 334μs 1.18μs 4.56μs 0 0 0 197.58 KB
#7089 AllCycleSimpleBody netcoreapp3.1 502μs 1.72μs 6.64μs 0 0 0 205.34 KB
#7089 AllCycleSimpleBody net472 441μs 107ns 412ns 36.6 2.16 0 239.62 KB
#7089 AllCycleMoreComplexBody net6.0 349μs 578ns 2.24μs 0 0 0 201.08 KB
#7089 AllCycleMoreComplexBody netcoreapp3.1 491μs 1.14μs 3.95μs 0 0 0 208.75 KB
#7089 AllCycleMoreComplexBody net472 451μs 129ns 498ns 37.9 2.23 0 243.13 KB
#7089 ObjectExtractorSimpleBody net6.0 316ns 1.77ns 10.2ns 0 0 0 280 B
#7089 ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.22ns 15ns 0 0 0 272 B
#7089 ObjectExtractorSimpleBody net472 303ns 0.0433ns 0.168ns 0.0432 0 0 281 B
#7089 ObjectExtractorMoreComplexBody net6.0 6.39μs 27.3ns 106ns 0 0 0 3.78 KB
#7089 ObjectExtractorMoreComplexBody netcoreapp3.1 7.8μs 30.5ns 118ns 0 0 0 3.69 KB
#7089 ObjectExtractorMoreComplexBody net472 6.86μs 2.41ns 9.01ns 0.583 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net6.0 2.16 KB 2.15 KB -11 B -0.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.3μs 263ns 984ns 0 0 0 32.41 KB
master EncodeArgs netcoreapp3.1 95.7μs 36.2ns 130ns 0 0 0 32.4 KB
master EncodeArgs net472 107μs 17.6ns 65.8ns 4.82 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 122ns 472ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 42.5ns 147ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 66.8ns 250ns 0 0 0 2.16 KB
#7089 EncodeArgs net6.0 73.8μs 73.7ns 266ns 0 0 0 32.4 KB
#7089 EncodeArgs netcoreapp3.1 97.3μs 82.1ns 318ns 0 0 0 32.4 KB
#7089 EncodeArgs net472 105μs 20.6ns 80ns 4.73 0 0 32.51 KB
#7089 EncodeLegacyArgs net6.0 144μs 94.4ns 365ns 0 0 0 2.15 KB
#7089 EncodeLegacyArgs netcoreapp3.1 197μs 184ns 714ns 0 0 0 2.14 KB
#7089 EncodeLegacyArgs net472 263μs 38.2ns 148ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 271μs 133ns 499ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 294μs 264ns 989ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 307μs 38.1ns 147ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 181μs 80.1ns 300ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 198μs 104ns 404ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 207μs 45.3ns 169ns 0 0 0 2.28 KB
#7089 RunWafRealisticBenchmark net6.0 270μs 109ns 409ns 0 0 0 4.55 KB
#7089 RunWafRealisticBenchmark netcoreapp3.1 292μs 131ns 453ns 0 0 0 4.48 KB
#7089 RunWafRealisticBenchmark net472 308μs 46.6ns 180ns 0 0 0 4.66 KB
#7089 RunWafRealisticBenchmarkWithAttack net6.0 181μs 103ns 399ns 0 0 0 2.24 KB
#7089 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 193μs 53.3ns 199ns 0 0 0 2.22 KB
#7089 RunWafRealisticBenchmarkWithAttack net472 207μs 38.1ns 148ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 29ns 104ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 69.9μs 118ns 440ns 0 0 0 17.42 KB
master SendRequest net472 0.0171ns 0.00147ns 0.00551ns 0 0 0 0 b
#7089 SendRequest net6.0 61.5μs 100ns 374ns 0 0 0 14.52 KB
#7089 SendRequest netcoreapp3.1 72μs 122ns 458ns 0 0 0 17.42 KB
#7089 SendRequest net472 0.0155ns 0.00153ns 0.00593ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 55.75 KB 56.18 KB 431 B 0.77%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 645μs 512ns 1.98μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 1.67μs 6.67μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 923μs 1.93μs 7.2μs 4.46 0 0 55.75 KB
#7089 WriteAndFlushEnrichedTraces net6.0 709μs 423ns 1.64μs 0 0 0 41.76 KB
#7089 WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 3.85μs 31.1μs 0 0 0 41.93 KB
#7089 WriteAndFlushEnrichedTraces net472 906μs 2.43μs 9.08μs 8.33 0 0 56.18 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.03 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑netcoreapp3.1 1.02 KB 1.02 KB -8 B -0.78%
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 995 B 987 B -8 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.99μs 10.2ns 46.8ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.53μs 3.43ns 13.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.7μs 2.41ns 9.34ns 0.147 0.0134 0 995 B
#7089 ExecuteNonQuery net6.0 1.93μs 1.91ns 6.88ns 0 0 0 1.02 KB
#7089 ExecuteNonQuery netcoreapp3.1 2.53μs 12ns 46.3ns 0 0 0 1.02 KB
#7089 ExecuteNonQuery net472 2.81μs 2.85ns 10.7ns 0.155 0.0141 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net472 1.11 KB 1.1 KB -8 B -0.72%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.09 KB 1.08 KB -8 B -0.74%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net472 1.05 KB 1.04 KB -8 B -0.76%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.04 KB 1.03 KB -8 B -0.77%
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.02 KB 1.01 KB -8 B -0.79%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.83μs 5.85ns 22.7ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.3μs 11.8ns 56.6ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.55μs 3.05ns 11.8ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.81μs 3.89ns 14.5ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.35μs 7.26ns 28.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.84μs 3.19ns 12.4ns 0.169 0 0 1.11 KB
#7089 CallElasticsearch net6.0 1.89μs 1.91ns 7.4ns 0 0 0 1.03 KB
#7089 CallElasticsearch netcoreapp3.1 2.35μs 11.1ns 43.1ns 0 0 0 1.03 KB
#7089 CallElasticsearch net472 3.64μs 8.4ns 32.5ns 0.163 0 0 1.04 KB
#7089 CallElasticsearchAsync net6.0 1.81μs 6.88ns 26.6ns 0 0 0 1.01 KB
#7089 CallElasticsearchAsync netcoreapp3.1 2.37μs 8.26ns 32ns 0 0 0 1.08 KB
#7089 CallElasticsearchAsync net472 3.79μs 6.24ns 24.2ns 0.169 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑netcoreapp3.1 960 B 952 B -8 B -0.83%
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 923 B 915 B -8 B -0.87%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.78μs 9.27ns 43.5ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.29μs 7.45ns 25.8ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 1.78ns 6.88ns 0.143 0 0 923 B
#7089 ExecuteAsync net6.0 1.78μs 8.04ns 29ns 0 0 0 952 B
#7089 ExecuteAsync netcoreapp3.1 2.37μs 5.74ns 22.2ns 0 0 0 952 B
#7089 ExecuteAsync net472 2.46μs 2.6ns 10.1ns 0.135 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.1μs 10.4ns 39ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.69μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 10.3ns 38.5ns 0.498 0 0 3.19 KB
#7089 SendAsync net6.0 6.95μs 7.84ns 29.3ns 0 0 0 2.36 KB
#7089 SendAsync netcoreapp3.1 8.74μs 7.83ns 30.3ns 0 0 0 2.9 KB
#7089 SendAsync net472 12.3μs 9.38ns 36.3ns 0.496 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #7089

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 1.206 413,700.00 499,100.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.130 458,300.00 517,800.00

More allocations :warning: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.96 KB 275.69 KB 15.73 KB 6.05%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.64 KB 42.94 KB 296 B 0.69%

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 286.72 KB 278.53 KB -8.19 KB -2.86%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 274.93 KB 256.71 KB -18.22 KB -6.63%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.6μs 212ns 1.6μs 0 0 0 43.83 KB
master StringConcatBenchmark netcoreapp3.1 47.2μs 224ns 838ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 56.8μs 259ns 968ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 458μs 1.08μs 3.89μs 0 0 0 259.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 447μs 6.44μs 63.7μs 0 0 0 274.93 KB
master StringConcatAspectBenchmark net472 410μs 2.07μs 9.27μs 0 0 0 286.72 KB
#7089 StringConcatBenchmark net6.0 49.2μs 276ns 1.81μs 0 0 0 43.78 KB
#7089 StringConcatBenchmark netcoreapp3.1 49.6μs 271ns 2.23μs 0 0 0 42.94 KB
#7089 StringConcatBenchmark net472 57.8μs 221ns 884ns 0 0 0 57.34 KB
#7089 StringConcatAspectBenchmark net6.0 518μs 1.48μs 5.93μs 0 0 0 275.69 KB
#7089 StringConcatAspectBenchmark netcoreapp3.1 500μs 1.73μs 6.68μs 0 0 0 256.71 KB
#7089 StringConcatAspectBenchmark net472 411μs 1.9μs 7.36μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.76 KB 1.7 KB -56 B -3.18%
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net472 1.69 KB 1.64 KB -56 B -3.31%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 2.6ns 10.1ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 4.38ns 17ns 0 0 0 1.76 KB
master EnrichedLog net472 4.05μs 4.83ns 18.7ns 0.265 0 0 1.69 KB
#7089 EnrichedLog net6.0 2.58μs 2.72ns 10.5ns 0 0 0 1.7 KB
#7089 EnrichedLog netcoreapp3.1 3.53μs 2.45ns 9.17ns 0 0 0 1.7 KB
#7089 EnrichedLog net472 4.02μs 3.53ns 13.2ns 0.242 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net472 4.57 KB 4.52 KB -55 B -1.20%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑netcoreapp3.1 4.37 KB 4.31 KB -56 B -1.28%
Benchmarks.Trace.Log4netBenchmark.EnrichedLog‑net6.0 4.37 KB 4.31 KB -58 B -1.33%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 145ns 563ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 330ns 1.24μs 0 0 0 4.37 KB
master EnrichedLog net472 167μs 161ns 603ns 0 0 0 4.57 KB
#7089 EnrichedLog net6.0 124μs 65.9ns 247ns 0 0 0 4.31 KB
#7089 EnrichedLog netcoreapp3.1 129μs 256ns 958ns 0 0 0 4.31 KB
#7089 EnrichedLog net472 167μs 85.3ns 296ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net6.0 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑netcoreapp3.1 2.32 KB 2.26 KB -56 B -2.41%
Benchmarks.Trace.NLogBenchmark.EnrichedLog‑net472 2.14 KB 2.08 KB -56 B -2.62%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 19.3ns 74.6ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.77μs 22.2ns 79.9ns 0 0 0 2.32 KB
master EnrichedLog net472 7.45μs 8.04ns 31.1ns 0.335 0 0 2.14 KB
#7089 EnrichedLog net6.0 4.92μs 4.61ns 17.3ns 0 0 0 2.26 KB
#7089 EnrichedLog netcoreapp3.1 6.69μs 18ns 67.4ns 0 0 0 2.26 KB
#7089 EnrichedLog net472 7.48μs 6.74ns 26.1ns 0.299 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑net6.0 1.21 KB 1.2 KB -8 B -0.66%
Benchmarks.Trace.RedisBenchmark.SendReceive‑netcoreapp3.1 1.21 KB 1.2 KB -8 B -0.66%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 10.5ns 49.4ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.53μs 11.8ns 47.4ns 0 0 0 1.21 KB
master SendReceive net472 3.28μs 2.71ns 10.5ns 0.178 0 0 1.21 KB
#7089 SendReceive net6.0 1.96μs 9.42ns 42.1ns 0 0 0 1.2 KB
#7089 SendReceive netcoreapp3.1 2.67μs 11.4ns 44.1ns 0 0 0 1.2 KB
#7089 SendReceive net472 3.18μs 3.85ns 14.9ns 0.19 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net472 2.08 KB 2.03 KB -56 B -2.69%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑netcoreapp3.1 1.69 KB 1.63 KB -56 B -3.32%
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.64 KB 1.58 KB -56 B -3.41%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.18μs 0.92ns 3.44ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.64μs 23ns 89.3ns 0 0 0 1.69 KB
master EnrichedLog net472 6.67μs 7.28ns 27.3ns 0.298 0 0 2.08 KB
#7089 EnrichedLog net6.0 4.3μs 8.55ns 33.1ns 0 0 0 1.58 KB
#7089 EnrichedLog netcoreapp3.1 5.76μs 10.9ns 41ns 0 0 0 1.63 KB
#7089 EnrichedLog net472 6.68μs 6.06ns 23.5ns 0.299 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 666 B 658 B -8 B -1.20%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 586 B 578 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 584 B 576 B -8 B -1.37%
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 584 B 576 B -8 B -1.37%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 751ns 3.97ns 22.4ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 953ns 4.42ns 17.7ns 0 0 0 584 B
master StartFinishSpan net472 914ns 0.809ns 3.13ns 0.0912 0 0 586 B
master StartFinishScope net6.0 918ns 0.479ns 1.73ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.24ns 34.2ns 0 0 0 704 B
master StartFinishScope net472 1.09μs 0.174ns 0.652ns 0.104 0 0 666 B
#7089 StartFinishSpan net6.0 768ns 1.79ns 6.69ns 0 0 0 576 B
#7089 StartFinishSpan netcoreapp3.1 974ns 2.52ns 9.77ns 0 0 0 576 B
#7089 StartFinishSpan net472 948ns 0.338ns 1.27ns 0.0899 0 0 578 B
#7089 StartFinishScope net6.0 884ns 4.79ns 27.9ns 0 0 0 696 B
#7089 StartFinishScope netcoreapp3.1 1.2μs 5.63ns 23.2ns 0 0 0 696 B
#7089 StartFinishScope net472 1.1μs 0.276ns 1.03ns 0.0992 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7089

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 704 B 696 B -8 B -1.14%
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 666 B 658 B -8 B -1.20%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.36ns 26.8ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 2.28ns 8.82ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.141ns 0.544ns 0.102 0 0 666 B
#7089 RunOnMethodBegin net6.0 1.05μs 5.02ns 21.3ns 0 0 0 696 B
#7089 RunOnMethodBegin netcoreapp3.1 1.4μs 6.57ns 26.3ns 0 0 0 696 B
#7089 RunOnMethodBegin net472 1.41μs 0.784ns 2.93ns 0.0985 0 0 658 B

pr-commenter[bot] avatar Jun 10 '25 18:06 pr-commenter[bot]