dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Kinesis Context Propagation

Open robcarlan-datadog opened this issue 5 months ago • 3 comments
trafficstars

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

robcarlan-datadog avatar Jun 02 '25 21:06 robcarlan-datadog

Datadog Report

All test runs 802fcc1 :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 96 48 0 65846 2549 24h 54m 45.84s Link
exploration_tests 0 0 0 22085 3 2m 13.38s Link

:x: Failed Tests (96)

This report shows up to 5 failed tests.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Details

    Expand for error
    xpected kinesisSpans not to be empty.
    
  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Details

    Expand for error
    xpected kinesisSpans not to be empty.
    
  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Details

    Expand for error
    xpected kinesisSpans not to be empty.
    
  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Details

    Expand for error
    xpected kinesisSpans not to be empty.
    
  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsKinesisTests - Details

    Expand for error
    xpected kinesisSpans not to be empty.
    

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 64, 72
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (1,008ms)  : 983, 1034
     .   : milestone, 1008,
    master - mean (1,005ms)  : 977, 1033
     .   : milestone, 1005,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (103ms)  : 101, 104
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (693ms)  : 670, 716
     .   : milestone, 693,
    master - mean (696ms)  : 681, 710
     .   : milestone, 696,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 86, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (650ms)  : 631, 668
     .   : milestone, 650,
    master - mean (654ms)  : 634, 673
     .   : milestone, 654,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (1,110ms)  : 1080, 1140
     .   : milestone, 1110,
    master - mean (1,114ms)  : 1087, 1140
     .   : milestone, 1114,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (269ms)  : 265, 273
     .   : milestone, 269,
    master - mean (270ms)  : 265, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (881ms)  : 850, 913
     .   : milestone, 881,
    master - mean (884ms)  : 856, 912
     .   : milestone, 884,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (7043) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 259, 265
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (7043) - mean (865ms)  : 832, 897
     .   : milestone, 865,
    master - mean (872ms)  : 845, 899
     .   : milestone, 872,

andrewlock avatar Jun 03 '25 14:06 andrewlock

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #7043 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.155
  • 1 benchmarks are slower, with geometric mean 1.140
  • 7 benchmarks have fewer allocations
  • 5 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.76 KB 5.71 KB -49 B -0.85%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.2μs 56.1ns 355ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.5μs 66.8ns 284ns 0 0 0 5.76 KB
master StartStopWithChild net472 22.1μs 116ns 602ns 0.898 0.224 0 6.15 KB
#7043 StartStopWithChild net6.0 10.9μs 57ns 301ns 0 0 0 5.56 KB
#7043 StartStopWithChild netcoreapp3.1 13.9μs 72.5ns 355ns 0 0 0 5.71 KB
#7043 StartStopWithChild net472 21.7μs 112ns 602ns 0.911 0.228 0 6.13 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.33 KB 23 B 0.70%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 924μs 60.8ns 235ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 109ns 392ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.25ms 401ns 1.55μs 0 0 0 3.31 KB
#7043 WriteAndFlushEnrichedTraces net6.0 935μs 63.1ns 218ns 0 0 0 2.71 KB
#7043 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 90.6ns 314ns 0 0 0 2.7 KB
#7043 WriteAndFlushEnrichedTraces net472 1.25ms 328ns 1.27μs 0 0 0 3.33 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 242.04 KB 239.88 KB -2.16 KB -0.89%
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 238.53 KB 236.35 KB -2.17 KB -0.91%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 333μs 301ns 1.17μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 507μs 2.5μs 10.9μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 442μs 111ns 429ns 36.6 2.16 0 238.53 KB
master AllCycleMoreComplexBody net6.0 338μs 1.67μs 6.87μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 506μs 1.02μs 3.82μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 453μs 97.1ns 350ns 37.9 0 0 242.04 KB
master ObjectExtractorSimpleBody net6.0 319ns 1.8ns 9.17ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 400ns 1.9ns 7.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 316ns 0.273ns 1.06ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.47μs 1.73ns 6.25ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.87μs 20.4ns 78.8ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.71μs 2.31ns 8.93ns 0.571 0 0 3.8 KB
#7043 AllCycleSimpleBody net6.0 332μs 1.69μs 8.47μs 0 0 0 197.06 KB
#7043 AllCycleSimpleBody netcoreapp3.1 486μs 307ns 1.19μs 0 0 0 204.77 KB
#7043 AllCycleSimpleBody net472 437μs 193ns 694ns 36.6 2.16 0 236.35 KB
#7043 AllCycleMoreComplexBody net6.0 333μs 1.77μs 8.86μs 0 0 0 200.56 KB
#7043 AllCycleMoreComplexBody netcoreapp3.1 513μs 326ns 1.22μs 0 0 0 208.18 KB
#7043 AllCycleMoreComplexBody net472 446μs 204ns 788ns 37.9 2.23 0 239.88 KB
#7043 ObjectExtractorSimpleBody net6.0 316ns 1.64ns 7.33ns 0 0 0 280 B
#7043 ObjectExtractorSimpleBody netcoreapp3.1 397ns 2.18ns 13.3ns 0 0 0 272 B
#7043 ObjectExtractorSimpleBody net472 303ns 0.0527ns 0.197ns 0.0444 0 0 281 B
#7043 ObjectExtractorMoreComplexBody net6.0 6.43μs 27.7ns 107ns 0 0 0 3.78 KB
#7043 ObjectExtractorMoreComplexBody netcoreapp3.1 7.77μs 32.7ns 127ns 0 0 0 3.69 KB
#7043 ObjectExtractorMoreComplexBody net472 6.73μs 5.33ns 20.7ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs‑net472 2.16 KB 2.17 KB 13 B 0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 73.7μs 40.5ns 157ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 93.4μs 281ns 1.09μs 0 0 0 32.4 KB
master EncodeArgs net472 105μs 6.72ns 25.1ns 4.73 0 0 32.51 KB
master EncodeLegacyArgs net6.0 146μs 107ns 413ns 0 0 0 2.16 KB
master EncodeLegacyArgs netcoreapp3.1 199μs 313ns 1.17μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 20ns 77.4ns 0 0 0 2.16 KB
#7043 EncodeArgs net6.0 73.3μs 80.4ns 290ns 0 0 0 32.41 KB
#7043 EncodeArgs netcoreapp3.1 94.2μs 281ns 1.09μs 0 0 0 32.4 KB
#7043 EncodeArgs net472 106μs 8.25ns 28.6ns 4.75 0 0 32.51 KB
#7043 EncodeLegacyArgs net6.0 143μs 34.4ns 133ns 0 0 0 2.16 KB
#7043 EncodeLegacyArgs netcoreapp3.1 196μs 39.5ns 148ns 0 0 0 2.15 KB
#7043 EncodeLegacyArgs net472 264μs 70ns 271ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 272μs 79.9ns 288ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 291μs 388ns 1.45μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 308μs 17ns 58.7ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 182μs 69.1ns 268ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 194μs 85.9ns 298ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 206μs 60.1ns 233ns 0 0 0 2.28 KB
#7043 RunWafRealisticBenchmark net6.0 271μs 105ns 408ns 0 0 0 4.55 KB
#7043 RunWafRealisticBenchmark netcoreapp3.1 291μs 382ns 1.48μs 0 0 0 4.48 KB
#7043 RunWafRealisticBenchmark net472 307μs 40.5ns 146ns 0 0 0 4.66 KB
#7043 RunWafRealisticBenchmarkWithAttack net6.0 181μs 69.9ns 262ns 0 0 0 2.24 KB
#7043 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 193μs 65.6ns 245ns 0 0 0 2.22 KB
#7043 RunWafRealisticBenchmarkWithAttack net472 206μs 30ns 116ns 0 0 0 2.28 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 62.4μs 146ns 564ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72.5μs 364ns 1.71μs 0 0 0 17.42 KB
master SendRequest net472 0.0162ns 0.00227ns 0.0088ns 0 0 0 0 b
#7043 SendRequest net6.0 60.3μs 34.7ns 134ns 0 0 0 14.53 KB
#7043 SendRequest netcoreapp3.1 70.5μs 157ns 787ns 0 0 0 17.42 KB
#7043 SendRequest net472 0.00446ns 0.00175ns 0.00676ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower :warning: Fewer allocations :tada:

Slower :warning: in #7043

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.140 673,834.82 767,939.58

Faster :tada: in #7043

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.155 966,533.48 836,945.09

Fewer allocations :tada: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.98 KB 41.62 KB -358 B -0.85%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.47 KB 55.94 KB -527 B -0.93%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 674μs 3.93μs 34.7μs 0 0 0 41.98 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 673μs 1.43μs 5.54μs 0 0 0 41.96 KB
master WriteAndFlushEnrichedTraces net472 969μs 2.93μs 11.4μs 8.93 0 0 56.47 KB
#7043 WriteAndFlushEnrichedTraces net6.0 647μs 2.36μs 9.12μs 0 0 0 41.62 KB
#7043 WriteAndFlushEnrichedTraces netcoreapp3.1 767μs 1.01μs 3.92μs 0 0 0 41.92 KB
#7043 WriteAndFlushEnrichedTraces net472 840μs 2.62μs 10.1μs 4.46 0 0 55.94 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.95μs 2.22ns 8.01ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.57μs 6.29ns 24.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.81μs 3.21ns 12.4ns 0.155 0.0141 0 995 B
#7043 ExecuteNonQuery net6.0 1.99μs 8.32ns 32.2ns 0 0 0 1.03 KB
#7043 ExecuteNonQuery netcoreapp3.1 2.52μs 9.33ns 36.1ns 0 0 0 1.02 KB
#7043 ExecuteNonQuery net472 2.67μs 4.7ns 18.2ns 0.148 0.0135 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.8μs 8.61ns 33.3ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.26μs 6.4ns 24.8ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.52μs 2.35ns 9.1ns 0.158 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.78μs 7.92ns 29.6ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.36μs 12.3ns 61.7ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.73μs 2.01ns 7.52ns 0.169 0 0 1.11 KB
#7043 CallElasticsearch net6.0 1.81μs 9.43ns 45.2ns 0 0 0 1.04 KB
#7043 CallElasticsearch netcoreapp3.1 2.39μs 7.71ns 29.9ns 0 0 0 1.04 KB
#7043 CallElasticsearch net472 3.52μs 1.93ns 7.49ns 0.159 0 0 1.05 KB
#7043 CallElasticsearchAsync net6.0 1.8μs 8.74ns 37.1ns 0 0 0 1.02 KB
#7043 CallElasticsearchAsync netcoreapp3.1 2.4μs 7.79ns 30.2ns 0 0 0 1.09 KB
#7043 CallElasticsearchAsync net472 3.71μs 3.11ns 12.1ns 0.166 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.89μs 2.88ns 10.4ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.35μs 1.43ns 5.54ns 0 0 0 960 B
master ExecuteAsync net472 2.63μs 3.13ns 12.1ns 0.143 0 0 923 B
#7043 ExecuteAsync net6.0 1.74μs 3.91ns 15.1ns 0 0 0 960 B
#7043 ExecuteAsync netcoreapp3.1 2.32μs 10.5ns 40.8ns 0 0 0 960 B
#7043 ExecuteAsync net472 2.54μs 0.746ns 2.79ns 0.139 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.91μs 11ns 42.4ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.62μs 21.2ns 82.2ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 10.1ns 39ns 0.487 0 0 3.19 KB
#7043 SendAsync net6.0 7.16μs 22.5ns 87ns 0 0 0 2.37 KB
#7043 SendAsync netcoreapp3.1 8.49μs 12.3ns 47.6ns 0 0 0 2.9 KB
#7043 SendAsync net472 12.4μs 10ns 38.8ns 0.494 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 248.91 KB 279.29 KB 30.38 KB 12.20%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.72 KB 8.19 KB 2.94%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.49 KB 43.82 KB 328 B 0.75%

Fewer allocations :tada: in #7043

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 45.5 KB 43.64 KB -1.86 KB -4.10%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 65.54 KB 57.34 KB -8.19 KB -12.50%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 41.9μs 225ns 1.15μs 0 0 0 43.49 KB
master StringConcatBenchmark netcoreapp3.1 49.5μs 475ns 4.46μs 0 0 0 45.5 KB
master StringConcatBenchmark net472 57.3μs 293ns 1.28μs 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 490μs 2.13μs 7.96μs 0 0 0 260.15 KB
master StringConcatAspectBenchmark netcoreapp3.1 487μs 1.38μs 4.98μs 0 0 0 248.91 KB
master StringConcatAspectBenchmark net472 410μs 2.18μs 11.9μs 0 0 0 278.53 KB
#7043 StringConcatBenchmark net6.0 43.5μs 195ns 1.31μs 0 0 0 43.82 KB
#7043 StringConcatBenchmark netcoreapp3.1 48.6μs 235ns 995ns 0 0 0 43.64 KB
#7043 StringConcatBenchmark net472 57.3μs 171ns 641ns 0 0 0 57.34 KB
#7043 StringConcatAspectBenchmark net6.0 472μs 1.79μs 6.44μs 0 0 0 259.05 KB
#7043 StringConcatAspectBenchmark netcoreapp3.1 532μs 2.45μs 8.83μs 0 0 0 279.29 KB
#7043 StringConcatAspectBenchmark net472 406μs 1.23μs 4.26μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 1.85ns 6.94ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.46μs 11.4ns 44ns 0 0 0 1.76 KB
master EnrichedLog net472 3.87μs 2.08ns 8.07ns 0.252 0 0 1.69 KB
#7043 EnrichedLog net6.0 2.56μs 13.1ns 62.7ns 0 0 0 1.76 KB
#7043 EnrichedLog netcoreapp3.1 3.51μs 18ns 84.5ns 0 0 0 1.76 KB
#7043 EnrichedLog net472 3.89μs 5.55ns 21.5ns 0.253 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 124μs 43.5ns 163ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 129μs 166ns 644ns 0 0 0 4.37 KB
master EnrichedLog net472 166μs 43.7ns 169ns 0 0 0 4.57 KB
#7043 EnrichedLog net6.0 123μs 58.9ns 212ns 0 0 0 4.37 KB
#7043 EnrichedLog netcoreapp3.1 129μs 293ns 1.13μs 0 0 0 4.37 KB
#7043 EnrichedLog net472 169μs 41.6ns 156ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.93μs 5.22ns 19.5ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.76μs 23.9ns 92.5ns 0 0 0 2.32 KB
master EnrichedLog net472 7.71μs 4.73ns 18.3ns 0.307 0 0 2.14 KB
#7043 EnrichedLog net6.0 5.06μs 5.55ns 21.5ns 0 0 0 2.32 KB
#7043 EnrichedLog netcoreapp3.1 6.56μs 21.9ns 84.8ns 0 0 0 2.32 KB
#7043 EnrichedLog net472 7.43μs 5.9ns 22.8ns 0.331 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2.04μs 9.23ns 35.7ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.56μs 6.34ns 24.5ns 0 0 0 1.21 KB
master SendReceive net472 3.04μs 1.84ns 7.12ns 0.182 0 0 1.21 KB
#7043 SendReceive net6.0 1.96μs 6.89ns 25.8ns 0 0 0 1.21 KB
#7043 SendReceive netcoreapp3.1 2.6μs 9.55ns 37ns 0 0 0 1.21 KB
#7043 SendReceive net472 3.19μs 2.14ns 8ns 0.192 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.22μs 10.2ns 38.2ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.45μs 14ns 54.2ns 0 0 0 1.69 KB
master EnrichedLog net472 6.37μs 6.81ns 26.4ns 0.32 0 0 2.08 KB
#7043 EnrichedLog net6.0 4.17μs 4.2ns 16.3ns 0 0 0 1.64 KB
#7043 EnrichedLog netcoreapp3.1 5.55μs 13.6ns 52.6ns 0 0 0 1.69 KB
#7043 EnrichedLog net472 6.61μs 4.44ns 17.2ns 0.329 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 748ns 4.19ns 28.1ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 980ns 5.3ns 29ns 0 0 0 584 B
master StartFinishSpan net472 904ns 0.42ns 1.63ns 0.0914 0 0 586 B
master StartFinishScope net6.0 925ns 4.97ns 27.2ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.13μs 6.08ns 31.6ns 0 0 0 705 B
master StartFinishScope net472 1.1μs 0.357ns 1.24ns 0.104 0 0 666 B
#7043 StartFinishSpan net6.0 734ns 3.4ns 14ns 0 0 0 584 B
#7043 StartFinishSpan netcoreapp3.1 925ns 5.08ns 29.2ns 0 0 0 584 B
#7043 StartFinishSpan net472 910ns 0.22ns 0.854ns 0.0915 0 0 586 B
#7043 StartFinishScope net6.0 894ns 4.14ns 15.5ns 0 0 0 704 B
#7043 StartFinishScope netcoreapp3.1 1.15μs 5.42ns 21.7ns 0 0 0 704 B
#7043 StartFinishScope net472 1.11μs 1.31ns 5.08ns 0.105 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 994ns 5.44ns 31.7ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.33μs 5.76ns 22.3ns 0 0 0 704 B
master RunOnMethodBegin net472 1.38μs 1.73ns 6.71ns 0.103 0 0 666 B
#7043 RunOnMethodBegin net6.0 1μs 4.83ns 18.7ns 0 0 0 704 B
#7043 RunOnMethodBegin netcoreapp3.1 1.33μs 5.26ns 20.4ns 0 0 0 704 B
#7043 RunOnMethodBegin net472 1.38μs 0.832ns 2.88ns 0.104 0 0 666 B

pr-commenter[bot] avatar Jun 03 '25 21:06 pr-commenter[bot]

Closing as the linked ticket is marked as done

bouwkast avatar Oct 03 '25 22:10 bouwkast