dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

[Profiler] Display some code only when Debug level is set

Open gleocadie opened this issue 6 months ago • 3 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar May 10 '25 13:05 gleocadie

Datadog Report

All test runs f78c5b3 :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 50 0 0 258632 2900 19h 39m 27.61s Link
exploration_tests 0 0 0 22085 3 2m 9.69s Link

:x: Failed Tests (50)

This report shows up to 5 failed tests.

  • IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Details

    Expand for error 
    xpected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Details

    Expand for error 
    xpected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Details

    Expand for error 
    xpected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Details

    Expand for error 
    xpected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.SystemDataSqlClientTests - Details

    Expand for error 
    xpected exit code: 0, actual exit code: 134.

datadog-datadog-prod-us1[bot] avatar May 10 '25 13:05 datadog-datadog-prod-us1[bot]

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #6952 compared to master:

  • All benchmarks have the same speed
  • 1 benchmarks have fewer allocations
  • 4 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.9μs 60ns 355ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.5μs 59.5ns 230ns 0 0 0 5.76 KB
master StartStopWithChild net472 21.5μs 121ns 794ns 0.996 0.332 0.111 6.14 KB
#6952 StartStopWithChild net6.0 10.7μs 57.5ns 315ns 0 0 0 5.54 KB
#6952 StartStopWithChild netcoreapp3.1 13.7μs 53.6ns 201ns 0 0 0 5.77 KB
#6952 StartStopWithChild net472 21.7μs 115ns 596ns 1.05 0.351 0.117 6.16 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #6952

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 3.31 KB 3.35 KB 46 B 1.39%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 934μs 49.8ns 179ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 106ns 382ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.22ms 36.1ns 135ns 0 0 0 3.31 KB
#6952 WriteAndFlushEnrichedTraces net6.0 938μs 76.3ns 286ns 0 0 0 2.71 KB
#6952 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 174ns 675ns 0 0 0 2.7 KB
#6952 WriteAndFlushEnrichedTraces net472 1.23ms 92.5ns 346ns 0 0 0 3.35 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 334μs 1.65μs 6.82μs 0 0 0 196.71 KB
master AllCycleSimpleBody netcoreapp3.1 503μs 2μs 7.73μs 0 0 0 204.37 KB
master AllCycleSimpleBody net472 442μs 166ns 598ns 36.6 2.16 0 235.77 KB
master AllCycleMoreComplexBody net6.0 334μs 299ns 1.16μs 0 0 0 200.21 KB
master AllCycleMoreComplexBody netcoreapp3.1 492μs 1.73μs 6.7μs 0 0 0 207.78 KB
master AllCycleMoreComplexBody net472 449μs 194ns 701ns 37.9 2.23 0 239.29 KB
master ObjectExtractorSimpleBody net6.0 314ns 1.65ns 7.75ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 401ns 2ns 8.25ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 306ns 0.0585ns 0.227ns 0.0439 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.38μs 29.9ns 123ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 30.2ns 117ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.76μs 2.49ns 9.65ns 0.575 0 0 3.8 KB
#6952 AllCycleSimpleBody net6.0 331μs 1.29μs 4.98μs 0 0 0 196.71 KB
#6952 AllCycleSimpleBody netcoreapp3.1 487μs 613ns 2.37μs 0 0 0 204.37 KB
#6952 AllCycleSimpleBody net472 437μs 258ns 999ns 36.6 2.16 0 235.77 KB
#6952 AllCycleMoreComplexBody net6.0 340μs 505ns 1.95μs 0 0 0 200.21 KB
#6952 AllCycleMoreComplexBody netcoreapp3.1 487μs 1.38μs 5.36μs 0 0 0 207.78 KB
#6952 AllCycleMoreComplexBody net472 445μs 267ns 1μs 37.9 2.23 0 239.27 KB
#6952 ObjectExtractorSimpleBody net6.0 320ns 0.0431ns 0.167ns 0 0 0 280 B
#6952 ObjectExtractorSimpleBody netcoreapp3.1 407ns 0.15ns 0.561ns 0 0 0 272 B
#6952 ObjectExtractorSimpleBody net472 303ns 0.0559ns 0.216ns 0.0442 0 0 281 B
#6952 ObjectExtractorMoreComplexBody net6.0 6.36μs 28.4ns 110ns 0 0 0 3.78 KB
#6952 ObjectExtractorMoreComplexBody netcoreapp3.1 7.73μs 37.2ns 153ns 0 0 0 3.69 KB
#6952 ObjectExtractorMoreComplexBody net472 6.71μs 2.17ns 8.4ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6952 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6952 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 54ns 202ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 70.9μs 87.8ns 316ns 0 0 0 17.42 KB
master SendRequest net472 0.0057ns 0.00114ns 0.0044ns 0 0 0 0 b
#6952 SendRequest net6.0 61.7μs 126ns 489ns 0 0 0 14.53 KB
#6952 SendRequest netcoreapp3.1 71.6μs 46.3ns 173ns 0 0 0 17.42 KB
#6952 SendRequest net472 0.00311ns 0.00155ns 0.00601ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #6952

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.05 KB 41.71 KB -341 B -0.81%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 799μs 1.03μs 3.85μs 0 0 0 42.05 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 716μs 1.59μs 6.17μs 0 0 0 41.92 KB
master WriteAndFlushEnrichedTraces net472 868μs 3.55μs 13.7μs 4.46 0 0 55.8 KB
#6952 WriteAndFlushEnrichedTraces net6.0 720μs 1.6μs 5.76μs 0 0 0 41.71 KB
#6952 WriteAndFlushEnrichedTraces netcoreapp3.1 758μs 3.81μs 18.3μs 0 0 0 42.08 KB
#6952 WriteAndFlushEnrichedTraces net472 883μs 3.11μs 12μs 4.46 0 0 56.01 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.92μs 9.58ns 43.9ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.42μs 8.89ns 34.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.8μs 5.16ns 20ns 0.152 0.0138 0 995 B
#6952 ExecuteNonQuery net6.0 1.94μs 7.53ns 29.2ns 0 0 0 1.03 KB
#6952 ExecuteNonQuery netcoreapp3.1 2.52μs 7.69ns 29.8ns 0 0 0 1.02 KB
#6952 ExecuteNonQuery net472 2.85μs 3.21ns 12.4ns 0.155 0.0141 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 9.17ns 43ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.31μs 11.1ns 43ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.59μs 2.78ns 10.4ns 0.162 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.88μs 6.25ns 24.2ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.37μs 9.76ns 37.8ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.59μs 1.68ns 6.3ns 0.161 0 0 1.11 KB
#6952 CallElasticsearch net6.0 1.77μs 8.32ns 32.2ns 0 0 0 1.04 KB
#6952 CallElasticsearch netcoreapp3.1 2.32μs 11ns 42.6ns 0 0 0 1.04 KB
#6952 CallElasticsearch net472 3.53μs 1.99ns 7.7ns 0.159 0 0 1.05 KB
#6952 CallElasticsearchAsync net6.0 1.86μs 2.27ns 8.8ns 0 0 0 1.02 KB
#6952 CallElasticsearchAsync netcoreapp3.1 2.47μs 8.79ns 34ns 0 0 0 1.09 KB
#6952 CallElasticsearchAsync net472 3.66μs 2.41ns 9.33ns 0.164 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.88μs 3.41ns 13.2ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.3μs 10.1ns 39.2ns 0 0 0 960 B
master ExecuteAsync net472 2.58μs 3.88ns 15ns 0.141 0 0 923 B
#6952 ExecuteAsync net6.0 1.81μs 8.69ns 33.6ns 0 0 0 960 B
#6952 ExecuteAsync netcoreapp3.1 2.32μs 1.97ns 7.12ns 0 0 0 960 B
#6952 ExecuteAsync net472 2.56μs 0.678ns 2.54ns 0.14 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7μs 5.24ns 19.6ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.7μs 13.7ns 53.2ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 7.03ns 27.2ns 0.496 0 0 3.19 KB
#6952 SendAsync net6.0 7.09μs 2.78ns 10ns 0 0 0 2.37 KB
#6952 SendAsync netcoreapp3.1 8.25μs 22.5ns 87.1ns 0 0 0 2.9 KB
#6952 SendAsync net472 12.5μs 11ns 42.4ns 0.497 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #6952

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.94 KB 44.33 KB 1.38 KB 3.22%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 251.46 KB 259.41 KB 7.95 KB 3.16%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 42.8μs 240ns 1.59μs 0 0 0 43.1 KB
master StringConcatBenchmark netcoreapp3.1 49.1μs 271ns 2.21μs 0 0 0 42.94 KB
master StringConcatBenchmark net472 57.4μs 206ns 800ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 471μs 1.84μs 6.65μs 0 0 0 274.46 KB
master StringConcatAspectBenchmark netcoreapp3.1 531μs 2.54μs 10.8μs 0 0 0 251.46 KB
master StringConcatAspectBenchmark net472 408μs 2.33μs 16.6μs 0 0 0 278.53 KB
#6952 StringConcatBenchmark net6.0 42μs 232ns 1.27μs 0 0 0 43.1 KB
#6952 StringConcatBenchmark netcoreapp3.1 50μs 294ns 2.63μs 0 0 0 44.33 KB
#6952 StringConcatBenchmark net472 57.3μs 236ns 881ns 0 0 0 65.54 KB
#6952 StringConcatAspectBenchmark net6.0 487μs 2.39μs 10.7μs 0 0 0 274.66 KB
#6952 StringConcatAspectBenchmark netcoreapp3.1 516μs 1.37μs 4.94μs 0 0 0 259.41 KB
#6952 StringConcatAspectBenchmark net472 412μs 2.14μs 10μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.58μs 2.36ns 8.51ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.44μs 16.8ns 67.3ns 0 0 0 1.76 KB
master EnrichedLog net472 3.96μs 6.02ns 23.3ns 0.256 0 0 1.69 KB
#6952 EnrichedLog net6.0 2.59μs 11.3ns 42.1ns 0 0 0 1.76 KB
#6952 EnrichedLog netcoreapp3.1 3.42μs 16.2ns 64.8ns 0 0 0 1.76 KB
#6952 EnrichedLog net472 4.11μs 3.17ns 12.3ns 0.266 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 193ns 724ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 127μs 181ns 703ns 0 0 0 4.37 KB
master EnrichedLog net472 167μs 111ns 415ns 0 0 0 4.57 KB
#6952 EnrichedLog net6.0 123μs 145ns 501ns 0 0 0 4.37 KB
#6952 EnrichedLog netcoreapp3.1 127μs 95.4ns 344ns 0 0 0 4.37 KB
#6952 EnrichedLog net472 166μs 23.4ns 87.6ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.96μs 18.3ns 70.8ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.61μs 32.3ns 129ns 0 0 0 2.32 KB
master EnrichedLog net472 7.3μs 11.2ns 43.2ns 0.327 0 0 2.14 KB
#6952 EnrichedLog net6.0 5.14μs 1.88ns 7.03ns 0 0 0 2.32 KB
#6952 EnrichedLog netcoreapp3.1 6.85μs 21.2ns 82.1ns 0 0 0 2.32 KB
#6952 EnrichedLog net472 7.31μs 6.46ns 24.2ns 0.326 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.96μs 10.6ns 56.1ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.64μs 11.3ns 43.6ns 0 0 0 1.21 KB
master SendReceive net472 3.18μs 3.19ns 11.9ns 0.19 0 0 1.21 KB
#6952 SendReceive net6.0 1.98μs 9.32ns 38.4ns 0 0 0 1.21 KB
#6952 SendReceive netcoreapp3.1 2.63μs 10.4ns 40.1ns 0 0 0 1.21 KB
#6952 SendReceive net472 3.32μs 2.32ns 8.69ns 0.181 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.14μs 9.04ns 35ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.58μs 24.7ns 95.5ns 0 0 0 1.69 KB
master EnrichedLog net472 6.97μs 10.5ns 39.3ns 0.312 0 0 2.08 KB
#6952 EnrichedLog net6.0 4.28μs 13.3ns 49.7ns 0 0 0 1.64 KB
#6952 EnrichedLog netcoreapp3.1 5.69μs 17.3ns 67ns 0 0 0 1.69 KB
#6952 EnrichedLog net472 6.88μs 4.42ns 16.5ns 0.309 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 734ns 3.73ns 15.8ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 955ns 1.1ns 4.26ns 0 0 0 584 B
master StartFinishSpan net472 916ns 0.606ns 2.27ns 0.0922 0 0 586 B
master StartFinishScope net6.0 902ns 0.293ns 1.09ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.15μs 6.02ns 28.9ns 0 0 0 704 B
master StartFinishScope net472 1.11μs 0.354ns 1.27ns 0.1 0 0 666 B
#6952 StartFinishSpan net6.0 746ns 3.66ns 14.7ns 0 0 0 584 B
#6952 StartFinishSpan netcoreapp3.1 946ns 4.94ns 25.7ns 0 0 0 584 B
#6952 StartFinishSpan net472 940ns 0.247ns 0.956ns 0.0888 0 0 586 B
#6952 StartFinishScope net6.0 913ns 4.41ns 18.7ns 0 0 0 704 B
#6952 StartFinishScope netcoreapp3.1 1.18μs 5.18ns 20.1ns 0 0 0 704 B
#6952 StartFinishScope net472 1.12μs 0.186ns 0.721ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.03μs 0.581ns 2.17ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.38μs 4.09ns 15.9ns 0 0 0 704 B
master RunOnMethodBegin net472 1.37μs 1.14ns 4.42ns 0.104 0 0 666 B
#6952 RunOnMethodBegin net6.0 1.01μs 0.685ns 2.65ns 0 0 0 704 B
#6952 RunOnMethodBegin netcoreapp3.1 1.37μs 6.13ns 21.2ns 0 0 0 704 B
#6952 RunOnMethodBegin net472 1.39μs 1.17ns 4.51ns 0.103 0 0 666 B

pr-commenter[bot] avatar May 10 '25 13:05 pr-commenter[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (69ms)  : 65, 72
     .   : milestone, 69,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (1,004ms)  : 978, 1030
     .   : milestone, 1004,
    master - mean (1,004ms)  : 977, 1032
     .   : milestone, 1004,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (103ms)  : 101, 105
     .   : milestone, 103,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (692ms)  : 675, 709
     .   : milestone, 692,
    master - mean (690ms)  : 673, 708
     .   : milestone, 690,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (658ms)  : 639, 677
     .   : milestone, 658,
    master - mean (651ms)  : 633, 669
     .   : milestone, 651,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (189ms)  : 184, 193
     .   : milestone, 189,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (1,109ms)  : 1082, 1135
     .   : milestone, 1109,
    master - mean (1,108ms)  : 1080, 1136
     .   : milestone, 1108,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (268ms)  : 264, 273
     .   : milestone, 268,
    master - mean (269ms)  : 266, 272
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (880ms)  : 848, 911
     .   : milestone, 880,
    master - mean (880ms)  : 855, 905
     .   : milestone, 880,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6952) - mean (261ms)  : 257, 266
     .   : milestone, 261,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (6952) - mean (866ms)  : 839, 893
     .   : milestone, 866,
    master - mean (875ms)  : 844, 906
     .   : milestone, 875,

andrewlock avatar May 10 '25 13:05 andrewlock