dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Config inversion] add ci step

Open anna-git opened this issue 7 months ago • 4 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

anna-git avatar May 08 '25 12:05 anna-git

Datadog Report

Branch report: anna/config-inversion Commit report: 5b83132 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 248459 Passed, 2291 Skipped, 15h 22m 6.11s Total Time

datadog-datadog-prod-us1[bot] avatar May 08 '25 13:05 datadog-datadog-prod-us1[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (68ms)  : 66, 70
     .   : milestone, 68,
    master - mean (68ms)  : 65, 71
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (1,009ms)  : 988, 1029
     .   : milestone, 1009,
    master - mean (1,011ms)  : 981, 1040
     .   : milestone, 1011,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (690ms)  : 668, 711
     .   : milestone, 690,
    master - mean (697ms)  : 675, 719
     .   : milestone, 697,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (650ms)  : 627, 672
     .   : milestone, 650,
    master - mean (659ms)  : 643, 675
     .   : milestone, 659,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (1,113ms)  : 1092, 1134
     .   : milestone, 1113,
    master - mean (1,112ms)  : 1087, 1138
     .   : milestone, 1112,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (270ms)  : 266, 274
     .   : milestone, 270,
    master - mean (268ms)  : 264, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (878ms)  : 850, 906
     .   : milestone, 878,
    master - mean (876ms)  : 853, 898
     .   : milestone, 876,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6943) - mean (262ms)  : 257, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6943) - mean (866ms)  : 829, 902
     .   : milestone, 866,
    master - mean (871ms)  : 841, 901
     .   : milestone, 871,

andrewlock avatar May 08 '25 14:05 andrewlock

Benchmarks

Benchmarks Report for benchmark platform :snail:

Benchmarks for #6943 compared to master:

  • All benchmarks have the same speed
  • 4 benchmarks have fewer allocations
  • 3 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #6943

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.65 KB 5.75 KB 93 B 1.64%

Fewer allocations :tada: in #6943

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net6.0 5.55 KB 5.52 KB -29 B -0.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 57.2ns 314ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.9μs 65ns 252ns 0 0 0 5.65 KB
master StartStopWithChild net472 22.2μs 124ns 784ns 0.98 0.436 0.109 6.13 KB
#6943 StartStopWithChild net6.0 10.2μs 57.3ns 376ns 0 0 0 5.52 KB
#6943 StartStopWithChild netcoreapp3.1 13.7μs 70.7ns 339ns 0 0 0 5.75 KB
#6943 StartStopWithChild net472 22.3μs 125ns 820ns 0.994 0.331 0.11 6.14 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 945μs 54.8ns 190ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 309ns 1.2μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 57ns 213ns 0 0 0 3.31 KB
#6943 WriteAndFlushEnrichedTraces net6.0 939μs 188ns 676ns 0 0 0 2.71 KB
#6943 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 129ns 466ns 0 0 0 2.7 KB
#6943 WriteAndFlushEnrichedTraces net472 1.23ms 67ns 260ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 335μs 560ns 2.17μs 0 0 0 197.06 KB
master AllCycleSimpleBody netcoreapp3.1 476μs 768ns 2.97μs 0 0 0 204.77 KB
master AllCycleSimpleBody net472 456μs 126ns 455ns 35.7 2.23 0 236.37 KB
master AllCycleMoreComplexBody net6.0 336μs 1.69μs 7.54μs 0 0 0 200.56 KB
master AllCycleMoreComplexBody netcoreapp3.1 482μs 1.8μs 6.96μs 0 0 0 208.18 KB
master AllCycleMoreComplexBody net472 448μs 151ns 564ns 37.9 2.23 0 239.88 KB
master ObjectExtractorSimpleBody net6.0 310ns 0.0693ns 0.25ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 390ns 2.1ns 11.7ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 305ns 0.0261ns 0.0977ns 0.0441 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.3μs 8.14ns 31.5ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.75μs 1.15ns 4.13ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.76μs 7.92ns 30.7ns 0.576 0 0 3.8 KB
#6943 AllCycleSimpleBody net6.0 332μs 1.73μs 7.33μs 0 0 0 197.06 KB
#6943 AllCycleSimpleBody netcoreapp3.1 505μs 563ns 1.95μs 0 0 0 204.77 KB
#6943 AllCycleSimpleBody net472 435μs 82.7ns 320ns 36.6 2.16 0 236.35 KB
#6943 AllCycleMoreComplexBody net6.0 345μs 567ns 2.19μs 0 0 0 200.56 KB
#6943 AllCycleMoreComplexBody netcoreapp3.1 490μs 679ns 2.63μs 0 0 0 208.18 KB
#6943 AllCycleMoreComplexBody net472 445μs 119ns 460ns 36.6 2.16 0 239.87 KB
#6943 ObjectExtractorSimpleBody net6.0 315ns 0.102ns 0.395ns 0 0 0 280 B
#6943 ObjectExtractorSimpleBody netcoreapp3.1 397ns 0.201ns 0.779ns 0 0 0 272 B
#6943 ObjectExtractorSimpleBody net472 303ns 0.185ns 0.718ns 0.0441 0 0 281 B
#6943 ObjectExtractorMoreComplexBody net6.0 6.31μs 1.7ns 6.59ns 0 0 0 3.78 KB
#6943 ObjectExtractorMoreComplexBody netcoreapp3.1 7.78μs 2.93ns 11.3ns 0 0 0 3.69 KB
#6943 ObjectExtractorMoreComplexBody net472 6.68μs 2.11ns 8.17ns 0.601 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeArgs net472 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeLegacyArgs net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeLegacyArgs netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6943 EncodeLegacyArgs net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.Asm.AppSecWafBenchmark - Unknown :shrug: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmark net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmark netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmark net472 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmarkWithAttack net6.0 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#6943 RunWafRealisticBenchmarkWithAttack net472 N/A N/A N/A NaN NaN NaN 0 b
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.2μs 42.7ns 160ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 70.6μs 117ns 407ns 0 0 0 17.42 KB
master SendRequest net472 0.0106ns 0.00294ns 0.0114ns 0 0 0 0 b
#6943 SendRequest net6.0 60.3μs 74.5ns 288ns 0 0 0 14.53 KB
#6943 SendRequest netcoreapp3.1 71.4μs 123ns 443ns 0 0 0 17.42 KB
#6943 SendRequest net472 0.0102ns 0.00297ns 0.0115ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 682μs 1.28μs 4.95μs 0 0 0 41.78 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 723μs 2.03μs 7.33μs 0 0 0 41.97 KB
master WriteAndFlushEnrichedTraces net472 912μs 2.38μs 9.21μs 4.46 0 0 55.98 KB
#6943 WriteAndFlushEnrichedTraces net6.0 730μs 790ns 3.06μs 0 0 0 41.58 KB
#6943 WriteAndFlushEnrichedTraces netcoreapp3.1 667μs 3.88μs 34.7μs 0 0 0 42.05 KB
#6943 WriteAndFlushEnrichedTraces net472 1.01ms 5.14μs 23.5μs 4.81 0 0 55.88 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 2.03μs 1.22ns 4.74ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.49μs 4.13ns 16ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.71μs 4.4ns 16.5ns 0.147 0.0133 0 995 B
#6943 ExecuteNonQuery net6.0 1.87μs 0.738ns 2.86ns 0 0 0 1.03 KB
#6943 ExecuteNonQuery netcoreapp3.1 2.57μs 7.4ns 27.7ns 0 0 0 1.02 KB
#6943 ExecuteNonQuery net472 2.73μs 4.33ns 16.8ns 0.15 0.0136 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.77μs 8.25ns 34ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.27μs 9.29ns 36ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.48μs 3.06ns 11.8ns 0.155 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.82μs 2.09ns 7.81ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.38μs 3.9ns 15.1ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.62μs 3.69ns 14.3ns 0.162 0 0 1.11 KB
#6943 CallElasticsearch net6.0 1.79μs 8.13ns 31.5ns 0 0 0 1.04 KB
#6943 CallElasticsearch netcoreapp3.1 2.28μs 10.8ns 40.6ns 0 0 0 1.04 KB
#6943 CallElasticsearch net472 3.55μs 4.1ns 15.9ns 0.159 0 0 1.05 KB
#6943 CallElasticsearchAsync net6.0 1.86μs 3.07ns 11.9ns 0 0 0 1.02 KB
#6943 CallElasticsearchAsync netcoreapp3.1 2.37μs 11.4ns 44ns 0 0 0 1.09 KB
#6943 CallElasticsearchAsync net472 3.76μs 7.55ns 29.2ns 0.17 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.75μs 6.92ns 26.8ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.43μs 4.44ns 17.2ns 0 0 0 960 B
master ExecuteAsync net472 2.5μs 2.92ns 11.3ns 0.138 0 0 923 B
#6943 ExecuteAsync net6.0 1.74μs 0.496ns 1.79ns 0 0 0 960 B
#6943 ExecuteAsync netcoreapp3.1 2.34μs 9.96ns 37.3ns 0 0 0 960 B
#6943 ExecuteAsync net472 2.64μs 3.3ns 12.8ns 0.145 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.96μs 12.6ns 48.6ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.67μs 19.7ns 76.2ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 4.94ns 18.5ns 0.494 0 0 3.19 KB
#6943 SendAsync net6.0 6.83μs 18.2ns 70.5ns 0 0 0 2.37 KB
#6943 SendAsync netcoreapp3.1 8.53μs 18ns 69.9ns 0 0 0 2.9 KB
#6943 SendAsync net472 12.1μs 8.1ns 31.4ns 0.485 0 0 3.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed :heavy_check_mark: More allocations :warning:

More allocations :warning: in #6943

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.78 KB 44.1 KB 1.32 KB 3.09%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.72 KB 8.19 KB 2.94%

Fewer allocations :tada: in #6943

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.34 KB 43.78 KB -560 B -1.26%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 277.86 KB 271.95 KB -5.91 KB -2.13%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.07 KB 249.74 KB -9.33 KB -3.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.8μs 312ns 2.93μs 0 0 0 44.34 KB
master StringConcatBenchmark netcoreapp3.1 48.4μs 386ns 3.62μs 0 0 0 42.78 KB
master StringConcatBenchmark net472 57.5μs 255ns 988ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 477μs 878ns 3.04μs 0 0 0 259.07 KB
master StringConcatAspectBenchmark netcoreapp3.1 547μs 2.6μs 10.7μs 0 0 0 277.86 KB
master StringConcatAspectBenchmark net472 407μs 2.22μs 13.7μs 0 0 0 278.53 KB
#6943 StringConcatBenchmark net6.0 42.5μs 243ns 1.57μs 0 0 0 43.78 KB
#6943 StringConcatBenchmark netcoreapp3.1 46.7μs 214ns 772ns 0 0 0 44.1 KB
#6943 StringConcatBenchmark net472 64μs 273ns 1.06μs 0 0 0 57.34 KB
#6943 StringConcatAspectBenchmark net6.0 457μs 1.63μs 6.29μs 0 0 0 249.74 KB
#6943 StringConcatAspectBenchmark netcoreapp3.1 505μs 2.2μs 7.95μs 0 0 0 271.95 KB
#6943 StringConcatAspectBenchmark net472 414μs 2.02μs 8.82μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.57μs 10.3ns 39.8ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.45μs 17ns 74.1ns 0 0 0 1.76 KB
master EnrichedLog net472 3.91μs 1.87ns 7.26ns 0.255 0 0 1.69 KB
#6943 EnrichedLog net6.0 2.55μs 0.911ns 3.53ns 0 0 0 1.76 KB
#6943 EnrichedLog netcoreapp3.1 3.44μs 14.4ns 54ns 0 0 0 1.76 KB
#6943 EnrichedLog net472 3.91μs 3.79ns 14.7ns 0.253 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 48.9ns 176ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 128μs 229ns 827ns 0 0 0 4.37 KB
master EnrichedLog net472 167μs 41.5ns 155ns 0 0 0 4.57 KB
#6943 EnrichedLog net6.0 130μs 670ns 3.21μs 0 0 0 4.37 KB
#6943 EnrichedLog netcoreapp3.1 136μs 656ns 2.62μs 0 0 0 4.37 KB
#6943 EnrichedLog net472 175μs 845ns 3.48μs 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.15μs 13ns 50.3ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.4μs 22.4ns 86.8ns 0 0 0 2.32 KB
master EnrichedLog net472 7.46μs 6.79ns 26.3ns 0.337 0 0 2.14 KB
#6943 EnrichedLog net6.0 5.05μs 6.4ns 24.8ns 0 0 0 2.32 KB
#6943 EnrichedLog netcoreapp3.1 6.64μs 18ns 69.8ns 0 0 0 2.32 KB
#6943 EnrichedLog net472 7.47μs 7.34ns 28.4ns 0.336 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.98μs 10.1ns 49.7ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.57μs 9.19ns 35.6ns 0 0 0 1.21 KB
master SendReceive net472 3.06μs 3.31ns 12.8ns 0.183 0 0 1.21 KB
#6943 SendReceive net6.0 2.04μs 10.6ns 50.8ns 0 0 0 1.21 KB
#6943 SendReceive netcoreapp3.1 2.66μs 13.3ns 57.8ns 0 0 0 1.21 KB
#6943 SendReceive net472 3.09μs 3.99ns 15.4ns 0.186 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.37μs 7.63ns 28.5ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.62μs 15.1ns 58.5ns 0 0 0 1.69 KB
master EnrichedLog net472 6.48μs 4.01ns 15.5ns 0.323 0 0 2.08 KB
#6943 EnrichedLog net6.0 4.32μs 12.2ns 45.6ns 0 0 0 1.64 KB
#6943 EnrichedLog netcoreapp3.1 5.63μs 22.1ns 85.7ns 0 0 0 1.69 KB
#6943 EnrichedLog net472 6.54μs 5.07ns 19.6ns 0.325 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 757ns 0.25ns 0.967ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 957ns 4.84ns 22.2ns 0 0 0 584 B
master StartFinishSpan net472 919ns 0.784ns 3.04ns 0.0927 0 0 586 B
master StartFinishScope net6.0 890ns 4.81ns 25.9ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.12μs 5.99ns 33.3ns 0 0 0 704 B
master StartFinishScope net472 1.14μs 1.06ns 4.12ns 0.102 0 0 666 B
#6943 StartFinishSpan net6.0 748ns 0.22ns 0.851ns 0 0 0 584 B
#6943 StartFinishSpan netcoreapp3.1 937ns 5.03ns 28ns 0 0 0 584 B
#6943 StartFinishSpan net472 891ns 0.129ns 0.499ns 0.093 0 0 586 B
#6943 StartFinishScope net6.0 898ns 0.232ns 0.87ns 0 0 0 704 B
#6943 StartFinishScope netcoreapp3.1 1.13μs 6.07ns 33.2ns 0 0 0 704 B
#6943 StartFinishScope net472 1.08μs 0.755ns 2.82ns 0.103 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 4.83ns 19.3ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.35μs 6.37ns 24.7ns 0 0 0 704 B
master RunOnMethodBegin net472 1.36μs 0.699ns 2.71ns 0.102 0 0 666 B
#6943 RunOnMethodBegin net6.0 1.06μs 0.783ns 2.93ns 0 0 0 704 B
#6943 RunOnMethodBegin netcoreapp3.1 1.35μs 1.43ns 5.55ns 0 0 0 704 B
#6943 RunOnMethodBegin net472 1.34μs 1.09ns 4.2ns 0.1 0 0 666 B

pr-commenter[bot] avatar May 08 '25 15:05 pr-commenter[bot]

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Was this helpful? Give us feedback!

datadog-datadog-prod-us1[bot] avatar May 12 '25 11:05 datadog-datadog-prod-us1[bot]