dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[AWS Lambda] Fix `DD_TRACE_ENABLED=0`

Open andrewlock opened this issue 9 months ago • 5 comments

Summary of changes

  • Update Lambda integration to check whether tracing is enabled before generating spans

Reason for change

A customer was unable to set DD_TRACE_ENABLED=0 to disable tracing

Implementation details

  • Add a check to see if it's enabled in the Lambda integration
  • Added the check inside the delegate instrumentation instead of the instrumentation so that the check is made with every call. The downside there is performance, but it means the value can be changed at runtime, which is consistent with other integrations.

Test coverage

Added two disabled scenarios... will update snapshots once I've grabbed them from CI...

Other details

Fixes

  • https://datadoghq.atlassian.net/browse/SLES-2140
  • https://github.com/DataDog/dd-trace-dotnet-aws-lambda-layer/issues/14

andrewlock avatar Mar 19 '25 18:03 andrewlock

Datadog Report

All test runs b89adb2 :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 4 0 0 517187 3292 26h 29m 2.93s Link
exploration_tests 0 0 0 22085 3 2m 9.09s Link

:x: Failed Tests (4)

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsLambdaTests - Details

    Expand for error 
    xpected relevantSpans to contain at least 80 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 78: {{TraceId: 1106441124354687534, SpanId: 11967694357528759710, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 1106441124354687534, SpanId: 12389510077196726197, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 7797387079998866463, SpanId: 17034064025879455210, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7797387079998866463, SpanId: 8270963636512387897, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 8208676244345576271, SpanId: 427994676922475226, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8208676244345576271, SpanId: 16944604933874165996, Name: manual.HandlerOneParamSync, Resource: manual.HandlerOneParamSync, Service: Samples.AWS.Lambda}, {TraceId: 8091326681157868922, SpanId: 3275199153218039825, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8091326681157868922, SpanId: 6915079368470321757, Name: manual.HandlerTwoParamsSync, Resource: manual.HandlerTwoParamsSync, Service: Samples.AWS.Lambda}, {TraceId: 16836234293947961663, SpanId: 282266575185387064, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 16836234293947961663, SpanId: 4185295711748367597, Name: manual.HandlerNoParamAsync, Resource: manual.HandlerNoParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 827951958439441630, SpanId: 10559551389116443114, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 827951958439441630, SpanId: 6270338739420125469, Name: manual.HandlerOneParamAsync, Resource: manual.HandlerOneParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 12644003324463768020, SpanId: 4776658334893286915, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 12644003324463768020, SpanId: 5484001114464055475, Name: manual.HandlerTwoParamsAsync, Resource: manual.HandlerTwoParamsAsync, Service: Samples.AWS.Lambda}, {TraceId: 2752509858918401671, SpanId: 9120754786659969372, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 2752509858918401671, SpanId: 7425832658269190329, Name: manual.HandlerNoParamVoid, Resource: manual.HandlerNoParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 9023374606896291687, SpanId: 2090934917043673791, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 9023374606896291687, SpanId: 7688626618496129036, Name: manual.HandlerOneParamVoid, Resource: manual.HandlerOneParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 9435258195314145684, SpanId: 14408013619376075251, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 9435258195314145684, SpanId: 17125320345678952639, Name: manual.HandlerTwoParamsVoid, Resource: manual.HandlerTwoParamsVoid, Service: Samples.AWS.Lambda}, {TraceId: 8566774531968252574, SpanId: 9920030479567029187, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8566774531968252574, SpanId: 5863878716422468723, Name: manual.HandlerNoParamSyncWithContext, Resource: manual.HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 7599943536439803943, SpanId: 16851429199100417658, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7599943536439803943, SpanId: 10509247843291377662, Name: manual.HandlerOneParamSyncWithContext, Resource: manual.HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 557225043298788442, SpanId: 5666851299902296340, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 557225043298788442, SpanId: 6360810015625731140, Name: manual.HandlerTwoParamsSyncWithContext, Resource: manual.HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 8844353213425550830, SpanId: 10989631795238804845, Name: http.request, Resource: GET serverless-dummy-api:9

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsLambdaTests - Details

    Expand for error 
    xpected relevantSpans to contain at least 80 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 78: {{TraceId: 10673080241960035590, SpanId: 17475578097559914901, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 10673080241960035590, SpanId: 6327957502124200073, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 5897395313516764265, SpanId: 13510869426870460557, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 5897395313516764265, SpanId: 4252525097456117318, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 3701955946296119817, SpanId: 10092187652784618057, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3701955946296119817, SpanId: 13565652564779726636, Name: manual.HandlerOneParamSync, Resource: manual.HandlerOneParamSync, Service: Samples.AWS.Lambda}, {TraceId: 3081884700777215460, SpanId: 8185601455237009396, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3081884700777215460, SpanId: 13088560365315286285, Name: manual.HandlerTwoParamsSync, Resource: manual.HandlerTwoParamsSync, Service: Samples.AWS.Lambda}, {TraceId: 10507035758837017105, SpanId: 7561728482359464270, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 10507035758837017105, SpanId: 11532510566717544644, Name: manual.HandlerNoParamAsync, Resource: manual.HandlerNoParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 1224385026403664269, SpanId: 9031233294808354113, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 1224385026403664269, SpanId: 9854165584921494062, Name: manual.HandlerOneParamAsync, Resource: manual.HandlerOneParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 3562880996757416113, SpanId: 4118193438342636955, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3562880996757416113, SpanId: 8052353902846628523, Name: manual.HandlerTwoParamsAsync, Resource: manual.HandlerTwoParamsAsync, Service: Samples.AWS.Lambda}, {TraceId: 7697440791818485052, SpanId: 3049544302201270068, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7697440791818485052, SpanId: 15704814229140380397, Name: manual.HandlerNoParamVoid, Resource: manual.HandlerNoParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 10861360813866860355, SpanId: 532136088195767667, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 10861360813866860355, SpanId: 18444468605958851573, Name: manual.HandlerOneParamVoid, Resource: manual.HandlerOneParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 10531576873648591533, SpanId: 8594655797388950192, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 10531576873648591533, SpanId: 15995824765652657016, Name: manual.HandlerTwoParamsVoid, Resource: manual.HandlerTwoParamsVoid, Service: Samples.AWS.Lambda}, {TraceId: 7519994611416575938, SpanId: 4422440485862873573, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7519994611416575938, SpanId: 546831867487460972, Name: manual.HandlerNoParamSyncWithContext, Resource: manual.HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 8543810201618117540, SpanId: 10856720791400322260, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8543810201618117540, SpanId: 8227459738374897012, Name: manual.HandlerOneParamSyncWithContext, Resource: manual.HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 2881865322260021862, SpanId: 7215157555775524580, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 2881865322260021862, SpanId: 10311491808305642054, Name: manual.HandlerTwoParamsSyncWithContext, Resource: manual.HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 13195465917973873584, SpanId: 7584986639987661606, Name: http.request, Resource: GET serverless-d

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsLambdaTests - Details

    Expand for error 
    xpected relevantSpans to contain at least 80 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 78: {{TraceId: 1922280148520519568, SpanId: 198780027263821899, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 1922280148520519568, SpanId: 15369078296017416200, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 8208781138113220325, SpanId: 1659927200295719473, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8208781138113220325, SpanId: 6707213687475256583, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 9066373009721439931, SpanId: 17921261047167399187, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 9066373009721439931, SpanId: 14993518049878731334, Name: manual.HandlerOneParamSync, Resource: manual.HandlerOneParamSync, Service: Samples.AWS.Lambda}, {TraceId: 8876700420246565482, SpanId: 13980103006280833661, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 8876700420246565482, SpanId: 109854404542204128, Name: manual.HandlerTwoParamsSync, Resource: manual.HandlerTwoParamsSync, Service: Samples.AWS.Lambda}, {TraceId: 14532924033087142022, SpanId: 4562476919559934170, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 14532924033087142022, SpanId: 8848661483410861130, Name: manual.HandlerNoParamAsync, Resource: manual.HandlerNoParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 13112704569870246945, SpanId: 16110294450617911104, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 13112704569870246945, SpanId: 13583672624109114502, Name: manual.HandlerOneParamAsync, Resource: manual.HandlerOneParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 14834853671451078681, SpanId: 7322885814249253788, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 14834853671451078681, SpanId: 17512851038708284389, Name: manual.HandlerTwoParamsAsync, Resource: manual.HandlerTwoParamsAsync, Service: Samples.AWS.Lambda}, {TraceId: 7569220052706747372, SpanId: 401780765038849419, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7569220052706747372, SpanId: 4512622215553712913, Name: manual.HandlerNoParamVoid, Resource: manual.HandlerNoParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 3040095731196331143, SpanId: 14424768942273442961, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3040095731196331143, SpanId: 2673443230010419650, Name: manual.HandlerOneParamVoid, Resource: manual.HandlerOneParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 6139031376860937765, SpanId: 15099584621325058067, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 6139031376860937765, SpanId: 13980187913289992664, Name: manual.HandlerTwoParamsVoid, Resource: manual.HandlerTwoParamsVoid, Service: Samples.AWS.Lambda}, {TraceId: 4672218385781060502, SpanId: 3101805421293903328, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 4672218385781060502, SpanId: 13492854940821057811, Name: manual.HandlerNoParamSyncWithContext, Resource: manual.HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 3108807515994330869, SpanId: 6257127000522812060, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3108807515994330869, SpanId: 3568650596841405144, Name: manual.HandlerOneParamSyncWithContext, Resource: manual.HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 3725646907660357303, SpanId: 6118710411151412236, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 3725646907660357303, SpanId: 349542689118497270, Name: manual.HandlerTwoParamsSyncWithContext, Resource: manual.HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 1756214589202048258, SpanId: 6152638187079167298, Name: http.request, Resource: GET serverless-dummy-

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsLambdaTests - Details

    Expand for error 
    xpected relevantSpans to contain at least 80 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 78: {{TraceId: 4445443054553638904, SpanId: 13123292102784458718, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 4445443054553638904, SpanId: 2724396347684794497, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 13292662252076292387, SpanId: 6748552432691163295, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 13292662252076292387, SpanId: 14750790855146611330, Name: manual.HandlerNoParamSync, Resource: manual.HandlerNoParamSync, Service: Samples.AWS.Lambda}, {TraceId: 6645227524801459526, SpanId: 6836037680471597516, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 6645227524801459526, SpanId: 7219544328812284747, Name: manual.HandlerOneParamSync, Resource: manual.HandlerOneParamSync, Service: Samples.AWS.Lambda}, {TraceId: 10788948339682735677, SpanId: 12884813084888665060, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 10788948339682735677, SpanId: 8195370963755174368, Name: manual.HandlerTwoParamsSync, Resource: manual.HandlerTwoParamsSync, Service: Samples.AWS.Lambda}, {TraceId: 11481209407243427359, SpanId: 6847060976464006524, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 11481209407243427359, SpanId: 8956797489969581515, Name: manual.HandlerNoParamAsync, Resource: manual.HandlerNoParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 639352745685334561, SpanId: 3181423122321149937, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 639352745685334561, SpanId: 16166344685375539473, Name: manual.HandlerOneParamAsync, Resource: manual.HandlerOneParamAsync, Service: Samples.AWS.Lambda}, {TraceId: 9632553472516982866, SpanId: 8780198940088045053, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsAsync, Service: Samples.AWS.Lambda-http-client}, {TraceId: 9632553472516982866, SpanId: 789430993891775326, Name: manual.HandlerTwoParamsAsync, Resource: manual.HandlerTwoParamsAsync, Service: Samples.AWS.Lambda}, {TraceId: 14445811034978133089, SpanId: 1266797353649208242, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 14445811034978133089, SpanId: 4768120135611382267, Name: manual.HandlerNoParamVoid, Resource: manual.HandlerNoParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 7131491482170901563, SpanId: 15672171142159401596, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 7131491482170901563, SpanId: 11793869453180262727, Name: manual.HandlerOneParamVoid, Resource: manual.HandlerOneParamVoid, Service: Samples.AWS.Lambda}, {TraceId: 14903876968945716027, SpanId: 9098990059758851558, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsVoid, Service: Samples.AWS.Lambda-http-client}, {TraceId: 14903876968945716027, SpanId: 15745928638354360860, Name: manual.HandlerTwoParamsVoid, Resource: manual.HandlerTwoParamsVoid, Service: Samples.AWS.Lambda}, {TraceId: 823636147525484898, SpanId: 6848242969582237948, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 823636147525484898, SpanId: 794424369062363651, Name: manual.HandlerNoParamSyncWithContext, Resource: manual.HandlerNoParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 5270306070370909164, SpanId: 16365368842354233972, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 5270306070370909164, SpanId: 3333304641542343338, Name: manual.HandlerOneParamSyncWithContext, Resource: manual.HandlerOneParamSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 1349409947285531056, SpanId: 1786060281428207721, Name: http.request, Resource: GET serverless-dummy-api:9005/function/HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda-http-client}, {TraceId: 1349409947285531056, SpanId: 13557175977310188035, Name: manual.HandlerTwoParamsSyncWithContext, Resource: manual.HandlerTwoParamsSyncWithContext, Service: Samples.AWS.Lambda}, {TraceId: 9313042214354701971, SpanId: 6705729459350535011, Name: http.request, Resource: GET serverless-dummy-

datadog-datadog-prod-us1[bot] avatar Mar 19 '25 18:03 datadog-datadog-prod-us1[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (70ms)  : 65, 74
     .   : milestone, 70,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (1,007ms)  : 985, 1029
     .   : milestone, 1007,
    master - mean (1,008ms)  : 983, 1033
     .   : milestone, 1008,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 104
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (687ms)  : 662, 711
     .   : milestone, 687,
    master - mean (688ms)  : 670, 706
     .   : milestone, 688,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (93ms)  : 88, 99
     .   : milestone, 93,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (645ms)  : 621, 669
     .   : milestone, 645,
    master - mean (642ms)  : 626, 658
     .   : milestone, 642,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (1,108ms)  : 1075, 1142
     .   : milestone, 1108,
    master - mean (1,109ms)  : 1079, 1140
     .   : milestone, 1109,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (269ms)  : 266, 273
     .   : milestone, 269,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (873ms)  : 841, 906
     .   : milestone, 873,
    master - mean (880ms)  : 847, 914
     .   : milestone, 880,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6781) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6781) - mean (852ms)  : 815, 889
     .   : milestone, 852,
    master - mean (858ms)  : 822, 895
     .   : milestone, 858,

andrewlock avatar Mar 19 '25 19:03 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6781 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.136
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.82μs 35.3ns 146ns 0.0204 0.00815 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 57ns 391ns 0.0201 0.00504 0 5.8 KB
master StartStopWithChild net472 16μs 49.1ns 190ns 1.03 0.301 0.0896 6.21 KB
#6781 StartStopWithChild net6.0 7.96μs 38ns 157ns 0.0161 0.00807 0 5.61 KB
#6781 StartStopWithChild netcoreapp3.1 9.99μs 50ns 283ns 0.0199 0.00497 0 5.8 KB
#6781 StartStopWithChild net472 16.2μs 36.2ns 135ns 1.04 0.304 0.096 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 531ns 1.99μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 437ns 1.69μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 840μs 1.11μs 4.28μs 0.419 0 0 3.3 KB
#6781 WriteAndFlushEnrichedTraces net6.0 526μs 867ns 3.36μs 0 0 0 2.7 KB
#6781 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 799ns 2.99μs 0 0 0 2.7 KB
#6781 WriteAndFlushEnrichedTraces net472 844μs 854ns 3.31μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 131μs 485ns 1.88μs 0.134 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 420ns 1.63μs 0.221 0 0 17.27 KB
master SendRequest net472 0.00039ns 0.000291ns 0.00105ns 0 0 0 0 b
#6781 SendRequest net6.0 130μs 491ns 1.9μs 0.193 0 0 14.47 KB
#6781 SendRequest netcoreapp3.1 147μs 327ns 1.27μs 0.223 0 0 17.27 KB
#6781 SendRequest net472 0.000187ns 0.000135ns 0.000523ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 600μs 3.46μs 26.8μs 0.566 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 687μs 3.83μs 25.7μs 0.332 0 0 41.8 KB
master WriteAndFlushEnrichedTraces net472 872μs 4.22μs 18.4μs 8.42 2.66 0.443 53.31 KB
#6781 WriteAndFlushEnrichedTraces net6.0 621μs 4.74μs 47.2μs 0.581 0 0 41.6 KB
#6781 WriteAndFlushEnrichedTraces netcoreapp3.1 729μs 4.94μs 48.7μs 0.355 0 0 41.73 KB
#6781 WriteAndFlushEnrichedTraces net472 847μs 2.33μs 8.06μs 8.33 2.5 0.417 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.37μs 0.817ns 3.06ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.72μs 1.43ns 5.34ns 0.0138 0 0 1.02 KB
master ExecuteNonQuery net472 2.02μs 2.73ns 10.2ns 0.157 0.00101 0 987 B
#6781 ExecuteNonQuery net6.0 1.28μs 2.02ns 7.83ns 0.0146 0 0 1.02 KB
#6781 ExecuteNonQuery netcoreapp3.1 1.73μs 1.36ns 5.1ns 0.0138 0 0 1.02 KB
#6781 ExecuteNonQuery net472 2.07μs 1.59ns 5.97ns 0.156 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.27μs 0.471ns 1.76ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.855ns 3.2ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.65μs 1.24ns 4.81ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.26μs 0.642ns 2.4ns 0.013 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 0.966ns 3.74ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.71μs 0.728ns 2.73ns 0.167 0 0 1.05 KB
#6781 CallElasticsearch net6.0 1.16μs 0.546ns 2.04ns 0.0135 0 0 976 B
#6781 CallElasticsearch netcoreapp3.1 1.57μs 0.51ns 1.98ns 0.0134 0 0 976 B
#6781 CallElasticsearch net472 2.53μs 0.811ns 3.04ns 0.157 0 0 995 B
#6781 CallElasticsearchAsync net6.0 1.26μs 1.25ns 4.83ns 0.0132 0 0 952 B
#6781 CallElasticsearchAsync netcoreapp3.1 1.68μs 1.14ns 4.41ns 0.0134 0 0 1.02 KB
#6781 CallElasticsearchAsync net472 2.62μs 1.15ns 4.46ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.29μs 0.502ns 1.88ns 0.0129 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 0.484ns 1.74ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.86μs 0.416ns 1.61ns 0.145 0 0 915 B
#6781 ExecuteAsync net6.0 1.35μs 0.428ns 1.66ns 0.0135 0 0 952 B
#6781 ExecuteAsync netcoreapp3.1 1.57μs 0.66ns 2.56ns 0.0125 0 0 952 B
#6781 ExecuteAsync net472 1.87μs 2.32ns 9ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.24μs 1.62ns 6.29ns 0.0318 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.32μs 4.96ns 18.6ns 0.0371 0 0 2.85 KB
master SendAsync net472 7.58μs 1.44ns 5.38ns 0.492 0 0 3.12 KB
#6781 SendAsync net6.0 4.53μs 1.37ns 5.29ns 0.0315 0 0 2.31 KB
#6781 SendAsync netcoreapp3.1 5.42μs 2.97ns 11.5ns 0.038 0 0 2.85 KB
#6781 SendAsync net472 7.38μs 2.25ns 8.7ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 0.775ns 2.9ns 0.0239 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 2.36μs 0.981ns 3.67ns 0.0232 0 0 1.69 KB
master EnrichedLog net472 2.59μs 0.982ns 3.68ns 0.258 0 0 1.62 KB
#6781 EnrichedLog net6.0 1.55μs 0.646ns 2.42ns 0.024 0 0 1.69 KB
#6781 EnrichedLog netcoreapp3.1 2.3μs 0.709ns 2.56ns 0.0228 0 0 1.69 KB
#6781 EnrichedLog net472 2.58μs 0.659ns 2.55ns 0.258 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 156ns 604ns 0 0 0 4.3 KB
master EnrichedLog netcoreapp3.1 117μs 210ns 814ns 0.0584 0 0 4.3 KB
master EnrichedLog net472 150μs 241ns 932ns 0.676 0.225 0 4.49 KB
#6781 EnrichedLog net6.0 113μs 105ns 380ns 0 0 0 4.3 KB
#6781 EnrichedLog netcoreapp3.1 116μs 186ns 721ns 0 0 0 4.3 KB
#6781 EnrichedLog net472 150μs 145ns 561ns 0.676 0.225 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.09μs 1.51ns 5.83ns 0.031 0 0 2.25 KB
master EnrichedLog netcoreapp3.1 4.26μs 1.64ns 6.12ns 0.03 0 0 2.25 KB
master EnrichedLog net472 4.89μs 1.93ns 7.47ns 0.329 0 0 2.07 KB
#6781 EnrichedLog net6.0 3.1μs 1.29ns 4.99ns 0.0318 0 0 2.25 KB
#6781 EnrichedLog netcoreapp3.1 4.1μs 1.38ns 4.97ns 0.0287 0 0 2.25 KB
#6781 EnrichedLog net472 4.76μs 1.85ns 7.18ns 0.329 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.665ns 2.49ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.7μs 0.708ns 2.74ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.08μs 0.618ns 2.31ns 0.183 0 0 1.16 KB
#6781 SendReceive net6.0 1.38μs 1.25ns 4.86ns 0.0164 0 0 1.14 KB
#6781 SendReceive netcoreapp3.1 1.81μs 0.728ns 2.82ns 0.0154 0 0 1.14 KB
#6781 SendReceive net472 2.02μs 0.435ns 1.68ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 1.23ns 4.75ns 0.0217 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.41ns 5.27ns 0.0218 0 0 1.67 KB
master EnrichedLog net472 4.49μs 1.57ns 6.09ns 0.326 0 0 2.07 KB
#6781 EnrichedLog net6.0 2.75μs 0.954ns 3.57ns 0.022 0 0 1.62 KB
#6781 EnrichedLog netcoreapp3.1 4.03μs 1.71ns 6.41ns 0.0221 0 0 1.67 KB
#6781 EnrichedLog net472 4.38μs 2.06ns 7.96ns 0.327 0 0 2.07 KB
Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6781

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.136 468.60 412.40

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 469ns 0.166ns 0.643ns 0.0082 0 0 576 B
master StartFinishSpan netcoreapp3.1 581ns 0.902ns 3.49ns 0.00774 0 0 576 B
master StartFinishSpan net472 598ns 0.148ns 0.573ns 0.0917 0 0 578 B
master StartFinishScope net6.0 495ns 0.178ns 0.69ns 0.00985 0 0 696 B
master StartFinishScope netcoreapp3.1 723ns 0.293ns 1.13ns 0.00935 0 0 696 B
master StartFinishScope net472 852ns 0.339ns 1.27ns 0.104 0 0 658 B
#6781 StartFinishSpan net6.0 412ns 0.108ns 0.416ns 0.00803 0 0 576 B
#6781 StartFinishSpan netcoreapp3.1 560ns 0.525ns 2.03ns 0.00761 0 0 576 B
#6781 StartFinishSpan net472 650ns 0.312ns 1.21ns 0.0918 0 0 578 B
#6781 StartFinishScope net6.0 539ns 0.141ns 0.548ns 0.00972 0 0 696 B
#6781 StartFinishScope netcoreapp3.1 717ns 0.56ns 2.02ns 0.00947 0 0 696 B
#6781 StartFinishScope net472 801ns 0.505ns 1.96ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 676ns 0.192ns 0.745ns 0.00986 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 957ns 0.315ns 1.22ns 0.00911 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.226ns 0.876ns 0.104 0 0 658 B
#6781 RunOnMethodBegin net6.0 610ns 0.174ns 0.628ns 0.00985 0 0 696 B
#6781 RunOnMethodBegin netcoreapp3.1 1.03μs 0.334ns 1.25ns 0.00936 0 0 696 B
#6781 RunOnMethodBegin net472 1.09μs 0.214ns 0.8ns 0.104 0 0 658 B

andrewlock avatar Mar 19 '25 23:03 andrewlock

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

+  },
+  {
+    TraceId: Id_153,
+    SpanId: Id_154,
+    Name: manual.HandlerNoParamSync,
+    Resource: manual.HandlerNoParamSync,
+    Service: Samples.AWS.Lambda,
+    Tags: {
+      language: dotnet,
+      runtime-id: Guid_39
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_153,
+    SpanId: Id_155,
+    Name: http.request,
+    Resource: GET serverless-dummy-api:9005/function/HandlerNoParamSync,
+    Service: Samples.AWS.Lambda-http-client,
+    Type: http,
+    ParentId: Id_154,
+    Tags: {
+      component: WebRequest,
+      http.method: GET,
+      http.status_code: 200,
+      http.url: http://serverless-dummy-api:9005/function/HandlerNoParamSync,
+      language: dotnet,
+      out.host: serverless-dummy-api,
+      runtime-id: Guid_39,
+      span.kind: client,
+      _dd.base_service: Samples.AWS.Lambda
+    },
+    Metrics: {
+      _dd.top_level: 1.0
+    }

github-actions[bot] avatar Mar 20 '25 14:03 github-actions[bot]

see also https://github.com/DataDog/dd-trace-dotnet-aws-lambda-layer/issues/14

lucaspimentel avatar Mar 20 '25 15:03 lucaspimentel