dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard

Bump Fody and Microsoft.NETFramework.ReferenceAssemblies in /tracer/src/Datadog.Trace.BenchmarkDotNet

Open dependabot[bot] opened this issue 9 months ago • 3 comments

Bumps Fody and Microsoft.NETFramework.ReferenceAssemblies. These dependencies needed to be updated together. Updates Fody from 6.8.1 to 6.9.2

Release notes

Sourced from Fody's releases.

6.9.2

What's Changed

New Contributors

Full Changelog: https://github.com/Fody/Fody/compare/6.9.1...6.9.2

6.9.1

What's Changed

Full Changelog: https://github.com/Fody/Fody/compare/6.9.0...6.9.1

6.9.0

What's Changed

Full Changelog: https://github.com/Fody/Fody/compare/6.8.2...6.9.0

6.8.2

What's Changed

Full Changelog: https://github.com/Fody/Fody/compare/6.8.1...6.8.2

Commits

Updates Microsoft.NETFramework.ReferenceAssemblies from 1.0.3 to 1.0.3

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Mar 03 '25 16:03 dependabot[bot]

Datadog Report

Branch report: dependabot/nuget/tracer/src/Datadog.Trace.BenchmarkDotNet/multi-218233af18 Commit report: 4e18047 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 249694 Passed, 2369 Skipped, 19h 37m 26.68s Total Time

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (70ms)  : 67, 73
     .   : milestone, 70,
    master - mean (70ms)  : 65, 74
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (1,006ms)  : 980, 1032
     .   : milestone, 1006,
    master - mean (1,003ms)  : 977, 1029
     .   : milestone, 1003,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (104ms)  : 101, 106
     .   : milestone, 104,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (692ms)  : 678, 706
     .   : milestone, 692,
    master - mean (688ms)  : 664, 711
     .   : milestone, 688,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (91ms)  : 88, 94
     .   : milestone, 91,
    master - mean (89ms)  : 87, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (644ms)  : 626, 663
     .   : milestone, 644,
    master - mean (640ms)  : 626, 654
     .   : milestone, 640,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (1,111ms)  : 1084, 1139
     .   : milestone, 1111,
    master - mean (1,107ms)  : 1081, 1133
     .   : milestone, 1107,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (270ms)  : 266, 275
     .   : milestone, 270,
    master - mean (271ms)  : 266, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (874ms)  : 839, 909
     .   : milestone, 874,
    master - mean (877ms)  : 842, 913
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6734) - mean (262ms)  : 257, 266
     .   : milestone, 262,
    master - mean (262ms)  : 259, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6734) - mean (855ms)  : 821, 888
     .   : milestone, 855,
    master - mean (855ms)  : 817, 892
     .   : milestone, 855,

andrewlock avatar Mar 03 '25 17:03 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6734 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.182
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.19μs 46.8ns 338ns 0.0119 0.00398 0 5.6 KB
master StartStopWithChild netcoreapp3.1 10.7μs 60.3ns 435ns 0.015 0.00499 0 5.81 KB
master StartStopWithChild net472 16.2μs 47.8ns 185ns 1.04 0.299 0.0969 6.2 KB
#6734 StartStopWithChild net6.0 8.17μs 48.7ns 487ns 0.0171 0.00855 0 5.61 KB
#6734 StartStopWithChild netcoreapp3.1 10.4μs 58.6ns 423ns 0.0156 0.0052 0 5.8 KB
#6734 StartStopWithChild net472 16μs 35.4ns 132ns 1.04 0.31 0.0954 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 483μs 358ns 1.39μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 635ns 2.46μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 849μs 397ns 1.54μs 0.422 0 0 3.3 KB
#6734 WriteAndFlushEnrichedTraces net6.0 498μs 420ns 1.63μs 0 0 0 2.7 KB
#6734 WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 290ns 1.08μs 0 0 0 2.7 KB
#6734 WriteAndFlushEnrichedTraces net472 837μs 514ns 1.99μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 133μs 411ns 1.59μs 0.199 0 0 14.47 KB
master SendRequest netcoreapp3.1 151μs 212ns 794ns 0.227 0 0 17.27 KB
master SendRequest net472 0.000146ns 9.84E‑05ns 0.000368ns 0 0 0 0 b
#6734 SendRequest net6.0 130μs 408ns 1.58μs 0.128 0 0 14.47 KB
#6734 SendRequest netcoreapp3.1 153μs 152ns 569ns 0.229 0 0 17.27 KB
#6734 SendRequest net472 0.000265ns 0.000156ns 0.000585ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #6734

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.84 KB 41.56 KB -281 B -0.67%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 549μs 2.62μs 10.5μs 0.543 0 0 41.47 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 3.34μs 13.8μs 0.324 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 878μs 3.73μs 13.9μs 8.19 2.59 0.431 53.32 KB
#6734 WriteAndFlushEnrichedTraces net6.0 578μs 2.86μs 12.2μs 0.568 0 0 41.66 KB
#6734 WriteAndFlushEnrichedTraces netcoreapp3.1 708μs 3.99μs 28.2μs 0.342 0 0 41.56 KB
#6734 WriteAndFlushEnrichedTraces net472 834μs 3.82μs 14.8μs 8.45 2.53 0.422 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 1.28ns 4.97ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.82μs 1.88ns 7.28ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.12μs 1.29ns 4.81ns 0.156 0.00106 0 987 B
#6734 ExecuteNonQuery net6.0 1.36μs 1.66ns 6.42ns 0.0143 0 0 1.02 KB
#6734 ExecuteNonQuery netcoreapp3.1 1.73μs 1.58ns 6.13ns 0.0138 0 0 1.02 KB
#6734 ExecuteNonQuery net472 2.07μs 1.08ns 3.91ns 0.157 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.26μs 0.7ns 2.62ns 0.0139 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 3.3ns 12.3ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.47μs 0.758ns 2.73ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.24μs 1.08ns 4.18ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 1.06ns 3.95ns 0.0131 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1ns 3.62ns 0.166 0 0 1.05 KB
#6734 CallElasticsearch net6.0 1.2μs 0.602ns 2.33ns 0.0135 0 0 976 B
#6734 CallElasticsearch netcoreapp3.1 1.59μs 0.389ns 1.46ns 0.0127 0 0 976 B
#6734 CallElasticsearch net472 2.45μs 1.36ns 4.91ns 0.157 0 0 995 B
#6734 CallElasticsearchAsync net6.0 1.33μs 0.515ns 1.93ns 0.0134 0 0 952 B
#6734 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.592ns 2.14ns 0.0137 0 0 1.02 KB
#6734 CallElasticsearchAsync net472 2.61μs 1.55ns 5.58ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 1.58ns 5.9ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.69μs 1.57ns 6.08ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.85μs 0.672ns 2.6ns 0.145 0 0 915 B
#6734 ExecuteAsync net6.0 1.29μs 0.583ns 2.18ns 0.0135 0 0 952 B
#6734 ExecuteAsync netcoreapp3.1 1.74μs 0.492ns 1.77ns 0.013 0 0 952 B
#6734 ExecuteAsync net472 1.88μs 0.723ns 2.8ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.36μs 1.04ns 3.75ns 0.0325 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.22μs 2.2ns 7.94ns 0.0393 0 0 2.85 KB
master SendAsync net472 7.45μs 2.36ns 9.15ns 0.492 0 0 3.12 KB
#6734 SendAsync net6.0 4.3μs 1.31ns 4.9ns 0.0323 0 0 2.31 KB
#6734 SendAsync netcoreapp3.1 5.55μs 5.25ns 20.3ns 0.0389 0 0 2.85 KB
#6734 SendAsync net472 7.33μs 2.39ns 9.27ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.781ns 3.03ns 0.0234 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.14μs 5.9ns 22.9ns 0.0223 0 0 1.64 KB
master EnrichedLog net472 2.63μs 2.01ns 7.8ns 0.25 0 0 1.57 KB
#6734 EnrichedLog net6.0 1.5μs 0.654ns 2.45ns 0.0233 0 0 1.64 KB
#6734 EnrichedLog netcoreapp3.1 2.14μs 1.01ns 3.76ns 0.0224 0 0 1.64 KB
#6734 EnrichedLog net472 2.6μs 1.05ns 4.06ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 158ns 612ns 0.0563 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 179ns 692ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 211ns 817ns 0.668 0.223 0 4.46 KB
#6734 EnrichedLog net6.0 114μs 118ns 458ns 0.0571 0 0 4.28 KB
#6734 EnrichedLog netcoreapp3.1 119μs 157ns 606ns 0 0 0 4.28 KB
#6734 EnrichedLog net472 150μs 140ns 541ns 0.67 0.223 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.9μs 0.691ns 2.59ns 0.0318 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.16μs 3.18ns 11.5ns 0.029 0 0 2.2 KB
master EnrichedLog net472 5.01μs 1.69ns 6.54ns 0.32 0 0 2.02 KB
#6734 EnrichedLog net6.0 2.96μs 1.31ns 5.07ns 0.0311 0 0 2.2 KB
#6734 EnrichedLog netcoreapp3.1 4.16μs 1.52ns 5.47ns 0.0291 0 0 2.2 KB
#6734 EnrichedLog net472 4.88μs 1.3ns 4.85ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 0.605ns 2.34ns 0.0156 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.74μs 0.624ns 2.41ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.11μs 1.34ns 5.2ns 0.183 0 0 1.16 KB
#6734 SendReceive net6.0 1.44μs 0.974ns 3.64ns 0.0158 0 0 1.14 KB
#6734 SendReceive netcoreapp3.1 1.91μs 0.773ns 2.99ns 0.0152 0 0 1.14 KB
#6734 SendReceive net472 1.99μs 2.7ns 10.5ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.74μs 0.565ns 2.19ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.9μs 2.99ns 11.6ns 0.0216 0 0 1.65 KB
master EnrichedLog net472 4.46μs 2.17ns 8.11ns 0.324 0 0 2.04 KB
#6734 EnrichedLog net6.0 2.75μs 9.28ns 35.9ns 0.0218 0 0 1.6 KB
#6734 EnrichedLog netcoreapp3.1 3.81μs 2.93ns 11ns 0.0211 0 0 1.65 KB
#6734 EnrichedLog net472 4.16μs 4.02ns 15.6ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6734

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.178 392.08 461.97
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.157 588.48 680.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 392ns 0.434ns 1.68ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 606ns 1.38ns 5.36ns 0.0079 0 0 576 B
master StartFinishSpan net472 589ns 0.892ns 3.46ns 0.0916 0 0 578 B
master StartFinishScope net6.0 481ns 0.798ns 3.09ns 0.00986 0 0 696 B
master StartFinishScope netcoreapp3.1 725ns 1.74ns 6.72ns 0.00921 0 0 696 B
master StartFinishScope net472 842ns 1.98ns 7.67ns 0.104 0 0 658 B
#6734 StartFinishSpan net6.0 463ns 0.635ns 2.46ns 0.00804 0 0 576 B
#6734 StartFinishSpan netcoreapp3.1 623ns 1.34ns 5.2ns 0.00792 0 0 576 B
#6734 StartFinishSpan net472 683ns 1.85ns 7.18ns 0.0916 0 0 578 B
#6734 StartFinishScope net6.0 479ns 0.649ns 2.43ns 0.00984 0 0 696 B
#6734 StartFinishScope netcoreapp3.1 746ns 1.76ns 6.83ns 0.00948 0 0 696 B
#6734 StartFinishScope net472 817ns 1.58ns 5.91ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6734

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.210 614.88 743.84

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 615ns 1.18ns 4.58ns 0.00981 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 922ns 1.49ns 5.78ns 0.00937 0 0 696 B
master RunOnMethodBegin net472 1.06μs 2.1ns 8.12ns 0.104 0 0 658 B
#6734 RunOnMethodBegin net6.0 744ns 0.542ns 1.96ns 0.00962 0 0 696 B
#6734 RunOnMethodBegin netcoreapp3.1 918ns 1.46ns 5.46ns 0.00957 0 0 696 B
#6734 RunOnMethodBegin net472 1.12μs 3.35ns 13ns 0.104 0 0 658 B

andrewlock avatar Mar 03 '25 19:03 andrewlock

Closing as stale, bot can always reopen the next time

bouwkast avatar Oct 03 '25 17:10 bouwkast

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Oct 03 '25 17:10 dependabot[bot]