dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Baggage part 3/3: add public api to `Datadog.Trace.Manual`

Open lucaspimentel opened this issue 1 year ago • 4 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

lucaspimentel avatar Oct 23 '24 17:10 lucaspimentel

  • #6190 Graphite 👈
  • #6258 Graphite
  • master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lucaspimentel and the rest of your teammates on Graphite Graphite

lucaspimentel avatar Oct 23 '24 17:10 lucaspimentel

Datadog Report

Branch report: lpimentel/baggage-datadog-api-3 Commit report: 2423329 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 364484 Passed, 2062 Skipped, 14h 51m 7.23s Total Time

datadog-ddstaging[bot] avatar Oct 23 '24 18:10 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (69ms)  : 68, 71
     .   : milestone, 69,
    master - mean (70ms)  : 68, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (1,113ms)  : 1095, 1131
     .   : milestone, 1113,
    master - mean (1,125ms)  : 1072, 1177
     .   : milestone, 1125,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (770ms)  : 753, 787
     .   : milestone, 770,
    master - mean (782ms)  : 767, 796
     .   : milestone, 782,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (728ms)  : 713, 743
     .   : milestone, 728,
    master - mean (750ms)  : 683, 817
     .   : milestone, 750,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (190ms)  : 185, 194
     .   : milestone, 190,
    master - mean (190ms)  : 186, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (1,230ms)  : 1209, 1251
     .   : milestone, 1230,
    master - mean (1,228ms)  : 1203, 1253
     .   : milestone, 1228,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (949ms)  : 934, 965
     .   : milestone, 949,
    master - mean (951ms)  : 937, 965
     .   : milestone, 951,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6190) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6190) - mean (931ms)  : 912, 949
     .   : milestone, 931,
    master - mean (936ms)  : 916, 957
     .   : milestone, 936,

andrewlock avatar Oct 23 '24 18:10 andrewlock

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (11.093M)   : 0, 11093153
    master (10.993M)   : 0, 10993209
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6190) (7.135M)   : 0, 7135446
    master (7.203M)   : 0, 7203027
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.503M)   : 0, 7502500

    section Manual
    master (11.115M)   : 0, 11115249

    section Manual + Automatic
    This PR (6190) (6.657M)   : 0, 6656905
    master (6.650M)   : 0, 6649770

    section DD_TRACE_ENABLED=0
    master (10.379M)   : 0, 10378918


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (9.379M)   : 0, 9378538
    master (9.396M)   : 0, 9395989
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6190) (6.489M)   : 0, 6489402
    master (6.432M)   : 0, 6432181

    section Trace stats
    master (6.826M)   : 0, 6826388

    section Manual
    master (9.596M)   : 0, 9595811

    section Manual + Automatic
    This PR (6190) (5.868M)   : 0, 5868255
    master (6.016M)   : 0, 6015725

    section DD_TRACE_ENABLED=0
    master (8.730M)   : 0, 8730305


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6190) (9.843M)   : 0, 9843320
    master (9.836M)   : 0, 9835977
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6190) (6.323M)   : 0, 6323449
    master (6.334M)   : 0, 6333662
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.012M)   : 0, 7011750

    section Manual
    master (9.898M)   : 0, 9897743

    section Manual + Automatic
    This PR (6190) (6.017M)   : 0, 6017446
    master (5.778M)   : 0, 5777929

    section DD_TRACE_ENABLED=0
    master (9.111M)   : 0, 9110736

andrewlock avatar Oct 23 '24 20:10 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6190 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.171
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.2μs 45.3ns 264ns 0.0118 0.00393 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 58.7ns 447ns 0.0214 0.0107 0 5.8 KB
master StartStopWithChild net472 16.5μs 38.9ns 151ns 1.04 0.301 0.0919 6.21 KB
#6190 StartStopWithChild net6.0 8μs 45ns 298ns 0.012 0.00401 0 5.61 KB
#6190 StartStopWithChild netcoreapp3.1 10.2μs 46.3ns 179ns 0.0263 0.0105 0 5.8 KB
#6190 StartStopWithChild net472 16.6μs 65.7ns 254ns 1.02 0.291 0.083 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 457μs 441ns 1.71μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 260ns 973ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 848μs 347ns 1.25μs 0.419 0 0 3.3 KB
#6190 WriteAndFlushEnrichedTraces net6.0 470μs 198ns 741ns 0 0 0 2.7 KB
#6190 WriteAndFlushEnrichedTraces netcoreapp3.1 646μs 408ns 1.58μs 0 0 0 2.7 KB
#6190 WriteAndFlushEnrichedTraces net472 847μs 393ns 1.47μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 198μs 1.15μs 9.58μs 0.195 0 0 18.73 KB
master SendRequest netcoreapp3.1 214μs 1.08μs 4.93μs 0.213 0 0 20.89 KB
master SendRequest net472 0.00101ns 0.000372ns 0.00144ns 0 0 0 0 b
#6190 SendRequest net6.0 196μs 1.09μs 7.23μs 0.187 0 0 18.73 KB
#6190 SendRequest netcoreapp3.1 216μs 1.21μs 8.75μs 0.209 0 0 20.89 KB
#6190 SendRequest net472 0.0015ns 0.000437ns 0.00169ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 568μs 2.51μs 9.06μs 0.548 0.274 0 41.45 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 3.47μs 15.5μs 0.342 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 892μs 4.37μs 18.5μs 8.42 2.66 0.443 53.32 KB
#6190 WriteAndFlushEnrichedTraces net6.0 548μs 2.39μs 9.57μs 0.556 0 0 41.61 KB
#6190 WriteAndFlushEnrichedTraces netcoreapp3.1 688μs 3.4μs 17.3μs 0.331 0 0 41.74 KB
#6190 WriteAndFlushEnrichedTraces net472 866μs 3.2μs 12.4μs 8.39 2.52 0.419 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.24μs 0.65ns 2.34ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 1.36ns 4.7ns 0.0139 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.45ns 5.44ns 0.157 0.00102 0 987 B
#6190 ExecuteNonQuery net6.0 1.24μs 1.12ns 4.34ns 0.0142 0 0 1.02 KB
#6190 ExecuteNonQuery netcoreapp3.1 1.8μs 1.68ns 6.52ns 0.0134 0 0 1.02 KB
#6190 ExecuteNonQuery net472 2.05μs 1.24ns 4.48ns 0.156 0.00102 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6190

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.117 1,271.29 1,420.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 1.38ns 5.16ns 0.014 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.62μs 0.574ns 2.15ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.5μs 2.36ns 9.14ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.27μs 0.703ns 2.72ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 0.741ns 2.87ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.67μs 1.94ns 7.5ns 0.166 0 0 1.05 KB
#6190 CallElasticsearch net6.0 1.26μs 0.536ns 2.01ns 0.0139 0 0 976 B
#6190 CallElasticsearch netcoreapp3.1 1.6μs 0.747ns 2.79ns 0.0128 0 0 976 B
#6190 CallElasticsearch net472 2.52μs 1.29ns 4.66ns 0.157 0 0 995 B
#6190 CallElasticsearchAsync net6.0 1.42μs 0.915ns 3.54ns 0.0135 0 0 952 B
#6190 CallElasticsearchAsync netcoreapp3.1 1.65μs 3.01ns 11.3ns 0.0135 0 0 1.02 KB
#6190 CallElasticsearchAsync net472 2.51μs 0.859ns 3.21ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6190

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.206 1,219.34 1,470.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 0.394ns 1.36ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.815ns 3.16ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.69μs 1.63ns 6.32ns 0.145 0 0 915 B
#6190 ExecuteAsync net6.0 1.48μs 4.49ns 17.4ns 0.0132 0 0 952 B
#6190 ExecuteAsync netcoreapp3.1 1.67μs 0.893ns 3.34ns 0.0126 0 0 952 B
#6190 ExecuteAsync net472 1.77μs 0.56ns 2.09ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.58μs 1.32ns 4.77ns 0.0321 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.26μs 1.28ns 4.8ns 0.0369 0 0 2.85 KB
master SendAsync net472 7.78μs 2.72ns 10.5ns 0.494 0 0 3.12 KB
#6190 SendAsync net6.0 4.33μs 2.9ns 10.8ns 0.0324 0 0 2.31 KB
#6190 SendAsync netcoreapp3.1 5.17μs 2.02ns 7.3ns 0.0388 0 0 2.85 KB
#6190 SendAsync net472 7.44μs 2.22ns 8.3ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.58μs 0.577ns 2.16ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.18μs 0.857ns 3.21ns 0.022 0 0 1.64 KB
master EnrichedLog net472 2.66μs 1.47ns 5.08ns 0.25 0 0 1.57 KB
#6190 EnrichedLog net6.0 1.53μs 0.919ns 3.44ns 0.0231 0 0 1.64 KB
#6190 EnrichedLog netcoreapp3.1 2.23μs 1.3ns 5.02ns 0.0221 0 0 1.64 KB
#6190 EnrichedLog net472 2.69μs 2.21ns 8.57ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 119μs 104ns 391ns 0.0588 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 124μs 469ns 1.81μs 0 0 0 4.28 KB
master EnrichedLog net472 156μs 222ns 860ns 0.706 0.235 0 4.46 KB
#6190 EnrichedLog net6.0 116μs 245ns 882ns 0.0576 0 0 4.28 KB
#6190 EnrichedLog netcoreapp3.1 121μs 136ns 508ns 0 0 0 4.28 KB
#6190 EnrichedLog net472 154μs 148ns 572ns 0.695 0.232 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.31ns 5.07ns 0.031 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.14μs 0.817ns 2.83ns 0.0289 0 0 2.2 KB
master EnrichedLog net472 4.92μs 1.16ns 4.17ns 0.321 0 0 2.02 KB
#6190 EnrichedLog net6.0 3.15μs 0.936ns 3.5ns 0.0298 0 0 2.2 KB
#6190 EnrichedLog netcoreapp3.1 4.21μs 1.48ns 5.72ns 0.0294 0 0 2.2 KB
#6190 EnrichedLog net472 5μs 1.06ns 4.12ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.429ns 1.66ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.83μs 0.845ns 3.27ns 0.0156 0 0 1.14 KB
master SendReceive net472 2.15μs 0.992ns 3.84ns 0.183 0 0 1.16 KB
#6190 SendReceive net6.0 1.4μs 0.779ns 3.02ns 0.0162 0 0 1.14 KB
#6190 SendReceive netcoreapp3.1 1.81μs 1.16ns 4.5ns 0.0154 0 0 1.14 KB
#6190 SendReceive net472 2.22μs 2.29ns 8.86ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.82μs 5.35ns 20.7ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.67ns 6.45ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.33μs 5.36ns 19.3ns 0.323 0 0 2.04 KB
#6190 EnrichedLog net6.0 2.74μs 1.37ns 5.31ns 0.0219 0 0 1.6 KB
#6190 EnrichedLog netcoreapp3.1 3.84μs 1.9ns 7.12ns 0.0211 0 0 1.65 KB
#6190 EnrichedLog net472 4.31μs 1.66ns 6.21ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 410ns 0.186ns 0.721ns 0.00804 0 0 576 B
master StartFinishSpan netcoreapp3.1 563ns 0.322ns 1.21ns 0.00783 0 0 576 B
master StartFinishSpan net472 701ns 0.974ns 3.64ns 0.0915 0 0 578 B
master StartFinishScope net6.0 517ns 0.475ns 1.84ns 0.00989 0 0 696 B
master StartFinishScope netcoreapp3.1 729ns 0.632ns 2.45ns 0.00936 0 0 696 B
master StartFinishScope net472 854ns 0.698ns 2.61ns 0.104 0 0 658 B
#6190 StartFinishSpan net6.0 420ns 0.196ns 0.735ns 0.00807 0 0 576 B
#6190 StartFinishSpan netcoreapp3.1 616ns 0.345ns 1.33ns 0.00778 0 0 576 B
#6190 StartFinishSpan net472 743ns 0.899ns 3.48ns 0.0918 0 0 578 B
#6190 StartFinishScope net6.0 543ns 0.425ns 1.65ns 0.00978 0 0 696 B
#6190 StartFinishScope netcoreapp3.1 775ns 1.56ns 5.82ns 0.00921 0 0 696 B
#6190 StartFinishScope net472 917ns 0.516ns 2ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6190

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.193 649.63 774.87

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 649ns 0.313ns 1.17ns 0.00979 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 998ns 0.786ns 3.04ns 0.00948 0 0 696 B
master RunOnMethodBegin net472 1.18μs 0.603ns 2.25ns 0.104 0 0 658 B
#6190 RunOnMethodBegin net6.0 776ns 0.451ns 1.75ns 0.0097 0 0 696 B
#6190 RunOnMethodBegin netcoreapp3.1 912ns 0.489ns 1.89ns 0.0092 0 0 696 B
#6190 RunOnMethodBegin net472 1.18μs 0.333ns 1.29ns 0.104 0 0 658 B

andrewlock avatar Oct 24 '24 02:10 andrewlock

Merge activity

  • Nov 12, 10:00 AM EST: A user merged this pull request with Graphite.

lucaspimentel avatar Nov 12 '24 15:11 lucaspimentel