Fixed build in docker
TestNativeWrapper was failing when building in docker on the dev machine. The changes in this PR allows ignoring symbol versions and adds support for weak_alias
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (72ms) : 64, 79
. : milestone, 72,
master - mean (71ms) : 64, 78
. : milestone, 71,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (1,107ms) : 1090, 1124
. : milestone, 1107,
master - mean (1,111ms) : 1093, 1129
. : milestone, 1111,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (108ms) : 106, 110
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (773ms) : 732, 814
. : milestone, 773,
master - mean (767ms) : 754, 780
. : milestone, 767,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (91ms) : 89, 93
. : milestone, 91,
master - mean (91ms) : 89, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (723ms) : 708, 738
. : milestone, 723,
master - mean (724ms) : 709, 739
. : milestone, 724,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (192ms) : 185, 198
. : milestone, 192,
master - mean (191ms) : 186, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (1,214ms) : 1187, 1242
. : milestone, 1214,
master - mean (1,211ms) : 1189, 1233
. : milestone, 1211,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (276ms) : 272, 281
. : milestone, 276,
master - mean (277ms) : 272, 281
. : milestone, 277,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (942ms) : 922, 963
. : milestone, 942,
master - mean (944ms) : 924, 964
. : milestone, 944,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6107) - mean (266ms) : 262, 270
. : milestone, 266,
master - mean (265ms) : 261, 269
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6107) - mean (932ms) : 911, 952
. : milestone, 932,
master - mean (927ms) : 903, 950
. : milestone, 927,
Datadog Report
Branch report: kr-igor/fix-native-wrapper-symbols
Commit report: 8b13ab0
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 65826 Passed, 181 Skipped, 1h 4m 13.42s Total Time
Benchmarks Report for tracer :snail:
Benchmarks for #6107 compared to master:
- 1 benchmarks are faster, with geometric mean 1.144
- 2 benchmarks are slower, with geometric mean 1.128
- All benchmarks have the same allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 7.83μs | 40.8ns | 238ns | 0.0195 | 0.00781 | 0 | 5.61 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 10.4μs | 55.8ns | 306ns | 0.0203 | 0.0102 | 0 | 5.8 KB |
| master | StartStopWithChild |
net472 | 16.3μs | 29.6ns | 111ns | 1.04 | 0.307 | 0.097 | 6.21 KB |
| #6107 | StartStopWithChild |
net6.0 | 8μs | 42.7ns | 230ns | 0.0197 | 0.00787 | 0 | 5.61 KB |
| #6107 | StartStopWithChild |
netcoreapp3.1 | 10.3μs | 54.7ns | 294ns | 0.0146 | 0.00487 | 0 | 5.8 KB |
| #6107 | StartStopWithChild |
net472 | 16.3μs | 46ns | 178ns | 1.04 | 0.304 | 0.104 | 6.22 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 490μs | 357ns | 1.34μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 668μs | 209ns | 782ns | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 866μs | 374ns | 1.45μs | 0.428 | 0 | 0 | 3.3 KB |
| #6107 | WriteAndFlushEnrichedTraces |
net6.0 | 497μs | 1.03μs | 3.85μs | 0 | 0 | 0 | 2.7 KB |
| #6107 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 660μs | 481ns | 1.86μs | 0 | 0 | 0 | 2.7 KB |
| #6107 | WriteAndFlushEnrichedTraces |
net472 | 869μs | 431ns | 1.61μs | 0.437 | 0 | 0 | 3.3 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 201μs | 1.17μs | 10.6μs | 0.197 | 0 | 0 | 18.73 KB |
| master | SendRequest |
netcoreapp3.1 | 225μs | 1.3μs | 11.6μs | 0.21 | 0 | 0 | 20.89 KB |
| master | SendRequest |
net472 | 0.00045ns | 0.00029ns | 0.00108ns | 0 | 0 | 0 | 0 b |
| #6107 | SendRequest |
net6.0 | 196μs | 1.11μs | 7.34μs | 0.191 | 0 | 0 | 18.73 KB |
| #6107 | SendRequest |
netcoreapp3.1 | 219μs | 1.21μs | 9.42μs | 0.227 | 0 | 0 | 20.89 KB |
| #6107 | SendRequest |
net472 | 0.000529ns | 0.000343ns | 0.00133ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 589μs | 3.35μs | 23.5μs | 0.584 | 0 | 0 | 41.67 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 672μs | 3.56μs | 18.5μs | 0.334 | 0 | 0 | 41.64 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 868μs | 3.04μs | 11.8μs | 8.25 | 2.6 | 0.434 | 53.31 KB |
| #6107 | WriteAndFlushEnrichedTraces |
net6.0 | 593μs | 3.26μs | 20.6μs | 0.61 | 0 | 0 | 41.68 KB |
| #6107 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 705μs | 3.61μs | 16.2μs | 0.357 | 0 | 0 | 41.63 KB |
| #6107 | WriteAndFlushEnrichedTraces |
net472 | 877μs | 4.18μs | 17.8μs | 8.08 | 2.55 | 0.425 | 53.35 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.2μs | 0.821ns | 3.07ns | 0.0139 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 1.73μs | 1.6ns | 5.78ns | 0.0139 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.14μs | 1.23ns | 4.61ns | 0.156 | 0.00106 | 0 | 987 B |
| #6107 | ExecuteNonQuery |
net6.0 | 1.31μs | 1.14ns | 4.41ns | 0.0138 | 0 | 0 | 1.02 KB |
| #6107 | ExecuteNonQuery |
netcoreapp3.1 | 1.7μs | 1.66ns | 6.44ns | 0.0135 | 0 | 0 | 1.02 KB |
| #6107 | ExecuteNonQuery |
net472 | 1.96μs | 1.45ns | 5.62ns | 0.156 | 0.000976 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:
Slower :warning: in #6107
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0
1.114
1,224.12
1,363.48
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.2μs | 0.724ns | 2.8ns | 0.0138 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.54μs | 0.808ns | 3.02ns | 0.0136 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.63μs | 2.53ns | 9.46ns | 0.157 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.22μs | 0.701ns | 2.72ns | 0.0135 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.65μs | 1.1ns | 4.27ns | 0.0141 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.57μs | 2.01ns | 7.77ns | 0.166 | 0 | 0 | 1.05 KB |
| #6107 | CallElasticsearch |
net6.0 | 1.12μs | 0.313ns | 1.17ns | 0.0135 | 0 | 0 | 976 B |
| #6107 | CallElasticsearch |
netcoreapp3.1 | 1.58μs | 1.02ns | 3.82ns | 0.0128 | 0 | 0 | 976 B |
| #6107 | CallElasticsearch |
net472 | 2.54μs | 3.11ns | 12ns | 0.158 | 0 | 0 | 995 B |
| #6107 | CallElasticsearchAsync |
net6.0 | 1.36μs | 0.52ns | 1.95ns | 0.0129 | 0 | 0 | 952 B |
| #6107 | CallElasticsearchAsync |
netcoreapp3.1 | 1.59μs | 0.99ns | 3.7ns | 0.0136 | 0 | 0 | 1.02 KB |
| #6107 | CallElasticsearchAsync |
net472 | 2.62μs | 2.01ns | 7.8ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #6107
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0
1.144
1,327.53
1,160.40
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.33μs | 0.442ns | 1.59ns | 0.0132 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.69μs | 0.699ns | 2.61ns | 0.0127 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.81μs | 0.357ns | 1.33ns | 0.145 | 0 | 0 | 915 B |
| #6107 | ExecuteAsync |
net6.0 | 1.16μs | 0.277ns | 1.04ns | 0.0134 | 0 | 0 | 952 B |
| #6107 | ExecuteAsync |
netcoreapp3.1 | 1.58μs | 0.648ns | 2.34ns | 0.0129 | 0 | 0 | 952 B |
| #6107 | ExecuteAsync |
net472 | 1.82μs | 1.37ns | 5.13ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.32μs | 1.05ns | 4.06ns | 0.0324 | 0 | 0 | 2.31 KB |
| master | SendAsync |
netcoreapp3.1 | 5.32μs | 2.12ns | 8.22ns | 0.0374 | 0 | 0 | 2.85 KB |
| master | SendAsync |
net472 | 7.32μs | 1.83ns | 7.09ns | 0.494 | 0 | 0 | 3.12 KB |
| #6107 | SendAsync |
net6.0 | 4.24μs | 1.44ns | 5.4ns | 0.0321 | 0 | 0 | 2.31 KB |
| #6107 | SendAsync |
netcoreapp3.1 | 5.37μs | 2.52ns | 9.74ns | 0.0374 | 0 | 0 | 2.85 KB |
| #6107 | SendAsync |
net472 | 7.34μs | 1.92ns | 7.17ns | 0.496 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.54μs | 1.14ns | 4.25ns | 0.0231 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.15μs | 1.58ns | 5.93ns | 0.0224 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.54μs | 1.37ns | 5.29ns | 0.249 | 0 | 0 | 1.57 KB |
| #6107 | EnrichedLog |
net6.0 | 1.45μs | 0.719ns | 2.59ns | 0.0232 | 0 | 0 | 1.64 KB |
| #6107 | EnrichedLog |
netcoreapp3.1 | 2.2μs | 1.16ns | 4.51ns | 0.0221 | 0 | 0 | 1.64 KB |
| #6107 | EnrichedLog |
net472 | 2.57μs | 1.18ns | 4.58ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 121μs | 115ns | 446ns | 0.0608 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 123μs | 92.9ns | 360ns | 0.0621 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 151μs | 143ns | 553ns | 0.678 | 0.226 | 0 | 4.46 KB |
| #6107 | EnrichedLog |
net6.0 | 121μs | 204ns | 788ns | 0 | 0 | 0 | 4.28 KB |
| #6107 | EnrichedLog |
netcoreapp3.1 | 124μs | 176ns | 683ns | 0 | 0 | 0 | 4.28 KB |
| #6107 | EnrichedLog |
net472 | 150μs | 121ns | 469ns | 0.672 | 0.224 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 3.06μs | 1.23ns | 4.62ns | 0.0307 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.17μs | 1.15ns | 4.32ns | 0.0292 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 4.95μs | 1.38ns | 5.35ns | 0.319 | 0 | 0 | 2.02 KB |
| #6107 | EnrichedLog |
net6.0 | 3.02μs | 1.07ns | 3.99ns | 0.0303 | 0 | 0 | 2.2 KB |
| #6107 | EnrichedLog |
netcoreapp3.1 | 4.05μs | 2.1ns | 8.15ns | 0.0283 | 0 | 0 | 2.2 KB |
| #6107 | EnrichedLog |
net472 | 4.92μs | 0.801ns | 3.1ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.43μs | 1.32ns | 5.1ns | 0.0158 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.69μs | 1.8ns | 6.96ns | 0.0153 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.05μs | 2.4ns | 8.97ns | 0.183 | 0 | 0 | 1.16 KB |
| #6107 | SendReceive |
net6.0 | 1.34μs | 1.73ns | 6.7ns | 0.0157 | 0 | 0 | 1.14 KB |
| #6107 | SendReceive |
netcoreapp3.1 | 1.76μs | 2.99ns | 11.9ns | 0.016 | 0 | 0 | 1.14 KB |
| #6107 | SendReceive |
net472 | 2.11μs | 2.66ns | 10.3ns | 0.184 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.79μs | 1.2ns | 4.64ns | 0.0223 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.92μs | 1.89ns | 7.31ns | 0.0216 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.43μs | 1.58ns | 6.12ns | 0.322 | 0 | 0 | 2.04 KB |
| #6107 | EnrichedLog |
net6.0 | 2.61μs | 0.72ns | 2.69ns | 0.0222 | 0 | 0 | 1.6 KB |
| #6107 | EnrichedLog |
netcoreapp3.1 | 3.87μs | 8.07ns | 31.3ns | 0.0212 | 0 | 0 | 1.65 KB |
| #6107 | EnrichedLog |
net472 | 4.47μs | 4.29ns | 16.6ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:
Slower :warning: in #6107
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1
1.142
659.19
752.75
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 409ns | 0.383ns | 1.49ns | 0.00797 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 606ns | 0.632ns | 2.37ns | 0.00759 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 637ns | 0.714ns | 2.76ns | 0.0916 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 477ns | 0.337ns | 1.31ns | 0.00975 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 659ns | 0.415ns | 1.55ns | 0.00931 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 874ns | 1.53ns | 5.93ns | 0.104 | 0 | 0 | 658 B |
| #6107 | StartFinishSpan |
net6.0 | 394ns | 0.188ns | 0.729ns | 0.00801 | 0 | 0 | 576 B |
| #6107 | StartFinishSpan |
netcoreapp3.1 | 607ns | 1.27ns | 4.91ns | 0.00764 | 0 | 0 | 576 B |
| #6107 | StartFinishSpan |
net472 | 649ns | 0.592ns | 2.29ns | 0.0917 | 0 | 0 | 578 B |
| #6107 | StartFinishScope |
net6.0 | 481ns | 0.431ns | 1.67ns | 0.00966 | 0 | 0 | 696 B |
| #6107 | StartFinishScope |
netcoreapp3.1 | 752ns | 1.02ns | 3.95ns | 0.00941 | 0 | 0 | 696 B |
| #6107 | StartFinishScope |
net472 | 901ns | 1.1ns | 3.8ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 637ns | 0.705ns | 2.73ns | 0.00964 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 926ns | 1.02ns | 3.83ns | 0.00937 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.11μs | 0.658ns | 2.55ns | 0.104 | 0 | 0 | 658 B |
| #6107 | RunOnMethodBegin |
net6.0 | 654ns | 0.399ns | 1.49ns | 0.00981 | 0 | 0 | 696 B |
| #6107 | RunOnMethodBegin |
netcoreapp3.1 | 947ns | 1.07ns | 4.16ns | 0.00912 | 0 | 0 | 696 B |
| #6107 | RunOnMethodBegin |
net472 | 1.12μs | 0.933ns | 3.61ns | 0.104 | 0 | 0 | 658 B |
Throughput/Crank Report :zap:
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6107) (11.207M) : 0, 11207182
master (11.088M) : 0, 11087997
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6107) (7.193M) : 0, 7192726
master (7.189M) : 0, 7189433
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.540M) : 0, 7540032
section Manual
master (10.979M) : 0, 10978609
section Manual + Automatic
This PR (6107) (6.768M) : 0, 6767516
master (6.705M) : 0, 6704874
section DD_TRACE_ENABLED=0
master (10.210M) : 0, 10210338
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6107) (9.486M) : 0, 9485843
master (9.281M) : 0, 9280802
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6107) (6.057M) : 0, 6057055
master (6.361M) : 0, 6360955
section Trace stats
master (6.592M) : 0, 6591771
section Manual
master (9.244M) : 0, 9244472
section Manual + Automatic
This PR (6107) (5.742M) : 0, 5741893
master (5.916M) : 0, 5915508
section DD_TRACE_ENABLED=0
master (8.775M) : 0, 8774768
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6107) (10.134M) : 0, 10134273
master (9.738M) : 0, 9737778
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6107) (6.300M) : 0, 6300126
master (6.366M) : 0, 6366399
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (6.991M) : 0, 6990849
section Manual
master (9.876M) : 0, 9876192
section Manual + Automatic
This PR (6107) (5.765M) : 0, 5764673
master (5.693M) : 0, 5692584
section DD_TRACE_ENABLED=0
master (9.017M) : 0, 9017039
Could you show the failure in a bit more detail pls, there's no reason this should fail in docker locally afaik, assuming you're building with the correct docker images... And if you're not, just don't run this target 😉
I'm using a custom Debian image. You can check the Dockerfile here. That image is used to build the tracer from master (or any other branch) on every change in that repo and re-deploy all DSM test applications.
None of the images in this repo worked for me (some failed locally, some failed during CI build), but maybe I was using the wrong ones. If you can point me to the image which works I'd be happy to use it instead.
The problem I see with the test is that it seems like NM returns "symbol versions" by default. Cutting versions off seems safe, since the golden file contains no versions. Alternatively I could add --without-symbol-versions to make sure the behavior is consistent. Here's the output:
426.4 14:49:11 [DBG] NM output: 00000000000200b0 D DdDotnetFolder
426.4 00000000000200b8 D DdDotnetMuslFolder
426.4 w _ITM_deregisterTMCloneTable
426.4 w _ITM_registerTMCloneTable
426.4 w __cxa_finalize@GLIBC_2.17
426.4 U __errno_location@GLIBC_2.17
426.4 U __getauxval@GLIBC_2.17
426.4 w __gmon_start__
426.4 w __libc_dlopen_mode
426.4 w __libc_dlsym
426.4 00000000000021ec T accept
426.4 00000000000022b4 T accept4
426.4 U access@GLIBC_2.17
426.4 000000000000146c T appendToPath
426.4 U asprintf@GLIBC_2.17
426.4 00000000000026fc T connect
426.4 00000000000200e0 B crashHandler
426.4 0000000000001304 T dd_inside_wrapped_functions
426.4 0000000000001ad8 T dd_nb_calls_to_dlopen_dlclose
426.4 0000000000020188 B dd_set_shared_memory
426.4 0000000000001a50 T dl_iterate_phdr
426.4 00000000000013c4 T dladdr
426.4 0000000000001b80 T dlclose
426.4 0000000000001ae8 T dlopen
426.4 w dlsym@GLIBC_2.34
426.4 0000000000001cb4 T execve
426.4 U free@GLIBC_2.17
426.4 0000000000000000 B functions_entered_counter
426.4 00000000000014d8 T getFolder
426.4 000000000000133c T getLibraryPath
426.4 0000000000001544 T getSubfolder
426.4 U getenv@GLIBC_2.17
426.4 00000000000015d4 T initLibrary
426.4 0000000000001444 T isAlpine
426.4 U malloc@GLIBC_2.17
426.4 0000000000002124 T poll
426.4 w pthread_once@GLIBC_2.34
426.4 000000000000238c T recv
426.4 0000000000002464 T recvfrom
426.4 000000000000261c T recvmmsg
426.4 0000000000002554 T recvmsg
426.4 0000000000002044 T select
426.4 00000000000027c4 T send
426.4 000000000000298c T sendmsg
426.4 000000000000289c T sendto
426.4 U strcasecmp@GLIBC_2.17
426.4 U strcmp@GLIBC_2.17
426.4 U strcpy@GLIBC_2.17
426.4 U strlen@GLIBC_2.17
426.4 U strncmp@GLIBC_2.17
426.4 U strncpy@GLIBC_2.17
426.4 U strrchr@GLIBC_2.17
Diff
426.5 System.Exception: Found differences in undefined symbols (access
426.5 asprintf
426.5 free
426.5 getauxval
426.5 getenv
426.5 malloc
426.5 strcasecmp
426.5 strcmp
426.5 strcpy
426.5 strlen
426.5 strncmp
426.5 strncpy
426.5 strrchr,@GLIBC_2.17
426.5 __getauxval@GLIBC_2.17
426.5 access@GLIBC_2.17
426.5 asprintf@GLIBC_2.17
426.5 free@GLIBC_2.17
426.5 getenv@GLIBC_2.17
426.5 malloc@GLIBC_2.17
426.5 strcasecmp@GLIBC_2.17
426.5 strcmp@GLIBC_2.17
426.5 strcpy@GLIBC_2.17
426.5 strlen@GLIBC_2.17
426.5 strncmp@GLIBC_2.17
426.5 strncpy@GLIBC_2.17
426.5 strrchr@GLIBC_2.17