dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Dynamic Instrumentation] DEBUG-2256 Do not create ProbeProcessor when LiveDebugger isn't fully initialized

Open dudikeleti opened this issue 1 year ago • 1 comments

Summary of changes

ProbeProcessor can be inialized from various places and it do a low of work. If the LiveDebugger isn't fully initialized, it useless to create it. This PR verify this.

dudikeleti avatar Sep 27 '24 11:09 dudikeleti

Datadog Report

Branch report: dudik/probeprocessor-guard Commit report: 8eaf465 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 463153 Passed, 3672 Skipped, 32h 33m 11.03s Total Time

datadog-ddstaging[bot] avatar Sep 27 '24 11:09 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (980ms)  : 958, 1002
     .   : milestone, 980,
    master - mean (978ms)  : 956, 1000
     .   : milestone, 978,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (109ms)  : 106, 111
     .   : milestone, 109,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (685ms)  : 671, 698
     .   : milestone, 685,
    master - mean (681ms)  : 666, 696
     .   : milestone, 681,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (92ms)  : 90, 93
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (639ms)  : 621, 656
     .   : milestone, 639,
    master - mean (635ms)  : 619, 651
     .   : milestone, 635,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (1,100ms)  : 1077, 1124
     .   : milestone, 1100,
    master - mean (1,100ms)  : 1070, 1131
     .   : milestone, 1100,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (278ms)  : 273, 284
     .   : milestone, 278,
    master - mean (279ms)  : 275, 284
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (880ms)  : 853, 907
     .   : milestone, 880,
    master - mean (879ms)  : 857, 901
     .   : milestone, 879,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6092) - mean (268ms)  : 264, 273
     .   : milestone, 268,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6092) - mean (863ms)  : 829, 897
     .   : milestone, 863,
    master - mean (858ms)  : 828, 889
     .   : milestone, 858,

andrewlock avatar Nov 15 '24 00:11 andrewlock

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (11.091M)   : 0, 11090980
    master (11.088M)   : 0, 11088184
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6092) (7.298M)   : 0, 7298075
    master (7.254M)   : 0, 7254128
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.516M)   : 0, 7515745

    section Manual
    master (11.014M)   : 0, 11013989

    section Manual + Automatic
    This PR (6092) (6.667M)   : 0, 6666880
    master (6.700M)   : 0, 6700166

    section DD_TRACE_ENABLED=0
    master (10.228M)   : 0, 10228208


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.571M)   : 0, 9571282
    master (9.438M)   : 0, 9438272
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6092) (6.391M)   : 0, 6390833
    master (6.384M)   : 0, 6384110

    section Trace stats
    master (6.758M)   : 0, 6758045

    section Manual
    master (9.394M)   : 0, 9393606

    section Manual + Automatic
    This PR (6092) (5.776M)   : 0, 5775908
    master (6.041M)   : 0, 6040522

    section DD_TRACE_ENABLED=0
    master (8.691M)   : 0, 8690632


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6092) (9.829M)   : 0, 9828854
    master (9.438M)   : 0, 9438032
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6092) (6.252M)   : 0, 6252406
    master (6.073M)   : 0, 6073208
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.747M)   : 0, 6747095

    section Manual
    master (9.357M)   : 0, 9356938

    section Manual + Automatic
    This PR (6092) (5.640M)   : 0, 5639575
    master (5.605M)   : 0, 5604930

    section DD_TRACE_ENABLED=0
    master (8.787M)   : 0, 8787187

andrewlock avatar Nov 15 '24 02:11 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6092 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.230
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.06μs 45.1ns 282ns 0.0128 0.00426 0 5.62 KB
master StartStopWithChild netcoreapp3.1 10.2μs 56.9ns 368ns 0.0199 0.00995 0 5.8 KB
master StartStopWithChild net472 16.6μs 31.1ns 120ns 1.05 0.318 0.0977 6.21 KB
#6092 StartStopWithChild net6.0 8.01μs 45.2ns 306ns 0.0122 0.00406 0 5.61 KB
#6092 StartStopWithChild netcoreapp3.1 10.2μs 57.4ns 389ns 0.0204 0.0102 0 5.8 KB
#6092 StartStopWithChild net472 16.2μs 60.2ns 233ns 1.05 0.316 0.105 6.22 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 495μs 963ns 3.6μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 440ns 1.65μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 850μs 759ns 2.94μs 0.425 0 0 3.3 KB
#6092 WriteAndFlushEnrichedTraces net6.0 498μs 159ns 595ns 0 0 0 2.7 KB
#6092 WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 309ns 1.2μs 0 0 0 2.7 KB
#6092 WriteAndFlushEnrichedTraces net472 844μs 238ns 857ns 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 143μs 821ns 6.67μs 0.204 0 0 14.47 KB
master SendRequest netcoreapp3.1 167μs 952ns 6.99μs 0.168 0 0 17.27 KB
master SendRequest net472 0.000879ns 0.000548ns 0.00205ns 0 0 0 0 b
#6092 SendRequest net6.0 146μs 816ns 5.35μs 0.142 0 0 14.47 KB
#6092 SendRequest netcoreapp3.1 169μs 940ns 8.3μs 0.158 0 0 17.27 KB
#6092 SendRequest net472 0.00577ns 0.00197ns 0.00762ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 549μs 1.63μs 6.3μs 0.539 0 0 41.69 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 3.26μs 15.3μs 0.322 0 0 41.83 KB
master WriteAndFlushEnrichedTraces net472 811μs 2.79μs 10.8μs 8.41 2.4 0.401 53.31 KB
#6092 WriteAndFlushEnrichedTraces net6.0 548μs 2.89μs 14.2μs 0.53 0 0 41.63 KB
#6092 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 2.36μs 9.14μs 0.324 0 0 41.86 KB
#6092 WriteAndFlushEnrichedTraces net472 855μs 3.99μs 16μs 8.69 2.48 0.414 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.22μs 1.41ns 4.9ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 1.78ns 6.88ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 1.67ns 6.26ns 0.157 0.00102 0 987 B
#6092 ExecuteNonQuery net6.0 1.27μs 0.977ns 3.79ns 0.0145 0 0 1.02 KB
#6092 ExecuteNonQuery netcoreapp3.1 1.77μs 0.969ns 3.75ns 0.014 0 0 1.02 KB
#6092 ExecuteNonQuery net472 1.98μs 1.87ns 7.01ns 0.156 0.00099 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.21μs 0.585ns 2.19ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.6μs 0.726ns 2.62ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.64μs 2.81ns 10.9ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.27μs 1.02ns 3.94ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 1.45ns 5.61ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 2.82ns 10.9ns 0.167 0 0 1.05 KB
#6092 CallElasticsearch net6.0 1.2μs 0.73ns 2.73ns 0.0136 0 0 976 B
#6092 CallElasticsearch netcoreapp3.1 1.57μs 2.51ns 9.73ns 0.0132 0 0 976 B
#6092 CallElasticsearch net472 2.5μs 1.27ns 4.74ns 0.158 0 0 995 B
#6092 CallElasticsearchAsync net6.0 1.38μs 0.995ns 3.85ns 0.0138 0 0 952 B
#6092 CallElasticsearchAsync netcoreapp3.1 1.63μs 0.786ns 2.94ns 0.0138 0 0 1.02 KB
#6092 CallElasticsearchAsync net472 2.6μs 0.747ns 2.79ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.903ns 3.38ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.67μs 2.14ns 8.3ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.83μs 0.913ns 3.54ns 0.145 0 0 915 B
#6092 ExecuteAsync net6.0 1.3μs 0.614ns 2.3ns 0.0131 0 0 952 B
#6092 ExecuteAsync netcoreapp3.1 1.64μs 1.76ns 6.81ns 0.0128 0 0 952 B
#6092 ExecuteAsync net472 1.87μs 0.616ns 2.39ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.41μs 2.23ns 8.64ns 0.0311 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.21μs 2.25ns 8.71ns 0.039 0 0 2.85 KB
master SendAsync net472 7.4μs 3.34ns 12.5ns 0.493 0 0 3.12 KB
#6092 SendAsync net6.0 4.36μs 2.68ns 10ns 0.0327 0 0 2.31 KB
#6092 SendAsync netcoreapp3.1 5.42μs 3.25ns 12.2ns 0.0378 0 0 2.85 KB
#6092 SendAsync net472 7.34μs 2.91ns 11.3ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.811ns 3.14ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 1.34ns 5.18ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.59μs 0.893ns 3.34ns 0.25 0 0 1.57 KB
#6092 EnrichedLog net6.0 1.47μs 0.709ns 2.65ns 0.0232 0 0 1.64 KB
#6092 EnrichedLog netcoreapp3.1 2.35μs 0.915ns 3.42ns 0.0224 0 0 1.64 KB
#6092 EnrichedLog net472 2.59μs 1.08ns 4.19ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 120μs 206ns 772ns 0.0604 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 123μs 198ns 766ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 238ns 921ns 0.678 0.226 0 4.46 KB
#6092 EnrichedLog net6.0 120μs 228ns 881ns 0 0 0 4.28 KB
#6092 EnrichedLog netcoreapp3.1 125μs 85.9ns 333ns 0 0 0 4.28 KB
#6092 EnrichedLog net472 151μs 149ns 577ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.9μs 1.35ns 5.24ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.2μs 2.7ns 10.4ns 0.0295 0 0 2.2 KB
master EnrichedLog net472 4.96μs 2.4ns 9.31ns 0.319 0 0 2.02 KB
#6092 EnrichedLog net6.0 2.96μs 1.98ns 7.68ns 0.0303 0 0 2.2 KB
#6092 EnrichedLog netcoreapp3.1 4.16μs 2.24ns 8.39ns 0.029 0 0 2.2 KB
#6092 EnrichedLog net472 4.8μs 2.57ns 9.93ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.976ns 3.78ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 1.17ns 4.52ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.13μs 1.98ns 7.69ns 0.183 0 0 1.16 KB
#6092 SendReceive net6.0 1.44μs 0.445ns 1.72ns 0.016 0 0 1.14 KB
#6092 SendReceive netcoreapp3.1 1.85μs 2.26ns 8.77ns 0.0157 0 0 1.14 KB
#6092 SendReceive net472 2.19μs 3ns 11.6ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.73μs 1.19ns 4.61ns 0.0219 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.87μs 1.43ns 5.54ns 0.0213 0 0 1.65 KB
master EnrichedLog net472 4.4μs 2.39ns 8.95ns 0.323 0 0 2.04 KB
#6092 EnrichedLog net6.0 2.73μs 0.896ns 3.47ns 0.0217 0 0 1.6 KB
#6092 EnrichedLog netcoreapp3.1 3.91μs 1.66ns 6.42ns 0.0213 0 0 1.65 KB
#6092 EnrichedLog net472 4.6μs 3.39ns 12.7ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6092

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.230 815.27 662.65

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 411ns 0.249ns 0.965ns 0.00806 0 0 576 B
master StartFinishSpan netcoreapp3.1 617ns 0.321ns 1.24ns 0.00771 0 0 576 B
master StartFinishSpan net472 663ns 0.26ns 1.01ns 0.0916 0 0 578 B
master StartFinishScope net6.0 498ns 0.251ns 0.971ns 0.00965 0 0 696 B
master StartFinishScope netcoreapp3.1 810ns 2.1ns 8.14ns 0.00929 0 0 696 B
master StartFinishScope net472 883ns 0.606ns 2.35ns 0.104 0 0 658 B
#6092 StartFinishSpan net6.0 409ns 0.269ns 1.04ns 0.00801 0 0 576 B
#6092 StartFinishSpan netcoreapp3.1 618ns 0.664ns 2.57ns 0.00775 0 0 576 B
#6092 StartFinishSpan net472 682ns 0.521ns 2.02ns 0.0916 0 0 578 B
#6092 StartFinishScope net6.0 501ns 0.47ns 1.69ns 0.00982 0 0 696 B
#6092 StartFinishScope netcoreapp3.1 663ns 0.513ns 1.92ns 0.00928 0 0 696 B
#6092 StartFinishScope net472 884ns 0.776ns 3ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 671ns 0.36ns 1.39ns 0.00981 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 950ns 1.09ns 4.23ns 0.00906 0 0 696 B
master RunOnMethodBegin net472 1.15μs 1.07ns 4.15ns 0.105 0 0 658 B
#6092 RunOnMethodBegin net6.0 671ns 0.474ns 1.77ns 0.00976 0 0 696 B
#6092 RunOnMethodBegin netcoreapp3.1 990ns 0.527ns 1.97ns 0.0094 0 0 696 B
#6092 RunOnMethodBegin net472 1.19μs 0.697ns 2.7ns 0.104 0 0 658 B

andrewlock avatar Nov 15 '24 03:11 andrewlock