dd-trace-dotnet Bump Fody from 6.8.1 to 6.8.2 in /tracer/src/Datadog.Trace

Bumps Fody from 6.8.1 to 6.8.2.

Release notes

6.8.2

What's Changed

Bump xunit from 2.8.1 to 2.9.0 by @dependabot in Fody/Fody#1281

Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 by @dependabot in Fody/Fody#1282

Bump Microsoft.NET.Test.Sdk from 17.9.0 to 17.10.0 by @dependabot in Fody/Fody#1272

Add folder name to test weaver by @GeertvanHorrik in Fody/Fody#1298

Full Changelog: https://github.com/Fody/Fody/compare/6.8.1...6.8.2

Commits

9c90354 V 6.8.2
0713ecf Merge pull request #1298 from Fody/feature/1297-weaving-helper
967a5e7 Change order of parameters
6445808 Add folder name
cd4299e Bump Microsoft.NET.Test.Sdk from 17.9.0 to 17.10.0 (#1272)
b6adc12 Bump xunit.runner.visualstudio from 2.8.1 to 2.8.2 (#1282)
45f66a7 Bump xunit from 2.8.1 to 2.9.0 (#1281)
2466f34 Update dependencies
See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Sep 16 '24 16:09 dependabot[bot]

Datadog Report

Branch report: dependabot/nuget/tracer/src/Datadog.Trace/Fody-6.8.2 Commit report: c1a5947 Test service: dd-trace-dotnet

:x: 2 Failed (0 Known Flaky), 362373 Passed, 2044 Skipped, 15h 15m 9.66s Total Time

:x: Failed Tests (2)

OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Details
Expand for error
```
xpected boolean to be true, but found False.
```
OnSupportedFrameworkInSsi_CallsForwarderWithExpectedTelemetry - Datadog.Trace.ClrProfiler.IntegrationTests.InstrumentationTests - Details
Expand for error
```
xpected boolean to be true, but found False.
```

Sep 16 '24 17:09 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (1,115ms)  : 1088, 1142
     .   : milestone, 1115,
    master - mean (1,117ms)  : 1090, 1144
     .   : milestone, 1117,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (109ms)  : 105, 114
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (809ms)  : 791, 826
     .   : milestone, 809,
    master - mean (812ms)  : 784, 840
     .   : milestone, 812,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (92ms)  : 87, 97
     .   : milestone, 92,
    master - mean (93ms)  : 88, 99
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (762ms)  : 741, 783
     .   : milestone, 762,
    master - mean (764ms)  : 739, 788
     .   : milestone, 764,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (1,199ms)  : 1166, 1231
     .   : milestone, 1199,
    master - mean (1,194ms)  : 1172, 1217
     .   : milestone, 1194,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (277ms)  : 272, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (963ms)  : 939, 987
     .   : milestone, 963,
    master - mean (969ms)  : 949, 989
     .   : milestone, 969,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6039) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (265ms)  : 260, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6039) - mean (944ms)  : 917, 970
     .   : milestone, 944,
    master - mean (946ms)  : 922, 970
     .   : milestone, 946,

Sep 16 '24 17:09 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6039 compared to master:

All benchmarks have the same speed
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.78μs	44.5ns	324ns	0.0112	0.00374	0	5.43 KB
master	`StartStopWithChild`	netcoreapp3.1	9.85μs	43.4ns	157ns	0.0143	0.00476	0	5.62 KB
master	`StartStopWithChild`	net472	16.1μs	33ns	123ns	1.03	0.313	0.102	6.06 KB
#6039	`StartStopWithChild`	net6.0	7.65μs	39.3ns	176ns	0.0186	0.00743	0	5.42 KB
#6039	`StartStopWithChild`	netcoreapp3.1	9.88μs	51.9ns	259ns	0.0251	0.01	0	5.62 KB
#6039	`StartStopWithChild`	net472	15.9μs	37.3ns	144ns	1.02	0.299	0.0865	6.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	481μs	158ns	549ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	625μs	304ns	1.18μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	342ns	1.33μs	0.419	3.3 KB
#6039	`WriteAndFlushEnrichedTraces`	net6.0	469μs	148ns	534ns	0	2.7 KB
#6039	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	638μs	375ns	1.45μs	0	2.7 KB
#6039	`WriteAndFlushEnrichedTraces`	net472	851μs	804ns	3.01μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	203μs	1.17μs	9.62μs	0.197	18.45 KB
master	`SendRequest`	netcoreapp3.1	225μs	1.29μs	9.79μs	0.216	20.61 KB
master	`SendRequest`	net472	0.00235ns	0.000752ns	0.00291ns	0	0 b
#6039	`SendRequest`	net6.0	199μs	1.16μs	9.88μs	0.199	18.45 KB
#6039	`SendRequest`	netcoreapp3.1	225μs	1.31μs	11.5μs	0.208	20.61 KB
#6039	`SendRequest`	net472	0.000405ns	0.000225ns	0.000841ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	562μs	2.9μs	16.2μs	0.558	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	697μs	3.34μs	13.8μs	0.326	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	net472	862μs	2.83μs	11μs	8.45	2.53	0.422	53.29 KB
#6039	`WriteAndFlushEnrichedTraces`	net6.0	574μs	2.4μs	8.98μs	0.282	0	0	41.66 KB
#6039	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	671μs	2.69μs	9.72μs	0.332	0	0	41.77 KB
#6039	`WriteAndFlushEnrichedTraces`	net472	840μs	2.26μs	8.77μs	8.22	2.47	0.411	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.27μs	0.95ns	3.68ns	0.014	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.73μs	1.25ns	4.84ns	0.0131	1.02 KB
master	`ExecuteNonQuery`	net472	2.04μs	2.14ns	8.31ns	0.156	987 B
#6039	`ExecuteNonQuery`	net6.0	1.3μs	0.905ns	3.51ns	0.0144	1.02 KB
#6039	`ExecuteNonQuery`	netcoreapp3.1	1.72μs	1.66ns	6.22ns	0.0138	1.02 KB
#6039	`ExecuteNonQuery`	net472	2.08μs	3.06ns	11.4ns	0.157	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	0.454ns	1.7ns	0.0136	0	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.56μs	1.79ns	6.7ns	0.0132	0	976 B
master	`CallElasticsearch`	net472	2.61μs	2.1ns	8.13ns	0.158	0.0013	995 B
master	`CallElasticsearchAsync`	net6.0	1.35μs	0.955ns	3.58ns	0.0135	0	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.65μs	0.667ns	2.41ns	0.0133	0	1.02 KB
master	`CallElasticsearchAsync`	net472	2.64μs	1.14ns	4.11ns	0.166	0.00133	1.05 KB
#6039	`CallElasticsearch`	net6.0	1.15μs	0.34ns	1.23ns	0.0135	0	976 B
#6039	`CallElasticsearch`	netcoreapp3.1	1.63μs	0.785ns	2.94ns	0.0131	0	976 B
#6039	`CallElasticsearch`	net472	2.41μs	2.03ns	7.85ns	0.158	0	995 B
#6039	`CallElasticsearchAsync`	net6.0	1.22μs	0.312ns	1.21ns	0.0134	0	952 B
#6039	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.636ns	2.46ns	0.0143	0	1.02 KB
#6039	`CallElasticsearchAsync`	net472	2.55μs	1.89ns	7.32ns	0.166	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.27μs	1.22ns	4.71ns	0.0133	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.62μs	0.891ns	3.21ns	0.0129	952 B
master	`ExecuteAsync`	net472	1.82μs	2.47ns	9.55ns	0.145	915 B
#6039	`ExecuteAsync`	net6.0	1.21μs	0.471ns	1.76ns	0.0133	952 B
#6039	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.527ns	1.9ns	0.013	952 B
#6039	`ExecuteAsync`	net472	1.78μs	0.692ns	2.68ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.15μs	0.911ns	3.29ns	0.0312	2.22 KB
master	`SendAsync`	netcoreapp3.1	5.2μs	20.1ns	78ns	0.036	2.76 KB
master	`SendAsync`	net472	7.84μs	1.8ns	6.98ns	0.496	3.15 KB
#6039	`SendAsync`	net6.0	4.24μs	1.57ns	6.1ns	0.0295	2.22 KB
#6039	`SendAsync`	netcoreapp3.1	5.12μs	2.59ns	9.69ns	0.0358	2.76 KB
#6039	`SendAsync`	net472	7.9μs	1.73ns	6.01ns	0.498	3.15 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.43μs	0.752ns	2.81ns	0.0229	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	1.17ns	4.36ns	0.0225	1.64 KB
master	`EnrichedLog`	net472	2.53μs	0.603ns	2.26ns	0.25	1.57 KB
#6039	`EnrichedLog`	net6.0	1.44μs	0.699ns	2.71ns	0.0231	1.64 KB
#6039	`EnrichedLog`	netcoreapp3.1	2.29μs	1.02ns	3.97ns	0.0222	1.64 KB
#6039	`EnrichedLog`	net472	2.59μs	1.41ns	5.09ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	165ns	594ns	0.0572	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	98.7ns	382ns	0.0589	0	4.28 KB
master	`EnrichedLog`	net472	145μs	54.4ns	211ns	0.654	0.218	4.46 KB
#6039	`EnrichedLog`	net6.0	113μs	104ns	361ns	0.0562	0	4.28 KB
#6039	`EnrichedLog`	netcoreapp3.1	119μs	294ns	1.14μs	0.0587	0	4.28 KB
#6039	`EnrichedLog`	net472	146μs	123ns	475ns	0.657	0.219	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.35ns	5.05ns	0.0305	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.31μs	1.12ns	4.36ns	0.0302	2.2 KB
master	`EnrichedLog`	net472	4.89μs	0.944ns	3.66ns	0.32	2.02 KB
#6039	`EnrichedLog`	net6.0	2.93μs	0.723ns	2.8ns	0.0308	2.2 KB
#6039	`EnrichedLog`	netcoreapp3.1	4.21μs	4.55ns	17.6ns	0.0296	2.2 KB
#6039	`EnrichedLog`	net472	4.98μs	1.38ns	5.34ns	0.318	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.38μs	0.582ns	2.18ns	0.0159	0	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	0.981ns	3.8ns	0.015	0	1.14 KB
master	`SendReceive`	net472	2.07μs	1.26ns	4.86ns	0.183	0.00103	1.16 KB
#6039	`SendReceive`	net6.0	1.28μs	0.542ns	2.1ns	0.016	0	1.14 KB
#6039	`SendReceive`	netcoreapp3.1	1.85μs	0.88ns	3.41ns	0.0147	0	1.14 KB
#6039	`SendReceive`	net472	2.11μs	0.882ns	3.42ns	0.184	0.00105	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.69μs	10.2ns	39.3ns	0.0225	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	4.03μs	1.14ns	4.41ns	0.0221	1.65 KB
master	`EnrichedLog`	net472	4.38μs	3.19ns	12.3ns	0.322	2.04 KB
#6039	`EnrichedLog`	net6.0	2.78μs	0.852ns	3.19ns	0.0223	1.6 KB
#6039	`EnrichedLog`	netcoreapp3.1	3.96μs	1.43ns	5.55ns	0.0218	1.65 KB
#6039	`EnrichedLog`	net472	4.22μs	3.81ns	14.8ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	412ns	0.227ns	0.819ns	0.00803	576 B
master	`StartFinishSpan`	netcoreapp3.1	579ns	0.265ns	0.99ns	0.00795	576 B
master	`StartFinishSpan`	net472	679ns	0.578ns	2.24ns	0.0918	578 B
master	`StartFinishScope`	net6.0	508ns	0.277ns	1.07ns	0.0097	696 B
master	`StartFinishScope`	netcoreapp3.1	704ns	0.446ns	1.67ns	0.00933	696 B
master	`StartFinishScope`	net472	856ns	1.78ns	6.89ns	0.104	658 B
#6039	`StartFinishSpan`	net6.0	411ns	0.148ns	0.573ns	0.0081	576 B
#6039	`StartFinishSpan`	netcoreapp3.1	558ns	0.553ns	2.14ns	0.00789	576 B
#6039	`StartFinishSpan`	net472	677ns	0.854ns	3.31ns	0.0917	578 B
#6039	`StartFinishScope`	net6.0	499ns	0.362ns	1.4ns	0.0097	696 B
#6039	`StartFinishScope`	netcoreapp3.1	730ns	0.478ns	1.79ns	0.00959	696 B
#6039	`StartFinishScope`	net472	886ns	0.589ns	2.28ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	653ns	0.484ns	1.88ns	0.00979	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	895ns	4.29ns	17.1ns	0.00925	696 B
master	`RunOnMethodBegin`	net472	1.12μs	1.12ns	4.33ns	0.104	658 B
#6039	`RunOnMethodBegin`	net6.0	657ns	0.779ns	3.02ns	0.00956	696 B
#6039	`RunOnMethodBegin`	netcoreapp3.1	934ns	0.339ns	1.31ns	0.00928	696 B
#6039	`RunOnMethodBegin`	net472	1.02μs	0.91ns	3.4ns	0.104	658 B

Sep 16 '24 22:09 andrewlock

Superseded by #6304.

Nov 18 '24 17:11 dependabot[bot]