dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Tracing] Update parsing validation for OTEL_SDK_DISABLED

Open zacharycmontoya opened this issue 1 year ago • 4 comments

Summary of changes

Consider both "true" and "false" valid values for the OTEL_SDK_DISABLED in terms of our metric reporting

Reason for change

This change is motivated by enforcing standardized behaviors in our tracers in our system-tests

Implementation details

Test coverage

Other details

zacharycmontoya avatar Sep 11 '24 19:09 zacharycmontoya

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (70ms)  : 66, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (1,115ms)  : 1092, 1139
     .   : milestone, 1115,
    master - mean (1,115ms)  : 1101, 1128
     .   : milestone, 1115,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (108ms)  : 105, 112
     .   : milestone, 108,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (813ms)  : 800, 827
     .   : milestone, 813,
    master - mean (815ms)  : 801, 829
     .   : milestone, 815,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (93ms)  : 89, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (770ms)  : 754, 785
     .   : milestone, 770,
    master - mean (767ms)  : 750, 783
     .   : milestone, 767,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (207ms)  : 200, 214
     .   : milestone, 207,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (1,445ms)  : crit, 1272, 1619
     .   : crit, milestone, 1445,
    master - mean (1,195ms)  : 1169, 1220
     .   : milestone, 1195,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (284ms)  : 278, 289
     .   : milestone, 284,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (1,003ms)  : 982, 1025
     .   : milestone, 1003,
    master - mean (975ms)  : 952, 998
     .   : milestone, 975,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6023) - mean (272ms)  : 266, 277
     .   : milestone, 272,
    master - mean (265ms)  : 261, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6023) - mean (959ms)  : 926, 992
     .   : milestone, 959,
    master - mean (961ms)  : 937, 985
     .   : milestone, 961,

andrewlock avatar Sep 11 '24 20:09 andrewlock

Datadog Report

Branch report: zach.montoya/fix-otel-env-metric Commit report: 063ac80 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 361660 Passed, 2056 Skipped, 15h 11m 53.38s Total Time

datadog-ddstaging[bot] avatar Sep 11 '24 20:09 datadog-ddstaging[bot]

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6023) (11.303M)   : 0, 11303286
    master (11.058M)   : 0, 11058270
    benchmarks/2.9.0 (11.185M)   : 0, 11185492

    section Automatic
    This PR (6023) (7.481M)   : 0, 7481499
    master (7.433M)   : 0, 7433068
    benchmarks/2.9.0 (7.935M)   : 0, 7934520

    section Trace stats
    master (7.639M)   : 0, 7639043

    section Manual
    master (11.001M)   : 0, 11001149

    section Manual + Automatic
    This PR (6023) (7.006M)   : 0, 7006289
    master (6.890M)   : 0, 6889686

    section DD_TRACE_ENABLED=0
    master (10.219M)   : 0, 10219072


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6023) (9.665M)   : 0, 9665078
    master (9.512M)   : 0, 9512187
    benchmarks/2.9.0 (9.560M)   : 0, 9559569

    section Automatic
    This PR (6023) (6.690M)   : 0, 6689549
    master (6.599M)   : 0, 6598948

    section Trace stats
    master (6.877M)   : 0, 6877069

    section Manual
    master (9.582M)   : 0, 9582301

    section Manual + Automatic
    This PR (6023) (6.115M)   : 0, 6114735
    master (6.227M)   : 0, 6227256

    section DD_TRACE_ENABLED=0
    master (8.944M)   : 0, 8943787


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6023) (10.141M)   : 0, 10140817
    master (9.874M)   : 0, 9873927
    benchmarks/2.9.0 (10.118M)   : 0, 10117626

    section Automatic
    This PR (6023) (6.894M)   : 0, 6893663
    master (6.609M)   : 0, 6609340
    benchmarks/2.9.0 (7.416M)   : 0, 7415715

    section Trace stats
    master (7.330M)   : 0, 7329885

    section Manual
    master (10.106M)   : 0, 10106430

    section Manual + Automatic
    This PR (6023) (6.482M)   : 0, 6482488
    master (6.122M)   : 0, 6122215

    section DD_TRACE_ENABLED=0
    master (9.295M)   : 0, 9294721

andrewlock avatar Sep 11 '24 20:09 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6023 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.168
  • 2 benchmarks are slower, with geometric mean 1.123
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.72μs 44.4ns 336ns 0.0162 0.0081 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.56μs 51.6ns 278ns 0.0193 0.00965 0 5.62 KB
master StartStopWithChild net472 16.1μs 41.6ns 161ns 1.02 0.296 0.0961 6.07 KB
#6023 StartStopWithChild net6.0 7.65μs 37.5ns 215ns 0.0225 0.0113 0.00375 5.43 KB
#6023 StartStopWithChild netcoreapp3.1 9.83μs 54.6ns 375ns 0.0192 0.00958 0 5.61 KB
#6023 StartStopWithChild net472 16μs 63.6ns 246ns 1.01 0.291 0.0865 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 470μs 225ns 871ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 338ns 1.27μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 831μs 470ns 1.82μs 0.411 0 0 3.3 KB
#6023 WriteAndFlushEnrichedTraces net6.0 464μs 308ns 1.19μs 0 0 0 2.7 KB
#6023 WriteAndFlushEnrichedTraces netcoreapp3.1 618μs 268ns 1.04μs 0 0 0 2.7 KB
#6023 WriteAndFlushEnrichedTraces net472 845μs 425ns 1.59μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 197μs 1.14μs 9.9μs 0.194 0 0 18.45 KB
master SendRequest netcoreapp3.1 219μs 1.25μs 9.68μs 0.233 0 0 20.61 KB
master SendRequest net472 0.0281ns 0.0116ns 0.0567ns 0 0 0 0 b
#6023 SendRequest net6.0 202μs 1.18μs 10.8μs 0.194 0 0 18.45 KB
#6023 SendRequest netcoreapp3.1 226μs 1.3μs 10.3μs 0.214 0 0 20.61 KB
#6023 SendRequest net472 0.000383ns 0.000298ns 0.00115ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 561μs 2.72μs 11.9μs 0.283 0 0 41.57 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 2.66μs 9.95μs 0.349 0 0 41.57 KB
master WriteAndFlushEnrichedTraces net472 871μs 4.63μs 24.9μs 8.87 2.53 0.422 53.33 KB
#6023 WriteAndFlushEnrichedTraces net6.0 559μs 3.11μs 19.9μs 0.566 0 0 41.55 KB
#6023 WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 2.63μs 9.84μs 0.332 0 0 41.63 KB
#6023 WriteAndFlushEnrichedTraces net472 859μs 3.21μs 12.4μs 8.28 2.48 0.414 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.37μs 1.33ns 4.98ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.84μs 1.76ns 6.6ns 0.0137 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 1.96ns 7.33ns 0.156 0 0 987 B
#6023 ExecuteNonQuery net6.0 1.32μs 1.25ns 4.85ns 0.0146 0 0 1.02 KB
#6023 ExecuteNonQuery netcoreapp3.1 1.78μs 1.44ns 5.19ns 0.0134 0 0 1.02 KB
#6023 ExecuteNonQuery net472 2.14μs 4.73ns 18.3ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6023

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.119 1,146.16 1,282.16

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.15μs 0.737ns 2.76ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.739ns 2.86ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.45μs 2.6ns 10.1ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.34μs 1.53ns 5.93ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.54μs 1.1ns 4.13ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.45μs 1.7ns 6.59ns 0.167 0 0 1.05 KB
#6023 CallElasticsearch net6.0 1.28μs 1.04ns 3.75ns 0.0135 0 0 976 B
#6023 CallElasticsearch netcoreapp3.1 1.57μs 1.27ns 4.92ns 0.0133 0 0 976 B
#6023 CallElasticsearch net472 2.45μs 0.878ns 3.4ns 0.157 0 0 995 B
#6023 CallElasticsearchAsync net6.0 1.32μs 0.665ns 2.49ns 0.0131 0 0 952 B
#6023 CallElasticsearchAsync netcoreapp3.1 1.63μs 1.77ns 6.61ns 0.0138 0 0 1.02 KB
#6023 CallElasticsearchAsync net472 2.47μs 1.85ns 7.18ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6023

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.148 1,298.55 1,130.82

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.775ns 3ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 2.21ns 8.57ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.78μs 0.664ns 2.39ns 0.145 0 0 915 B
#6023 ExecuteAsync net6.0 1.13μs 0.646ns 2.5ns 0.0131 0 0 952 B
#6023 ExecuteAsync netcoreapp3.1 1.62μs 3.07ns 11.5ns 0.0131 0 0 952 B
#6023 ExecuteAsync net472 1.89μs 0.814ns 3.15ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 1.32ns 4.75ns 0.0299 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.04μs 2.25ns 8.7ns 0.0377 0 0 2.76 KB
master SendAsync net472 7.77μs 1.65ns 6.4ns 0.498 0 0 3.15 KB
#6023 SendAsync net6.0 4.17μs 2.25ns 8.1ns 0.0312 0 0 2.22 KB
#6023 SendAsync netcoreapp3.1 5.06μs 2.71ns 10.5ns 0.0355 0 0 2.76 KB
#6023 SendAsync net472 7.81μs 2.23ns 8.62ns 0.5 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.51μs 0.694ns 2.59ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.2μs 1.86ns 6.96ns 0.0224 0 0 1.64 KB
master EnrichedLog net472 2.81μs 2.45ns 9.16ns 0.249 0 0 1.57 KB
#6023 EnrichedLog net6.0 1.55μs 0.632ns 2.28ns 0.0233 0 0 1.64 KB
#6023 EnrichedLog netcoreapp3.1 2.07μs 0.919ns 3.56ns 0.0219 0 0 1.64 KB
#6023 EnrichedLog net472 2.61μs 0.84ns 3.14ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 153ns 594ns 0.0578 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 288ns 1.12μs 0 0 0 4.28 KB
master EnrichedLog net472 148μs 137ns 529ns 0.663 0.221 0 4.46 KB
#6023 EnrichedLog net6.0 116μs 161ns 622ns 0.0569 0 0 4.28 KB
#6023 EnrichedLog netcoreapp3.1 120μs 163ns 633ns 0.059 0 0 4.28 KB
#6023 EnrichedLog net472 148μs 152ns 588ns 0.664 0.221 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.14μs 0.559ns 2.02ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.13μs 1.27ns 4.93ns 0.0288 0 0 2.2 KB
master EnrichedLog net472 4.89μs 1.39ns 5.38ns 0.321 0 0 2.02 KB
#6023 EnrichedLog net6.0 2.94μs 0.902ns 3.5ns 0.0308 0 0 2.2 KB
#6023 EnrichedLog netcoreapp3.1 4.15μs 1.94ns 7.51ns 0.0289 0 0 2.2 KB
#6023 EnrichedLog net472 4.78μs 2.1ns 7.87ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.32μs 0.418ns 1.56ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 0.502ns 1.81ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.16μs 1.93ns 7.24ns 0.184 0.00109 0 1.16 KB
#6023 SendReceive net6.0 1.33μs 0.625ns 2.42ns 0.0158 0 0 1.14 KB
#6023 SendReceive netcoreapp3.1 1.83μs 0.881ns 3.3ns 0.0155 0 0 1.14 KB
#6023 SendReceive net472 2.04μs 1.13ns 4.4ns 0.183 0.00102 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6023

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SerilogBenchmark.EnrichedLog‑net6.0 1.135 2,930.18 2,582.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.93μs 0.521ns 1.95ns 0.022 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.89μs 1.93ns 7.46ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.34μs 2.47ns 9.56ns 0.322 0 0 2.04 KB
#6023 EnrichedLog net6.0 2.58μs 0.629ns 2.44ns 0.0221 0 0 1.6 KB
#6023 EnrichedLog netcoreapp3.1 3.79μs 1.39ns 5.19ns 0.0229 0 0 1.65 KB
#6023 EnrichedLog net472 4.26μs 1.71ns 6.42ns 0.324 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6023

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.127 392.43 442.09

Faster :tada: in #6023

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.224 811.79 663.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 392ns 0.242ns 0.936ns 0.00813 0 0 576 B
master StartFinishSpan netcoreapp3.1 577ns 1.62ns 5.85ns 0.00797 0 0 576 B
master StartFinishSpan net472 655ns 0.893ns 3.46ns 0.0917 0 0 578 B
master StartFinishScope net6.0 538ns 0.392ns 1.52ns 0.00965 0 0 696 B
master StartFinishScope netcoreapp3.1 812ns 0.641ns 2.48ns 0.00937 0 0 696 B
master StartFinishScope net472 820ns 0.766ns 2.97ns 0.104 0 0 658 B
#6023 StartFinishSpan net6.0 442ns 0.343ns 1.33ns 0.0081 0 0 576 B
#6023 StartFinishSpan netcoreapp3.1 546ns 0.256ns 0.959ns 0.00791 0 0 576 B
#6023 StartFinishSpan net472 635ns 0.526ns 2.04ns 0.0918 0 0 578 B
#6023 StartFinishScope net6.0 538ns 0.468ns 1.81ns 0.00971 0 0 696 B
#6023 StartFinishScope netcoreapp3.1 663ns 0.266ns 1.03ns 0.00931 0 0 696 B
#6023 StartFinishScope net472 878ns 0.904ns 3.5ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 587ns 0.573ns 2.22ns 0.00977 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 927ns 0.975ns 3.77ns 0.00922 0 0 696 B
master RunOnMethodBegin net472 1.09μs 1.44ns 5.59ns 0.104 0 0 658 B
#6023 RunOnMethodBegin net6.0 594ns 0.363ns 1.41ns 0.0098 0 0 696 B
#6023 RunOnMethodBegin netcoreapp3.1 881ns 0.427ns 1.65ns 0.00927 0 0 696 B
#6023 RunOnMethodBegin net472 1.11μs 1.19ns 4.62ns 0.104 0 0 658 B

andrewlock avatar Sep 11 '24 20:09 andrewlock