dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Set "component" tag for ASP.NET

Open bouwkast opened this issue 1 year ago • 9 comments

Summary of changes

Sets component tag for ASP.NET to aspnet

Reason for change

component tag was missing.

Implementation details

Add missing tag.

Test coverage

Lots of snapshots

Other details

bouwkast avatar Sep 09 '24 15:09 bouwkast

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (6010) - mean (68ms)  : 66, 71
     .   : milestone, 68,
    master - mean (69ms)  : 66, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,054ms)  : 993, 1115
     .   : milestone, 1054,
    master - mean (1,055ms)  : 991, 1120
     .   : milestone, 1055,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (106ms)  : 105, 107
     .   : milestone, 106,
    master - mean (106ms)  : 105, 108
     .   : milestone, 106,

    section Baseline
    This PR (6010) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (744ms)  : 721, 766
     .   : milestone, 744,
    master - mean (744ms)  : 722, 767
     .   : milestone, 744,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (100ms)  : 99, 101
     .   : milestone, 100,
    master - mean (100ms)  : 100, 101
     .   : milestone, 100,

    section Baseline
    This PR (6010) - mean (100ms)  : 97, 102
     .   : milestone, 100,
    master - mean (100ms)  : 97, 102
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (773ms)  : 723, 823
     .   : milestone, 773,
    master - mean (770ms)  : 719, 821
     .   : milestone, 770,


gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (92ms)  : 91, 93
     .   : milestone, 92,

    section Baseline
    This PR (6010) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (657ms)  : 644, 671
     .   : milestone, 657,
    master - mean (664ms)  : 649, 679
     .   : milestone, 664,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (201ms)  : 198, 205
     .   : milestone, 201,
    master - mean (202ms)  : 197, 207
     .   : milestone, 202,

    section Baseline
    This PR (6010) - mean (200ms)  : 193, 207
     .   : milestone, 200,
    master - mean (199ms)  : 192, 205
     .   : milestone, 199,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (1,190ms)  : 1123, 1257
     .   : milestone, 1190,
    master - mean (1,181ms)  : 1129, 1233
     .   : milestone, 1181,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (285ms)  : 279, 291
     .   : milestone, 285,
    master - mean (287ms)  : 277, 298
     .   : milestone, 287,

    section Baseline
    This PR (6010) - mean (285ms)  : 278, 292
     .   : milestone, 285,
    master - mean (286ms)  : 277, 294
     .   : milestone, 286,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (953ms)  : 913, 994
     .   : milestone, 953,
    master - mean (960ms)  : 921, 999
     .   : milestone, 960,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (288ms)  : 282, 293
     .   : milestone, 288,
    master - mean (289ms)  : 282, 296
     .   : milestone, 289,

    section Baseline
    This PR (6010) - mean (288ms)  : 280, 296
     .   : milestone, 288,
    master - mean (288ms)  : 280, 297
     .   : milestone, 288,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (998ms)  : 936, 1061
     .   : milestone, 998,
    master - mean (1,010ms)  : 956, 1064
     .   : milestone, 1010,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (6010) - mean (278ms)  : 273, 282
     .   : milestone, 278,
    master - mean (279ms)  : 270, 288
     .   : milestone, 279,

    section Baseline
    This PR (6010) - mean (278ms)  : 273, 283
     .   : milestone, 278,
    master - mean (277ms)  : 269, 284
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (6010) - mean (867ms)  : 840, 895
     .   : milestone, 867,
    master - mean (873ms)  : 848, 898
     .   : milestone, 873,

andrewlock avatar Sep 09 '24 15:09 andrewlock

Datadog Report

Branch report: steven/AIDM-312 Commit report: 4540146 Test service: dd-trace-dotnet

:x: 6 Failed (1 Known Flaky), 468894 Passed, 3265 Skipped, 28h 55m 43.35s Total Time

:x: Failed Tests (6)

This report shows up to 5 failed tests.

  • WriteAndFlushEnrichedTraces - Benchmarks.Trace.AgentWriterBenchmark - Details

  • SendRequest - Benchmarks.Trace.AspNetCoreBenchmark - Details

  • WriteAndFlushEnrichedTraces - Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Details

  • ExecuteNonQuery - Benchmarks.Trace.DbCommandBenchmark - Details

  • ManualAndAutomatic - Datadog.Trace.ClrProfiler.IntegrationTests.ManualInstrumentationTests - :snowflake: Known flaky - Details

    Expand for error 
    xpected exit code: 0, actual exit code: -2146233082.

datadog-ddstaging[bot] avatar Sep 09 '24 15:09 datadog-ddstaging[bot]

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (11.204M)   : 0, 11204202
    master (11.115M)   : 0, 11115307
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (6010) (7.293M)   : 0, 7293026
    master (7.335M)   : 0, 7334625
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.700M)   : 0, 7700429

    section Manual
    master (10.990M)   : 0, 10989510

    section Manual + Automatic
    This PR (6010) (6.869M)   : 0, 6869215
    master (6.780M)   : 0, 6780487

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305060


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.531M)   : 0, 9530910
    master (9.774M)   : 0, 9773727
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (6010) (6.474M)   : 0, 6474248
    master (6.463M)   : 0, 6462618

    section Trace stats
    master (6.907M)   : 0, 6906626

    section Manual
    master (9.697M)   : 0, 9697280

    section Manual + Automatic
    This PR (6010) (6.172M)   : 0, 6172072
    master (6.155M)   : 0, 6155472

    section DD_TRACE_ENABLED=0
    master (8.868M)   : 0, 8867528


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6010) (9.775M)   : 0, 9775351
    master (10.077M)   : 0, 10076675
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (6010) (6.472M)   : 0, 6472450
    master (6.567M)   : 0, 6566975
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.314M)   : 0, 7314135

    section Manual
    master (10.073M)   : 0, 10073436

    section Manual + Automatic
    This PR (6010) (6.103M)   : 0, 6103152
    master (6.134M)   : 0, 6134127

    section DD_TRACE_ENABLED=0
    master (9.536M)   : 0, 9535909

andrewlock avatar Sep 09 '24 17:09 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #6010 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.198
  • 1 benchmarks are slower, with geometric mean 1.134
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.86μs 37.4ns 191ns 0.0155 0.00777 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10μs 53.3ns 277ns 0.0145 0.00483 0 5.8 KB
master StartStopWithChild net472 15.8μs 35.3ns 132ns 1.03 0.293 0.0952 6.21 KB
#6010 StartStopWithChild net6.0 7.81μs 43.5ns 278ns 0.0204 0.0122 0.00407 5.61 KB
#6010 StartStopWithChild netcoreapp3.1 10.2μs 47.2ns 216ns 0.0155 0.00516 0 5.8 KB
#6010 StartStopWithChild net472 15.9μs 45.1ns 169ns 1.05 0.324 0.103 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 519μs 350ns 1.36μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 607ns 2.27μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 851μs 292ns 1.09μs 0.422 0 0 3.3 KB
#6010 WriteAndFlushEnrichedTraces net6.0 491μs 599ns 2.24μs 0 0 0 2.7 KB
#6010 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 218ns 786ns 0 0 0 2.7 KB
#6010 WriteAndFlushEnrichedTraces net472 845μs 461ns 1.79μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 131μs 529ns 2.05μs 0.132 0 0 14.47 KB
master SendRequest netcoreapp3.1 150μs 238ns 920ns 0.226 0 0 17.27 KB
master SendRequest net472 0.00515ns 0.00186ns 0.00721ns 0 0 0 0 b
#6010 SendRequest net6.0 129μs 663ns 2.97μs 0.13 0 0 14.47 KB
#6010 SendRequest netcoreapp3.1 145μs 357ns 1.38μs 0.216 0 0 17.27 KB
#6010 SendRequest net472 0.0076ns 0.00206ns 0.008ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #6010

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.75 KB 41.5 KB -250 B -0.60%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 591μs 3.09μs 16μs 0.631 0 0 41.46 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 3.12μs 11.7μs 0.355 0 0 41.75 KB
master WriteAndFlushEnrichedTraces net472 851μs 3.13μs 12.1μs 8.81 2.52 0.419 53.32 KB
#6010 WriteAndFlushEnrichedTraces net6.0 581μs 3.13μs 18μs 0.551 0 0 41.66 KB
#6010 WriteAndFlushEnrichedTraces netcoreapp3.1 744μs 4.21μs 29.2μs 0.372 0 0 41.5 KB
#6010 WriteAndFlushEnrichedTraces net472 832μs 2.49μs 9.3μs 8.39 2.52 0.419 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 2.62ns 10.1ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.73μs 3.43ns 13.3ns 0.0129 0 0 1.02 KB
master ExecuteNonQuery net472 2.15μs 2.1ns 7.84ns 0.156 0.00107 0 987 B
#6010 ExecuteNonQuery net6.0 1.25μs 1.51ns 5.85ns 0.0144 0 0 1.02 KB
#6010 ExecuteNonQuery netcoreapp3.1 1.72μs 1.76ns 6.6ns 0.0131 0 0 1.02 KB
#6010 ExecuteNonQuery net472 2.15μs 1.88ns 7.03ns 0.156 0.00109 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6010

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.134 1,222.49 1,386.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.28μs 0.527ns 2.04ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.58μs 0.729ns 2.73ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.66μs 1.78ns 6.89ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.22μs 0.825ns 3.2ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.65μs 2.08ns 8.06ns 0.0138 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 1.2ns 4.48ns 0.166 0 0 1.05 KB
#6010 CallElasticsearch net6.0 1.28μs 2.02ns 7.56ns 0.0135 0 0 976 B
#6010 CallElasticsearch netcoreapp3.1 1.54μs 1.46ns 5.47ns 0.0131 0 0 976 B
#6010 CallElasticsearch net472 2.47μs 1.77ns 6.84ns 0.158 0 0 995 B
#6010 CallElasticsearchAsync net6.0 1.39μs 0.377ns 1.46ns 0.0132 0 0 952 B
#6010 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.889ns 3.44ns 0.0136 0 0 1.02 KB
#6010 CallElasticsearchAsync net472 2.72μs 1.72ns 6.67ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.3μs 0.677ns 2.62ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.64μs 0.678ns 2.63ns 0.0123 0 0 952 B
master ExecuteAsync net472 1.87μs 0.755ns 2.93ns 0.145 0 0 915 B
#6010 ExecuteAsync net6.0 1.36μs 0.614ns 2.3ns 0.013 0 0 952 B
#6010 ExecuteAsync netcoreapp3.1 1.63μs 0.65ns 2.34ns 0.0124 0 0 952 B
#6010 ExecuteAsync net472 1.85μs 0.601ns 2.33ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.51μs 2.1ns 7.85ns 0.0312 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.35μs 1.63ns 6.33ns 0.0374 0 0 2.85 KB
master SendAsync net472 7.46μs 2.18ns 8.46ns 0.493 0 0 3.12 KB
#6010 SendAsync net6.0 4.27μs 2.07ns 7.47ns 0.032 0 0 2.31 KB
#6010 SendAsync netcoreapp3.1 5.26μs 2.5ns 9.67ns 0.0392 0 0 2.85 KB
#6010 SendAsync net472 7.48μs 1.73ns 6.7ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.51μs 0.417ns 1.56ns 0.0227 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.25μs 0.478ns 1.66ns 0.0227 0 0 1.64 KB
master EnrichedLog net472 2.54μs 1.02ns 3.97ns 0.249 0 0 1.57 KB
#6010 EnrichedLog net6.0 1.62μs 0.918ns 3.44ns 0.0233 0 0 1.64 KB
#6010 EnrichedLog netcoreapp3.1 2.13μs 1.47ns 5.49ns 0.0212 0 0 1.64 KB
#6010 EnrichedLog net472 2.77μs 1.27ns 4.57ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 130ns 487ns 0.0559 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 116μs 191ns 741ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 84.5ns 327ns 0.674 0.225 0 4.46 KB
#6010 EnrichedLog net6.0 113μs 139ns 521ns 0.056 0 0 4.28 KB
#6010 EnrichedLog netcoreapp3.1 116μs 112ns 432ns 0 0 0 4.28 KB
#6010 EnrichedLog net472 150μs 108ns 417ns 0.675 0.225 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3μs 1.37ns 5.32ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.28μs 2.96ns 11.5ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 4.97μs 1.79ns 6.92ns 0.32 0 0 2.02 KB
#6010 EnrichedLog net6.0 2.89μs 1.15ns 3.97ns 0.0303 0 0 2.2 KB
#6010 EnrichedLog netcoreapp3.1 4.26μs 1.2ns 4.49ns 0.0298 0 0 2.2 KB
#6010 EnrichedLog net472 4.87μs 1.27ns 4.93ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 1.22ns 4.73ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.71μs 2.64ns 10.2ns 0.0155 0 0 1.14 KB
master SendReceive net472 1.98μs 1.68ns 6.49ns 0.183 0 0 1.16 KB
#6010 SendReceive net6.0 1.37μs 0.826ns 3.09ns 0.0157 0 0 1.14 KB
#6010 SendReceive netcoreapp3.1 1.8μs 1.22ns 4.58ns 0.0153 0 0 1.14 KB
#6010 SendReceive net472 2.16μs 1.07ns 4.15ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.76μs 1.18ns 4.55ns 0.0221 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.91μs 3.11ns 12.1ns 0.0215 0 0 1.65 KB
master EnrichedLog net472 4.39μs 1.99ns 6.89ns 0.322 0 0 2.04 KB
#6010 EnrichedLog net6.0 2.76μs 1.09ns 4.2ns 0.0222 0 0 1.6 KB
#6010 EnrichedLog netcoreapp3.1 3.84μs 1.52ns 5.87ns 0.0211 0 0 1.65 KB
#6010 EnrichedLog net472 4.26μs 3.21ns 12.4ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6010

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.198 575.79 480.44
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.197 481.69 402.50

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 482ns 0.868ns 3.36ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 547ns 0.762ns 2.85ns 0.00786 0 0 576 B
master StartFinishSpan net472 630ns 1.17ns 4.54ns 0.0918 0 0 578 B
master StartFinishScope net6.0 575ns 0.882ns 3.42ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 669ns 0.458ns 1.71ns 0.0093 0 0 696 B
master StartFinishScope net472 805ns 1.48ns 5.75ns 0.105 0 0 658 B
#6010 StartFinishSpan net6.0 402ns 0.395ns 1.53ns 0.00801 0 0 576 B
#6010 StartFinishSpan netcoreapp3.1 546ns 0.755ns 2.92ns 0.00769 0 0 576 B
#6010 StartFinishSpan net472 572ns 0.863ns 3.34ns 0.0916 0 0 578 B
#6010 StartFinishScope net6.0 481ns 0.608ns 2.35ns 0.00968 0 0 696 B
#6010 StartFinishScope netcoreapp3.1 741ns 0.992ns 3.84ns 0.00944 0 0 696 B
#6010 StartFinishScope net472 812ns 1.45ns 5.63ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 650ns 0.737ns 2.85ns 0.00982 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 984ns 1.68ns 6.49ns 0.00924 0 0 696 B
master RunOnMethodBegin net472 1.01μs 2.88ns 11.2ns 0.105 0 0 658 B
#6010 RunOnMethodBegin net6.0 663ns 0.67ns 2.6ns 0.0097 0 0 696 B
#6010 RunOnMethodBegin netcoreapp3.1 943ns 1.23ns 4.62ns 0.00934 0 0 696 B
#6010 RunOnMethodBegin net472 1.05μs 2.46ns 9.52ns 0.104 0 0 658 B

andrewlock avatar Sep 09 '24 17:09 andrewlock

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

2351 occurrences of :

+      component: aspnet,

14 occurrences of :

-      language: dotnet,
[...]
-      _dd.base_service: Samples.CosmosDb
+      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
+      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet

14 occurrences of :

-      language: dotnet,
[...]
+      _dd.git.commit.sha: aaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbb,
+      _dd.git.repository_url: https://github.com/DataDog/dd-trace-dotnet,

github-actions[bot] avatar Sep 09 '24 18:09 github-actions[bot]

Datadog Report

Branch report: steven/AIDM-312 Commit report: fedd41e Test service: dd-trace-dotnet

:x: 35 Failed (0 Known Flaky), 553934 Passed, 4467 Skipped, 32h 7m 18.8s Total Time

:x: Failed Tests (35)

This report shows up to 5 failed tests.

  • HttpClient_SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.HttpMessageHandlerTests - Details

    Expand for error 
    
xpected var spansCreated = spansCreatedByIntegration {empty} to contain key "integration_name:httpmessagehandler".

  • TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

    Expand for error 
    

 {
   TraceId: Id_1,
   SpanId: Id_2,
   Name: aspnet-webapi.request,
   Resource: GET /api/route/{id},
   Service: sample,
   Type: web,
   ParentId: Id_3,
..

  • TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

    Expand for error 
    

 {
   TraceId: Id_1,
   SpanId: Id_2,
   Name: aspnet-webapi.request,
   Resource: GET /api/route/{id},
   Service: sample,
   Type: web,
   ParentId: Id_3,
..

  • TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

    Expand for error 
    

 {
   TraceId: Id_1,
   SpanId: Id_2,
   Name: aspnet-webapi.request,
   Resource: POST /api/home/{id},
   Service: sample,
   Type: web,
   ParentId: Id_3,
..

  • TestBlockedRequests - Datadog.Trace.Security.IntegrationTests.AspNetWebApiClassicWithoutSecurity - Details

    Expand for error 
    

 {
   TraceId: Id_1,
   SpanId: Id_2,
   Name: aspnet-webapi.request,
   Resource: POST /api/home/{id},
   Service: sample,
   Type: web,
   ParentId: Id_3,
..

datadog-ddstaging[bot] avatar Feb 11 '25 16:02 datadog-ddstaging[bot]

Datadog Report

All test runs 67a9253 :link:

:x: 2 Total Test Services: 1 Failed, 1 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 110 0 0 567170 4291 31h 52m 25.6s Link
exploration_tests 0 0 0 22085 3 2m 11.21s Link

:x: Failed Tests (110)

This report shows up to 5 failed tests.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc5TestsInferredProxySpansDisabled - Details

    Expand for error 
    
erified path: D:\a\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\AspNetMvc5Tests.InferredProxySpans_Disabled.__path=_badrequest_statusCode=500.verified.txt

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc5TestsInferredProxySpansDisabled - Details

    Expand for error 
    
erified path: D:\a\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\AspNetMvc5Tests.InferredProxySpans_Disabled.__path=_Home_Get_statusCode=500.verified.txt)' in 'Samples.AspNetMvc5.Controllers.HomeController'. An optional parameter must be a reference type, a nullable type, or be declared as an optional parameter.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc5TestsInferredProxySpansDisabled - Details

    Expand for error 
    
erified path: D:\a\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\AspNetMvc5Tests.InferredProxySpans_Disabled.__path=_badrequest-TransferRequest=true_statusCode=500.verified.txt

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc5TestsInferredProxySpansDisabled - Details

    Expand for error 
    
erified path: D:\a\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\AspNetMvc5Tests.InferredProxySpans_Disabled.__path=_Home_Get_3_statusCode=200.verified.txt

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AspNetMvc5TestsInferredProxySpansDisabled - Details

    Expand for error 
    
erified path: D:\a\1\s\tracer\test\Datadog.Trace.ClrProfiler.IntegrationTests\..\snapshots\AspNetMvc5Tests.InferredProxySpans_Disabled.__path=_BadRequestWithStatusCode_401-TransferRequest=true_statusCode=401.verified.txt

datadog-datadog-prod-us1[bot] avatar May 08 '25 12:05 datadog-datadog-prod-us1[bot]

Benchmarks Report for appsec :snail:

Benchmarks for #6010 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.157
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #6010

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody‑net6.0 1.141 188,801.55 215,391.32

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 227μs 6.82μs 66.5μs 1.73 0 0 196.85 KB
master AllCycleSimpleBody netcoreapp3.1 303μs 911ns 5.07μs 1.5 0 0 204.51 KB
master AllCycleSimpleBody net472 264μs 203ns 759ns 36.7 1.31 0 237.47 KB
master AllCycleMoreComplexBody net6.0 197μs 174ns 651ns 1.96 0 0 200.35 KB
master AllCycleMoreComplexBody netcoreapp3.1 306μs 229ns 856ns 1.64 0 0 207.93 KB
master AllCycleMoreComplexBody net472 269μs 207ns 775ns 37.7 1.35 0 240.97 KB
master ObjectExtractorSimpleBody net6.0 142ns 0.174ns 0.674ns 0.00354 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 193ns 0.254ns 0.949ns 0.0029 0 0 272 B
master ObjectExtractorSimpleBody net472 166ns 0.24ns 0.928ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3μs 2.88ns 11.2ns 0.0451 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.76μs 4.57ns 17.1ns 0.0375 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.58μs 4.88ns 18.9ns 0.597 0 0 3.8 KB
#6010 AllCycleSimpleBody net6.0 216μs 286ns 1.11μs 2.17 0 0 196.71 KB
#6010 AllCycleSimpleBody netcoreapp3.1 324μs 376ns 1.41μs 1.62 0 0 204.37 KB
#6010 AllCycleSimpleBody net472 282μs 263ns 984ns 36.6 1.41 0 237.31 KB
#6010 AllCycleMoreComplexBody net6.0 219μs 146ns 528ns 2.19 0 0 200.21 KB
#6010 AllCycleMoreComplexBody netcoreapp3.1 331μs 223ns 804ns 1.86 0 0 207.78 KB
#6010 AllCycleMoreComplexBody net472 292μs 330ns 1.19μs 37.6 1.45 0 240.82 KB
#6010 ObjectExtractorSimpleBody net6.0 142ns 0.167ns 0.625ns 0.00357 0 0 280 B
#6010 ObjectExtractorSimpleBody netcoreapp3.1 192ns 0.324ns 1.26ns 0.00384 0 0 272 B
#6010 ObjectExtractorSimpleBody net472 167ns 0.464ns 1.73ns 0.0438 0 0 281 B
#6010 ObjectExtractorMoreComplexBody net6.0 2.92μs 2.88ns 10.8ns 0.0433 0 0 3.78 KB
#6010 ObjectExtractorMoreComplexBody netcoreapp3.1 3.73μs 4.39ns 17ns 0.0375 0 0 3.69 KB
#6010 ObjectExtractorMoreComplexBody net472 3.67μs 11.5ns 43.2ns 0.599 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 37.7μs 46.1ns 179ns 0.374 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 53.9μs 48.1ns 180ns 0.268 0 0 32.4 KB
master EncodeArgs net472 65.8μs 72.2ns 280ns 4.91 0 0 32.51 KB
master EncodeLegacyArgs net6.0 74.3μs 118ns 455ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 104μs 137ns 532ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 152μs 206ns 799ns 0 0 0 2.15 KB
#6010 EncodeArgs net6.0 36.5μs 26.9ns 97ns 0.363 0 0 32.4 KB
#6010 EncodeArgs netcoreapp3.1 54μs 48.9ns 189ns 0.269 0 0 32.4 KB
#6010 EncodeArgs net472 66.4μs 75ns 281ns 4.91 0 0 32.51 KB
#6010 EncodeLegacyArgs net6.0 80.4μs 433ns 2.45μs 0 0 0 2.14 KB
#6010 EncodeLegacyArgs netcoreapp3.1 106μs 50ns 180ns 0 0 0 2.14 KB
#6010 EncodeLegacyArgs net472 153μs 53.8ns 194ns 0 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 173μs 61.7ns 222ns 0 0 0 2.54 KB
master RunWafRealisticBenchmark netcoreapp3.1 184μs 209ns 781ns 0 0 0 2.49 KB
master RunWafRealisticBenchmark net472 198μs 79.6ns 308ns 0 0 0 2.55 KB
master RunWafRealisticBenchmarkWithAttack net6.0 115μs 84.1ns 315ns 0 0 0 1.57 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 121μs 160ns 620ns 0 0 0 1.55 KB
master RunWafRealisticBenchmarkWithAttack net472 131μs 62.1ns 232ns 0 0 0 1.59 KB
#6010 RunWafRealisticBenchmark net6.0 174μs 76.5ns 286ns 0 0 0 2.54 KB
#6010 RunWafRealisticBenchmark netcoreapp3.1 185μs 122ns 455ns 0 0 0 2.49 KB
#6010 RunWafRealisticBenchmark net472 198μs 234ns 874ns 0 0 0 2.55 KB
#6010 RunWafRealisticBenchmarkWithAttack net6.0 115μs 51.9ns 187ns 0 0 0 1.57 KB
#6010 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 121μs 78.9ns 284ns 0 0 0 1.55 KB
#6010 RunWafRealisticBenchmarkWithAttack net472 132μs 77.7ns 291ns 0 0 0 1.59 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower :warning: More allocations :warning:

Slower :warning: in #6010

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.174 53,700.00 63,050.00 multimodal

More allocations :warning: in #6010

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 55.8 KB 59.04 KB 3.24 KB 5.81%

Fewer allocations :tada: in #6010

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 265.82 KB 253.85 KB -11.98 KB -4.51%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 62.3μs 797ns 7.97μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 53.7μs 154ns 577ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 37μs 76.4ns 265ns 0 0 0 55.8 KB
master StringConcatAspectBenchmark net6.0 313μs 1.76μs 11.2μs 0 0 0 254.96 KB
master StringConcatAspectBenchmark netcoreapp3.1 347μs 1.89μs 10.7μs 0 0 0 265.82 KB
master StringConcatAspectBenchmark net472 278μs 4.97μs 46.9μs 0 0 0 278.53 KB
#6010 StringConcatBenchmark net6.0 60.5μs 859ns 8.59μs 0 0 0 43.44 KB
#6010 StringConcatBenchmark netcoreapp3.1 64.8μs 974ns 9.74μs 0 0 0 42.64 KB
#6010 StringConcatBenchmark net472 37μs 108ns 388ns 0 0 0 59.04 KB
#6010 StringConcatAspectBenchmark net6.0 314μs 1.74μs 10.7μs 0 0 0 255.66 KB
#6010 StringConcatAspectBenchmark netcoreapp3.1 309μs 6.03μs 59.1μs 0 0 0 253.85 KB
#6010 StringConcatAspectBenchmark net472 302μs 7.87μs 76.3μs 0 0 0 278.53 KB

andrewlock avatar May 08 '25 12:05 andrewlock

Benchmarks

Benchmarks Report for tracer :snail:

Benchmarks for #6010 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.273
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:

Fewer allocations :tada: in #6010

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.22 KB 6.17 KB -50 B -0.80%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.7μs 56ns 291ns 0 0 0 5.55 KB
master StartStopWithChild netcoreapp3.1 13.7μs 43.1ns 167ns 0 0 0 5.76 KB
master StartStopWithChild net472 22μs 123ns 843ns 0.989 0.22 0 6.22 KB
#6010 StartStopWithChild net6.0 10.8μs 59.1ns 364ns 0 0 0 5.56 KB
#6010 StartStopWithChild netcoreapp3.1 13.4μs 62.1ns 249ns 0 0 0 5.76 KB
#6010 StartStopWithChild net472 21.3μs 116ns 698ns 0.89 0.334 0 6.17 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 940μs 39.8ns 138ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 37.3ns 129ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.22ms 88.7ns 307ns 0 0 0 3.31 KB
#6010 WriteAndFlushEnrichedTraces net6.0 936μs 107ns 414ns 0 0 0 2.71 KB
#6010 WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 188ns 705ns 0 0 0 2.7 KB
#6010 WriteAndFlushEnrichedTraces net472 1.23ms 2.82μs 10.9μs 0 0 0 3.31 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.7μs 124ns 481ns 0 0 0 14.53 KB
master SendRequest netcoreapp3.1 72μs 172ns 643ns 0 0 0 17.42 KB
master SendRequest net472 0.00167ns 0.000848ns 0.00329ns 0 0 0 0 b
#6010 SendRequest net6.0 60.5μs 154ns 555ns 0 0 0 14.53 KB
#6010 SendRequest netcoreapp3.1 71.6μs 122ns 439ns 0 0 0 17.42 KB
#6010 SendRequest net472 0.00903ns 0.00251ns 0.00971ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #6010

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 1.273 809,395.51 635,925.00

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 808μs 1.5μs 5.82μs 0 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 716μs 3.36μs 13.5μs 0 0 0 41.89 KB
master WriteAndFlushEnrichedTraces net472 893μs 1.82μs 6.57μs 4.46 0 0 56.17 KB
#6010 WriteAndFlushEnrichedTraces net6.0 636μs 499ns 1.93μs 0 0 0 41.65 KB
#6010 WriteAndFlushEnrichedTraces netcoreapp3.1 720μs 5.09μs 50.3μs 0 0 0 41.81 KB
#6010 WriteAndFlushEnrichedTraces net472 844μs 4.4μs 22.4μs 8.33 0 0 56.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.94μs 10.5ns 55.5ns 0 0 0 1.03 KB
master ExecuteNonQuery netcoreapp3.1 2.43μs 10.2ns 39.4ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.79μs 2.65ns 10.3ns 0.154 0.014 0 995 B
#6010 ExecuteNonQuery net6.0 1.82μs 4.78ns 18.5ns 0 0 0 1.03 KB
#6010 ExecuteNonQuery netcoreapp3.1 2.42μs 1.11ns 4.15ns 0 0 0 1.02 KB
#6010 ExecuteNonQuery net472 2.82μs 4.65ns 18ns 0.156 0.0141 0 995 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.78μs 8.62ns 35.5ns 0 0 0 1.04 KB
master CallElasticsearch netcoreapp3.1 2.24μs 9.26ns 35.8ns 0 0 0 1.04 KB
master CallElasticsearch net472 3.53μs 1.57ns 6.06ns 0.159 0 0 1.05 KB
master CallElasticsearchAsync net6.0 1.86μs 1.33ns 5.15ns 0 0 0 1.02 KB
master CallElasticsearchAsync netcoreapp3.1 2.37μs 11ns 42.7ns 0 0 0 1.09 KB
master CallElasticsearchAsync net472 3.67μs 2.97ns 11.5ns 0.166 0 0 1.11 KB
#6010 CallElasticsearch net6.0 1.78μs 9.03ns 41.4ns 0 0 0 1.04 KB
#6010 CallElasticsearch netcoreapp3.1 2.3μs 7.8ns 30.2ns 0 0 0 1.04 KB
#6010 CallElasticsearch net472 3.53μs 2.48ns 9.59ns 0.159 0 0 1.05 KB
#6010 CallElasticsearchAsync net6.0 1.87μs 6.74ns 26.1ns 0 0 0 1.02 KB
#6010 CallElasticsearchAsync netcoreapp3.1 2.43μs 3.79ns 14.2ns 0 0 0 1.09 KB
#6010 CallElasticsearchAsync net472 3.84μs 1.78ns 6.43ns 0.171 0 0 1.11 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.8μs 8.49ns 32.9ns 0 0 0 960 B
master ExecuteAsync netcoreapp3.1 2.27μs 9.73ns 37.7ns 0 0 0 960 B
master ExecuteAsync net472 2.6μs 3.33ns 12.9ns 0.143 0 0 923 B
#6010 ExecuteAsync net6.0 1.78μs 3.7ns 14.3ns 0 0 0 960 B
#6010 ExecuteAsync netcoreapp3.1 2.34μs 6.15ns 23.8ns 0 0 0 960 B
#6010 ExecuteAsync net472 2.6μs 0.852ns 3.3ns 0.143 0 0 923 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.81μs 6.06ns 22.7ns 0 0 0 2.37 KB
master SendAsync netcoreapp3.1 8.61μs 14.1ns 54.6ns 0 0 0 2.9 KB
master SendAsync net472 12.5μs 5.98ns 23.2ns 0.501 0 0 3.19 KB
#6010 SendAsync net6.0 7.04μs 18.8ns 72.8ns 0 0 0 2.37 KB
#6010 SendAsync netcoreapp3.1 8.5μs 11.7ns 45.5ns 0 0 0 2.9 KB
#6010 SendAsync net472 12.2μs 11.7ns 45.5ns 0.484 0 0 3.19 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 11.5ns 43ns 0 0 0 1.76 KB
master EnrichedLog netcoreapp3.1 3.42μs 13.6ns 50.9ns 0 0 0 1.76 KB
master EnrichedLog net472 3.9μs 6.04ns 23.4ns 0.253 0 0 1.69 KB
#6010 EnrichedLog net6.0 2.58μs 7.77ns 30.1ns 0 0 0 1.76 KB
#6010 EnrichedLog netcoreapp3.1 3.5μs 16.5ns 66.1ns 0 0 0 1.76 KB
#6010 EnrichedLog net472 4.01μs 4.31ns 16.1ns 0.26 0 0 1.69 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 122μs 127ns 459ns 0 0 0 4.37 KB
master EnrichedLog netcoreapp3.1 126μs 35.4ns 128ns 0 0 0 4.37 KB
master EnrichedLog net472 167μs 76.3ns 296ns 0 0 0 4.57 KB
#6010 EnrichedLog net6.0 123μs 65.6ns 236ns 0 0 0 4.37 KB
#6010 EnrichedLog netcoreapp3.1 128μs 131ns 507ns 0 0 0 4.37 KB
#6010 EnrichedLog net472 168μs 177ns 686ns 0 0 0 4.57 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.11μs 18.3ns 70.9ns 0 0 0 2.32 KB
master EnrichedLog netcoreapp3.1 6.64μs 19.8ns 76.8ns 0 0 0 2.32 KB
master EnrichedLog net472 7.39μs 4.08ns 15.3ns 0.332 0 0 2.14 KB
#6010 EnrichedLog net6.0 5.08μs 4.85ns 18.1ns 0 0 0 2.32 KB
#6010 EnrichedLog netcoreapp3.1 6.53μs 19ns 73.5ns 0 0 0 2.32 KB
#6010 EnrichedLog net472 7.56μs 6.47ns 25.1ns 0.302 0 0 2.14 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 2μs 9.75ns 42.5ns 0 0 0 1.21 KB
master SendReceive netcoreapp3.1 2.54μs 11.5ns 44.4ns 0 0 0 1.21 KB
master SendReceive net472 3.1μs 2.08ns 8.06ns 0.184 0 0 1.21 KB
#6010 SendReceive net6.0 1.95μs 1.1ns 4.26ns 0 0 0 1.21 KB
#6010 SendReceive netcoreapp3.1 2.67μs 13ns 56.8ns 0 0 0 1.21 KB
#6010 SendReceive net472 3.03μs 4.13ns 14.9ns 0.183 0 0 1.21 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.2μs 12.1ns 47ns 0 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 5.97μs 19.2ns 74.2ns 0 0 0 1.69 KB
master EnrichedLog net472 6.98μs 7.39ns 28.6ns 0.313 0 0 2.08 KB
#6010 EnrichedLog net6.0 4.19μs 8.05ns 30.1ns 0 0 0 1.64 KB
#6010 EnrichedLog netcoreapp3.1 5.54μs 13.8ns 53.5ns 0 0 0 1.69 KB
#6010 EnrichedLog net472 6.43μs 6.8ns 26.3ns 0.32 0 0 2.08 KB
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 762ns 3.74ns 15ns 0 0 0 584 B
master StartFinishSpan netcoreapp3.1 945ns 4.87ns 22.3ns 0 0 0 584 B
master StartFinishSpan net472 941ns 0.16ns 0.597ns 0.0901 0 0 586 B
master StartFinishScope net6.0 888ns 4.56ns 25ns 0 0 0 704 B
master StartFinishScope netcoreapp3.1 1.16μs 5.96ns 29.8ns 0 0 0 704 B
master StartFinishScope net472 1.11μs 0.156ns 0.604ns 0.105 0 0 666 B
#6010 StartFinishSpan net6.0 760ns 1.81ns 6.78ns 0 0 0 584 B
#6010 StartFinishSpan netcoreapp3.1 930ns 4.8ns 22ns 0 0 0 584 B
#6010 StartFinishSpan net472 898ns 0.201ns 0.778ns 0.0927 0 0 586 B
#6010 StartFinishScope net6.0 927ns 0.458ns 1.77ns 0 0 0 704 B
#6010 StartFinishScope netcoreapp3.1 1.16μs 3.42ns 13.3ns 0 0 0 704 B
#6010 StartFinishScope net472 1.08μs 0.161ns 0.58ns 0.102 0 0 666 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1μs 5.5ns 32.1ns 0 0 0 704 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 5.38ns 20.8ns 0 0 0 704 B
master RunOnMethodBegin net472 1.39μs 1.35ns 4.88ns 0.104 0 0 666 B
#6010 RunOnMethodBegin net6.0 1.04μs 0.686ns 2.66ns 0 0 0 704 B
#6010 RunOnMethodBegin netcoreapp3.1 1.48μs 5.27ns 20.4ns 0 0 0 704 B
#6010 RunOnMethodBegin net472 1.35μs 1.11ns 4.3ns 0.101 0 0 666 B

pr-commenter[bot] avatar May 08 '25 12:05 pr-commenter[bot]

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

FlakyRetriesWithExceptionReplay from Datadog.Trace.ClrProfiler.IntegrationTests.CI.MsTestV2RetriesTests (Datadog) (✨ Fix with BitsAI) 
The sample did not exit in 600000ms. Memory dump taken: True. Killing process.

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e2d6585 | Docs | Was this helpful? Give us feedback!

datadog-official[bot] avatar Oct 01 '25 00:10 datadog-official[bot]