Add ability to disable `ActivitySource`s from being listened to
Summary of changes
This adds the ability for ActivitySources to be disabled so that they won't be listened to by the .NET Tracer.
Reason for change
Currently there is no way to disable an ActivitySource if OpenTelemetry is enabled in the .NET Tracer without entirely disabling OpenTelemetry support. The IgnoreActivityHandler is insufficient as it will still listen to the ActivitySource so they will create Activity objects.
Implementation details
- Adds
DD_TRACE_DISABLED_ACTIVITY_SOURCESthat accepts a comma-separated list ofActivitySourcenames that supports the glob-pattern.- example:
"DD_TRACE_DISABLED_ACTIVITY_SOURCES": "SomeSourceName,*SomeGlobPattern*"
- example:
- Adds
DisableActivityHandlerthat will determine based on the above environment variable whether or not a givenActivitySourceshould be listened to.
Test coverage
- Updated the
NetActivitySdksample project with an ignoredActivitySourceand some that are disabled.
Other details
When merged, get this merged: https://github.com/DataDog/dd-go/pull/148984
Fixes #5740
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (69ms) : 67, 71
. : milestone, 69,
master - mean (70ms) : 65, 75
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (999ms) : 977, 1021
. : milestone, 999,
master - mean (1,001ms) : 976, 1025
. : milestone, 1001,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (102ms) : 100, 104
. : milestone, 102,
master - mean (102ms) : 100, 105
. : milestone, 102,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (671ms) : 656, 685
. : milestone, 671,
master - mean (725ms) : 664, 787
. : milestone, 725,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (89ms) : 87, 90
. : milestone, 89,
master - mean (100ms) : 92, 109
. : milestone, 100,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (625ms) : 605, 646
. : milestone, 625,
master - mean (690ms) : 654, 726
. : milestone, 690,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (191ms) : 187, 196
. : milestone, 191,
master - mean (191ms) : 187, 194
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (1,111ms) : 1072, 1151
. : milestone, 1111,
master - mean (1,106ms) : 1081, 1132
. : milestone, 1106,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (272ms) : 266, 278
. : milestone, 272,
master - mean (270ms) : 266, 275
. : milestone, 270,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (861ms) : 827, 895
. : milestone, 861,
master - mean (865ms) : 835, 894
. : milestone, 865,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5795) - mean (262ms) : 258, 267
. : milestone, 262,
master - mean (262ms) : 258, 266
. : milestone, 262,
section CallTarget+Inlining+NGEN
This PR (5795) - mean (838ms) : 809, 866
. : milestone, 838,
master - mean (847ms) : 813, 881
. : milestone, 847,
Benchmarks Report for tracer :snail:
Benchmarks for #5795 compared to master:
- 2 benchmarks are faster, with geometric mean 1.213
- 1 benchmarks have fewer allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 7.86μs | 43ns | 262ns | 0.0203 | 0.00811 | 0 | 5.61 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 10.1μs | 55.5ns | 324ns | 0.0199 | 0.00996 | 0 | 5.8 KB |
| master | StartStopWithChild |
net472 | 15.9μs | 38.1ns | 142ns | 1.04 | 0.307 | 0.0944 | 6.21 KB |
| #5795 | StartStopWithChild |
net6.0 | 8.22μs | 53.1ns | 531ns | 0.0188 | 0.00753 | 0 | 5.61 KB |
| #5795 | StartStopWithChild |
netcoreapp3.1 | 10.8μs | 61.9ns | 476ns | 0.0222 | 0.0111 | 0 | 5.8 KB |
| #5795 | StartStopWithChild |
net472 | 15.8μs | 41.7ns | 161ns | 1.05 | 0.318 | 0.101 | 6.2 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 492μs | 486ns | 1.82μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 700μs | 282ns | 1.05μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 848μs | 626ns | 2.34μs | 0.422 | 0 | 0 | 3.3 KB |
| #5795 | WriteAndFlushEnrichedTraces |
net6.0 | 477μs | 305ns | 1.14μs | 0 | 0 | 0 | 2.7 KB |
| #5795 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 646μs | 257ns | 963ns | 0 | 0 | 0 | 2.7 KB |
| #5795 | WriteAndFlushEnrichedTraces |
net472 | 853μs | 1.3μs | 4.85μs | 0.422 | 0 | 0 | 3.3 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 132μs | 417ns | 1.61μs | 0.135 | 0 | 0 | 14.47 KB |
| master | SendRequest |
netcoreapp3.1 | 147μs | 396ns | 1.53μs | 0.22 | 0 | 0 | 17.27 KB |
| master | SendRequest |
net472 | 0.00199ns | 0.000288ns | 0.00112ns | 0 | 0 | 0 | 0 b |
| #5795 | SendRequest |
net6.0 | 128μs | 365ns | 1.41μs | 0.193 | 0 | 0 | 14.47 KB |
| #5795 | SendRequest |
netcoreapp3.1 | 150μs | 137ns | 512ns | 0.15 | 0 | 0 | 17.27 KB |
| #5795 | SendRequest |
net472 | 0.00591ns | 0.00149ns | 0.00576ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Fewer allocations :tada:
Fewer allocations :tada: in #5795
Benchmark
Base Allocated
Diff Allocated
Change
Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0
41.87 KB
41.57 KB
-299 B
-0.71%
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 608μs | 3.32μs | 18.8μs | 0.604 | 0 | 0 | 41.87 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 670μs | 3.78μs | 27.5μs | 0.338 | 0 | 0 | 41.69 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 840μs | 2.83μs | 10.6μs | 8.22 | 2.47 | 0.411 | 53.34 KB |
| #5795 | WriteAndFlushEnrichedTraces |
net6.0 | 573μs | 2.99μs | 21.4μs | 0.566 | 0 | 0 | 41.57 KB |
| #5795 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 656μs | 3.35μs | 15.7μs | 0.331 | 0 | 0 | 41.65 KB |
| #5795 | WriteAndFlushEnrichedTraces |
net472 | 832μs | 3.58μs | 13.8μs | 8.33 | 2.5 | 0.417 | 53.3 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.44μs | 2.09ns | 8.1ns | 0.0138 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 1.75μs | 2.38ns | 9.22ns | 0.0139 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2.07μs | 4.15ns | 16.1ns | 0.156 | 0.00103 | 0 | 987 B |
| #5795 | ExecuteNonQuery |
net6.0 | 1.4μs | 1.42ns | 5.48ns | 0.014 | 0 | 0 | 1.02 KB |
| #5795 | ExecuteNonQuery |
netcoreapp3.1 | 1.76μs | 1.13ns | 4.23ns | 0.0132 | 0 | 0 | 1.02 KB |
| #5795 | ExecuteNonQuery |
net472 | 2.04μs | 2.45ns | 9.47ns | 0.157 | 0.00102 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.21μs | 0.404ns | 1.51ns | 0.0139 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.5μs | 0.958ns | 3.59ns | 0.0128 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.46μs | 2.36ns | 9.14ns | 0.158 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.37μs | 1.01ns | 3.76ns | 0.013 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.71μs | 0.965ns | 3.61ns | 0.0139 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.67μs | 1.97ns | 7.63ns | 0.166 | 0 | 0 | 1.05 KB |
| #5795 | CallElasticsearch |
net6.0 | 1.2μs | 0.658ns | 2.46ns | 0.0133 | 0 | 0 | 976 B |
| #5795 | CallElasticsearch |
netcoreapp3.1 | 1.61μs | 1.3ns | 4.86ns | 0.0129 | 0 | 0 | 976 B |
| #5795 | CallElasticsearch |
net472 | 2.53μs | 1.52ns | 5.89ns | 0.157 | 0 | 0 | 995 B |
| #5795 | CallElasticsearchAsync |
net6.0 | 1.36μs | 0.424ns | 1.59ns | 0.013 | 0 | 0 | 952 B |
| #5795 | CallElasticsearchAsync |
netcoreapp3.1 | 1.59μs | 0.639ns | 2.47ns | 0.0142 | 0 | 0 | 1.02 KB |
| #5795 | CallElasticsearchAsync |
net472 | 2.65μs | 1.77ns | 6.84ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.44μs | 1.02ns | 3.96ns | 0.013 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.71μs | 0.954ns | 3.7ns | 0.012 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.86μs | 0.559ns | 2.09ns | 0.145 | 0 | 0 | 915 B |
| #5795 | ExecuteAsync |
net6.0 | 1.33μs | 0.401ns | 1.55ns | 0.0133 | 0 | 0 | 952 B |
| #5795 | ExecuteAsync |
netcoreapp3.1 | 1.73μs | 0.699ns | 2.61ns | 0.0129 | 0 | 0 | 952 B |
| #5795 | ExecuteAsync |
net472 | 1.94μs | 1.06ns | 3.98ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.41μs | 1.19ns | 4.47ns | 0.0331 | 0 | 0 | 2.31 KB |
| master | SendAsync |
netcoreapp3.1 | 5.35μs | 3.47ns | 13ns | 0.0374 | 0 | 0 | 2.85 KB |
| master | SendAsync |
net472 | 7.37μs | 2.03ns | 7.85ns | 0.495 | 0 | 0 | 3.12 KB |
| #5795 | SendAsync |
net6.0 | 4.51μs | 10ns | 38.9ns | 0.0316 | 0 | 0 | 2.31 KB |
| #5795 | SendAsync |
netcoreapp3.1 | 5.31μs | 1.2ns | 4.65ns | 0.037 | 0 | 0 | 2.85 KB |
| #5795 | SendAsync |
net472 | 7.42μs | 2.22ns | 8.59ns | 0.495 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.58μs | 0.493ns | 1.78ns | 0.023 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.19μs | 1.07ns | 3.99ns | 0.0228 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.67μs | 4.35ns | 16.9ns | 0.25 | 0 | 0 | 1.57 KB |
| #5795 | EnrichedLog |
net6.0 | 1.57μs | 2.99ns | 10.8ns | 0.0225 | 0 | 0 | 1.64 KB |
| #5795 | EnrichedLog |
netcoreapp3.1 | 2.1μs | 0.806ns | 3.01ns | 0.0221 | 0 | 0 | 1.64 KB |
| #5795 | EnrichedLog |
net472 | 2.69μs | 5ns | 19.4ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 112μs | 212ns | 822ns | 0.0558 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 117μs | 148ns | 573ns | 0.0582 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 151μs | 82.1ns | 307ns | 0.681 | 0.227 | 0 | 4.46 KB |
| #5795 | EnrichedLog |
net6.0 | 113μs | 162ns | 629ns | 0.056 | 0 | 0 | 4.28 KB |
| #5795 | EnrichedLog |
netcoreapp3.1 | 117μs | 226ns | 844ns | 0.0578 | 0 | 0 | 4.28 KB |
| #5795 | EnrichedLog |
net472 | 150μs | 151ns | 584ns | 0.672 | 0.224 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 3.11μs | 0.496ns | 1.72ns | 0.0311 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.2μs | 2.35ns | 8.79ns | 0.0294 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 5.03μs | 1.01ns | 3.79ns | 0.32 | 0 | 0 | 2.02 KB |
| #5795 | EnrichedLog |
net6.0 | 3.02μs | 1.39ns | 5.39ns | 0.0302 | 0 | 0 | 2.2 KB |
| #5795 | EnrichedLog |
netcoreapp3.1 | 4.08μs | 0.923ns | 3.33ns | 0.0286 | 0 | 0 | 2.2 KB |
| #5795 | EnrichedLog |
net472 | 4.84μs | 2.62ns | 10.1ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.27μs | 0.38ns | 1.47ns | 0.0159 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.77μs | 0.486ns | 1.68ns | 0.015 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.12μs | 2.85ns | 11.1ns | 0.183 | 0 | 0 | 1.16 KB |
| #5795 | SendReceive |
net6.0 | 1.33μs | 0.657ns | 2.46ns | 0.016 | 0 | 0 | 1.14 KB |
| #5795 | SendReceive |
netcoreapp3.1 | 1.69μs | 0.48ns | 1.8ns | 0.0152 | 0 | 0 | 1.14 KB |
| #5795 | SendReceive |
net472 | 2.1μs | 0.794ns | 2.86ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.77μs | 1.19ns | 4.44ns | 0.022 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.97μs | 5.6ns | 20.9ns | 0.0217 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.3μs | 3.26ns | 12.6ns | 0.323 | 0 | 0 | 2.04 KB |
| #5795 | EnrichedLog |
net6.0 | 2.75μs | 1.05ns | 4.05ns | 0.0219 | 0 | 0 | 1.6 KB |
| #5795 | EnrichedLog |
netcoreapp3.1 | 3.95μs | 1.28ns | 4.94ns | 0.0217 | 0 | 0 | 1.65 KB |
| #5795 | EnrichedLog |
net472 | 4.25μs | 3.3ns | 12.8ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 391ns | 0.461ns | 1.79ns | 0.00817 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 557ns | 0.82ns | 3.18ns | 0.00784 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 584ns | 1.27ns | 4.91ns | 0.0915 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 515ns | 0.487ns | 1.89ns | 0.00983 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 742ns | 1.68ns | 6.07ns | 0.00932 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 839ns | 2.27ns | 8.78ns | 0.105 | 0 | 0 | 658 B |
| #5795 | StartFinishSpan |
net6.0 | 391ns | 0.67ns | 2.59ns | 0.00811 | 0 | 0 | 576 B |
| #5795 | StartFinishSpan |
netcoreapp3.1 | 561ns | 2.62ns | 10.1ns | 0.00776 | 0 | 0 | 576 B |
| #5795 | StartFinishSpan |
net472 | 576ns | 2.1ns | 7.87ns | 0.0915 | 0 | 0 | 578 B |
| #5795 | StartFinishScope |
net6.0 | 464ns | 0.721ns | 2.7ns | 0.00985 | 0 | 0 | 696 B |
| #5795 | StartFinishScope |
netcoreapp3.1 | 690ns | 1.17ns | 4.53ns | 0.00961 | 0 | 0 | 696 B |
| #5795 | StartFinishScope |
net472 | 757ns | 1.29ns | 4.82ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #5795
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.253
731.18
583.38
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472
1.173
1,162.68
990.87
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 733ns | 1.3ns | 5.05ns | 0.00951 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 907ns | 1.48ns | 5.73ns | 0.00936 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.16μs | 1.52ns | 5.88ns | 0.105 | 0 | 0 | 658 B |
| #5795 | RunOnMethodBegin |
net6.0 | 583ns | 1.32ns | 5.12ns | 0.00967 | 0 | 0 | 696 B |
| #5795 | RunOnMethodBegin |
netcoreapp3.1 | 889ns | 1.38ns | 5.33ns | 0.00934 | 0 | 0 | 696 B |
| #5795 | RunOnMethodBegin |
net472 | 994ns | 2.82ns | 10.9ns | 0.104 | 0 | 0 | 658 B |
Datadog Report
Branch report: steven/disable-otel-integrations
Commit report: f4e4f36
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 362976 Passed, 2071 Skipped, 14h 55m 57.67s Total Time
Throughput/Crank Report :zap:
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5795) (11.089M) : 0, 11089168
master (11.252M) : 0, 11251784
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5795) (7.359M) : 0, 7359058
master (7.466M) : 0, 7465753
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.766M) : 0, 7765791
section Manual
master (11.114M) : 0, 11114354
section Manual + Automatic
This PR (5795) (6.826M) : 0, 6826031
master (6.846M) : 0, 6845872
section DD_TRACE_ENABLED=0
master (10.389M) : 0, 10388612
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5795) (9.725M) : 0, 9724710
master (9.539M) : 0, 9539093
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5795) (6.440M) : 0, 6439529
master (6.648M) : 0, 6647799
section Trace stats
master (6.855M) : 0, 6855301
section Manual
master (9.525M) : 0, 9525425
section Manual + Automatic
This PR (5795) (6.293M) : 0, 6292650
master (6.161M) : 0, 6160600
section DD_TRACE_ENABLED=0
master (8.832M) : 0, 8832117
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5795) (9.994M) : 0, 9994176
master (10.064M) : 0, 10064242
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5795) (6.655M) : 0, 6654718
master (6.841M) : 0, 6841333
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.427M) : 0, 7426854
section Manual
master (10.084M) : 0, 10084210
section Manual + Automatic
This PR (5795) (6.140M) : 0, 6139715
master (6.348M) : 0, 6347556
section DD_TRACE_ENABLED=0
master (9.577M) : 0, 9576577
Any updates on the progress of this PR? This would be really useful for us!
Any updates on the progress of this PR? This would be really useful for us!
Hi @johan-lindqvist, work has stalled somewhat on this, but I'll carve out some time this next week to get this wrapped up.