[Profiler] override native call for wrapped functions

[gleocadie]

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

[github-actions[bot]]

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer. The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

+        "language": "dotnet",

5947 occurrences of :

+      language: dotnet,

1 occurrences of :

-  {
-    TraceId: Id_1,
-    SpanId: Id_2,
-    Name: Manual-1.Initial,
-    Resource: Manual-1.Initial,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_1,
-    SpanId: Id_3,
-    Name: Manual-1.Initial.HttpClient,
-    Resource: Manual-1.Initial.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_2,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_4,
-    SpanId: Id_5,
-    Name: Manual-1.Initial.HttpListener,
-    Resource: Manual-1.Initial.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_6,
-    SpanId: Id_7,
-    Name: Manual-2.Reconfigured,
-    Resource: Manual-2.Reconfigured,
-    Service: updated-name,
-    Tags: {
-      env: updated-env,
-      language: dotnet,
-      runtime-id: Guid_1,
-      Updated-key: Updated Value
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_6,
-    SpanId: Id_8,
-    Name: Manual-2.Reconfigured.HttpClient,
-    Resource: Manual-2.Reconfigured.HttpClient,
-    Service: updated-name,
-    ParentId: Id_7,
-    Tags: {
-      env: updated-env,
-      language: dotnet,
-      Updated-key: Updated Value
-    }
-  },
-  {
-    TraceId: Id_9,
-    SpanId: Id_10,
-    Name: Manual-2.Reconfigured.HttpListener,
-    Resource: Manual-2.Reconfigured.HttpListener,
-    Service: updated-name,
-    Tags: {
-      content: PONG,
-      env: updated-env,
-      language: dotnet,
-      runtime-id: Guid_1,
-      Updated-key: Updated Value
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_11,
-    SpanId: Id_12,
-    Name: Manual-3.HttpDisabled,
-    Resource: Manual-3.HttpDisabled,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_11,
-    SpanId: Id_13,
-    Name: Manual-3.HttpDisabled.HttpClient,
-    Resource: Manual-3.HttpDisabled.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_12,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_14,
-    SpanId: Id_15,
-    Name: Manual-3.HttpDisabled.HttpListener,
-    Resource: Manual-3.HttpDisabled.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_16,
-    SpanId: Id_17,
-    Name: Manual-4.DefaultsReinstated,
-    Resource: Manual-4.DefaultsReinstated,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_16,
-    SpanId: Id_18,
-    Name: Manual-4.DefaultsReinstated.HttpClient,
-    Resource: Manual-4.DefaultsReinstated.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_17,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_19,
-    SpanId: Id_20,
-    Name: Manual-4.DefaultsReinstated.HttpListener,
-    Resource: Manual-4.DefaultsReinstated.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_21,
-    SpanId: Id_22,
-    Name: Manual-5.Ext.HttpListener,
-    Resource: Manual-5.Ext.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_23,
-    SpanId: Id_24,
-    Name: Manual-5.Ext.Outer,
-    Resource: Manual-5.Ext.Outer,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1,
-      usr.email: [email protected],
-      usr.id: my-id,
-      usr.name: Bits,
-      usr.role: Mascot,
-      usr.scope: test-scope,
-      usr.session_id: abc123
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 2.0
-    }
-  },
-  {
-    TraceId: Id_23,
-    SpanId: Id_25,
-    Name: Manual-5.Ext.Inner,
-    Resource: Manual-5.Ext.Inner,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_24,
-    Error: 1,
-    Tags: {
-      Custom: Some-Value,
-      env: integration_tests,
-      error.msg: Exception of type 'CustomException' was thrown.,
-      error.stack:
[...]
-      error.type: CustomException,
-      language: dotnet
-    },
-    Metrics: {
-      Some-Number: 123.0
-    }
-  },
-  {
-    TraceId: Id_23,
-    SpanId: Id_26,
-    Name: Manual-5.Ext.HttpClient,
-    Resource: Manual-5.Ext.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_25,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_27,
-    SpanId: Id_28,
-    Name: Manual-6.EventSdk.Custom.Outer,
-    Resource: Manual-6.EventSdk.Custom.Outer,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      appsec.events.custom-event-meta.key-1: val-1,
-      appsec.events.custom-event-meta.key-2: val-2,
-      appsec.events.custom-event-meta.track: true,
-      appsec.events.custom-event.track: true,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1,
-      _dd.appsec.events.custom-event-meta.sdk: true,
-      _dd.appsec.events.custom-event.sdk: true
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_27,
-    SpanId: Id_29,
-    Name: Manual-6.EventSdk.Custom.Inner,
-    Resource: Manual-6.EventSdk.Custom.Inner,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_28,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_27,
-    SpanId: Id_30,
-    Name: Manual-6.Ext.HttpClient,
-    Resource: Manual-6.Ext.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_29,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_31,
-    SpanId: Id_32,
-    Name: Manual-6.Ext.HttpListener,
-    Resource: Manual-6.Ext.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_33,
-    SpanId: Id_34,
-    Name: Manual-7.EventSdk.Success.Outer,
-    Resource: Manual-7.EventSdk.Success.Outer,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      appsec.events.users.login.success.key-1: val-1,
-      appsec.events.users.login.success.key-2: val-2,
-      appsec.events.users.login.success.track: true,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1,
-      usr.id: my-id,
-      _dd.appsec.events.users.login.success.sdk: true
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_33,
-    SpanId: Id_35,
-    Name: Manual-7.EventSdk.Success.Inner,
-    Resource: Manual-7.EventSdk.Success.Inner,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_34,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_33,
-    SpanId: Id_36,
-    Name: Manual-7.Ext.HttpClient,
-    Resource: Manual-7.Ext.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_35,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_37,
-    SpanId: Id_38,
-    Name: Manual-7.Ext.HttpListener,
-    Resource: Manual-7.Ext.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_39,
-    SpanId: Id_40,
-    Name: Manual-8.EventSdk.Failure.Outer,
-    Resource: Manual-8.EventSdk.Failure.Outer,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      appsec.events.users.login.failure.key-1: val-1,
-      appsec.events.users.login.failure.key-2: val-2,
-      appsec.events.users.login.failure.track: true,
-      appsec.events.users.login.failure.usr.exists: true,
-      appsec.events.users.login.failure.usr.id: my-id,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1,
-      _dd.appsec.events.users.login.failure.sdk: true
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_39,
-    SpanId: Id_41,
-    Name: Manual-8.EventSdk.Failure.Inner,
-    Resource: Manual-8.EventSdk.Failure.Inner,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_40,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_39,
-    SpanId: Id_42,
-    Name: Manual-8.Ext.HttpClient,
-    Resource: Manual-8.Ext.HttpClient,
-    Service: Samples.ManualInstrumentation,
-    ParentId: Id_41,
-    Tags: {
-      env: integration_tests,
-      language: dotnet
-    }
-  },
-  {
-    TraceId: Id_43,
-    SpanId: Id_44,
-    Name: Manual-8.Ext.HttpListener,
-    Resource: Manual-8.Ext.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  },
-  {
-    TraceId: Id_45,
-    SpanId: Id_46,
-    Name: Manual-9.CustomContext.HttpListener,
-    Resource: Manual-9.CustomContext.HttpListener,
-    Service: Samples.ManualInstrumentation,
-    Tags: {
-      content: PONG,
-      env: integration_tests,
-      language: dotnet,
-      runtime-id: Guid_1
-    },
-    Metrics: {
-      process_id: 0,
-      _dd.top_level: 1.0,
-      _dd.tracer_kr: 1.0,
-      _sampling_priority_v1: 1.0
-    }
-  }

[datadog-ddstaging[bot]]

Datadog Report

Branch report: gleocadie/override-native-call-for-wrapped-functions Commit report: 0e71b42 Test service: dd-trace-dotnet

:x: 91 Failed (0 Known Flaky), 451616 Passed, 3006 Skipped, 19h 54m 45.74s Total Time

:x: Failed Tests (91)

This report shows up to 5 failed tests.

• CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

  Expand for error

  xpected agent.NbCallsOnProfilingEndpoint to be greater than 0, but found 0.
  

• CheckCpuLimit - Datadog.Profiler.IntegrationTests.SmokeTests.CpuLimitTest - Details

  Expand for error

  xpected agent.NbCallsOnProfilingEndpoint to be greater than 0, but found 0.
  

• IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

  Expand for error

  xpected exit code: 0, actual exit code: 134.
  

• SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

  Expand for error

  xpected exit code: 0, actual exit code: 134.
  

• SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

  Expand for error

  xpected exit code: 0, actual exit code: 134.
  

[andrewlock]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

• This PR (5749)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 65, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (982ms)  : 960, 1005
     .   : milestone, 982,
    master - mean (981ms)  : 960, 1003
     .   : milestone, 981,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (682ms)  : 666, 697
     .   : milestone, 682,
    master - mean (679ms)  : 666, 692
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (640ms)  : 623, 657
     .   : milestone, 640,
    master - mean (634ms)  : 620, 649
     .   : milestone, 634,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 195
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (1,100ms)  : 1071, 1128
     .   : milestone, 1100,
    master - mean (1,093ms)  : 1065, 1121
     .   : milestone, 1093,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (277ms)  : 272, 281
     .   : milestone, 277,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (872ms)  : 839, 906
     .   : milestone, 872,
    master - mean (870ms)  : 847, 893
     .   : milestone, 870,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5749) - mean (266ms)  : 262, 271
     .   : milestone, 266,
    master - mean (265ms)  : 261, 269
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5749) - mean (851ms)  : 816, 886
     .   : milestone, 851,
    master - mean (850ms)  : 818, 882
     .   : milestone, 850,

[andrewlock]

Benchmarks Report for tracer :snail:

Benchmarks for #5749 compared to master:

• 2 benchmarks are slower, with geometric mean 1.200
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartStopWithChild	net6.0	8.21μs	44.8ns	269ns	0.0156	0.00779	0	5.61 KB
master	StartStopWithChild	netcoreapp3.1	10μs	53.8ns	304ns	0.015	0.00499	0	5.8 KB
master	StartStopWithChild	net472	16.3μs	35.8ns	139ns	1.03	0.3	0.0974	6.22 KB
#5749	StartStopWithChild	net6.0	8.08μs	45.5ns	322ns	0.0208	0.00834	0	5.62 KB
#5749	StartStopWithChild	netcoreapp3.1	10.2μs	44.8ns	173ns	0.0152	0.00507	0	5.8 KB
#5749	StartStopWithChild	net472	16.3μs	56.5ns	219ns	1.03	0.298	0.0887	6.2 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	494μs	370ns	1.38μs	0	0	0	2.7 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	654μs	285ns	1.1μs	0	0	0	2.7 KB
master	WriteAndFlushEnrichedTraces	net472	843μs	355ns	1.28μs	0.422	0	0	3.3 KB
#5749	WriteAndFlushEnrichedTraces	net6.0	482μs	335ns	1.3μs	0	0	0	2.7 KB
#5749	WriteAndFlushEnrichedTraces	netcoreapp3.1	674μs	228ns	822ns	0	0	0	2.7 KB
#5749	WriteAndFlushEnrichedTraces	net472	847μs	503ns	1.95μs	0.422	0	0	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net6.0	147μs	794ns	4.49μs	0.152	0	0	14.47 KB
master	SendRequest	netcoreapp3.1	159μs	848ns	5.3μs	0.157	0	0	17.27 KB
master	SendRequest	net472	0.000771ns	0.000473ns	0.00171ns	0	0	0	0 b
#5749	SendRequest	net6.0	144μs	718ns	4.92μs	0.147	0	0	14.47 KB
#5749	SendRequest	netcoreapp3.1	166μs	942ns	7.05μs	0.157	0	0	17.27 KB
#5749	SendRequest	net472	0.00177ns	0.000642ns	0.00231ns	0	0	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	566μs	2.67μs	9.99μs	0.556	0	0	41.72 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	666μs	3.33μs	15.6μs	0.322	0	0	41.91 KB
master	WriteAndFlushEnrichedTraces	net472	864μs	2.96μs	11.1μs	8.45	2.53	0.422	53.29 KB
#5749	WriteAndFlushEnrichedTraces	net6.0	589μs	3.12μs	16.8μs	0.553	0	0	41.62 KB
#5749	WriteAndFlushEnrichedTraces	netcoreapp3.1	650μs	1.95μs	7.31μs	0.334	0	0	41.84 KB
#5749	WriteAndFlushEnrichedTraces	net472	845μs	4.01μs	15.5μs	8.08	2.55	0.425	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net6.0	1.41μs	1.48ns	5.75ns	0.0141	0	0	1.02 KB
master	ExecuteNonQuery	netcoreapp3.1	1.83μs	1.44ns	5.58ns	0.0136	0	0	1.02 KB
master	ExecuteNonQuery	net472	2.11μs	1.23ns	4.74ns	0.157	0.00106	0	987 B
#5749	ExecuteNonQuery	net6.0	1.3μs	1.22ns	4.74ns	0.0148	0	0	1.02 KB
#5749	ExecuteNonQuery	netcoreapp3.1	1.72μs	0.392ns	1.41ns	0.0141	0	0	1.02 KB
#5749	ExecuteNonQuery	net472	2.1μs	1.58ns	6.11ns	0.157	0.00105	0	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net6.0	1.3μs	1.29ns	5.01ns	0.0138	0	0	976 B
master	CallElasticsearch	netcoreapp3.1	1.63μs	1.16ns	4.51ns	0.0132	0	0	976 B
master	CallElasticsearch	net472	2.46μs	2.19ns	8.2ns	0.158	0	0	995 B
master	CallElasticsearchAsync	net6.0	1.37μs	0.742ns	2.78ns	0.0129	0	0	952 B
master	CallElasticsearchAsync	netcoreapp3.1	1.64μs	0.853ns	3.3ns	0.0141	0	0	1.02 KB
master	CallElasticsearchAsync	net472	2.74μs	1.86ns	7.2ns	0.166	0	0	1.05 KB
#5749	CallElasticsearch	net6.0	1.27μs	1.51ns	5.83ns	0.0133	0	0	976 B
#5749	CallElasticsearch	netcoreapp3.1	1.57μs	0.688ns	2.58ns	0.0135	0	0	976 B
#5749	CallElasticsearch	net472	2.63μs	3.84ns	14.9ns	0.157	0	0	995 B
#5749	CallElasticsearchAsync	net6.0	1.25μs	0.537ns	2.01ns	0.0131	0	0	952 B
#5749	CallElasticsearchAsync	netcoreapp3.1	1.64μs	0.834ns	3.12ns	0.0132	0	0	1.02 KB
#5749	CallElasticsearchAsync	net472	2.72μs	0.628ns	2.35ns	0.166	0	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net6.0	1.37μs	1.07ns	4.02ns	0.0138	0	0	952 B
master	ExecuteAsync	netcoreapp3.1	1.66μs	1.1ns	4.1ns	0.0132	0	0	952 B
master	ExecuteAsync	net472	1.78μs	0.578ns	2.16ns	0.145	0	0	915 B
#5749	ExecuteAsync	net6.0	1.38μs	0.917ns	3.43ns	0.0131	0	0	952 B
#5749	ExecuteAsync	netcoreapp3.1	1.6μs	0.833ns	3.12ns	0.0127	0	0	952 B
#5749	ExecuteAsync	net472	1.88μs	0.345ns	1.34ns	0.145	0	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net6.0	4.39μs	1.85ns	7.18ns	0.0329	0	0	2.31 KB
master	SendAsync	netcoreapp3.1	5.42μs	2.55ns	9.53ns	0.0378	0	0	2.85 KB
master	SendAsync	net472	7.39μs	1.71ns	6.4ns	0.493	0	0	3.12 KB
#5749	SendAsync	net6.0	4.35μs	2.4ns	9.28ns	0.0327	0	0	2.31 KB
#5749	SendAsync	netcoreapp3.1	5.26μs	2.83ns	11ns	0.0368	0	0	2.85 KB
#5749	SendAsync	net472	7.35μs	2.35ns	9.1ns	0.496	0	0	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	1.47μs	0.71ns	2.66ns	0.0235	0	0	1.64 KB
master	EnrichedLog	netcoreapp3.1	2.36μs	1.4ns	5.24ns	0.0213	0	0	1.64 KB
master	EnrichedLog	net472	2.57μs	1.07ns	4.15ns	0.249	0	0	1.57 KB
#5749	EnrichedLog	net6.0	1.63μs	0.362ns	1.35ns	0.0229	0	0	1.64 KB
#5749	EnrichedLog	netcoreapp3.1	2.18μs	1.17ns	4.52ns	0.022	0	0	1.64 KB
#5749	EnrichedLog	net472	2.6μs	1.55ns	5.79ns	0.25	0	0	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	120μs	119ns	461ns	0	0	0	4.28 KB
master	EnrichedLog	netcoreapp3.1	126μs	105ns	394ns	0	0	0	4.28 KB
master	EnrichedLog	net472	151μs	179ns	694ns	0.676	0.225	0	4.46 KB
#5749	EnrichedLog	net6.0	120μs	123ns	476ns	0	0	0	4.28 KB
#5749	EnrichedLog	netcoreapp3.1	125μs	96.5ns	348ns	0	0	0	4.28 KB
#5749	EnrichedLog	net472	151μs	121ns	469ns	0.678	0.226	0	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	3.02μs	1.21ns	4.18ns	0.0318	0	0	2.2 KB
master	EnrichedLog	netcoreapp3.1	4.15μs	1.82ns	7.04ns	0.0296	0	0	2.2 KB
master	EnrichedLog	net472	5.04μs	1.36ns	5.29ns	0.319	0	0	2.02 KB
#5749	EnrichedLog	net6.0	3.32μs	18.4ns	146ns	0.0301	0	0	2.2 KB
#5749	EnrichedLog	netcoreapp3.1	4.2μs	1.78ns	6.9ns	0.0294	0	0	2.2 KB
#5749	EnrichedLog	net472	4.87μs	1.19ns	4.59ns	0.319	0	0	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net6.0	1.34μs	0.789ns	2.85ns	0.0154	0	0	1.14 KB
master	SendReceive	netcoreapp3.1	1.77μs	0.496ns	1.92ns	0.0151	0	0	1.14 KB
master	SendReceive	net472	2.08μs	0.886ns	3.32ns	0.184	0	0	1.16 KB
#5749	SendReceive	net6.0	1.39μs	0.586ns	2.27ns	0.016	0	0	1.14 KB
#5749	SendReceive	netcoreapp3.1	1.77μs	0.574ns	2.22ns	0.015	0	0	1.14 KB
#5749	SendReceive	net472	2.17μs	2.53ns	9.11ns	0.183	0	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	2.81μs	1.23ns	4.77ns	0.0224	0	0	1.6 KB
master	EnrichedLog	netcoreapp3.1	3.78μs	1.56ns	6.05ns	0.0209	0	0	1.65 KB
master	EnrichedLog	net472	4.43μs	1.93ns	7.21ns	0.322	0	0	2.04 KB
#5749	EnrichedLog	net6.0	2.73μs	1.1ns	4.11ns	0.0218	0	0	1.6 KB
#5749	EnrichedLog	netcoreapp3.1	3.86μs	2.08ns	8.05ns	0.0213	0	0	1.65 KB
#5749	EnrichedLog	net472	4.36μs	3.35ns	13ns	0.324	0	0	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5749

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.251	394.34	493.22
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.152	563.84	649.40

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net6.0	394ns	0.255ns	0.987ns	0.00812	0	0	576 B
master	StartFinishSpan	netcoreapp3.1	564ns	0.426ns	1.65ns	0.00761	0	0	576 B
master	StartFinishSpan	net472	643ns	0.407ns	1.58ns	0.0917	0	0	578 B
master	StartFinishScope	net6.0	496ns	0.208ns	0.805ns	0.00968	0	0	696 B
master	StartFinishScope	netcoreapp3.1	784ns	0.347ns	1.25ns	0.00942	0	0	696 B
master	StartFinishScope	net472	868ns	0.668ns	2.59ns	0.104	0	0	658 B
#5749	StartFinishSpan	net6.0	493ns	0.261ns	1.01ns	0.0081	0	0	576 B
#5749	StartFinishSpan	netcoreapp3.1	649ns	0.609ns	2.28ns	0.00785	0	0	576 B
#5749	StartFinishSpan	net472	656ns	0.515ns	2ns	0.0918	0	0	578 B
#5749	StartFinishScope	net6.0	533ns	0.295ns	1.14ns	0.00984	0	0	696 B
#5749	StartFinishScope	netcoreapp3.1	804ns	0.478ns	1.85ns	0.0095	0	0	696 B
#5749	StartFinishScope	net472	878ns	0.978ns	3.79ns	0.104	0	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net6.0	653ns	0.518ns	2ns	0.00989	0	0	696 B
master	RunOnMethodBegin	netcoreapp3.1	894ns	0.626ns	2.42ns	0.0094	0	0	696 B
master	RunOnMethodBegin	net472	1.17μs	0.922ns	3.57ns	0.104	0	0	658 B
#5749	RunOnMethodBegin	net6.0	646ns	0.289ns	1.12ns	0.00968	0	0	696 B
#5749	RunOnMethodBegin	netcoreapp3.1	892ns	0.396ns	1.53ns	0.0093	0	0	696 B
#5749	RunOnMethodBegin	net472	1.16μs	0.799ns	2.99ns	0.105	0	0	658 B

[andrewlock]

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

• This PR (5749)
• master
• benchmarks/2.9.0

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5749) (11.241M)   : 0, 11240527
    master (11.262M)   : 0, 11261987
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (5749) (7.189M)   : 0, 7188584
    master (7.252M)   : 0, 7252121
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.492M)   : 0, 7491512

    section Manual
    master (11.082M)   : 0, 11081514

    section Manual + Automatic
    This PR (5749) (6.743M)   : 0, 6743234
    master (6.511M)   : 0, 6511339

    section DD_TRACE_ENABLED=0
    master (10.305M)   : 0, 10305041

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5749) (9.422M)   : 0, 9422108
    master (9.633M)   : 0, 9633274
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (5749) (6.284M)   : 0, 6284438
    master (6.436M)   : 0, 6436394

    section Trace stats
    master (6.676M)   : 0, 6676124

    section Manual
    master (9.575M)   : 0, 9575331

    section Manual + Automatic
    This PR (5749) (5.892M)   : 0, 5892285
    master (5.718M)   : 0, 5718155

    section DD_TRACE_ENABLED=0
    master (8.573M)   : 0, 8572716

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5749) (9.345M)   : 0, 9345379
    master (9.876M)   : 0, 9876001
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (5749) (6.112M)   : crit ,0, 6112132
    master (6.512M)   : 0, 6511943
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (7.089M)   : 0, 7089152

    section Manual
    master (10.204M)   : 0, 10203572

    section Manual + Automatic
    This PR (5749) (5.693M)   : crit ,0, 5692757
    master (6.050M)   : 0, 6050240

    section DD_TRACE_ENABLED=0
    master (9.471M)   : 0, 9471285