dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Dynamic Instrumentation] Fix SymDB config keys to match RFC

Open dudikeleti opened this issue 1 year ago • 4 comments

Summary of changes

Change the config key of enabling SymDB

Reason for change

To match SymDB internal RFC

dudikeleti avatar Jun 25 '24 11:06 dudikeleti

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (75ms)  : 65, 85
     .   : milestone, 75,
    master - mean (72ms)  : 63, 82
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (1,018ms)  : 997, 1040
     .   : milestone, 1018,
    master - mean (1,013ms)  : 991, 1035
     .   : milestone, 1013,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (109ms)  : 106, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (705ms)  : 682, 728
     .   : milestone, 705,
    master - mean (708ms)  : 685, 731
     .   : milestone, 708,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (93ms)  : 90, 97
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (668ms)  : 647, 689
     .   : milestone, 668,
    master - mean (658ms)  : 634, 682
     .   : milestone, 658,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (191ms)  : 188, 194
     .   : milestone, 191,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (1,111ms)  : 1090, 1132
     .   : milestone, 1111,
    master - mean (1,108ms)  : 1088, 1128
     .   : milestone, 1108,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (884ms)  : 860, 908
     .   : milestone, 884,
    master - mean (881ms)  : 860, 903
     .   : milestone, 881,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5737) - mean (264ms)  : 260, 269
     .   : milestone, 264,
    master - mean (264ms)  : 260, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5737) - mean (863ms)  : 834, 893
     .   : milestone, 863,
    master - mean (859ms)  : 837, 882
     .   : milestone, 859,

andrewlock avatar Jun 25 '24 11:06 andrewlock

Datadog Report

Branch report: dudik_update-config-keys Commit report: b36a836 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 342345 Passed, 1757 Skipped, 14h 28m 24.66s Total Time

datadog-ddstaging[bot] avatar Jun 25 '24 12:06 datadog-ddstaging[bot]

Benchmarks Report for tracer :snail:

Benchmarks for #5737 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.128
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.8μs 44.1ns 292ns 0.0153 0.00763 0 5.42 KB
master StartStopWithChild netcoreapp3.1 10.2μs 56.6ns 339ns 0.0242 0.00968 0 5.62 KB
master StartStopWithChild net472 16.5μs 65.1ns 252ns 1.01 0.296 0.0821 6.07 KB
#5737 StartStopWithChild net6.0 7.87μs 42.5ns 244ns 0.0166 0.00416 0 5.43 KB
#5737 StartStopWithChild netcoreapp3.1 10.4μs 55.8ns 325ns 0.0155 0.00516 0 5.62 KB
#5737 StartStopWithChild net472 17.9μs 141ns 1.41μs 1.03 0.318 0.0972 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 495μs 218ns 846ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 159ns 596ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 820μs 205ns 795ns 0.408 0 0 3.3 KB
#5737 WriteAndFlushEnrichedTraces net6.0 487μs 109ns 424ns 0 0 0 2.7 KB
#5737 WriteAndFlushEnrichedTraces netcoreapp3.1 635μs 400ns 1.55μs 0 0 0 2.7 KB
#5737 WriteAndFlushEnrichedTraces net472 843μs 1.03μs 3.73μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 172μs 123ns 474ns 0.258 0 0 18.45 KB
master SendRequest netcoreapp3.1 189μs 213ns 824ns 0.189 0 0 20.61 KB
master SendRequest net472 0.000438ns 0.000248ns 0.00096ns 0 0 0 0 b
#5737 SendRequest net6.0 172μs 195ns 756ns 0.172 0 0 18.45 KB
#5737 SendRequest netcoreapp3.1 193μs 281ns 1.09μs 0.193 0 0 20.61 KB
#5737 SendRequest net472 0.000161ns 0.000123ns 0.000461ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 553μs 277ns 1.07μs 0.541 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 981ns 3.8μs 0.327 0 0 41.71 KB
master WriteAndFlushEnrichedTraces net472 836μs 4.08μs 16.3μs 8.08 2.55 0.425 53.23 KB
#5737 WriteAndFlushEnrichedTraces net6.0 540μs 710ns 2.75μs 0.539 0 0 41.7 KB
#5737 WriteAndFlushEnrichedTraces netcoreapp3.1 649μs 1μs 3.89μs 0.324 0 0 41.78 KB
#5737 WriteAndFlushEnrichedTraces net472 887μs 3.42μs 13.3μs 8.25 2.6 0.434 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.19μs 0.592ns 2.29ns 0.0144 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 0.639ns 2.47ns 0.0132 0 0 1.02 KB
master ExecuteNonQuery net472 1.99μs 3.31ns 12.4ns 0.157 0 0 987 B
#5737 ExecuteNonQuery net6.0 1.25μs 0.981ns 3.8ns 0.0144 0 0 1.02 KB
#5737 ExecuteNonQuery netcoreapp3.1 1.69μs 2.15ns 8.31ns 0.0136 0 0 1.02 KB
#5737 ExecuteNonQuery net472 1.97μs 1.03ns 4ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 6.71ns 37.9ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.58μs 2.33ns 9.01ns 0.0134 0 0 976 B
master CallElasticsearch net472 2.52μs 0.964ns 3.61ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.34μs 0.738ns 2.86ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.727ns 2.82ns 0.014 0 0 1.02 KB
master CallElasticsearchAsync net472 2.63μs 1.71ns 6.62ns 0.167 0 0 1.05 KB
#5737 CallElasticsearch net6.0 1.24μs 0.68ns 2.63ns 0.0136 0 0 976 B
#5737 CallElasticsearch netcoreapp3.1 1.5μs 1.65ns 6.39ns 0.0127 0 0 976 B
#5737 CallElasticsearch net472 2.47μs 1.23ns 4.76ns 0.157 0 0 995 B
#5737 CallElasticsearchAsync net6.0 1.32μs 0.802ns 3.11ns 0.0134 0 0 952 B
#5737 CallElasticsearchAsync netcoreapp3.1 1.55μs 0.622ns 2.41ns 0.0138 0 0 1.02 KB
#5737 CallElasticsearchAsync net472 2.51μs 1.21ns 4.68ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.26μs 0.581ns 2.25ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 0.768ns 2.97ns 0.0128 0 0 952 B
master ExecuteAsync net472 1.75μs 1.4ns 5.04ns 0.145 0 0 915 B
#5737 ExecuteAsync net6.0 1.25μs 0.595ns 2.3ns 0.0132 0 0 952 B
#5737 ExecuteAsync netcoreapp3.1 1.52μs 0.405ns 1.52ns 0.0129 0 0 952 B
#5737 ExecuteAsync net472 1.78μs 1.09ns 4.23ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.01μs 1ns 3.88ns 0.03 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.04μs 2.26ns 8.77ns 0.0376 0 0 2.76 KB
master SendAsync net472 7.56μs 2.53ns 9.46ns 0.498 0 0 3.15 KB
#5737 SendAsync net6.0 4.16μs 4.2ns 15.7ns 0.0312 0 0 2.22 KB
#5737 SendAsync netcoreapp3.1 5.12μs 2.23ns 8.63ns 0.0357 0 0 2.76 KB
#5737 SendAsync net472 7.72μs 26ns 101ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 0.775ns 3ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.12μs 1.87ns 7.25ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.5μs 1.71ns 6.4ns 0.249 0 0 1.57 KB
#5737 EnrichedLog net6.0 1.42μs 0.583ns 2.18ns 0.0227 0 0 1.64 KB
#5737 EnrichedLog netcoreapp3.1 2.14μs 1.49ns 5.58ns 0.0225 0 0 1.64 KB
#5737 EnrichedLog net472 2.55μs 1.05ns 4.06ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 118μs 210ns 812ns 0.0576 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 91.2ns 353ns 0 0 0 4.28 KB
master EnrichedLog net472 147μs 92.8ns 360ns 0.658 0.219 0 4.46 KB
#5737 EnrichedLog net6.0 115μs 44.1ns 165ns 0.0579 0 0 4.28 KB
#5737 EnrichedLog netcoreapp3.1 117μs 58.2ns 210ns 0 0 0 4.28 KB
#5737 EnrichedLog net472 147μs 48.6ns 188ns 0.66 0.22 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 1.48ns 5.73ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.28μs 1.23ns 4.61ns 0.0279 0 0 2.2 KB
master EnrichedLog net472 4.76μs 1.63ns 6.3ns 0.321 0 0 2.02 KB
#5737 EnrichedLog net6.0 2.99μs 3.09ns 12ns 0.03 0 0 2.2 KB
#5737 EnrichedLog netcoreapp3.1 4.07μs 1.2ns 4.5ns 0.0285 0 0 2.2 KB
#5737 EnrichedLog net472 4.92μs 1.31ns 5.08ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.3μs 0.558ns 2.16ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 1.44ns 5.59ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.1μs 1.13ns 4.37ns 0.183 0.00105 0 1.16 KB
#5737 SendReceive net6.0 1.38μs 0.606ns 2.27ns 0.0159 0 0 1.14 KB
#5737 SendReceive netcoreapp3.1 1.84μs 1.04ns 4.01ns 0.0155 0 0 1.14 KB
#5737 SendReceive net472 2.13μs 1.75ns 6.78ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.69μs 0.837ns 3.24ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.8μs 0.776ns 2.91ns 0.0209 0 0 1.65 KB
master EnrichedLog net472 4.39μs 0.944ns 3.53ns 0.322 0 0 2.04 KB
#5737 EnrichedLog net6.0 2.62μs 2.95ns 10.7ns 0.0223 0 0 1.6 KB
#5737 EnrichedLog netcoreapp3.1 3.88μs 1.17ns 4.38ns 0.0218 0 0 1.65 KB
#5737 EnrichedLog net472 4.48μs 1.94ns 7.53ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5737

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.128 612.23 690.44

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 420ns 0.265ns 0.956ns 0.00806 0 0 576 B
master StartFinishSpan netcoreapp3.1 577ns 0.494ns 1.91ns 0.00768 0 0 576 B
master StartFinishSpan net472 613ns 0.641ns 2.48ns 0.0916 0 0 578 B
master StartFinishScope net6.0 533ns 0.145ns 0.541ns 0.00987 0 0 696 B
master StartFinishScope netcoreapp3.1 740ns 0.757ns 2.93ns 0.00949 0 0 696 B
master StartFinishScope net472 842ns 0.428ns 1.48ns 0.104 0 0 658 B
#5737 StartFinishSpan net6.0 402ns 0.542ns 1.96ns 0.00815 0 0 576 B
#5737 StartFinishSpan netcoreapp3.1 610ns 0.216ns 0.779ns 0.00804 0 0 576 B
#5737 StartFinishSpan net472 691ns 0.629ns 2.35ns 0.0916 0 0 578 B
#5737 StartFinishScope net6.0 531ns 0.128ns 0.481ns 0.00989 0 0 696 B
#5737 StartFinishScope netcoreapp3.1 667ns 0.279ns 1.01ns 0.0094 0 0 696 B
#5737 StartFinishScope net472 903ns 0.499ns 1.8ns 0.105 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 659ns 0.195ns 0.731ns 0.00995 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 967ns 4.69ns 18.7ns 0.00948 0 0 696 B
master RunOnMethodBegin net472 1.16μs 0.364ns 1.41ns 0.104 0 0 658 B
#5737 RunOnMethodBegin net6.0 624ns 0.958ns 3.71ns 0.0097 0 0 696 B
#5737 RunOnMethodBegin netcoreapp3.1 968ns 0.932ns 3.61ns 0.00916 0 0 696 B
#5737 RunOnMethodBegin net472 1.14μs 0.475ns 1.78ns 0.104 0 0 658 B

andrewlock avatar Jun 25 '24 12:06 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5737) (11.958M)   : 0, 11957845
    master (11.956M)   : 0, 11956052
    benchmarks/2.9.0 (11.967M)   : 0, 11966853

    section Automatic
    This PR (5737) (8.118M)   : 0, 8118238
    master (8.134M)   : 0, 8133534
    benchmarks/2.9.0 (8.405M)   : 0, 8404892

    section Trace stats
    master (8.463M)   : 0, 8462714

    section Manual
    This PR (5737) (10.296M)   : 0, 10295859
    master (10.444M)   : 0, 10443993

    section Manual + Automatic
    This PR (5737) (7.659M)   : 0, 7658833
    master (7.695M)   : 0, 7694938

    section Version Conflict
    master (6.851M)   : 0, 6850859


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5737) (9.447M)   : 0, 9447486
    master (9.502M)   : 0, 9502331
    benchmarks/2.9.0 (9.255M)   : 0, 9255366

    section Automatic
    This PR (5737) (6.291M)   : 0, 6291280
    master (6.589M)   : 0, 6589204

    section Trace stats
    master (6.630M)   : 0, 6630265

    section Manual
    This PR (5737) (7.923M)   : 0, 7923105
    master (8.176M)   : 0, 8176343

    section Manual + Automatic
    This PR (5737) (6.213M)   : 0, 6212696
    master (6.047M)   : 0, 6047122

    section Version Conflict
    master (5.500M)   : 0, 5500346


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5737) (10.116M)   : 0, 10115720
    master (10.201M)   : 0, 10201473
    benchmarks/2.9.0 (10.302M)   : 0, 10302396

    section Automatic
    This PR (5737) (7.200M)   : 0, 7200171
    master (7.200M)   : 0, 7200433
    benchmarks/2.9.0 (7.635M)   : 0, 7634994

    section Trace stats
    master (7.395M)   : 0, 7395068

    section Manual
    This PR (5737) (8.839M)   : 0, 8839105
    master (9.027M)   : 0, 9026978

    section Manual + Automatic
    This PR (5737) (6.942M)   : 0, 6942438
    master (6.888M)   : 0, 6888149

    section Version Conflict
    master (6.270M)   : 0, 6269938

andrewlock avatar Jun 25 '24 15:06 andrewlock