dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[build] update root `.dockerignore` file

Open lucaspimentel opened this issue 1 year ago • 4 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

lucaspimentel avatar Jun 20 '24 18:06 lucaspimentel

Datadog Report

Branch report: lpimentel/dockerignore Commit report: 8b7985b Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 342266 Passed, 1783 Skipped, 14h 39m 51.39s Total Time

datadog-ddstaging[bot] avatar Jun 20 '24 18:06 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (75ms)  : 64, 85
     .   : milestone, 75,
    master - mean (70ms)  : 66, 75
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (1,049ms)  : 1030, 1069
     .   : milestone, 1049,
    master - mean (1,048ms)  : 1028, 1068
     .   : milestone, 1048,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (109ms)  : 106, 113
     .   : milestone, 109,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (747ms)  : 729, 766
     .   : milestone, 747,
    master - mean (745ms)  : 722, 769
     .   : milestone, 745,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (94ms)  : 89, 98
     .   : milestone, 94,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (697ms)  : 678, 717
     .   : milestone, 697,
    master - mean (696ms)  : 678, 714
     .   : milestone, 696,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (191ms)  : 187, 196
     .   : milestone, 191,
    master - mean (192ms)  : 188, 196
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (1,192ms)  : 1171, 1213
     .   : milestone, 1192,
    master - mean (1,187ms)  : 1164, 1210
     .   : milestone, 1187,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (278ms)  : 271, 285
     .   : milestone, 278,
    master - mean (277ms)  : 271, 283
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (966ms)  : 942, 990
     .   : milestone, 966,
    master - mean (967ms)  : 944, 990
     .   : milestone, 967,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5719) - mean (265ms)  : 261, 270
     .   : milestone, 265,
    master - mean (265ms)  : 259, 271
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5719) - mean (950ms)  : 924, 976
     .   : milestone, 950,
    master - mean (949ms)  : 926, 971
     .   : milestone, 949,

andrewlock avatar Jun 20 '24 19:06 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5719) (11.564M)   : 0, 11564333
    master (11.512M)   : 0, 11511804
    benchmarks/2.9.0 (11.486M)   : 0, 11485944

    section Automatic
    This PR (5719) (7.852M)   : 0, 7852091
    master (7.843M)   : 0, 7842926
    benchmarks/2.9.0 (8.079M)   : 0, 8078652

    section Trace stats
    master (8.151M)   : 0, 8151401

    section Manual
    This PR (5719) (10.077M)   : 0, 10077184
    master (10.013M)   : 0, 10013455

    section Manual + Automatic
    This PR (5719) (7.377M)   : 0, 7377141
    master (7.489M)   : 0, 7488707

    section Version Conflict
    master (6.642M)   : 0, 6641889


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5719) (9.549M)   : 0, 9549125
    master (9.495M)   : 0, 9494938
    benchmarks/2.9.0 (9.655M)   : 0, 9655153

    section Automatic
    This PR (5719) (6.520M)   : 0, 6520035
    master (6.479M)   : 0, 6478710

    section Trace stats
    master (6.879M)   : 0, 6879028

    section Manual
    This PR (5719) (8.131M)   : 0, 8130685
    master (8.078M)   : 0, 8078195

    section Manual + Automatic
    This PR (5719) (6.064M)   : 0, 6064104
    master (6.175M)   : 0, 6175368

    section Version Conflict
    master (5.559M)   : 0, 5559377


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5719) (9.963M)   : 0, 9963415
    master (10.125M)   : 0, 10125420
    benchmarks/2.9.0 (10.359M)   : 0, 10359271

    section Automatic
    This PR (5719) (7.086M)   : 0, 7085765
    master (7.228M)   : 0, 7227689
    benchmarks/2.9.0 (7.441M)   : 0, 7440770

    section Trace stats
    master (7.543M)   : 0, 7543465

    section Manual
    This PR (5719) (8.677M)   : 0, 8677296
    master (9.037M)   : 0, 9037258

    section Manual + Automatic
    This PR (5719) (6.765M)   : 0, 6765240
    master (6.948M)   : 0, 6947618

    section Version Conflict
    master (6.297M)   : 0, 6296514

andrewlock avatar Jun 20 '24 19:06 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5719 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.136
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.69μs 43.5ns 292ns 0.0144 0.00722 0 5.42 KB
master StartStopWithChild netcoreapp3.1 10μs 56.3ns 402ns 0.0201 0.0101 0 5.62 KB
master StartStopWithChild net472 16.2μs 55.7ns 216ns 1.01 0.289 0.0883 6.06 KB
#5719 StartStopWithChild net6.0 7.65μs 42.1ns 249ns 0.0155 0.00387 0 5.43 KB
#5719 StartStopWithChild netcoreapp3.1 10.1μs 55.8ns 361ns 0.0151 0.00504 0 5.62 KB
#5719 StartStopWithChild net472 16.2μs 61.1ns 237ns 1.01 0.29 0.0941 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 490μs 89.6ns 310ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 641μs 206ns 797ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 842μs 1.25μs 4.83μs 0.419 0 0 3.3 KB
#5719 WriteAndFlushEnrichedTraces net6.0 478μs 158ns 610ns 0 0 0 2.7 KB
#5719 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 192ns 745ns 0 0 0 2.7 KB
#5719 WriteAndFlushEnrichedTraces net472 836μs 385ns 1.49μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 207ns 803ns 0.169 0 0 18.45 KB
master SendRequest netcoreapp3.1 193μs 240ns 898ns 0.193 0 0 20.61 KB
master SendRequest net472 9.67E‑05ns 5.95E‑05ns 0.000223ns 0 0 0 0 b
#5719 SendRequest net6.0 171μs 234ns 905ns 0.257 0 0 18.45 KB
#5719 SendRequest netcoreapp3.1 193μs 381ns 1.48μs 0.191 0 0 20.61 KB
#5719 SendRequest net472 2.6E‑05ns 2.6E‑05ns 9.38E‑05ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 550μs 1.77μs 6.86μs 0.53 0 0 41.81 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 1.55μs 6μs 0.316 0 0 41.61 KB
master WriteAndFlushEnrichedTraces net472 873μs 4.04μs 16.2μs 8.36 2.64 0.44 53.28 KB
#5719 WriteAndFlushEnrichedTraces net6.0 537μs 259ns 1μs 0.53 0 0 41.82 KB
#5719 WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 1.21μs 4.68μs 0.314 0 0 41.71 KB
#5719 WriteAndFlushEnrichedTraces net472 870μs 3.63μs 14.1μs 8.36 2.64 0.44 53.27 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.28μs 0.539ns 2.02ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.7μs 0.728ns 2.82ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 1.94μs 2.35ns 9.12ns 0.156 0 0 987 B
#5719 ExecuteNonQuery net6.0 1.18μs 1.05ns 4.08ns 0.0142 0 0 1.02 KB
#5719 ExecuteNonQuery netcoreapp3.1 1.67μs 1.03ns 3.98ns 0.0134 0 0 1.02 KB
#5719 ExecuteNonQuery net472 1.99μs 0.817ns 2.95ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.23μs 0.629ns 2.44ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.677ns 2.53ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.69μs 1.3ns 4.87ns 0.158 0.00134 0 995 B
master CallElasticsearchAsync net6.0 1.3μs 0.466ns 1.68ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.62μs 0.469ns 1.69ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.69μs 1.25ns 4.83ns 0.167 0 0 1.05 KB
#5719 CallElasticsearch net6.0 1.13μs 0.87ns 3.37ns 0.0136 0 0 976 B
#5719 CallElasticsearch netcoreapp3.1 1.54μs 0.41ns 1.48ns 0.0131 0 0 976 B
#5719 CallElasticsearch net472 2.5μs 0.827ns 3.09ns 0.157 0.00125 0 995 B
#5719 CallElasticsearchAsync net6.0 1.25μs 0.705ns 2.73ns 0.0131 0 0 952 B
#5719 CallElasticsearchAsync netcoreapp3.1 1.66μs 2.01ns 7.51ns 0.0136 0 0 1.02 KB
#5719 CallElasticsearchAsync net472 2.7μs 1.24ns 4.8ns 0.166 0.00135 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.539ns 2.09ns 0.0133 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.63μs 1.09ns 4.24ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.85μs 1ns 3.89ns 0.145 0 0 915 B
#5719 ExecuteAsync net6.0 1.23μs 0.525ns 1.96ns 0.0136 0 0 952 B
#5719 ExecuteAsync netcoreapp3.1 1.61μs 1.28ns 4.96ns 0.0129 0 0 952 B
#5719 ExecuteAsync net472 1.86μs 1.02ns 3.8ns 0.145 0.000932 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.1μs 2.35ns 8.47ns 0.0311 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.09μs 0.971ns 3.36ns 0.0384 0 0 2.76 KB
master SendAsync net472 7.79μs 1.66ns 6.41ns 0.499 0 0 3.15 KB
#5719 SendAsync net6.0 4.23μs 2.21ns 8.57ns 0.0297 0 0 2.22 KB
#5719 SendAsync netcoreapp3.1 5.23μs 1.68ns 6.04ns 0.0367 0 0 2.76 KB
#5719 SendAsync net472 7.87μs 2.64ns 9.86ns 0.496 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.5μs 0.8ns 2.99ns 0.0232 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.2μs 2.76ns 10.3ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.53μs 1.22ns 4.55ns 0.249 0 0 1.57 KB
#5719 EnrichedLog net6.0 1.46μs 0.648ns 2.43ns 0.0232 0 0 1.64 KB
#5719 EnrichedLog netcoreapp3.1 2.23μs 1.69ns 6.33ns 0.0212 0 0 1.64 KB
#5719 EnrichedLog net472 2.55μs 0.681ns 2.55ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 208ns 805ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 178ns 689ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 178ns 689ns 0.672 0.224 0 4.46 KB
#5719 EnrichedLog net6.0 115μs 121ns 469ns 0.0569 0 0 4.28 KB
#5719 EnrichedLog netcoreapp3.1 121μs 122ns 472ns 0.0598 0 0 4.28 KB
#5719 EnrichedLog net472 149μs 204ns 790ns 0.668 0.223 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 0.739ns 2.77ns 0.0309 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 2.98ns 11.6ns 0.0287 0 0 2.2 KB
master EnrichedLog net472 4.95μs 1.5ns 5.79ns 0.319 0 0 2.02 KB
#5719 EnrichedLog net6.0 3.09μs 0.425ns 1.59ns 0.0309 0 0 2.2 KB
#5719 EnrichedLog netcoreapp3.1 4.19μs 1.66ns 6.42ns 0.0293 0 0 2.2 KB
#5719 EnrichedLog net472 4.86μs 7.57ns 29.3ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 0.454ns 1.76ns 0.0157 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.69μs 2.13ns 8.27ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.01μs 0.532ns 1.84ns 0.183 0.00101 0 1.16 KB
#5719 SendReceive net6.0 1.41μs 1.12ns 4.2ns 0.0163 0 0 1.14 KB
#5719 SendReceive netcoreapp3.1 1.79μs 1.22ns 4.73ns 0.0153 0 0 1.14 KB
#5719 SendReceive net472 1.99μs 3.43ns 13.3ns 0.183 0.000994 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 0.707ns 2.74ns 0.0218 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4.04μs 1.13ns 4.39ns 0.0222 0 0 1.65 KB
master EnrichedLog net472 4.34μs 2.42ns 8.73ns 0.324 0 0 2.04 KB
#5719 EnrichedLog net6.0 2.73μs 1.28ns 4.96ns 0.0219 0 0 1.6 KB
#5719 EnrichedLog netcoreapp3.1 4.15μs 1.74ns 6.72ns 0.0208 0 0 1.65 KB
#5719 EnrichedLog net472 4.37μs 1.72ns 6.64ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5719

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.136 474.99 539.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 406ns 0.296ns 1.15ns 0.00814 0 0 576 B
master StartFinishSpan netcoreapp3.1 550ns 0.2ns 0.773ns 0.00785 0 0 576 B
master StartFinishSpan net472 758ns 0.511ns 1.98ns 0.0916 0 0 578 B
master StartFinishScope net6.0 475ns 0.186ns 0.719ns 0.00964 0 0 696 B
master StartFinishScope netcoreapp3.1 744ns 0.235ns 0.909ns 0.00925 0 0 696 B
master StartFinishScope net472 870ns 0.993ns 3.85ns 0.104 0 0 658 B
#5719 StartFinishSpan net6.0 437ns 0.278ns 1.08ns 0.00804 0 0 576 B
#5719 StartFinishSpan netcoreapp3.1 552ns 0.256ns 0.991ns 0.00777 0 0 576 B
#5719 StartFinishSpan net472 699ns 1.65ns 6.38ns 0.0918 0 0 578 B
#5719 StartFinishScope net6.0 540ns 0.263ns 1.02ns 0.00972 0 0 696 B
#5719 StartFinishScope netcoreapp3.1 777ns 0.493ns 1.78ns 0.00947 0 0 696 B
#5719 StartFinishScope net472 843ns 1.39ns 5.37ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 718ns 0.22ns 0.853ns 0.00972 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 913ns 0.293ns 1.1ns 0.00932 0 0 696 B
master RunOnMethodBegin net472 1.12μs 0.274ns 1.06ns 0.104 0 0 658 B
#5719 RunOnMethodBegin net6.0 669ns 0.129ns 0.499ns 0.00975 0 0 696 B
#5719 RunOnMethodBegin netcoreapp3.1 927ns 0.262ns 1.02ns 0.00939 0 0 696 B
#5719 RunOnMethodBegin net472 1.19μs 0.24ns 0.928ns 0.105 0 0 658 B

andrewlock avatar Jun 20 '24 19:06 andrewlock