dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[CI Visibility] Cache CodeOwners match and MethodSymbolResolver

Open tonyredondo opened this issue 1 year ago • 4 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

tonyredondo avatar Jun 14 '24 14:06 tonyredondo

Datadog Report

Branch report: tony/civisibility-pdb-and-codeowners-cache Commit report: 7406148 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 341764 Passed, 1649 Skipped, 14h 9m 28.94s Total Time

datadog-ddstaging[bot] avatar Jun 14 '24 15:06 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (73ms)  : 66, 81
     .   : milestone, 73,
    master - mean (72ms)  : 65, 80
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (1,017ms)  : 997, 1036
     .   : milestone, 1017,
    master - mean (1,013ms)  : 992, 1034
     .   : milestone, 1013,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (735ms)  : 709, 761
     .   : milestone, 735,
    master - mean (728ms)  : 706, 750
     .   : milestone, 728,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (92ms)  : 89, 95
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (680ms)  : 662, 698
     .   : milestone, 680,
    master - mean (675ms)  : 656, 694
     .   : milestone, 675,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (195ms)  : 191, 198
     .   : milestone, 195,
    master - mean (195ms)  : 191, 198
     .   : milestone, 195,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (1,118ms)  : 1097, 1140
     .   : milestone, 1118,
    master - mean (1,117ms)  : 1097, 1137
     .   : milestone, 1117,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (279ms)  : 274, 283
     .   : milestone, 279,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (913ms)  : 887, 939
     .   : milestone, 913,
    master - mean (909ms)  : 887, 932
     .   : milestone, 909,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5695) - mean (268ms)  : 263, 273
     .   : milestone, 268,
    master - mean (267ms)  : 262, 271
     .   : milestone, 267,

    section CallTarget+Inlining+NGEN
    This PR (5695) - mean (897ms)  : 874, 920
     .   : milestone, 897,
    master - mean (890ms)  : 865, 915
     .   : milestone, 890,

andrewlock avatar Jun 14 '24 15:06 andrewlock

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5695) (11.520M)   : 0, 11520313
    master (11.438M)   : 0, 11438227
    benchmarks/2.9.0 (11.574M)   : 0, 11573681

    section Automatic
    This PR (5695) (7.734M)   : 0, 7734304
    master (7.760M)   : 0, 7760404
    benchmarks/2.9.0 (8.261M)   : 0, 8260805

    section Trace stats
    master (8.093M)   : 0, 8093497

    section Manual
    This PR (5695) (9.998M)   : 0, 9997613
    master (9.921M)   : 0, 9920785

    section Manual + Automatic
    This PR (5695) (7.345M)   : 0, 7345184
    master (7.331M)   : 0, 7330615

    section Version Conflict
    master (6.585M)   : 0, 6585366


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5695) (9.512M)   : 0, 9512178
    master (9.481M)   : 0, 9480572
    benchmarks/2.9.0 (9.623M)   : 0, 9623209

    section Automatic
    This PR (5695) (6.624M)   : 0, 6624145
    master (6.400M)   : 0, 6399659

    section Trace stats
    master (6.953M)   : 0, 6952919

    section Manual
    This PR (5695) (8.108M)   : 0, 8108339
    master (8.277M)   : 0, 8277338

    section Manual + Automatic
    This PR (5695) (5.997M)   : 0, 5997461
    master (6.042M)   : 0, 6041661

    section Version Conflict
    master (5.603M)   : 0, 5603024


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5695) (10.090M)   : 0, 10090285
    master (9.801M)   : 0, 9800651
    benchmarks/2.9.0 (9.948M)   : 0, 9948007

    section Automatic
    This PR (5695) (7.039M)   : 0, 7038884
    master (6.988M)   : 0, 6988350
    benchmarks/2.9.0 (7.263M)   : 0, 7263417

    section Trace stats
    master (7.356M)   : 0, 7356260

    section Manual
    This PR (5695) (9.034M)   : 0, 9034461
    master (8.603M)   : 0, 8602853

    section Manual + Automatic
    This PR (5695) (7.008M)   : 0, 7007533
    master (6.774M)   : 0, 6773730

    section Version Conflict
    master (6.037M)   : 0, 6036783

andrewlock avatar Jun 14 '24 16:06 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5695 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.120
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.79μs 41.7ns 309ns 0.015 0.00375 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.67μs 53.3ns 337ns 0.0235 0.00938 0 5.61 KB
master StartStopWithChild net472 16.2μs 66ns 256ns 1.02 0.291 0.089 6.06 KB
#5695 StartStopWithChild net6.0 7.73μs 35.3ns 137ns 0.0114 0.00379 0 5.42 KB
#5695 StartStopWithChild netcoreapp3.1 9.86μs 53.7ns 304ns 0.0142 0.00949 0 5.61 KB
#5695 StartStopWithChild net472 16μs 26.1ns 97.8ns 1.05 0.341 0.0872 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 476μs 158ns 611ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 195ns 730ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 829μs 329ns 1.23μs 0.411 0 0 3.3 KB
#5695 WriteAndFlushEnrichedTraces net6.0 491μs 332ns 1.29μs 0 0 0 2.7 KB
#5695 WriteAndFlushEnrichedTraces netcoreapp3.1 628μs 109ns 392ns 0 0 0 2.7 KB
#5695 WriteAndFlushEnrichedTraces net472 820μs 145ns 542ns 0.411 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 208ns 805ns 0.171 0 0 18.44 KB
master SendRequest netcoreapp3.1 192μs 307ns 1.19μs 0.191 0 0 20.6 KB
master SendRequest net472 0.00065ns 0.00032ns 0.00124ns 0 0 0 0 b
#5695 SendRequest net6.0 171μs 190ns 711ns 0.168 0 0 18.44 KB
#5695 SendRequest netcoreapp3.1 193μs 361ns 1.4μs 0.194 0 0 20.6 KB
#5695 SendRequest net472 0.000294ns 0.000206ns 0.000799ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 552μs 330ns 1.19μs 0.558 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 1.01μs 3.92μs 0.327 0 0 41.97 KB
master WriteAndFlushEnrichedTraces net472 843μs 3.58μs 15.6μs 8.39 2.52 0.419 53.23 KB
#5695 WriteAndFlushEnrichedTraces net6.0 568μs 430ns 1.67μs 0.541 0 0 41.74 KB
#5695 WriteAndFlushEnrichedTraces netcoreapp3.1 655μs 1.66μs 6.43μs 0.329 0 0 41.87 KB
#5695 WriteAndFlushEnrichedTraces net472 889μs 4.04μs 15.7μs 8.36 2.64 0.44 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.13μs 0.855ns 3.31ns 0.0113 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.54μs 1.01ns 3.89ns 0.0108 0 0 808 B
master ExecuteNonQuery net472 1.76μs 3.96ns 15.3ns 0.122 0 0 770 B
#5695 ExecuteNonQuery net6.0 1.19μs 0.652ns 2.52ns 0.0113 0 0 808 B
#5695 ExecuteNonQuery netcoreapp3.1 1.45μs 1.52ns 5.5ns 0.0109 0 0 808 B
#5695 ExecuteNonQuery net472 1.74μs 2.91ns 10.9ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.572ns 2.14ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.6μs 0.6ns 2.24ns 0.0128 0 0 976 B
master CallElasticsearch net472 2.48μs 1.9ns 7.38ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.32μs 0.602ns 2.25ns 0.0132 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.71μs 0.92ns 3.44ns 0.0137 0 0 1.02 KB
master CallElasticsearchAsync net472 2.66μs 1.34ns 4.82ns 0.166 0 0 1.05 KB
#5695 CallElasticsearch net6.0 1.23μs 0.321ns 1.11ns 0.0136 0 0 976 B
#5695 CallElasticsearch netcoreapp3.1 1.45μs 0.643ns 2.4ns 0.0131 0 0 976 B
#5695 CallElasticsearch net472 2.53μs 1.49ns 5.77ns 0.158 0 0 995 B
#5695 CallElasticsearchAsync net6.0 1.32μs 0.376ns 1.41ns 0.0133 0 0 952 B
#5695 CallElasticsearchAsync netcoreapp3.1 1.59μs 1.53ns 5.72ns 0.0134 0 0 1.02 KB
#5695 CallElasticsearchAsync net472 2.51μs 1.62ns 6.29ns 0.167 0.00126 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 1.49ns 5.58ns 0.0132 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.557ns 2.16ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.8μs 1.2ns 4.64ns 0.145 0 0 915 B
#5695 ExecuteAsync net6.0 1.28μs 0.434ns 1.68ns 0.0134 0 0 952 B
#5695 ExecuteAsync netcoreapp3.1 1.59μs 1.98ns 7.43ns 0.0128 0 0 952 B
#5695 ExecuteAsync net472 1.93μs 2.32ns 8.99ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.32μs 0.646ns 2.5ns 0.0303 0 0 2.22 KB
master SendAsync netcoreapp3.1 4.93μs 3.05ns 11.8ns 0.0369 0 0 2.76 KB
master SendAsync net472 7.65μs 2.55ns 9.55ns 0.496 0 0 3.15 KB
#5695 SendAsync net6.0 4.18μs 1.95ns 7.3ns 0.0313 0 0 2.22 KB
#5695 SendAsync netcoreapp3.1 5.21μs 1.31ns 5.06ns 0.0366 0 0 2.76 KB
#5695 SendAsync net472 7.6μs 3.03ns 11.7ns 0.498 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.42μs 0.738ns 2.76ns 0.023 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.1μs 0.893ns 3.46ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.42μs 1.02ns 3.68ns 0.249 0 0 1.57 KB
#5695 EnrichedLog net6.0 1.56μs 1.09ns 4.09ns 0.0234 0 0 1.64 KB
#5695 EnrichedLog netcoreapp3.1 2.21μs 1.4ns 5.26ns 0.0222 0 0 1.64 KB
#5695 EnrichedLog net472 2.66μs 1.84ns 6.89ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 106ns 398ns 0.0561 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 142ns 549ns 0.0587 0 0 4.28 KB
master EnrichedLog net472 146μs 93.7ns 350ns 0.658 0.219 0 4.46 KB
#5695 EnrichedLog net6.0 112μs 72.2ns 270ns 0.0561 0 0 4.28 KB
#5695 EnrichedLog netcoreapp3.1 116μs 116ns 449ns 0.058 0 0 4.28 KB
#5695 EnrichedLog net472 146μs 209ns 809ns 0.654 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.99μs 0.788ns 2.95ns 0.0299 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 2.22ns 8.02ns 0.0299 0 0 2.2 KB
master EnrichedLog net472 4.72μs 2.28ns 8.81ns 0.319 0 0 2.02 KB
#5695 EnrichedLog net6.0 3.28μs 1.16ns 4.48ns 0.0312 0 0 2.2 KB
#5695 EnrichedLog netcoreapp3.1 4.23μs 1.23ns 4.78ns 0.0296 0 0 2.2 KB
#5695 EnrichedLog net472 4.87μs 0.947ns 3.55ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 3.5ns 13.1ns 0.0162 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 0.708ns 2.74ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.03μs 0.866ns 3.24ns 0.183 0 0 1.16 KB
#5695 SendReceive net6.0 1.36μs 1.13ns 4.4ns 0.0157 0 0 1.14 KB
#5695 SendReceive netcoreapp3.1 1.67μs 0.687ns 2.57ns 0.015 0 0 1.14 KB
#5695 SendReceive net472 2.05μs 4.39ns 17ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 1.07ns 4.16ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 4μs 1.36ns 5.27ns 0.022 0 0 1.65 KB
master EnrichedLog net472 4.38μs 2.99ns 11.6ns 0.323 0 0 2.04 KB
#5695 EnrichedLog net6.0 2.69μs 0.9ns 3.37ns 0.0227 0 0 1.6 KB
#5695 EnrichedLog netcoreapp3.1 3.98μs 1.6ns 6.19ns 0.0217 0 0 1.65 KB
#5695 EnrichedLog net472 4.34μs 1.83ns 6.85ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5695

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.120 590.86 662.03

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.213ns 0.798ns 0.00812 0 0 576 B
master StartFinishSpan netcoreapp3.1 585ns 0.3ns 1.12ns 0.00768 0 0 576 B
master StartFinishSpan net472 591ns 0.263ns 1.02ns 0.0916 0 0 578 B
master StartFinishScope net6.0 504ns 0.193ns 0.748ns 0.0097 0 0 696 B
master StartFinishScope netcoreapp3.1 735ns 0.491ns 1.9ns 0.00949 0 0 696 B
master StartFinishScope net472 864ns 0.584ns 2.26ns 0.104 0 0 658 B
#5695 StartFinishSpan net6.0 392ns 0.298ns 1.12ns 0.00809 0 0 576 B
#5695 StartFinishSpan netcoreapp3.1 555ns 0.242ns 0.905ns 0.00795 0 0 576 B
#5695 StartFinishSpan net472 661ns 0.569ns 2.2ns 0.0916 0 0 578 B
#5695 StartFinishScope net6.0 534ns 0.293ns 1.14ns 0.00965 0 0 696 B
#5695 StartFinishScope netcoreapp3.1 722ns 0.745ns 2.89ns 0.00962 0 0 696 B
#5695 StartFinishScope net472 863ns 0.528ns 2.04ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 671ns 0.302ns 1.17ns 0.00993 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 868ns 0.579ns 2.24ns 0.00956 0 0 696 B
master RunOnMethodBegin net472 1.13μs 0.589ns 2.28ns 0.104 0 0 658 B
#5695 RunOnMethodBegin net6.0 706ns 0.245ns 0.949ns 0.00987 0 0 696 B
#5695 RunOnMethodBegin netcoreapp3.1 918ns 0.396ns 1.53ns 0.00941 0 0 696 B
#5695 RunOnMethodBegin net472 1.16μs 0.697ns 2.7ns 0.104 0 0 658 B

andrewlock avatar Jun 14 '24 20:06 andrewlock