Bump NLog from 5.2.8 to 5.3.2 in /tracer/dependabot

[dependabot[bot]]

Bumps NLog from 5.2.8 to 5.3.2.

Release notes

Sourced from NLog's releases.

NLog 5.3.2

Bug Fix

• #5515 Fix NullReferenceException when using LoggingRules with filters and no targets (#5515) (@​snakefoot)

NLog 5.3.1

Improvements

• #5313 CallSite can hide single class type using AddCallSiteHiddenClassType (#5313) (@​wadebaird)
• #5489 Logging Rule with FinalMinLevel also supports dynamic filters (#5489) (@​snakefoot)
• #5463 LogManager GetCurrentClassLogger fallback to assembly-name when no namespace (#5463) (@​snakefoot)
• #5480 Logger LayoutRenderer able to output the Logger PrefixName (#5480) (@​snakefoot)
• #5466 NLogViewer Target - Allow override of the FormattedMessage (#5466) (@​snakefoot)
• #5487 CallSite fallback to Exception TargetSite when available (#5487) (@​snakefoot)
• #5242 NLogTraceListener - Align Filter-behavior for all Write-methods (#5242) (@​snakefoot)
• #5490 LogManager AddHiddenAssembly marked obsolete, instead use AddCallSiteHiddenAssembly (#5490) (@​snakefoot)
• #5443 InternalLogger - Marked LogToTrace as obsolete to reduce dependencies (#5443) (@​snakefoot)
• #5297 Replaced MutableUnsafeAttribute with ThreadAgnosticImmutableAttribute (#5297) (@​snakefoot)
• #5431 Marked ILoggerBase and ISuppress as obsolete and instead use ILogger (#5431) (@​snakefoot)
• #5491 LoggingRule - Marked ChildRules as obsolete (#5491) (@​snakefoot)
• #5416 FileTarget - Marked NetworkWrites as obsolete, and replaced by KeepFileOpen=false (#5416) (@​snakefoot)
• #5355 Marked EscapeDataNLogLegacy as obsolete (#5355) (@​snakefoot)
• #5380 WrapperTarget is the wrapper and not the wrapped (#5380) (@​snakefoot)
• #5485 LogFactory - Disconnect from Target write and Target flush (#5485) (@​snakefoot)
• #5509 NLog Schema nuget-package with updated license info (#5509) (@​snakefoot)
• #5493 Added sealed to internal classes (#5493) (@​snakefoot)
• #5497 Added more NLog Wiki Links to XML docs (#5497) (@​snakefoot)
• #5475 CsvLayout - Fixed links to NLog Wiki in XML docs (#5475) (@​hangy)

Changelog

Sourced from NLog's changelog.

Version 5.3.2 (2024/04/30)

Bug fix

• #5515 Fix NullReferenceException when using LoggingRules with filters and no targets (#5515) (@​snakefoot)

Version 5.3.1 (2024/04/27)

Improvements

• #5313 CallSite can hide single class type using AddCallSiteHiddenClassType (#5313) (@​wadebaird)
• #5489 Logging Rule with FinalMinLevel also supports dynamic filters (#5489) (@​snakefoot)
• #5463 LogManager GetCurrentClassLogger fallback to assembly-name when no namespace (#5463) (@​snakefoot)
• #5480 Logger LayoutRenderer able to output the Logger PrefixName (#5480) (@​snakefoot)
• #5466 NLogViewer Target - Allow override of the FormattedMessage (#5466) (@​snakefoot)
• #5487 CallSite fallback to Exception TargetSite when available (#5487) (@​snakefoot)
• #5242 NLogTraceListener - Align Filter-behavior for all Write-methods (#5242) (@​snakefoot)
• #5490 LogManager AddHiddenAssembly marked obsolete, instead use AddCallSiteHiddenAssembly (#5490) (@​snakefoot)
• #5443 InternalLogger - Marked LogToTrace as obsolete to reduce dependencies (#5443) (@​snakefoot)
• #5297 Replaced MutableUnsafeAttribute with ThreadAgnosticImmutableAttribute (#5297) (@​snakefoot)
• #5431 Marked ILoggerBase and ISuppress as obsolete and instead use ILogger (#5431) (@​snakefoot)
• #5491 LoggingRule - Marked ChildRules as obsolete (#5491) (@​snakefoot)
• #5416 FileTarget - Marked NetworkWrites as obsolete, and replaced by KeepFileOpen=false (#5416) (@​snakefoot)
• #5355 Marked EscapeDataNLogLegacy as obsolete (#5355) (@​snakefoot)
• #5380 WrapperTarget is the wrapper and not the wrapped (#5380) (@​snakefoot)
• #5485 LogFactory - Disconnect from Target write and Target flush (#5485) (@​snakefoot)
• #5509 NLog Schema nuget-package with updated license info (#5509) (@​snakefoot)
• #5493 Added sealed to internal classes (#5493) (@​snakefoot)
• #5497 Added more NLog Wiki Links to XML docs (#5497) (@​snakefoot)
• #5475 CsvLayout - Fixed links to NLog Wiki in XML docs (#5475) (@​hangy)

Commits

• 8d52d4f Version 5.3.2 (#5516)
• 8d8860f Fix NullReferenceException when using LoggingRules with filters and no target...
• cf6675d Version 5.3.1 (#5513)
• c11b862 Version 5.3 (#5496)
• f0af62a IsTrimmable only for NetStandard2 and newer (#5510)
• 0bfa4f5 NLog Schema nuget-package with updated license info (#5509)
• 79867c4 Bump xunit from 2.7.0 to 2.7.1 in /tests/NLog.UnitTests (#5508)
• b757fd9 Improve XML docs for obsoleted members with links to alternatives (#5498)
• 2a11efb Added Wiki Links to XML docs (#5497)
• 788b285 CallSiteInformation - Reduce lookups of StackFrame.GetMethod (#5495)
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[datadog-ddstaging[bot]]

Datadog Report

Branch report: dependabot/nuget/tracer/dependabot/NLog-5.3.2 Commit report: 9074b4c Test service: dd-trace-dotnet

:x: 27 Failed (0 Known Flaky), 333722 Passed, 1490 Skipped, 13h 29m 32.27s Total Time

:x: Failed Tests (27)

This report shows up to 5 failed tests.

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass13_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass13_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass13_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass13_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

• DirectlyShipsLogs - Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests - Details

  Expand for error

  xpected logs to contain at least 3 item(s), but found 0: {empty}.
  xpected logs to contain only items matching (x.Service == "LogsInjection.NLog"), but the collection is empty.
  xpected logs to contain only items matching (x.Env == "integration_tests"), but the collection is empty.
  xpected logs to contain only items matching (x.Version == "1.0.0"), but the collection is empty.
  xpected logs to contain only items matching (x.Host == value(Datadog.Trace.ClrProfiler.IntegrationTests.NLogTests+<>c__DisplayClass13_0).hostName), but the collection is empty.
  xpected logs to contain only items matching (x.Source == "csharp"), but the collection is empty.
  xpected logs to contain only items matching (x.Exception == null), but the collection is empty.
  xpected logs to contain only items matching (Convert(x.LogLevel, Int32) == 2), but the collection is empty.
  xpected logs to contain only items matching x.TryGetProperty("LoggerName").Item1, but the collection is empty.
  xpected logs.Where(x => !x.Message.Contains(ExcludeMessagePrefix)) to contain 1 item(s), but found 0: {empty}.
  ..
  

[andrewlock]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

• This PR (5583)
• master

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

• Welch test with statistical test for significance of 5%
• Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (72ms)  : 66, 78
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (1,008ms)  : 973, 1042
     .   : milestone, 1008,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (725ms)  : 688, 763
     .   : milestone, 725,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (95ms)  : 89, 100
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (683ms)  : 648, 718
     .   : milestone, 683,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (193ms)  : 189, 196
     .   : milestone, 193,
    master - mean (192ms)  : 189, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (1,119ms)  : 1102, 1135
     .   : milestone, 1119,
    master - mean (1,120ms)  : 1102, 1137
     .   : milestone, 1120,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (919ms)  : 895, 942
     .   : milestone, 919,
    master - mean (921ms)  : 904, 938
     .   : milestone, 921,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5583) - mean (267ms)  : 262, 272
     .   : milestone, 267,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5583) - mean (903ms)  : 881, 924
     .   : milestone, 903,
    master - mean (902ms)  : 883, 920
     .   : milestone, 902,

[andrewlock]

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

• This PR (5583)
• master
• benchmarks/2.9.0

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5583) (11.118M)   : 0, 11118421
    master (11.616M)   : 0, 11615706
    benchmarks/2.9.0 (11.624M)   : 0, 11623859

    section Automatic
    This PR (5583) (7.530M)   : 0, 7530495
    master (7.655M)   : 0, 7655281
    benchmarks/2.9.0 (8.265M)   : 0, 8264971

    section Trace stats
    master (8.103M)   : 0, 8103029

    section Manual
    This PR (5583) (9.686M)   : 0, 9685720
    master (9.865M)   : 0, 9864889

    section Manual + Automatic
    This PR (5583) (7.179M)   : 0, 7178554
    master (7.369M)   : 0, 7368730

    section Version Conflict
    master (6.506M)   : 0, 6505858

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5583) (9.590M)   : 0, 9590480
    master (9.681M)   : 0, 9681463
    benchmarks/2.9.0 (9.540M)   : 0, 9540485

    section Automatic
    This PR (5583) (6.657M)   : 0, 6656639
    master (6.501M)   : 0, 6501141

    section Trace stats
    master (6.940M)   : 0, 6940418

    section Manual
    This PR (5583) (7.996M)   : 0, 7995974
    master (8.010M)   : 0, 8010151

    section Manual + Automatic
    This PR (5583) (6.241M)   : 0, 6240914
    master (6.179M)   : 0, 6179114

    section Version Conflict
    master (5.548M)   : 0, 5548375

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5583) (10.241M)   : 0, 10241207
    master (9.959M)   : 0, 9958679
    benchmarks/2.9.0 (10.172M)   : 0, 10172493

    section Automatic
    This PR (5583) (7.091M)   : 0, 7091264
    master (7.143M)   : 0, 7142793
    benchmarks/2.9.0 (7.430M)   : 0, 7430131

    section Trace stats
    master (7.412M)   : 0, 7411748

    section Manual
    This PR (5583) (8.831M)   : 0, 8830581
    master (8.759M)   : 0, 8759430

    section Manual + Automatic
    This PR (5583) (6.900M)   : 0, 6899659
    master (6.877M)   : 0, 6877374

    section Version Conflict
    master (6.197M)   : 0, 6197244

[andrewlock]

Benchmarks Report for tracer :snail:

Benchmarks for #5583 compared to master:

• 2 benchmarks are faster, with geometric mean 1.158
• 1 benchmarks are slower, with geometric mean 1.173
• All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

• Mann–Whitney U test with statistical test for significance of 5%
• Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartStopWithChild	net6.0	8.82μs	46.3ns	266ns	0.0214	0.00858	0	7.56 KB
master	StartStopWithChild	netcoreapp3.1	10.8μs	48ns	186ns	0.0327	0.0163	0	7.64 KB
master	StartStopWithChild	net472	17.1μs	54.6ns	211ns	1.34	0.362	0.103	8.06 KB
#5583	StartStopWithChild	net6.0	8.8μs	47.5ns	269ns	0.0214	0.00855	0	7.55 KB
#5583	StartStopWithChild	netcoreapp3.1	10.8μs	58.5ns	315ns	0.0274	0.0109	0	7.65 KB
#5583	StartStopWithChild	net472	17.4μs	63ns	236ns	1.35	0.353	0.109	8.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	480μs	1.17μs	4.55μs	0	0	0	2.7 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	657μs	145ns	543ns	0	0	0	2.7 KB
master	WriteAndFlushEnrichedTraces	net472	830μs	202ns	754ns	0.414	0	0	3.3 KB
#5583	WriteAndFlushEnrichedTraces	net6.0	479μs	286ns	1.11μs	0	0	0	2.7 KB
#5583	WriteAndFlushEnrichedTraces	netcoreapp3.1	633μs	260ns	1.01μs	0	0	0	2.7 KB
#5583	WriteAndFlushEnrichedTraces	net472	852μs	225ns	842ns	0.422	0	0	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendRequest	net6.0	172μs	287ns	1.11μs	0.257	0	0	18.44 KB
master	SendRequest	netcoreapp3.1	191μs	363ns	1.41μs	0.191	0	0	20.6 KB
master	SendRequest	net472	0.00067ns	0.000219ns	0.000819ns	0	0	0	0 b
#5583	SendRequest	net6.0	174μs	203ns	786ns	0.174	0	0	18.44 KB
#5583	SendRequest	netcoreapp3.1	192μs	239ns	924ns	0.192	0	0	20.6 KB
#5583	SendRequest	net472	0.00094ns	0.000232ns	0.000897ns	0	0	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	WriteAndFlushEnrichedTraces	net6.0	542μs	507ns	1.83μs	0.551	0	0	41.44 KB
master	WriteAndFlushEnrichedTraces	netcoreapp3.1	654μs	1.17μs	4.54μs	0.321	0	0	41.98 KB
master	WriteAndFlushEnrichedTraces	net472	847μs	3.98μs	15.4μs	8.45	2.53	0.422	53.26 KB
#5583	WriteAndFlushEnrichedTraces	net6.0	548μs	383ns	1.48μs	0.546	0	0	41.61 KB
#5583	WriteAndFlushEnrichedTraces	netcoreapp3.1	655μs	2.11μs	8.18μs	0.326	0	0	41.96 KB
#5583	WriteAndFlushEnrichedTraces	net472	842μs	2.76μs	10.7μs	8.08	2.55	0.425	53.22 KB

Benchmarks.Trace.DbCommandBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5583

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.155	1,159.55	1,003.86

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteNonQuery	net6.0	1.16μs	0.46ns	1.72ns	0.011	0	0	808 B
master	ExecuteNonQuery	netcoreapp3.1	1.42μs	0.702ns	2.72ns	0.0106	0	0	808 B
master	ExecuteNonQuery	net472	1.71μs	1.74ns	6.72ns	0.122	0	0	770 B
#5583	ExecuteNonQuery	net6.0	1μs	0.68ns	2.63ns	0.011	0	0	808 B
#5583	ExecuteNonQuery	netcoreapp3.1	1.48μs	1.67ns	6.46ns	0.0104	0	0	808 B
#5583	ExecuteNonQuery	net472	1.74μs	2.08ns	8.06ns	0.122	0	0	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	CallElasticsearch	net6.0	1.17μs	0.543ns	2.03ns	0.0135	0	0	976 B
master	CallElasticsearch	netcoreapp3.1	1.58μs	1.57ns	6.1ns	0.0127	0	0	976 B
master	CallElasticsearch	net472	2.47μs	1.02ns	3.94ns	0.158	0.00124	0	995 B
master	CallElasticsearchAsync	net6.0	1.24μs	1.12ns	4.17ns	0.0131	0	0	952 B
master	CallElasticsearchAsync	netcoreapp3.1	1.6μs	0.942ns	3.52ns	0.0135	0	0	1.02 KB
master	CallElasticsearchAsync	net472	2.6μs	1.7ns	6.58ns	0.167	0.0013	0	1.05 KB
#5583	CallElasticsearch	net6.0	1.07μs	0.397ns	1.54ns	0.0135	0	0	976 B
#5583	CallElasticsearch	netcoreapp3.1	1.54μs	0.607ns	2.27ns	0.013	0	0	976 B
#5583	CallElasticsearch	net472	2.52μs	2.14ns	8.28ns	0.158	0	0	995 B
#5583	CallElasticsearchAsync	net6.0	1.29μs	0.93ns	3.6ns	0.0135	0	0	952 B
#5583	CallElasticsearchAsync	netcoreapp3.1	1.72μs	0.864ns	3.34ns	0.0137	0	0	1.02 KB
#5583	CallElasticsearchAsync	net472	2.63μs	1.75ns	6.79ns	0.166	0.00128	0	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	ExecuteAsync	net6.0	1.31μs	0.997ns	3.86ns	0.0132	0	0	952 B
master	ExecuteAsync	netcoreapp3.1	1.56μs	0.585ns	2.19ns	0.0131	0	0	952 B
master	ExecuteAsync	net472	1.8μs	1.23ns	4.61ns	0.145	0	0	915 B
#5583	ExecuteAsync	net6.0	1.25μs	1.09ns	4.08ns	0.0132	0	0	952 B
#5583	ExecuteAsync	netcoreapp3.1	1.59μs	0.544ns	2.03ns	0.0125	0	0	952 B
#5583	ExecuteAsync	net472	1.76μs	0.643ns	2.49ns	0.145	0.000884	0	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendAsync	net6.0	4.16μs	0.787ns	3.05ns	0.0313	0	0	2.22 KB
master	SendAsync	netcoreapp3.1	5.02μs	1.05ns	3.8ns	0.0351	0	0	2.76 KB
master	SendAsync	net472	7.55μs	3.72ns	14.4ns	0.496	0	0	3.12 KB
#5583	SendAsync	net6.0	4.18μs	2.09ns	8.11ns	0.0313	0	0	2.22 KB
#5583	SendAsync	netcoreapp3.1	5.09μs	3.54ns	13.7ns	0.0382	0	0	2.76 KB
#5583	SendAsync	net472	7.52μs	3.49ns	13.5ns	0.495	0	0	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	1.43μs	0.659ns	2.55ns	0.023	0	0	1.64 KB
master	EnrichedLog	netcoreapp3.1	2.16μs	0.725ns	2.61ns	0.0216	0	0	1.64 KB
master	EnrichedLog	net472	2.46μs	1.12ns	4.18ns	0.249	0	0	1.57 KB
#5583	EnrichedLog	net6.0	1.48μs	1.01ns	3.78ns	0.0229	0	0	1.64 KB
#5583	EnrichedLog	netcoreapp3.1	2.28μs	1.59ns	5.94ns	0.0221	0	0	1.64 KB
#5583	EnrichedLog	net472	2.56μs	0.808ns	2.91ns	0.249	0	0	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	114μs	164ns	636ns	0.0565	0	0	4.28 KB
master	EnrichedLog	netcoreapp3.1	118μs	87ns	337ns	0.0587	0	0	4.28 KB
master	EnrichedLog	net472	148μs	87.2ns	338ns	0.664	0.221	0	4.46 KB
#5583	EnrichedLog	net6.0	113μs	224ns	868ns	0.0564	0	0	4.28 KB
#5583	EnrichedLog	netcoreapp3.1	119μs	113ns	437ns	0	0	0	4.28 KB
#5583	EnrichedLog	net472	148μs	61.7ns	239ns	0.666	0.222	0	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	3.09μs	0.765ns	2.96ns	0.0308	0	0	2.2 KB
master	EnrichedLog	netcoreapp3.1	4.01μs	0.829ns	3.21ns	0.0301	0	0	2.2 KB
master	EnrichedLog	net472	4.97μs	1.25ns	4.82ns	0.319	0	0	2.02 KB
#5583	EnrichedLog	net6.0	3.01μs	1.25ns	4.69ns	0.0301	0	0	2.2 KB
#5583	EnrichedLog	netcoreapp3.1	4.09μs	2.16ns	8.08ns	0.0289	0	0	2.2 KB
#5583	EnrichedLog	net472	4.67μs	1.75ns	6.79ns	0.319	0	0	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	SendReceive	net6.0	1.36μs	1.09ns	4.21ns	0.0157	0	0	1.14 KB
master	SendReceive	netcoreapp3.1	1.83μs	1.02ns	3.97ns	0.0156	0	0	1.14 KB
master	SendReceive	net472	2.07μs	0.916ns	3.43ns	0.183	0.00103	0	1.16 KB
#5583	SendReceive	net6.0	1.38μs	0.711ns	2.75ns	0.0159	0	0	1.14 KB
#5583	SendReceive	netcoreapp3.1	1.7μs	1.02ns	3.82ns	0.0153	0	0	1.14 KB
#5583	SendReceive	net472	2.08μs	0.99ns	3.7ns	0.183	0.00104	0	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	EnrichedLog	net6.0	2.74μs	1.26ns	4.88ns	0.0219	0	0	1.6 KB
master	EnrichedLog	netcoreapp3.1	3.87μs	5.01ns	19.4ns	0.0211	0	0	1.65 KB
master	EnrichedLog	net472	4.28μs	2.91ns	10.9ns	0.323	0	0	2.04 KB
#5583	EnrichedLog	net6.0	2.83μs	0.899ns	3.48ns	0.0225	0	0	1.6 KB
#5583	EnrichedLog	netcoreapp3.1	3.97μs	1.17ns	4.53ns	0.0219	0	0	1.65 KB
#5583	EnrichedLog	net472	4.47μs	2.04ns	7.89ns	0.324	0	0	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5583

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.173	539.00	632.10

Faster :tada: in #5583

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.160	452.17	389.83

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	StartFinishSpan	net6.0	452ns	0.218ns	0.844ns	0.00813	0	0	576 B
master	StartFinishSpan	netcoreapp3.1	539ns	0.228ns	0.854ns	0.00785	0	0	576 B
master	StartFinishSpan	net472	726ns	0.611ns	2.28ns	0.0917	0	0	578 B
master	StartFinishScope	net6.0	474ns	0.213ns	0.824ns	0.00973	0	0	696 B
master	StartFinishScope	netcoreapp3.1	739ns	0.377ns	1.46ns	0.00931	0	0	696 B
master	StartFinishScope	net472	858ns	0.371ns	1.44ns	0.104	0	0	658 B
#5583	StartFinishSpan	net6.0	390ns	0.109ns	0.423ns	0.00802	0	0	576 B
#5583	StartFinishSpan	netcoreapp3.1	632ns	0.234ns	0.905ns	0.00795	0	0	576 B
#5583	StartFinishSpan	net472	677ns	0.208ns	0.805ns	0.0918	0	0	578 B
#5583	StartFinishScope	net6.0	500ns	0.574ns	2.22ns	0.00976	0	0	696 B
#5583	StartFinishScope	netcoreapp3.1	668ns	0.193ns	0.72ns	0.0094	0	0	696 B
#5583	StartFinishScope	net472	903ns	0.664ns	2.57ns	0.105	0	0	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	RunOnMethodBegin	net6.0	652ns	0.241ns	0.9ns	0.00983	0	0	696 B
master	RunOnMethodBegin	netcoreapp3.1	926ns	0.454ns	1.7ns	0.00921	0	0	696 B
master	RunOnMethodBegin	net472	1.15μs	0.461ns	1.72ns	0.104	0	0	658 B
#5583	RunOnMethodBegin	net6.0	640ns	0.221ns	0.855ns	0.00964	0	0	696 B
#5583	RunOnMethodBegin	netcoreapp3.1	893ns	0.627ns	2.43ns	0.0097	0	0	696 B
#5583	RunOnMethodBegin	net472	1.15μs	2ns	7.76ns	0.105	0	0	658 B

[bouwkast]

@dependabot rebase

[dependabot[bot]]

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

[bouwkast]

@dependabot close