dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

Gleocadie/universal native loader and wrapper

Open gleocadie opened this issue 1 year ago • 4 comments

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

gleocadie avatar May 17 '24 14:05 gleocadie

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (74ms)  : 65, 82
     .   : milestone, 74,
    master - mean (74ms)  : 64, 83
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (1,009ms)  : 972, 1046
     .   : milestone, 1009,
    master - mean (998ms)  : 973, 1024
     .   : milestone, 998,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (731ms)  : 709, 754
     .   : milestone, 731,
    master - mean (727ms)  : 707, 747
     .   : milestone, 727,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (93ms)  : 89, 97
     .   : milestone, 93,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (680ms)  : 656, 704
     .   : milestone, 680,
    master - mean (679ms)  : 654, 704
     .   : milestone, 679,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (192ms)  : 188, 196
     .   : milestone, 192,
    master - mean (192ms)  : 187, 197
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (1,114ms)  : 1092, 1137
     .   : milestone, 1114,
    master - mean (1,107ms)  : 1090, 1124
     .   : milestone, 1107,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (279ms)  : 271, 287
     .   : milestone, 279,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (916ms)  : 899, 933
     .   : milestone, 916,
    master - mean (913ms)  : 891, 934
     .   : milestone, 913,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5580) - mean (266ms)  : 261, 271
     .   : milestone, 266,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (5580) - mean (894ms)  : 872, 917
     .   : milestone, 894,
    master - mean (894ms)  : 872, 916
     .   : milestone, 894,

andrewlock avatar May 17 '24 14:05 andrewlock

Datadog Report

Branch report: gleocadie/universal-native-loader-and-wrapper Commit report: 7d5f12d Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 331191 Passed, 1839 Skipped, 14h 52m 22.87s Total Time

datadog-ddstaging[bot] avatar May 17 '24 14:05 datadog-ddstaging[bot]

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5580) (11.373M)   : 0, 11373134
    master (12.009M)   : 0, 12009369
    benchmarks/2.9.0 (12.177M)   : 0, 12177433

    section Automatic
    This PR (5580) (7.687M)   : 0, 7687111
    master (8.052M)   : 0, 8051625
    benchmarks/2.9.0 (8.655M)   : 0, 8654767

    section Trace stats
    master (8.395M)   : 0, 8395110

    section Manual
    This PR (5580) (9.873M)   : 0, 9873058
    master (10.389M)   : 0, 10389476

    section Manual + Automatic
    This PR (5580) (7.244M)   : crit ,0, 7244155
    master (7.736M)   : 0, 7735676

    section Version Conflict
    master (6.926M)   : 0, 6925925


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5580) (9.494M)   : 0, 9494417
    master (9.644M)   : 0, 9643882
    benchmarks/2.9.0 (9.537M)   : 0, 9537345

    section Automatic
    This PR (5580) (6.432M)   : 0, 6431754
    master (6.601M)   : 0, 6600515

    section Trace stats
    master (6.694M)   : 0, 6693876

    section Manual
    This PR (5580) (8.123M)   : 0, 8123335
    master (8.261M)   : 0, 8261341

    section Manual + Automatic
    This PR (5580) (6.078M)   : 0, 6077633
    master (6.136M)   : 0, 6135775

    section Version Conflict
    master (5.657M)   : 0, 5657384


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5580) (9.921M)   : 0, 9920782
    master (9.666M)   : 0, 9666180
    benchmarks/2.9.0 (9.818M)   : 0, 9818357

    section Automatic
    This PR (5580) (7.194M)   : 0, 7194112
    master (7.004M)   : 0, 7004298
    benchmarks/2.9.0 (7.235M)   : 0, 7235236

    section Trace stats
    master (7.336M)   : 0, 7336339

    section Manual
    This PR (5580) (8.756M)   : 0, 8755904
    master (8.744M)   : 0, 8744434

    section Manual + Automatic
    This PR (5580) (6.897M)   : 0, 6897004
    master (6.749M)   : 0, 6748869

    section Version Conflict
    master (6.118M)   : 0, 6117887

andrewlock avatar May 17 '24 18:05 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5580 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.116
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.94μs 50.8ns 352ns 0.0264 0.0088 0 7.56 KB
master StartStopWithChild netcoreapp3.1 10.9μs 59.5ns 326ns 0.0323 0.0161 0 7.65 KB
master StartStopWithChild net472 17.2μs 68.3ns 265ns 1.33 0.338 0.0954 8.06 KB
#5580 StartStopWithChild net6.0 8.85μs 46.8ns 277ns 0.0219 0.00877 0 7.55 KB
#5580 StartStopWithChild netcoreapp3.1 10.7μs 59.8ns 392ns 0.0266 0.0107 0 7.65 KB
#5580 StartStopWithChild net472 17.3μs 51.2ns 198ns 1.35 0.364 0.102 8.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 467μs 323ns 1.25μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 250ns 967ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 829μs 164ns 614ns 0.414 0 0 3.3 KB
#5580 WriteAndFlushEnrichedTraces net6.0 470μs 225ns 871ns 0 0 0 2.7 KB
#5580 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 166ns 622ns 0 0 0 2.7 KB
#5580 WriteAndFlushEnrichedTraces net472 835μs 258ns 998ns 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 167ns 647ns 0.256 0 0 18.44 KB
master SendRequest netcoreapp3.1 192μs 280ns 1.08μs 0.192 0 0 20.6 KB
master SendRequest net472 0.000205ns 0.000145ns 0.000544ns 0 0 0 0 b
#5580 SendRequest net6.0 170μs 214ns 831ns 0.169 0 0 18.44 KB
#5580 SendRequest netcoreapp3.1 190μs 238ns 891ns 0.191 0 0 20.6 KB
#5580 SendRequest net472 5.86E‑05ns 5.86E‑05ns 0.000227ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 540μs 593ns 2.14μs 0.546 0 0 41.95 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 659μs 1.42μs 5.49μs 0.324 0 0 41.91 KB
master WriteAndFlushEnrichedTraces net472 849μs 4.08μs 17.3μs 8.19 2.59 0.431 53.25 KB
#5580 WriteAndFlushEnrichedTraces net6.0 559μs 220ns 851ns 0.558 0 0 41.79 KB
#5580 WriteAndFlushEnrichedTraces netcoreapp3.1 654μs 1.18μs 4.56μs 0.322 0 0 41.95 KB
#5580 WriteAndFlushEnrichedTraces net472 841μs 4.32μs 21.2μs 8.25 2.6 0.434 53.26 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.15μs 0.529ns 1.98ns 0.0109 0 0 808 B
master ExecuteNonQuery netcoreapp3.1 1.42μs 0.775ns 3ns 0.0106 0 0 808 B
master ExecuteNonQuery net472 1.77μs 1.48ns 5.75ns 0.122 0 0 770 B
#5580 ExecuteNonQuery net6.0 1.21μs 0.442ns 1.71ns 0.0115 0 0 808 B
#5580 ExecuteNonQuery netcoreapp3.1 1.46μs 0.7ns 2.62ns 0.011 0 0 808 B
#5580 ExecuteNonQuery net472 1.67μs 0.992ns 3.84ns 0.122 0 0 770 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 0.545ns 2.04ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.49μs 0.874ns 3.27ns 0.0135 0 0 976 B
master CallElasticsearch net472 2.48μs 1.25ns 4.85ns 0.158 0.00124 0 995 B
master CallElasticsearchAsync net6.0 1.23μs 1.02ns 3.84ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 0.609ns 2.36ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.55μs 1.21ns 4.38ns 0.167 0 0 1.05 KB
#5580 CallElasticsearch net6.0 1.26μs 0.847ns 3.17ns 0.0139 0 0 976 B
#5580 CallElasticsearch netcoreapp3.1 1.57μs 2.09ns 8.1ns 0.0132 0 0 976 B
#5580 CallElasticsearch net472 2.52μs 1.37ns 5.29ns 0.157 0 0 995 B
#5580 CallElasticsearchAsync net6.0 1.22μs 0.726ns 2.81ns 0.0135 0 0 952 B
#5580 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.684ns 2.65ns 0.0137 0 0 1.02 KB
#5580 CallElasticsearchAsync net472 2.63μs 1.83ns 7.07ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.32μs 0.593ns 2.22ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.57μs 0.906ns 3.51ns 0.0127 0 0 952 B
master ExecuteAsync net472 1.81μs 1.35ns 5.23ns 0.145 0 0 915 B
#5580 ExecuteAsync net6.0 1.21μs 0.61ns 2.36ns 0.0133 0 0 952 B
#5580 ExecuteAsync netcoreapp3.1 1.65μs 0.936ns 3.62ns 0.0124 0 0 952 B
#5580 ExecuteAsync net472 1.8μs 4ns 15.5ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 2.53ns 9.46ns 0.0315 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.1μs 2.63ns 10.2ns 0.0382 0 0 2.76 KB
master SendAsync net472 7.55μs 2.96ns 11.5ns 0.493 0 0 3.12 KB
#5580 SendAsync net6.0 4.12μs 3.62ns 13.6ns 0.031 0 0 2.22 KB
#5580 SendAsync netcoreapp3.1 5.1μs 1.65ns 6.4ns 0.0381 0 0 2.76 KB
#5580 SendAsync net472 7.52μs 3.45ns 12.9ns 0.495 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.408ns 1.47ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.08μs 0.965ns 3.48ns 0.0219 0 0 1.64 KB
master EnrichedLog net472 2.63μs 0.727ns 2.72ns 0.25 0 0 1.57 KB
#5580 EnrichedLog net6.0 1.54μs 0.709ns 2.75ns 0.0228 0 0 1.64 KB
#5580 EnrichedLog netcoreapp3.1 2.11μs 0.818ns 2.95ns 0.0222 0 0 1.64 KB
#5580 EnrichedLog net472 2.57μs 2.45ns 9.49ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 78.4ns 304ns 0.0559 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 117μs 105ns 406ns 0.0588 0 0 4.28 KB
master EnrichedLog net472 148μs 53.3ns 200ns 0.664 0.221 0 4.46 KB
#5580 EnrichedLog net6.0 113μs 85.4ns 331ns 0.0568 0 0 4.28 KB
#5580 EnrichedLog netcoreapp3.1 118μs 182ns 704ns 0 0 0 4.28 KB
#5580 EnrichedLog net472 150μs 46.4ns 174ns 0.672 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 1.87ns 7.25ns 0.03 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.24μs 2.03ns 7.87ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 4.72μs 2.02ns 7.81ns 0.319 0 0 2.02 KB
#5580 EnrichedLog net6.0 2.9μs 0.963ns 3.73ns 0.0316 0 0 2.2 KB
#5580 EnrichedLog netcoreapp3.1 4.09μs 0.909ns 3.4ns 0.0288 0 0 2.2 KB
#5580 EnrichedLog net472 4.83μs 1.53ns 5.91ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.568ns 2.2ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.83μs 2ns 7.76ns 0.0155 0 0 1.14 KB
master SendReceive net472 2.13μs 1.12ns 4.03ns 0.183 0 0 1.16 KB
#5580 SendReceive net6.0 1.42μs 0.705ns 2.54ns 0.0156 0 0 1.14 KB
#5580 SendReceive netcoreapp3.1 1.72μs 0.825ns 3.19ns 0.0154 0 0 1.14 KB
#5580 SendReceive net472 2.1μs 1.1ns 4.11ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.83μs 1.13ns 4.38ns 0.0225 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.96μs 1.56ns 6.06ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 4.35μs 1.85ns 7.15ns 0.323 0 0 2.04 KB
#5580 EnrichedLog net6.0 2.74μs 1.36ns 5.26ns 0.022 0 0 1.6 KB
#5580 EnrichedLog netcoreapp3.1 3.86μs 0.91ns 3.52ns 0.0213 0 0 1.65 KB
#5580 EnrichedLog net472 4.39μs 2.22ns 8.59ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5580

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.116 408.25 455.48

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 408ns 0.0492ns 0.19ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 575ns 0.262ns 1.02ns 0.00775 0 0 576 B
master StartFinishSpan net472 701ns 0.415ns 1.55ns 0.0917 0 0 578 B
master StartFinishScope net6.0 531ns 0.2ns 0.776ns 0.00984 0 0 696 B
master StartFinishScope netcoreapp3.1 823ns 0.543ns 2.03ns 0.00911 0 0 696 B
master StartFinishScope net472 874ns 0.441ns 1.65ns 0.104 0 0 658 B
#5580 StartFinishSpan net6.0 455ns 0.138ns 0.534ns 0.00803 0 0 576 B
#5580 StartFinishSpan netcoreapp3.1 536ns 0.19ns 0.735ns 0.00794 0 0 576 B
#5580 StartFinishSpan net472 662ns 0.42ns 1.63ns 0.0918 0 0 578 B
#5580 StartFinishScope net6.0 490ns 0.12ns 0.466ns 0.00966 0 0 696 B
#5580 StartFinishScope netcoreapp3.1 770ns 0.259ns 1ns 0.00947 0 0 696 B
#5580 StartFinishScope net472 920ns 0.538ns 2.08ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 642ns 0.217ns 0.811ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 969ns 0.23ns 0.862ns 0.00919 0 0 696 B
master RunOnMethodBegin net472 1.16μs 0.667ns 2.58ns 0.104 0 0 658 B
#5580 RunOnMethodBegin net6.0 582ns 0.213ns 0.826ns 0.00997 0 0 696 B
#5580 RunOnMethodBegin netcoreapp3.1 912ns 0.87ns 3.37ns 0.00933 0 0 696 B
#5580 RunOnMethodBegin net472 1.13μs 0.194ns 0.753ns 0.104 0 0 658 B

andrewlock avatar May 17 '24 18:05 andrewlock