[Dynamic Instrumentation] DEBUG-2216 Getting value of field or property throws `NotSupportedException`
Summary of changes
In some scenarios getting the value of member info throws NotSupportedException. This PR not meant to solve all of them, but make this method more stable and also adding log description to cases that we fail to get the value.
Datadog Report
Branch report: dudik/get-membervalue-throws-nse
Commit report: f32f7f5
Test service: dd-trace-dotnet
:x: 1726 Failed (2 Known Flaky), 275503 Passed, 2060 Skipped, 22h 53m 41.9s Total Time
:x: Failed Tests (1726)
This report shows up to 5 failed tests.
-
InstallAndUninstallMethodProbeWithOverloadsTest-Datadog.Trace.Debugger.IntegrationTests.ProbesTests- DetailsExpand for error
napshot count not found. Expected 9, actual 0 -
InstallAndUninstallMethodProbeWithOverloadsTest-Datadog.Trace.Debugger.IntegrationTests.ProbesTests- DetailsExpand for error
napshot count not found. Expected 9, actual 0 -
InstallAndUninstallMethodProbeWithOverloadsTest-Datadog.Trace.Debugger.IntegrationTests.ProbesTests- DetailsExpand for error
napshot count not found. Expected 9, actual 0 -
InstallAndUninstallMethodProbeWithOverloadsTest-Datadog.Trace.Debugger.IntegrationTests.ProbesTests- DetailsExpand for error
napshot count not found. Expected 9, actual 0 -
InstallAndUninstallMethodProbeWithOverloadsTest-Datadog.Trace.Debugger.IntegrationTests.ProbesTests- DetailsExpand for error
napshot count not found. Expected 9, actual 0
Execution-Time Benchmarks Report :stopwatch:
Execution-time results for samples comparing the following branches/commits:
Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
- Welch test with statistical test for significance of 5%
- Only results indicating a difference greater than 5% and 5 ms are considered.
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.
Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (73ms) : 64, 83
. : milestone, 73,
master - mean (73ms) : 61, 85
. : milestone, 73,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (1,066ms) : 1045, 1088
. : milestone, 1066,
master - mean (1,061ms) : 1040, 1082
. : milestone, 1061,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (110ms) : 106, 114
. : milestone, 110,
master - mean (109ms) : 104, 113
. : milestone, 109,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (753ms) : 725, 781
. : milestone, 753,
master - mean (744ms) : 723, 766
. : milestone, 744,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (93ms) : 90, 96
. : milestone, 93,
master - mean (92ms) : 86, 98
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (702ms) : 680, 724
. : milestone, 702,
master - mean (695ms) : 677, 713
. : milestone, 695,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (192ms) : 188, 196
. : milestone, 192,
master - mean (193ms) : 189, 196
. : milestone, 193,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (1,165ms) : 1138, 1192
. : milestone, 1165,
master - mean (1,174ms) : 1143, 1206
. : milestone, 1174,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (278ms) : 273, 283
. : milestone, 278,
master - mean (276ms) : 272, 281
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (920ms) : 893, 948
. : milestone, 920,
master - mean (921ms) : 893, 948
. : milestone, 921,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5558) - mean (267ms) : 262, 272
. : milestone, 267,
master - mean (266ms) : 261, 271
. : milestone, 266,
section CallTarget+Inlining+NGEN
This PR (5558) - mean (904ms) : 885, 924
. : milestone, 904,
master - mean (907ms) : 881, 933
. : milestone, 907,
Benchmarks Report for tracer :snail:
Benchmarks for #5558 compared to master:
- 2 benchmarks are faster, with geometric mean 1.126
- 1 benchmarks are slower, with geometric mean 1.142
- All benchmarks have the same allocations
The following thresholds were used for comparing the benchmark speeds:
- Mann–Whitney U test with statistical test for significance of 5%
- Only results indicating a difference greater than 10% and 0.3 ns are considered.
Allocation changes below 0.5% are ignored.
Benchmark details
Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartStopWithChild |
net6.0 | 7.54μs | 38.7ns | 222ns | 0.0218 | 0.0109 | 0 | 5.42 KB |
| master | StartStopWithChild |
netcoreapp3.1 | 9.86μs | 53.6ns | 288ns | 0.0197 | 0.00987 | 0 | 5.62 KB |
| master | StartStopWithChild |
net472 | 16μs | 39.8ns | 154ns | 1.01 | 0.294 | 0.0795 | 6.06 KB |
| #5558 | StartStopWithChild |
net6.0 | 7.92μs | 44ns | 292ns | 0.0198 | 0.00792 | 0 | 5.43 KB |
| #5558 | StartStopWithChild |
netcoreapp3.1 | 9.95μs | 50.9ns | 356ns | 0.0146 | 0.00486 | 0 | 5.62 KB |
| #5558 | StartStopWithChild |
net472 | 17.3μs | 86.7ns | 397ns | 1.04 | 0.325 | 0.103 | 6.07 KB |
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 479μs | 685ns | 2.65μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 648μs | 1.09μs | 4.21μs | 0 | 0 | 0 | 2.7 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 838μs | 689ns | 2.58μs | 0.417 | 0 | 0 | 3.3 KB |
| #5558 | WriteAndFlushEnrichedTraces |
net6.0 | 465μs | 210ns | 785ns | 0 | 0 | 0 | 2.7 KB |
| #5558 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 629μs | 369ns | 1.38μs | 0 | 0 | 0 | 2.7 KB |
| #5558 | WriteAndFlushEnrichedTraces |
net472 | 838μs | 679ns | 2.45μs | 0.419 | 0 | 0 | 3.3 KB |
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendRequest |
net6.0 | 212μs | 1.23μs | 12.2μs | 0.208 | 0 | 0 | 18.45 KB |
| master | SendRequest |
netcoreapp3.1 | 221μs | 1.27μs | 9.66μs | 0.208 | 0 | 0 | 20.61 KB |
| master | SendRequest |
net472 | 0.00108ns | 0.000367ns | 0.00137ns | 0 | 0 | 0 | 0 b |
| #5558 | SendRequest |
net6.0 | 214μs | 1.4μs | 13.9μs | 0.193 | 0 | 0 | 18.45 KB |
| #5558 | SendRequest |
netcoreapp3.1 | 225μs | 1.31μs | 11.2μs | 0.223 | 0 | 0 | 20.61 KB |
| #5558 | SendRequest |
net472 | 0.00589ns | 0.00163ns | 0.00633ns | 0 | 0 | 0 | 0 b |
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | WriteAndFlushEnrichedTraces |
net6.0 | 581μs | 3.33μs | 24.5μs | 0.558 | 0 | 0 | 41.62 KB |
| master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 695μs | 3.69μs | 20.2μs | 0.336 | 0 | 0 | 41.62 KB |
| master | WriteAndFlushEnrichedTraces |
net472 | 912μs | 4.68μs | 20.9μs | 8.09 | 2.25 | 0.45 | 53.27 KB |
| #5558 | WriteAndFlushEnrichedTraces |
net6.0 | 600μs | 3.33μs | 26.3μs | 0.691 | 0 | 0 | 41.53 KB |
| #5558 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 680μs | 3.38μs | 14.3μs | 0.326 | 0 | 0 | 41.74 KB |
| #5558 | WriteAndFlushEnrichedTraces |
net472 | 879μs | 4.08μs | 15.8μs | 8.13 | 2.57 | 0.428 | 53.28 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteNonQuery |
net6.0 | 1.24μs | 1.73ns | 6.69ns | 0.0143 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
netcoreapp3.1 | 1.79μs | 2.6ns | 10.1ns | 0.0134 | 0 | 0 | 1.02 KB |
| master | ExecuteNonQuery |
net472 | 2μs | 3.18ns | 11.9ns | 0.156 | 0 | 0 | 987 B |
| #5558 | ExecuteNonQuery |
net6.0 | 1.22μs | 1.68ns | 6.51ns | 0.014 | 0 | 0 | 1.02 KB |
| #5558 | ExecuteNonQuery |
netcoreapp3.1 | 1.7μs | 1.9ns | 7.37ns | 0.0136 | 0 | 0 | 1.02 KB |
| #5558 | ExecuteNonQuery |
net472 | 2.02μs | 2.1ns | 7.86ns | 0.157 | 0 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | CallElasticsearch |
net6.0 | 1.12μs | 0.549ns | 2.13ns | 0.0136 | 0 | 0 | 976 B |
| master | CallElasticsearch |
netcoreapp3.1 | 1.55μs | 0.844ns | 3.27ns | 0.0132 | 0 | 0 | 976 B |
| master | CallElasticsearch |
net472 | 2.34μs | 0.965ns | 3.61ns | 0.158 | 0 | 0 | 995 B |
| master | CallElasticsearchAsync |
net6.0 | 1.27μs | 0.7ns | 2.71ns | 0.0134 | 0 | 0 | 952 B |
| master | CallElasticsearchAsync |
netcoreapp3.1 | 1.62μs | 1.03ns | 3.57ns | 0.0139 | 0 | 0 | 1.02 KB |
| master | CallElasticsearchAsync |
net472 | 2.77μs | 1.89ns | 7.08ns | 0.167 | 0 | 0 | 1.05 KB |
| #5558 | CallElasticsearch |
net6.0 | 1.18μs | 0.645ns | 2.41ns | 0.0137 | 0 | 0 | 976 B |
| #5558 | CallElasticsearch |
netcoreapp3.1 | 1.56μs | 0.827ns | 3.2ns | 0.0132 | 0 | 0 | 976 B |
| #5558 | CallElasticsearch |
net472 | 2.39μs | 0.847ns | 3.17ns | 0.158 | 0.00119 | 0 | 995 B |
| #5558 | CallElasticsearchAsync |
net6.0 | 1.36μs | 0.641ns | 2.4ns | 0.013 | 0 | 0 | 952 B |
| #5558 | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 0.921ns | 3.45ns | 0.0139 | 0 | 0 | 1.02 KB |
| #5558 | CallElasticsearchAsync |
net472 | 2.67μs | 1.11ns | 4.16ns | 0.167 | 0.00133 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | ExecuteAsync |
net6.0 | 1.26μs | 0.302ns | 1.09ns | 0.0133 | 0 | 0 | 952 B |
| master | ExecuteAsync |
netcoreapp3.1 | 1.6μs | 1.15ns | 4.3ns | 0.0121 | 0 | 0 | 952 B |
| master | ExecuteAsync |
net472 | 1.74μs | 1.74ns | 6.28ns | 0.145 | 0 | 0 | 915 B |
| #5558 | ExecuteAsync |
net6.0 | 1.13μs | 1.06ns | 3.98ns | 0.0131 | 0 | 0 | 952 B |
| #5558 | ExecuteAsync |
netcoreapp3.1 | 1.65μs | 0.589ns | 2.2ns | 0.0124 | 0 | 0 | 952 B |
| #5558 | ExecuteAsync |
net472 | 1.76μs | 1.67ns | 6.46ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendAsync |
net6.0 | 4.24μs | 1.32ns | 4.95ns | 0.0315 | 0 | 0 | 2.22 KB |
| master | SendAsync |
netcoreapp3.1 | 5.18μs | 3.43ns | 13.3ns | 0.0364 | 0 | 0 | 2.76 KB |
| master | SendAsync |
net472 | 7.78μs | 2.46ns | 9.54ns | 0.498 | 0 | 0 | 3.15 KB |
| #5558 | SendAsync |
net6.0 | 4.29μs | 1.51ns | 5.63ns | 0.0302 | 0 | 0 | 2.22 KB |
| #5558 | SendAsync |
netcoreapp3.1 | 5.03μs | 1.66ns | 6.44ns | 0.0379 | 0 | 0 | 2.76 KB |
| #5558 | SendAsync |
net472 | 7.73μs | 2.47ns | 9.57ns | 0.497 | 0 | 0 | 3.15 KB |
Benchmarks.Trace.ILoggerBenchmark - Slower :warning: Same allocations :heavy_check_mark:
Slower :warning: in #5558
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1
1.142
2,092.79
2,390.47
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 1.46μs | 0.809ns | 3.03ns | 0.0233 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
netcoreapp3.1 | 2.09μs | 0.755ns | 2.72ns | 0.0217 | 0 | 0 | 1.64 KB |
| master | EnrichedLog |
net472 | 2.74μs | 1.47ns | 5.1ns | 0.25 | 0 | 0 | 1.57 KB |
| #5558 | EnrichedLog |
net6.0 | 1.46μs | 0.85ns | 3.18ns | 0.0227 | 0 | 0 | 1.64 KB |
| #5558 | EnrichedLog |
netcoreapp3.1 | 2.39μs | 1.42ns | 5.52ns | 0.0226 | 0 | 0 | 1.64 KB |
| #5558 | EnrichedLog |
net472 | 2.62μs | 1.45ns | 5.43ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 116μs | 264ns | 1.02μs | 0.0571 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
netcoreapp3.1 | 117μs | 167ns | 626ns | 0.0588 | 0 | 0 | 4.28 KB |
| master | EnrichedLog |
net472 | 147μs | 178ns | 691ns | 0.661 | 0.22 | 0 | 4.46 KB |
| #5558 | EnrichedLog |
net6.0 | 114μs | 161ns | 601ns | 0.0576 | 0 | 0 | 4.28 KB |
| #5558 | EnrichedLog |
netcoreapp3.1 | 121μs | 212ns | 821ns | 0.06 | 0 | 0 | 4.28 KB |
| #5558 | EnrichedLog |
net472 | 146μs | 110ns | 398ns | 0.659 | 0.22 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.95μs | 1.06ns | 3.83ns | 0.031 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
netcoreapp3.1 | 4.08μs | 1.18ns | 4.42ns | 0.0285 | 0 | 0 | 2.2 KB |
| master | EnrichedLog |
net472 | 4.71μs | 1.23ns | 4.61ns | 0.319 | 0 | 0 | 2.02 KB |
| #5558 | EnrichedLog |
net6.0 | 3μs | 1.3ns | 5.04ns | 0.0313 | 0 | 0 | 2.2 KB |
| #5558 | EnrichedLog |
netcoreapp3.1 | 4.15μs | 1.56ns | 5.83ns | 0.0293 | 0 | 0 | 2.2 KB |
| #5558 | EnrichedLog |
net472 | 4.85μs | 1.46ns | 5.65ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | SendReceive |
net6.0 | 1.28μs | 0.672ns | 2.6ns | 0.0161 | 0 | 0 | 1.14 KB |
| master | SendReceive |
netcoreapp3.1 | 1.69μs | 0.752ns | 2.81ns | 0.0152 | 0 | 0 | 1.14 KB |
| master | SendReceive |
net472 | 2.08μs | 0.513ns | 1.99ns | 0.183 | 0 | 0 | 1.16 KB |
| #5558 | SendReceive |
net6.0 | 1.33μs | 0.451ns | 1.75ns | 0.0159 | 0 | 0 | 1.14 KB |
| #5558 | SendReceive |
netcoreapp3.1 | 1.8μs | 0.541ns | 2.1ns | 0.0152 | 0 | 0 | 1.14 KB |
| #5558 | SendReceive |
net472 | 2.16μs | 1.11ns | 4.32ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | EnrichedLog |
net6.0 | 2.87μs | 1.48ns | 5.73ns | 0.0231 | 0 | 0 | 1.6 KB |
| master | EnrichedLog |
netcoreapp3.1 | 3.83μs | 1.62ns | 6.05ns | 0.0209 | 0 | 0 | 1.65 KB |
| master | EnrichedLog |
net472 | 4.39μs | 2.52ns | 9.75ns | 0.322 | 0 | 0 | 2.04 KB |
| #5558 | EnrichedLog |
net6.0 | 2.74μs | 1.23ns | 4.77ns | 0.022 | 0 | 0 | 1.6 KB |
| #5558 | EnrichedLog |
netcoreapp3.1 | 3.97μs | 1.45ns | 5.63ns | 0.0218 | 0 | 0 | 1.65 KB |
| #5558 | EnrichedLog |
net472 | 4.23μs | 2.36ns | 9.13ns | 0.323 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #5558
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.132
540.79
477.91
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 399ns | 0.417ns | 1.56ns | 0.00801 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 570ns | 0.252ns | 0.975ns | 0.00772 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 714ns | 0.749ns | 2.9ns | 0.0915 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 541ns | 0.112ns | 0.418ns | 0.00985 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 749ns | 0.459ns | 1.72ns | 0.00934 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 880ns | 0.377ns | 1.46ns | 0.104 | 0 | 0 | 658 B |
| #5558 | StartFinishSpan |
net6.0 | 404ns | 0.337ns | 1.31ns | 0.00811 | 0 | 0 | 576 B |
| #5558 | StartFinishSpan |
netcoreapp3.1 | 594ns | 0.95ns | 3.68ns | 0.00794 | 0 | 0 | 576 B |
| #5558 | StartFinishSpan |
net472 | 726ns | 0.722ns | 2.8ns | 0.0918 | 0 | 0 | 578 B |
| #5558 | StartFinishScope |
net6.0 | 478ns | 0.206ns | 0.77ns | 0.00977 | 0 | 0 | 696 B |
| #5558 | StartFinishScope |
netcoreapp3.1 | 732ns | 0.791ns | 2.96ns | 0.00956 | 0 | 0 | 696 B |
| #5558 | StartFinishScope |
net472 | 864ns | 0.506ns | 1.96ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark:
Faster :tada: in #5558
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.121
665.74
593.99
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 664ns | 0.887ns | 3.43ns | 0.0096 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 935ns | 0.933ns | 3.62ns | 0.00927 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.08μs | 0.4ns | 1.55ns | 0.104 | 0 | 0 | 658 B |
| #5558 | RunOnMethodBegin |
net6.0 | 594ns | 0.171ns | 0.664ns | 0.00979 | 0 | 0 | 696 B |
| #5558 | RunOnMethodBegin |
netcoreapp3.1 | 1.01μs | 0.636ns | 2.46ns | 0.00944 | 0 | 0 | 696 B |
| #5558 | RunOnMethodBegin |
net472 | 1.08μs | 0.823ns | 3.19ns | 0.105 | 0 | 0 | 658 B |
Throughput/Crank Report :zap:
Throughput results for AspNetCoreSimpleController comparing the following branches/commits:
Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.
Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5558) (11.440M) : 0, 11439815
master (11.676M) : 0, 11676260
benchmarks/2.9.0 (11.335M) : 0, 11335046
section Automatic
This PR (5558) (7.797M) : 0, 7797380
master (7.826M) : 0, 7826412
benchmarks/2.9.0 (8.124M) : 0, 8123605
section Trace stats
master (8.123M) : 0, 8122959
section Manual
master (11.704M) : 0, 11704124
section Manual + Automatic
This PR (5558) (7.323M) : 0, 7323257
master (7.322M) : 0, 7322125
section DD_TRACE_ENABLED=0
master (10.783M) : 0, 10782786
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5558) (9.478M) : 0, 9477657
section Automatic
This PR (5558) (6.509M) : 0, 6508757
section Manual + Automatic
This PR (5558) (6.187M) : 0, 6187220
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5558) (10.187M) : 0, 10187266
master (9.997M) : 0, 9997107
benchmarks/2.9.0 (10.092M) : 0, 10091577
section Automatic
This PR (5558) (6.905M) : 0, 6905395
master (6.660M) : 0, 6660328
benchmarks/2.9.0 (7.470M) : 0, 7469858
section Trace stats
master (7.375M) : 0, 7375399
section Manual
master (10.122M) : 0, 10122027
section Manual + Automatic
This PR (5558) (6.475M) : 0, 6475298
master (6.269M) : 0, 6268723
section DD_TRACE_ENABLED=0
master (9.425M) : 0, 9425316
Datadog Report
Branch report: dudik/get-membervalue-throws-nse
Commit report: 48a3a66
Test service: dd-trace-dotnet
:white_check_mark: 0 Failed, 349120 Passed, 2259 Skipped, 23h 8m 54.14s Total Time