dd-trace-dotnet icon indicating copy to clipboard operation
dd-trace-dotnet copied to clipboard
verified publisher icon DataDog

[Dynamic Instrumentation] DEBUG-2365 Support string lexicographic comparison

Open dudikeleti opened this issue 1 year ago • 5 comments

Summary of changes

Allow the customer to use < <= > >= with strings in the EL

Test coverage

See tests in the PR

dudikeleti avatar May 07 '24 15:05 dudikeleti

Datadog Report

Branch report: dudik/lexicographic-comparison Commit report: 9b1c9df Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 325022 Passed, 2032 Skipped, 43m 12.23s Wall Time :snowflake: 3 New Flaky :hourglass: 3 Performance Regressions

New Flaky Tests (3)

  • TestTemplates - Datadog.Trace.Tests.Debugger.DebuggerExpressionLanguageTests - Last Failure

    Expand for error 
    esults do not match.
ifferences:
eceived: DebuggerExpressionLanguageTests.ToStringNotSupported.received.txt
erified: DebuggerExpressionLanguageTests.ToStringNotSupported.verified.txt
eceived Content:
emplate:
egments: 


   "ref": "Nested"
..

  • TestTemplates - Datadog.Trace.Tests.Debugger.DebuggerExpressionLanguageTests - Last Failure

    Expand for error 
    esults do not match.
ifferences:
eceived: DebuggerExpressionLanguageTests.ToStringNotSupported.received.txt
erified: DebuggerExpressionLanguageTests.ToStringNotSupported.verified.txt
eceived Content:
emplate:
egments: 


   "ref": "Nested"
..

  • TestTemplates - Datadog.Trace.Tests.Debugger.DebuggerExpressionLanguageTests - Last Failure

    Expand for error 
    esults do not match.
ifferences:
eceived: DebuggerExpressionLanguageTests.ToStringNotSupported.received.txt
erified: DebuggerExpressionLanguageTests.ToStringNotSupported.verified.txt
eceived Content:
emplate:
egments: 


   "ref": "Nested"
..

:hourglass: Performance Regressions vs Default Branch (3)

  • Baseline_exception - scenarios 4.41s (+196.2ms, +5%) - Details
  • Baseline_exception - scenarios 3.96s (+164.06ms, +4%) - Details
  • Profiler_exceptions - scenarios 5.35s (+991.61ms, +23%) - Details

datadog-ddstaging[bot] avatar May 07 '24 15:05 datadog-ddstaging[bot]

Execution-Time Benchmarks Report :stopwatch:

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (71ms)  : 64, 79
     .   : milestone, 71,
    master - mean (73ms)  : 64, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (1,067ms)  : 1044, 1090
     .   : milestone, 1067,
    master - mean (1,061ms)  : 1045, 1078
     .   : milestone, 1061,


gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (109ms)  : 104, 113
     .   : milestone, 109,
    master - mean (108ms)  : 104, 112
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (751ms)  : 724, 779
     .   : milestone, 751,
    master - mean (746ms)  : 728, 763
     .   : milestone, 746,


gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (92ms)  : 89, 94
     .   : milestone, 92,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (704ms)  : 683, 724
     .   : milestone, 704,
    master - mean (702ms)  : 685, 718
     .   : milestone, 702,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (192ms)  : 189, 196
     .   : milestone, 192,
    master - mean (192ms)  : 189, 195
     .   : milestone, 192,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (1,199ms)  : 1082, 1316
     .   : milestone, 1199,
    master - mean (1,163ms)  : 1140, 1186
     .   : milestone, 1163,


gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (278ms)  : 271, 285
     .   : milestone, 278,
    master - mean (276ms)  : 271, 281
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (919ms)  : 894, 944
     .   : milestone, 919,
    master - mean (913ms)  : 894, 933
     .   : milestone, 913,


gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5538) - mean (266ms)  : 262, 270
     .   : milestone, 266,
    master - mean (266ms)  : 263, 269
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (5538) - mean (906ms)  : 880, 933
     .   : milestone, 906,
    master - mean (918ms)  : 856, 979
     .   : milestone, 918,

andrewlock avatar May 07 '24 16:05 andrewlock

Benchmarks Report for tracer :snail:

Benchmarks for #5538 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.123
  • 1 benchmarks are slower, with geometric mean 1.132
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.64μs 35.3ns 141ns 0.0147 0.00733 0 5.43 KB
master StartStopWithChild netcoreapp3.1 10μs 55.5ns 347ns 0.0203 0.0102 0 5.62 KB
master StartStopWithChild net472 16.1μs 44.6ns 173ns 1.04 0.327 0.112 6.08 KB
#5538 StartStopWithChild net6.0 7.63μs 42.5ns 288ns 0.016 0.008 0 5.43 KB
#5538 StartStopWithChild netcoreapp3.1 9.97μs 50.4ns 231ns 0.0292 0.0146 0 5.62 KB
#5538 StartStopWithChild net472 16.2μs 63.1ns 244ns 1.02 0.298 0.0887 6.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 462μs 1.15μs 4.46μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 631μs 220ns 852ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 869μs 985ns 3.82μs 0.422 0 0 3.3 KB
#5538 WriteAndFlushEnrichedTraces net6.0 474μs 249ns 932ns 0 0 0 2.7 KB
#5538 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 628ns 2.35μs 0 0 0 2.7 KB
#5538 WriteAndFlushEnrichedTraces net472 854μs 560ns 2.17μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 198μs 1.14μs 8.95μs 0.181 0 0 18.45 KB
master SendRequest netcoreapp3.1 221μs 1.28μs 11.3μs 0.23 0 0 20.61 KB
master SendRequest net472 0.00477ns 0.000814ns 0.00294ns 0 0 0 0 b
#5538 SendRequest net6.0 197μs 1.26μs 12.5μs 0.188 0 0 18.45 KB
#5538 SendRequest netcoreapp3.1 221μs 1.22μs 10.3μs 0.224 0 0 20.61 KB
#5538 SendRequest net472 0.00038ns 0.00027ns 0.000935ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 587μs 2.77μs 11.1μs 0.598 0 0 41.59 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 685μs 3.36μs 13.9μs 0.353 0 0 41.67 KB
master WriteAndFlushEnrichedTraces net472 901μs 3.7μs 14.3μs 8.42 2.66 0.443 53.3 KB
#5538 WriteAndFlushEnrichedTraces net6.0 578μs 2.54μs 10.8μs 0.598 0 0 41.6 KB
#5538 WriteAndFlushEnrichedTraces netcoreapp3.1 716μs 4.13μs 34μs 0.338 0 0 41.79 KB
#5538 WriteAndFlushEnrichedTraces net472 869μs 3.45μs 12.9μs 8.68 2.6 0.434 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.23μs 1.48ns 5.55ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.64μs 1.92ns 7.44ns 0.0142 0 0 1.02 KB
master ExecuteNonQuery net472 2.04μs 2.01ns 7.5ns 0.156 0 0 987 B
#5538 ExecuteNonQuery net6.0 1.32μs 0.949ns 3.42ns 0.0145 0 0 1.02 KB
#5538 ExecuteNonQuery netcoreapp3.1 1.67μs 2.26ns 8.75ns 0.0135 0 0 1.02 KB
#5538 ExecuteNonQuery net472 1.96μs 1.84ns 6.87ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.32μs 1.14ns 4.42ns 0.0132 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.51μs 0.65ns 2.43ns 0.0127 0 0 976 B
master CallElasticsearch net472 2.51μs 1.15ns 4.15ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 0.535ns 2ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.67μs 0.482ns 1.74ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.61μs 2.02ns 7.82ns 0.167 0.0013 0 1.05 KB
#5538 CallElasticsearch net6.0 1.26μs 0.579ns 2.24ns 0.0139 0 0 976 B
#5538 CallElasticsearch netcoreapp3.1 1.5μs 0.822ns 3.08ns 0.0128 0 0 976 B
#5538 CallElasticsearch net472 2.45μs 0.636ns 2.38ns 0.158 0 0 995 B
#5538 CallElasticsearchAsync net6.0 1.3μs 0.597ns 2.15ns 0.0136 0 0 952 B
#5538 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.842ns 3.15ns 0.0136 0 0 1.02 KB
#5538 CallElasticsearchAsync net472 2.62μs 1.4ns 5.22ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.552ns 2.06ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.6μs 1.39ns 5.4ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.75μs 1.71ns 6.63ns 0.145 0 0 915 B
#5538 ExecuteAsync net6.0 1.24μs 0.513ns 1.92ns 0.0131 0 0 952 B
#5538 ExecuteAsync netcoreapp3.1 1.59μs 1.32ns 4.75ns 0.0127 0 0 952 B
#5538 ExecuteAsync net472 1.73μs 0.427ns 1.6ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.17μs 1.49ns 5.59ns 0.0315 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.29μs 1.95ns 7.31ns 0.037 0 0 2.76 KB
master SendAsync net472 7.67μs 2.69ns 10.1ns 0.497 0 0 3.15 KB
#5538 SendAsync net6.0 4.29μs 3.11ns 11.2ns 0.0304 0 0 2.22 KB
#5538 SendAsync netcoreapp3.1 5.15μs 2.93ns 10.6ns 0.036 0 0 2.76 KB
#5538 SendAsync net472 7.92μs 2.63ns 10.2ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 0.967ns 3.75ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.35μs 1.04ns 3.91ns 0.0223 0 0 1.64 KB
master EnrichedLog net472 2.68μs 1.41ns 5.45ns 0.249 0 0 1.57 KB
#5538 EnrichedLog net6.0 1.54μs 2.41ns 9.32ns 0.0232 0 0 1.64 KB
#5538 EnrichedLog netcoreapp3.1 2.2μs 0.994ns 3.58ns 0.0221 0 0 1.64 KB
#5538 EnrichedLog net472 2.57μs 1.72ns 6.42ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 115μs 186ns 719ns 0.0557 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 307ns 1.19μs 0.0589 0 0 4.28 KB
master EnrichedLog net472 150μs 271ns 1.05μs 0.685 0.228 0 4.46 KB
#5538 EnrichedLog net6.0 115μs 323ns 1.25μs 0 0 0 4.28 KB
#5538 EnrichedLog netcoreapp3.1 119μs 294ns 1.14μs 0 0 0 4.28 KB
#5538 EnrichedLog net472 148μs 159ns 594ns 0.666 0.222 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 0.968ns 3.62ns 0.0307 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.11μs 3.07ns 11.9ns 0.0288 0 0 2.2 KB
master EnrichedLog net472 4.81μs 1.62ns 6.27ns 0.318 0 0 2.02 KB
#5538 EnrichedLog net6.0 2.96μs 1.12ns 4.2ns 0.0308 0 0 2.2 KB
#5538 EnrichedLog netcoreapp3.1 4.11μs 1.39ns 5.39ns 0.0287 0 0 2.2 KB
#5538 EnrichedLog net472 4.76μs 1.46ns 5.67ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 0.858ns 3.09ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 3.53ns 12.7ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.13μs 1.19ns 4.47ns 0.183 0.00107 0 1.16 KB
#5538 SendReceive net6.0 1.37μs 1.02ns 3.96ns 0.016 0 0 1.14 KB
#5538 SendReceive netcoreapp3.1 1.7μs 0.995ns 3.86ns 0.0152 0 0 1.14 KB
#5538 SendReceive net472 2.14μs 0.519ns 1.94ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed :heavy_check_mark: Same allocations :heavy_check_mark:

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 3.77ns 14.6ns 0.0219 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.83μs 2.57ns 9.94ns 0.023 0 0 1.65 KB
master EnrichedLog net472 4.33μs 2.13ns 8.24ns 0.323 0 0 2.04 KB
#5538 EnrichedLog net6.0 2.76μs 0.973ns 3.77ns 0.0221 0 0 1.6 KB
#5538 EnrichedLog netcoreapp3.1 4μs 2.21ns 8.58ns 0.0219 0 0 1.65 KB
#5538 EnrichedLog net472 4.41μs 2.04ns 7.9ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower :warning: Same allocations :heavy_check_mark:

Slower :warning: in #5538

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.132 400.49 453.18

Faster :tada: in #5538

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.123 881.04 784.59

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.174ns 0.674ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 554ns 0.401ns 1.55ns 0.00791 0 0 576 B
master StartFinishSpan net472 651ns 0.353ns 1.37ns 0.0917 0 0 578 B
master StartFinishScope net6.0 482ns 0.172ns 0.668ns 0.00983 0 0 696 B
master StartFinishScope netcoreapp3.1 711ns 0.401ns 1.5ns 0.00939 0 0 696 B
master StartFinishScope net472 880ns 0.579ns 2.24ns 0.104 0 0 658 B
#5538 StartFinishSpan net6.0 453ns 0.0833ns 0.312ns 0.00817 0 0 576 B
#5538 StartFinishSpan netcoreapp3.1 616ns 1.31ns 5.08ns 0.00791 0 0 576 B
#5538 StartFinishSpan net472 669ns 0.399ns 1.55ns 0.0917 0 0 578 B
#5538 StartFinishScope net6.0 482ns 0.234ns 0.845ns 0.00972 0 0 696 B
#5538 StartFinishScope netcoreapp3.1 763ns 0.25ns 0.901ns 0.00955 0 0 696 B
#5538 StartFinishScope net472 785ns 0.446ns 1.73ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster :tada: Same allocations :heavy_check_mark:

Faster :tada: in #5538

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.124 681.49 606.57

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 682ns 0.346ns 1.34ns 0.00955 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 927ns 0.487ns 1.82ns 0.00904 0 0 696 B
master RunOnMethodBegin net472 1.07μs 0.37ns 1.43ns 0.105 0 0 658 B
#5538 RunOnMethodBegin net6.0 606ns 0.511ns 1.98ns 0.00976 0 0 696 B
#5538 RunOnMethodBegin netcoreapp3.1 905ns 0.424ns 1.59ns 0.00951 0 0 696 B
#5538 RunOnMethodBegin net472 1.1μs 0.393ns 1.52ns 0.105 0 0 658 B

andrewlock avatar May 07 '24 16:05 andrewlock

Throughput/Crank Report :zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5538) (9.044M)   : 0, 9043685
    master (11.493M)   : 0, 11493461
    benchmarks/2.9.0 (11.613M)   : 0, 11613444

    section Automatic
    This PR (5538) (7.638M)   : 0, 7638022
    master (7.678M)   : 0, 7677895
    benchmarks/2.9.0 (8.160M)   : 0, 8160128

    section Trace stats
    master (7.764M)   : 0, 7764115

    section Manual
    master (11.594M)   : 0, 11593617

    section Manual + Automatic
    This PR (5538) (7.177M)   : 0, 7177296
    master (7.089M)   : 0, 7088887

    section DD_TRACE_ENABLED=0
    master (10.632M)   : 0, 10631514


gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5538) (9.475M)   : 0, 9475486
    master (9.518M)   : 0, 9517670

    section Automatic
    This PR (5538) (6.479M)   : 0, 6478721
    master (6.468M)   : 0, 6467925

    section Trace stats
    master (6.625M)   : 0, 6625059

    section Manual
    master (9.605M)   : 0, 9604710

    section Manual + Automatic
    This PR (5538) (6.138M)   : 0, 6138302
    master (6.172M)   : 0, 6172150

    section DD_TRACE_ENABLED=0
    master (8.894M)   : 0, 8894200


gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5538) (10.030M)   : 0, 10030290
    benchmarks/2.9.0 (10.301M)   : 0, 10300652

    section Automatic
    This PR (5538) (6.928M)   : 0, 6928274
    benchmarks/2.9.0 (7.460M)   : 0, 7459640

    section Manual + Automatic
    This PR (5538) (6.547M)   : 0, 6547094

andrewlock avatar May 07 '24 16:05 andrewlock

Datadog Report

Branch report: dudik/lexicographic-comparison Commit report: 7780347 Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 279997 Passed, 2101 Skipped, 21h 51m 48.07s Total Time :snowflake: 2 New Flaky

New Flaky Tests (2)

  • TestConditions - Datadog.Trace.Tests.Debugger.DebuggerExpressionLanguageTests - Last Failure

    Expand for error 
    esults do not match.
ifferences:
eceived: DebuggerExpressionLanguageTests.GreaterThanString.received.txt
erified: DebuggerExpressionLanguageTests.GreaterThanString.verified.txt
eceived Content:
ondition:
son:

   "gt": [
     {
..

  • TestConditions - Datadog.Trace.Tests.Debugger.DebuggerExpressionLanguageTests - Last Failure

    Expand for error 
    esults do not match.
ifferences:
eceived: DebuggerExpressionLanguageTests.GreaterThanString.received.txt
erified: DebuggerExpressionLanguageTests.GreaterThanString.verified.txt
eceived Content:
ondition:
son:

   "gt": [
     {
..

datadog-ddstaging[bot] avatar May 28 '24 15:05 datadog-ddstaging[bot]

Datadog Report

Branch report: dudik/lexicographic-comparison Commit report: b7124ca Test service: dd-trace-dotnet

:white_check_mark: 0 Failed, 345551 Passed, 2249 Skipped, 22h 31m 20.11s Total Time :hourglass: 1 Performance Regression

:hourglass: Performance Regressions vs Default Branch (1)

  • Baseline_garbagecollections - scenarios 1.03s (+29.67ms, +3%) - Details

datadog-ddstaging[bot] avatar Jul 23 '24 11:07 datadog-ddstaging[bot]